Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229847/?format=api
{ "id": 2229847, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229847/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-42-andrei.otcheretianski@intel.com/", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.1/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428200639.40243-42-andrei.otcheretianski@intel.com>", "date": "2026-04-28T20:05:42", "name": "[41/97] NAN: Pass struct as parameter to wpas_nan_add_ndi_sta()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4a3e3ab297026f24f4df136d86169f71f7e7f5c7", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.1/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-42-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 501927, "url": "http://patchwork.ozlabs.org/api/1.1/series/501927/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/list/?series=501927", "date": "2026-04-28T20:05:05", "name": "NAN: Group keys support, schedule update and more", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501927/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229847/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229847/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Y4nXn7ag;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=JiCosH2W;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s5c0C4Hz1xrS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:11:32 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHolq-00000002Gxg-1BnQ;\n\tTue, 28 Apr 2026 20:11:02 +0000", "from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoja-00000002CcZ-1M94\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:08:54 +0000", "from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:08:19 -0700", "from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:08:16 -0700" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=2RUDBDXmmrYu1JXPEcRyjAeIuz8qq/NSFKXCRx+Harw=; b=Y4nXn7agNtdfli\n\tOT7NyPTudGpuQmRw94F9iM6y1nfLSH0ID2hNdbJazzY4oTNq7ADBa7nREdHAwn7x56m419jTdIQO9\n\t+KEGH/BQCXIuZQviYT0krpvoP4LDq4Tn08ML6kEgKCq+XV8/vU+t/JgHceg19zQtXlHVv7ARKdrt4\n\tBB1aP1Nxhiks/Y3tcYWvQtwWMTiu8UsGLP+aLnITUIEbz5yhS8g8dOsILb9tDQCHVfYzeV5aM0o0r\n\tw+M89l//WPXcTCOCmKLDFyjjWyCEho58OYYFFcOC9P2gLq17ZJzuezIf2GJno6vZEuO1ML7KdOQ5v\n\tCHUx77HWfn3PMvjlg19A==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406922; x=1808942922;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=yTrUTMc9TW/DuC+aQCv6nttInfHYy9XF09lq/xAgW1E=;\n b=JiCosH2Wucl3/3+t0diLkJUQx/hw1OqgdXdbfChFMFNRBQasQJxEnzcF\n JOLL+hCT1jU3H/Qc9J3qw383u/w7qHi5O6G/NDzqVl0EM5rT4buyyS1hw\n xtxsWSRTRD0l9xYUd6QKewH1LRAC89i/3GObU6rysFw6sXPR5TL5iSLMu\n A670QE5SD6VVW50kl1eC+eoF4aEPmWefO9Nz7HWrNOLOt71OUp88p7HNw\n Ed0K5JzTGKY/3GS/mUiong1Vop+NYEt/87jvl/1coWIce3Bbs5IeFGQKA\n psjWY5Zr7vdM4Rz6qePa+mHBhaH72b9Zx6z2p5T4Qv9BjQZVKXVVJPcOG\n g==;" ], "X-CSE-ConnectionGUID": [ "G1SVC1vnRkmOk8beAVzN5Q==", "TAWMev7wQg+nQQ5tm0lMkg==" ], "X-CSE-MsgGUID": [ "BREFWWrJRpS7WjPcTXcZXg==", "5MXyiRTvSlCYewcQjpxwaQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11770\"; a=\"78519414\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519414\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257610398\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org", "Cc": "vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAvraham Stern <avraham.stern@intel.com>", "Subject": "[PATCH 41/97] NAN: Pass struct as parameter to wpas_nan_add_ndi_sta()", "Date": "Tue, 28 Apr 2026 23:05:42 +0300", "Message-ID": "<20260428200639.40243-42-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "References": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260428_130842_546582_61C17E89 ", "X-CRM114-Status": "GOOD ( 13.83 )", "X-Spam-Score": "-4.5 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Avraham Stern <avraham.stern@intel.com> All the\n parameters\n of wpas_nan_add_ndi_sta() are part of the nan_ndp_connection_params\n struct.\n Use the struct as the function parameter to make it easier to pass more\n info\n to this function.\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Avraham Stern <avraham.stern@intel.com>\n\nAll the parameters of wpas_nan_add_ndi_sta() are part of the\nnan_ndp_connection_params struct. Use the struct as the function\nparameter to make it easier to pass more info to this function.\n\nSigned-off-by: Avraham Stern <avraham.stern@intel.com>\n---\n wpa_supplicant/nan_supplicant.c | 49 ++++++++++++++++-----------------\n 1 file changed, 23 insertions(+), 26 deletions(-)", "diff": "diff --git a/wpa_supplicant/nan_supplicant.c b/wpa_supplicant/nan_supplicant.c\nindex 81ae22e95a..94a6aa1f0d 100644\n--- a/wpa_supplicant/nan_supplicant.c\n+++ b/wpa_supplicant/nan_supplicant.c\n@@ -450,21 +450,21 @@ static int wpas_nan_configure_nmi_sta_capa(struct wpa_supplicant *wpa_s,\n \n \n static int wpas_nan_add_ndi_sta(struct wpa_supplicant *wpa_s,\n-\t\t\t\tconst u8 *peer_nmi, const u8 *local_ndi,\n-\t\t\t\tconst u8 *peer_ndi, bool install_keys,\n-\t\t\t\tbool first_ndp, bool new_ndi_sta)\n+\t\t\t\tstruct nan_ndp_connection_params *params)\n {\n \tu8 tk[WPA_TK_MAX_LEN];\n \tsize_t tk_len;\n \tenum nan_cipher_suite_id csid;\n \tstruct wpa_supplicant *ndi_wpa_s;\n \tstruct hostapd_sta_add_params sta_params;\n+\tconst u8 *peer_nmi = params->ndp_id.peer_nmi;\n+\tconst u8 *peer_ndi = params->peer_ndi;\n \n-\tndi_wpa_s = wpas_nan_get_ndi_iface(wpa_s, local_ndi);\n+\tndi_wpa_s = wpas_nan_get_ndi_iface(wpa_s, params->local_ndi);\n \tif (!ndi_wpa_s) {\n \t\twpa_printf(MSG_INFO,\n \t\t\t \"NAN: No NDI interface found for \" MACSTR,\n-\t\t\t MAC2STR(local_ndi));\n+\t\t\t MAC2STR(params->local_ndi));\n \t\treturn -1;\n \t}\n \n@@ -472,21 +472,21 @@ static int wpas_nan_add_ndi_sta(struct wpa_supplicant *wpa_s,\n \t * the first NDP. After that it is assumed that capablities are not\n \t * changing.\n \t */\n-\tif (first_ndp &&\n+\tif (params->first_ndp &&\n \t wpas_nan_configure_nmi_sta_capa(wpa_s, peer_nmi)) {\n \t\twpa_printf(MSG_INFO,\n \t\t\t \"NAN: Failed to configure NMI station capabilities\");\n \t\treturn -1;\n \t}\n \n-\tif (new_ndi_sta) {\n+\tif (params->new_ndi_sta) {\n \t\tos_memset(&sta_params, 0, sizeof(sta_params));\n \t\tsta_params.addr = peer_ndi;\n \t\tsta_params.nmi_addr = peer_nmi;\n \t\tsta_params.flags = WPA_STA_AUTHENTICATED | WPA_STA_ASSOCIATED;\n \n \t\t/* Set MFP flag early, to prevent races until keys are installed */\n-\t\tif (install_keys)\n+\t\tif (params->install_keys)\n \t\t\tsta_params.flags |= WPA_STA_MFP;\n \t\telse\n \t\t\tsta_params.flags |= WPA_STA_AUTHORIZED;\n@@ -502,7 +502,7 @@ static int wpas_nan_add_ndi_sta(struct wpa_supplicant *wpa_s,\n \t\t\t \"NAN: NDI station already exists for peer \" MACSTR,\n \t\t\t MAC2STR(peer_ndi));\n \t\t/* Set MFP flag if keys will be installed (security upgrade) */\n-\t\tif (install_keys &&\n+\t\tif (params->install_keys &&\n \t\t wpa_drv_sta_set_flags(ndi_wpa_s, peer_ndi, WPA_STA_MFP,\n \t\t\t\t\t WPA_STA_MFP, ~0)) {\n \t\t\twpa_printf(MSG_INFO,\n@@ -512,20 +512,20 @@ static int wpas_nan_add_ndi_sta(struct wpa_supplicant *wpa_s,\n \t\t}\n \t}\n \n-\tif (!install_keys) {\n-\t\tif (new_ndi_sta)\n-\t\t\twpa_printf(MSG_DEBUG,\n-\t\t\t\t \"NAN: NDI station added without keys for peer \"\n-\t\t\t\t MACSTR, MAC2STR(peer_ndi));\n-\t\telse\n-\t\t\twpa_printf(MSG_DEBUG,\n-\t\t\t\t \"NAN: Using existing NDI station without new keys for peer \"\n-\t\t\t\t MACSTR, MAC2STR(peer_ndi));\n+\twpa_printf(MSG_DEBUG, \"NAN: NDI station for peer \" MACSTR \" %s\",\n+\t\t MAC2STR(peer_ndi),\n+\t\t params->new_ndi_sta ? \"added\" : \"already exists\");\n+\n+\tif (!params->install_keys) {\n+\t\twpa_printf(MSG_DEBUG,\n+\t\t\t \"NAN: NDI station %s without keys for peer \" MACSTR,\n+\t\t\t params->new_ndi_sta ? \"added\" : \"ready\",\n+\t\t\t MAC2STR(peer_ndi));\n \t\tgoto out_success;\n \t}\n \n-\tif (nan_peer_get_tk(wpa_s->nan, peer_nmi, peer_ndi, local_ndi, tk,\n-\t\t\t &tk_len, &csid)) {\n+\tif (nan_peer_get_tk(wpa_s->nan, peer_nmi, peer_ndi, params->local_ndi,\n+\t\t\t tk, &tk_len, &csid)) {\n \t\twpa_printf(MSG_INFO, \"NAN: Failed to get TK for NDI station\");\n \t\tgoto remove_sta;\n \t}\n@@ -563,8 +563,8 @@ out_success:\n \treturn 0;\n \n remove_sta:\n-\tif (new_ndi_sta)\n-\t\twpa_drv_sta_remove(ndi_wpa_s, peer_ndi);\n+\tif (params->new_ndi_sta)\n+\t\twpa_drv_sta_remove(ndi_wpa_s, params->peer_ndi);\n \treturn -1;\n }\n \n@@ -616,10 +616,7 @@ static int wpas_nan_ndp_connected_cb(void *ctx,\n {\n \tstruct wpa_supplicant *wpa_s = ctx;\n \n-\tif (wpas_nan_add_ndi_sta(wpa_s, params->ndp_id.peer_nmi,\n-\t\t\t\t params->local_ndi, params->peer_ndi,\n-\t\t\t\t params->install_keys,\n-\t\t\t\t params->first_ndp, params->new_ndi_sta) < 0) {\n+\tif (wpas_nan_add_ndi_sta(wpa_s, params) < 0) {\n \t\twpa_printf(MSG_INFO,\n \t\t\t \"NAN: Failed to add NDI station for NDP connection\");\n \t\treturn -1;\n", "prefixes": [ "41/97" ] }