Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229824/?format=api
{ "id": 2229824, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229824/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-21-andrei.otcheretianski@intel.com/", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.1/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428200639.40243-21-andrei.otcheretianski@intel.com>", "date": "2026-04-28T20:05:21", "name": "[RFC,20/97] tests: Add coverage for interface ID in NDP", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1452b2479c1cc8fc77272b9a5ef5e96801739cc8", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.1/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-21-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 501927, "url": "http://patchwork.ozlabs.org/api/1.1/series/501927/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/list/?series=501927", "date": "2026-04-28T20:05:05", "name": "NAN: Group keys support, schedule update and more", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501927/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229824/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229824/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=sA9mRL36;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Ui3RhO57;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s2z08B0z1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:09:15 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHojY-00000002DsX-0POt;\n\tTue, 28 Apr 2026 20:08:40 +0000", "from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoig-00000002CcZ-0FcU\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:07:47 +0000", "from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:46 -0700", "from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:44 -0700" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=ZlqOvEX6Zo4lquBdDCBDfYf5eo8UZlea7PZcIe1CT0U=; b=sA9mRL36RTRYoB\n\tl+IdCMe6OaHCsaV0PitVtuYEXAUA/Jx7biGS3ZKEnefN9JTW/13FA9jWdjkW6rrCfqjHRmM/zO/qr\n\tRuaSPu/emhI9GsrEOG3Oj5ZWapmYXOLOKo58XaEO268VbeM1UMU1VedYjUk2KF5QYjVBhLlXFlCXs\n\tXzdRUb4U8nyj24Zg6HiaHmi9hECxYWIpxLqaAYOPZ8GOUOKbOXUgeBeo+tsxznqWHufz9CeP5WbUH\n\tvnjU/kAJuQnisn1jqttQqof3Gk8tkid+3lnNHleTS7C654M546KyQQ6/lsTkOafY8ga/wMajJnjkA\n\tOFpStDRjc6OG3ZprXghg==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406867; x=1808942867;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=K6Xwlb0rUmMifycjLWCOhR/A3AGF0AgQb4MPnW3NtqQ=;\n b=Ui3RhO57QaIw1nPuy8bt19YQ25hjizPgr8qOD7Ac30Yzp6Y5aYLxFvPW\n m5A30RWOZAuC5qC1jbPnaTzZ8VFc0lRsGyARAaoUzGcjOCXE5Ea4/Tx2H\n H2w79aPcyQ1CKEoPBunVkWRW0hcvTgfb9DX33eaIW+UWNfyKCD5Yt2OOY\n hDS/ru3fC3/xJ/WMXhJo0OcKIlILPEWYQhTKk4qBG2rzWgcPtXJwlWfya\n SYpdgSMcHM0uTIpqr48kTjoIfWrh4ew0v95lDI+LbVtZ0Jb/OgZ86uTWZ\n MfDDJY+IPK5i4CwJORZ+IG3h2EV1yTWlxbYvFPNwzvNgAw1FzH0Q4CkKH\n Q==;" ], "X-CSE-ConnectionGUID": [ "6N2haPqMRWySHwQsjCvcRQ==", "i9RA+dQoQUeZn45i1Vx3iA==" ], "X-CSE-MsgGUID": [ "97o9b72+TwC8fKU6X+aPPg==", "yB2EVTgQTqqep/r7qMxbBQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11770\"; a=\"78519332\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519332\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257610059\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org", "Cc": "vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tIlan Peer <ilan.peer@intel.com>", "Subject": "[RFC 20/97] tests: Add coverage for interface ID in NDP", "Date": "Tue, 28 Apr 2026 23:05:21 +0300", "Message-ID": "<20260428200639.40243-21-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "References": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260428_130746_695446_0B96DD36 ", "X-CRM114-Status": "GOOD ( 10.37 )", "X-Spam-Score": "-4.5 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: From: Ilan Peer <ilan.peer@intel.com> Add testing coverage\n for configuring interface ID as part of NDP request and NDP response, and\n parsing it from the NAN-NDP-CONNECTED events. Signed-off-by: Ilan Peer\n <ilan.peer@intel.com>\n --- tests/hwsim/test_nan.py | 52 ++++++++++++++++++++++++++++++ 1 file\n changed,\n 39 insertions(+), 13 deletions(-)\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "From: Ilan Peer <ilan.peer@intel.com>\n\nAdd testing coverage for configuring interface ID as part\nof NDP request and NDP response, and parsing it from the\nNAN-NDP-CONNECTED events.\n\nSigned-off-by: Ilan Peer <ilan.peer@intel.com>\n---\n tests/hwsim/test_nan.py | 52 ++++++++++++++++++++++++++++++-----------\n 1 file changed, 39 insertions(+), 13 deletions(-)", "diff": "diff --git a/tests/hwsim/test_nan.py b/tests/hwsim/test_nan.py\nindex b977e9c0a6..560672f015 100644\n--- a/tests/hwsim/test_nan.py\n+++ b/tests/hwsim/test_nan.py\n@@ -135,7 +135,7 @@ class NanDevice:\n \n def ndp_request(self, ndi, handle, peer_nmi, peer_id, ssi=None,\n qos_slots=0, qos_latency=0xffff, csid=None, password=None,\n- pmk=None):\n+ pmk=None, interface_id=None):\n cmd = f\"NAN_NDP_REQUEST handle={handle} ndi={ndi} peer_nmi={peer_nmi} peer_id={peer_id}\"\n \n params = [\n@@ -143,6 +143,7 @@ class NanDevice:\n (\"csid\", csid),\n (\"password\", password),\n (\"pmk\", pmk),\n+ (\"interface_id\", interface_id),\n ]\n \n cmd += \"\".join(f\" {name}={value}\" for name, value in params if value is not None)\n@@ -155,7 +156,7 @@ class NanDevice:\n def ndp_response(self, action, peer_nmi, ndi=None, peer_ndi=None,\n ndp_id=None, init_ndi=None, reason_code=None, ssi=None,\n qos_slots=0, qos_latency=0xffff, handle=None, csid=None,\n- password=None, pmk=None):\n+ password=None, pmk=None, interface_id=None):\n if action not in [\"accept\", \"reject\"]:\n raise Exception(f\"Invalid action: {action}. Must be 'accept' or 'reject'\")\n \n@@ -172,6 +173,7 @@ class NanDevice:\n (\"csid\", csid),\n (\"password\", password),\n (\"pmk\", pmk),\n+ (\"interface_id\", interface_id),\n ]\n \n cmd += \"\".join(f\" {name}={value}\" for name, value in params if value is not None)\n@@ -1027,7 +1029,8 @@ def _nan_discover_service(pub, sub, service_name, pssi, sssi):\n return pid, sid, paddr, saddr\n \n def _nan_ndp_request_and_accept(pub, sub, pid, sid, paddr, saddr, req_ssi, resp_ssi, csid=None,\n- password=None, pmk=None, counter=False, wrong_pwd=False, configure_schedule=True):\n+ password=None, pmk=None, counter=False, wrong_pwd=False,\n+ configure_schedule=True, pub_interface_id=None, sub_interface_id=None):\n \"\"\"\n Request NDP from subscriber and accept on publisher.\n \n@@ -1040,7 +1043,8 @@ def _nan_ndp_request_and_accept(pub, sub, pid, sid, paddr, saddr, req_ssi, resp_\n \n # NDP request\n if \"OK\" not in sub.ndp_request(sub.ndi_name, sid, paddr, pid, req_ssi,\n- csid=csid, password=password, pmk=pmk):\n+ csid=csid, password=password, pmk=pmk,\n+ interface_id=sub_interface_id):\n raise Exception(\"NDP request failed\")\n \n ev = pub.wpas.wait_event([\"NAN-NDP-REQUEST\"], timeout=5)\n@@ -1066,7 +1070,8 @@ def _nan_ndp_request_and_accept(pub, sub, pid, sid, paddr, saddr, req_ssi, resp_\n # Accept NDP request\n accept_pwd = \"WRONG_PWD\" if wrong_pwd else password\n if \"OK\" not in pub.ndp_response(\"accept\", saddr, ndi=pub.ndi_name, ndp_id=ndp_id, init_ndi=init_ndi,\n- handle=pid, ssi=resp_ssi, csid=csid, password=accept_pwd, pmk=pmk):\n+ handle=pid, ssi=resp_ssi, csid=csid, password=accept_pwd, pmk=pmk,\n+ interface_id=pub_interface_id):\n raise Exception(\"NDP response (accept) failed\")\n \n # Verify disconnection on wrong password\n@@ -1103,12 +1108,26 @@ def _nan_ndp_request_and_accept(pub, sub, pid, sid, paddr, saddr, req_ssi, resp_\n if ev is None:\n raise Exception(\"NAN-NDP-CONNECTED event not seen on publisher\")\n \n+ data_pub = split_nan_event(ev)\n+\n ev = sub.wpas.wait_event([\"NAN-NDP-CONNECTED\"], timeout=5)\n if ev is None:\n raise Exception(\"NAN-NDP-CONNECTED event not seen on subscriber\")\n \n logger.info(\"NDP connection established successfully\")\n \n+ data_sub = split_nan_event(ev)\n+\n+ if (sub_interface_id):\n+ interface_id = data_pub.get(\"interface_id\")\n+ if interface_id != sub_interface_id:\n+ raise Exception(\"No or invalid subscriber interface ID\")\n+\n+ if (pub_interface_id):\n+ interface_id = data_sub.get(\"interface_id\")\n+ if interface_id != pub_interface_id:\n+ raise Exception(\"No or invalid publisher interface ID\")\n+\n return ndp_id, init_ndi\n \n def _nan_ndp_terminate(pub, sub, paddr, init_ndi, ndp_id):\n@@ -1131,7 +1150,7 @@ def _nan_test_connectivity(pub, sub):\n test_connectivity(wpas_ndi_pub, wpas_ndi_sub, tos=0, ifname1=pub.ndi_name, ifname2=sub.ndi_name,\n max_tries=3, timeout=5, broadcast=False)\n \n-def _run_nan_dp(counter=False, csid=None, wrong_pwd=False, use_pmk=False):\n+def _run_nan_dp(counter=False, csid=None, wrong_pwd=False, use_pmk=False, use_interface_id=False):\n if use_pmk:\n pmk = \"00112233445566778899aabbccddeeff00112233445566778899aabbccddeeff\"\n pwd = None\n@@ -1139,6 +1158,10 @@ def _run_nan_dp(counter=False, csid=None, wrong_pwd=False, use_pmk=False):\n pwd = \"NAN\" if csid is not None else None\n pmk = None\n \n+ pub_interface_id, sub_interface_id = (\n+ (\"0011223344556677\", \"8899aabbccddeeff\") if use_interface_id else (None, None)\n+ )\n+\n with hwsim_nan_radios() as (wpas1, wpas2), \\\n NanDevice(wpas1, \"nan0\", \"ndi0\") as pub, NanDevice(wpas2, \"nan1\", \"ndi1\") as sub:\n \n@@ -1157,8 +1180,9 @@ def _run_nan_dp(counter=False, csid=None, wrong_pwd=False, use_pmk=False):\n \n result = _nan_ndp_request_and_accept(pub, sub, pid, sid, paddr, saddr, req_ssi=\"aabbcc\",\n resp_ssi=\"ddeeff\", csid=csid, password=pwd, pmk=pmk,\n- counter=counter, wrong_pwd=wrong_pwd)\n-\n+ counter=counter, wrong_pwd=wrong_pwd,\n+ pub_interface_id=pub_interface_id,\n+ sub_interface_id=sub_interface_id)\n if result is None:\n # wrong_pwd test completed\n return\n@@ -1168,16 +1192,18 @@ def _run_nan_dp(counter=False, csid=None, wrong_pwd=False, use_pmk=False):\n _nan_test_connectivity(pub, sub)\n _nan_ndp_terminate(pub, sub, paddr, init_ndi, ndp_id)\n \n-def run_nan_dp(country=\"US\", counter=False, csid=None, wrong_pwd=False, use_pmk=False):\n+def run_nan_dp(country=\"US\", counter=False, csid=None, wrong_pwd=False, use_pmk=False,\n+ use_interface_id=False):\n set_country(country)\n try:\n- _run_nan_dp(counter=counter, csid=csid, wrong_pwd=wrong_pwd, use_pmk=use_pmk)\n+ _run_nan_dp(counter=counter, csid=csid, wrong_pwd=wrong_pwd, use_pmk=use_pmk,\n+ use_interface_id=use_interface_id)\n finally:\n set_country(\"00\")\n \n def test_nan_dp_open(dev, apdev, params):\n \"\"\"NAN DP open\"\"\"\n- run_nan_dp()\n+ run_nan_dp(use_interface_id=True)\n \n def test_nan_dp_open_2_ndps(dev, apdev, params):\n \"\"\"NAN DP open - 2 NDPs with same peer\"\"\"\n@@ -1244,7 +1270,7 @@ def _run_nan_dp_2_ndps(secure_ndp2=False):\n \n def test_nan_dp_open_counter(dev, apdev, params):\n \"\"\"NAN DP open with counter proposal\"\"\"\n- run_nan_dp(counter=True)\n+ run_nan_dp(counter=True, use_interface_id=True)\n \n def test_nan_dp_sk_ccmp128(dev, apdev, params):\n \"\"\"NAN DP - 2way NDL + SK CCMP security\"\"\"\n@@ -1260,7 +1286,7 @@ def test_nan_dp_wrong_pwd(dev, apdev, params):\n \n def test_nan_dp_pmk(dev, apdev, params):\n \"\"\"NAN DP - 3way NDL + SK CCMP security with PMK\"\"\"\n- run_nan_dp(counter=True, csid=1, use_pmk=True)\n+ run_nan_dp(counter=True, csid=1, use_pmk=True, use_interface_id=True)\n \n def nan_pre_bootstrap(pub, sub, pmb=0x1):\n paddr = pub.wpas.own_addr()\n", "prefixes": [ "RFC", "20/97" ] }