Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229817/?format=api
{ "id": 2229817, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229817/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-15-andrei.otcheretianski@intel.com/", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.1/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428200639.40243-15-andrei.otcheretianski@intel.com>", "date": "2026-04-28T20:05:15", "name": "[14/97] NAN: Indicate if NDP disconnection is due to a failure", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ff2305b0cc30d89419266ca239a4656454964059", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.1/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-15-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 501927, "url": "http://patchwork.ozlabs.org/api/1.1/series/501927/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/list/?series=501927", "date": "2026-04-28T20:05:05", "name": "NAN: Group keys support, schedule update and more", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501927/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229817/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229817/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=22dZ+2+N;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=ZBEfMwZa;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s262S4qz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:08:30 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoik-00000002Ctu-1jyS;\n\tTue, 28 Apr 2026 20:07:50 +0000", "from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoiW-00000002CUE-2z0x\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:07:38 +0000", "from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:37 -0700", "from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:35 -0700" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=OTEPEjbRgVLzJF+9h5fePz2eEY59ZxXpDVHzPda9LiE=; b=22dZ+2+NZzIvo9\n\tcA40kIvHwclFe8J9TVkACSmspMLZqFKdu0YRDX1/6RIR4kBhoyEV4/gKIIDrCaJfDsxsNe7lUnOGG\n\tUCTdxwk4p8vwOYc+dnRHhy8B4fBEVtAiZxhc+3OoCM9l2Dc7y52q6fIt1Gn/rG6pn2ZcXpp8R36mJ\n\tcE60T4DdIPPO7/QkG2OqSBwP6yOlc3hF969KaiLLJOEidgMwbGfD7jetJrdpzT0BTt7wBSOsezgjb\n\tq641nD1bnhtv3g5rjjKNfHlfzEpI1qKJ6UqPaDriWyDGIFTh87Lp1zW4k5hEwO/U+thD30yEHex6X\n\t8+TbZnbp+VSDmX//9UYQ==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406857; x=1808942857;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=BadLGg0q7x2FsIktx30DYJgrZ01TOYN6O6uj4o0ghJw=;\n b=ZBEfMwZavMIWw402L2by+f0AsiVbXdCKpE+Irpl60RW3A4RNyr/jo5tc\n Pst7UcOSFHE8/I6Ai0ohTD0yKo59nygoichVVhAvuK6RKcKbRHRAfPAaZ\n HCIHayEM8BJr/2nqT7l4roFulJ3LoMQtmabG2rJUPW1uMID2ZYkjBiS4P\n OtUtNjHLW6jAs6AqNSmAfqHhdJO1WvdVKovctB/wxB4CCE7QIE2N9Rz0f\n qk2ywv5KdminyhDOGgapOAfsRlo54WnFI+5Wf0hvfKiYZWpuTMmLl6/oi\n t9+BxE3AtaY2JW7RDoyYFrNL1kFS//+damJcwJCTUuGazneBsxBOSta92\n g==;" ], "X-CSE-ConnectionGUID": [ "IuORZxrfTei44x6VFxckjw==", "3ZSrlBGwRlatZgmtlyEtPA==" ], "X-CSE-MsgGUID": [ "8EiM6qxGTryBveeFLfqGnQ==", "scuGqSh1RtOWl5w+56A4sA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11770\"; a=\"78519308\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519308\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257610010\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org", "Cc": "vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAndrei Otcheretianski <andrei.otcheretianski@intel.com>", "Subject": "[PATCH 14/97] NAN: Indicate if NDP disconnection is due to a failure", "Date": "Tue, 28 Apr 2026 23:05:15 +0300", "Message-ID": "<20260428200639.40243-15-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "References": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260428_130736_846317_886FB93B ", "X-CRM114-Status": "GOOD ( 15.86 )", "X-Spam-Score": "-4.5 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Add failure=0/1 parameter to NAN-NDP-DISCONNECTED\n notification.\n This allows to distinguish between gracefull NDP termination and NDP\n establishment\n failure. Signed-off-by: Andrei Otcheretianski\n <andrei.otcheretianski@intel.com>\n --- src/nan/nan.c | 13 ++++++++++--- src/nan/nan.h | 12 ++++++++----\n src/nan/nan_module_tests.c\n | 4 +++- wpa_supplicant/nan_suppl [...]\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Add failure=0/1 parameter to NAN-NDP-DISCONNECTED notification.\nThis allows to distinguish between gracefull NDP termination and NDP\nestablishment failure.\n\nSigned-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>\n---\n src/nan/nan.c | 13 ++++++++++---\n src/nan/nan.h | 12 ++++++++----\n src/nan/nan_module_tests.c | 4 +++-\n wpa_supplicant/nan_supplicant.c | 5 +++--\n wpa_supplicant/notify.c | 7 ++++---\n wpa_supplicant/notify.h | 3 ++-\n 6 files changed, 30 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/nan/nan.c b/src/nan/nan.c\nindex 792ef5fa20..3410313610 100644\n--- a/src/nan/nan.c\n+++ b/src/nan/nan.c\n@@ -1543,7 +1543,7 @@ static void nan_ndp_disconnected(struct nan_data *nan, struct nan_peer *peer,\n {\n \tconst u8 *local_ndi, *peer_ndi;\n \tstruct nan_ndp_id ndp_id;\n-\tbool remove_sta;\n+\tbool remove_sta, fail;\n \n \tos_memset(&ndp_id, 0, sizeof(ndp_id));\n \n@@ -1570,10 +1570,17 @@ static void nan_ndp_disconnected(struct nan_data *nan, struct nan_peer *peer,\n \t */\n \tremove_sta = !nan_peer_ndi_in_use(peer, peer_ndi);\n \n+\t/*\n+\t * NAN_NDP_STATE_NONE means the NDP was not in progress, thus\n+\t * the failure flag should be false.\n+\t */\n+\tfail = peer->ndp_setup.state != NAN_NDP_STATE_NONE;\n+\n \tif (nan->cfg->ndp_disconnected)\n \t\tnan->cfg->ndp_disconnected(nan->cfg->cb_ctx, &ndp_id,\n \t\t\t\t\t local_ndi, peer_ndi, reason,\n-\t\t\t\t\t locally_generated, remove_sta);\n+\t\t\t\t\t locally_generated, remove_sta,\n+\t\t\t\t\t fail);\n \n \tnan_ndp_setup_stop(nan, peer);\n }\n@@ -2156,7 +2163,7 @@ void nan_ndp_terminated(struct nan_data *nan, struct nan_peer *peer,\n \tif (nan->cfg->ndp_disconnected)\n \t\tnan->cfg->ndp_disconnected(nan->cfg->cb_ctx, ndp_id, local_ndi,\n \t\t\t\t\t peer_ndi, reason, false,\n-\t\t\t\t\t remove_sta);\n+\t\t\t\t\t remove_sta, false);\n \n \t/* Need to also remove the NDL if it is not needed */\n \tif (dl_list_empty(&peer->ndps) && !peer->ndp_setup.ndp)\ndiff --git a/src/nan/nan.h b/src/nan/nan.h\nindex 1188ffac77..2d9372f014 100644\n--- a/src/nan/nan.h\n+++ b/src/nan/nan.h\n@@ -495,15 +495,19 @@ struct nan_config {\n \t * false if triggered by the peer\n \t * @remove_sta: true if the NDI station should be removed (no other NDPs\n \t * using the same peer NDI)\n+\t * @failure: true if NDP setup failed (before connected), false if\n+\t * graceful disconnection after NDP was established\n \t *\n-\t * This callback notifies that an NDP has been disconnected. It can be\n-\t * called both during NDP establishment (indicating failure) or after\n-\t * successful establishment (indicating termination).\n+\t * This callback notifies that an NDP has been disconnected. When\n+\t * @failure is true, NDP setup failed before connection was established.\n+\t * When @failure is false, it indicates graceful termination after NDP\n+\t * was successfully connected.\n \t */\n \tvoid (*ndp_disconnected)(void *ctx, struct nan_ndp_id *ndp_id,\n \t\t\t\t const u8 *local_ndi, const u8 *peer_ndi,\n \t\t\t\t enum nan_reason reason,\n-\t\t\t\t bool locally_generated, bool remove_sta);\n+\t\t\t\t bool locally_generated, bool remove_sta,\n+\t\t\t\t bool failure);\n \n \t/**\n \t * get_chans - Get the prioritized allowed channel information to be\ndiff --git a/src/nan/nan_module_tests.c b/src/nan/nan_module_tests.c\nindex 9f376278d1..43b8a57c45 100644\n--- a/src/nan/nan_module_tests.c\n+++ b/src/nan/nan_module_tests.c\n@@ -641,6 +641,7 @@ static int nan_test_ndp_connected_cb(void *ctx,\n * @reason: Reason for disconnection\n * @locally_generated: true if locally generated, false if triggered by peer\n * @remove_sta: true if the NDI station should be removed\n+ * @failure: true if NDP setup failed, false if graceful disconnection\n *\n * The handling of the event is done asynchronously through the NAN test actions\n * processing.\n@@ -650,7 +651,8 @@ static void nan_test_ndp_disconnected_cb(void *ctx, struct nan_ndp_id *ndp_id,\n \t\t\t\t\t const u8 *peer_ndi,\n \t\t\t\t\t enum nan_reason reason,\n \t\t\t\t\t bool locally_generated,\n-\t\t\t\t\t bool remove_sta)\n+\t\t\t\t\t bool remove_sta,\n+\t\t\t\t\t bool failure)\n {\n \tstruct nan_device *dev = ctx;\n \ndiff --git a/wpa_supplicant/nan_supplicant.c b/wpa_supplicant/nan_supplicant.c\nindex e8c5b25c4c..a1fff99aba 100644\n--- a/wpa_supplicant/nan_supplicant.c\n+++ b/wpa_supplicant/nan_supplicant.c\n@@ -639,14 +639,15 @@ static void wpas_nan_ndp_disconnected_cb(void *ctx, struct nan_ndp_id *ndp_id,\n \t\t\t\t\t const u8 *peer_ndi,\n \t\t\t\t\t enum nan_reason reason,\n \t\t\t\t\t bool locally_generated,\n-\t\t\t\t\t bool remove_sta)\n+\t\t\t\t\t bool remove_sta,\n+\t\t\t\t\t bool failure)\n {\n \tstruct wpa_supplicant *wpa_s = ctx;\n \n \twpas_nan_remove_ndi_sta(wpa_s, local_ndi, peer_ndi, remove_sta);\n \twpas_notify_nan_ndp_disconnected(wpa_s, ndp_id->peer_nmi,\n \t\t\t\t\t ndp_id->id, local_ndi, peer_ndi,\n-\t\t\t\t\t reason, locally_generated);\n+\t\t\t\t\t reason, locally_generated, failure);\n }\n \n \ndiff --git a/wpa_supplicant/notify.c b/wpa_supplicant/notify.c\nindex c445aba316..2881fddab2 100644\n--- a/wpa_supplicant/notify.c\n+++ b/wpa_supplicant/notify.c\n@@ -1436,14 +1436,15 @@ void wpas_notify_nan_ndp_disconnected(struct wpa_supplicant *wpa_s,\n \t\t\t\t const u8 *local_ndi,\n \t\t\t\t const u8 *peer_ndi,\n \t\t\t\t enum nan_reason reason,\n-\t\t\t\t bool locally_generated)\n+\t\t\t\t bool locally_generated,\n+\t\t\t\t bool failure)\n {\n \twpa_msg_global(wpa_s, MSG_INFO, NAN_NDP_DISCONNECTED\n \t\t \"peer=\" MACSTR \" ndp_id=%u local_ndi=\" MACSTR\n-\t\t \" peer_ndi=\" MACSTR \" reason=%u locally_generated=%d\",\n+\t\t \" peer_ndi=\" MACSTR \" reason=%u locally_generated=%d, failure=%d\",\n \t\t MAC2STR(peer_nmi), ndp_id,\n \t\t MAC2STR(local_ndi), MAC2STR(peer_ndi), reason,\n-\t\t locally_generated);\n+\t\t locally_generated, failure);\n }\n \n \ndiff --git a/wpa_supplicant/notify.h b/wpa_supplicant/notify.h\nindex 1a593a4fdb..3c2feece9e 100644\n--- a/wpa_supplicant/notify.h\n+++ b/wpa_supplicant/notify.h\n@@ -243,7 +243,8 @@ void wpas_notify_nan_ndp_disconnected(struct wpa_supplicant *wpa_s,\n \t\t\t\t const u8 *peer_nmi, u32 ndp_id,\n \t\t\t\t const u8 *local_ndi, const u8 *peer_ndi,\n \t\t\t\t enum nan_reason reason,\n-\t\t\t\t bool locally_generated);\n+\t\t\t\t bool locally_generated,\n+\t\t\t\t bool failure);\n void wpas_notify_nan_cluster_join(struct wpa_supplicant *wpa_s,\n \t\t\t\t const u8 *cluster_id, bool new_cluster);\n void wpas_notify_nan_pairing_status(struct wpa_supplicant *wpa_s,\n", "prefixes": [ "14/97" ] }