Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229804/?format=api
{ "id": 2229804, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229804/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-8-andrei.otcheretianski@intel.com/", "project": { "id": 22, "url": "http://patchwork.ozlabs.org/api/1.1/projects/22/?format=api", "name": "HostAP Development", "link_name": "hostap", "list_id": "hostap.lists.infradead.org", "list_email": "hostap@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428200639.40243-8-andrei.otcheretianski@intel.com>", "date": "2026-04-28T20:05:08", "name": "[07/97] NAN: Send NAF with rejection on schedule validation error", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c68f1830a97bcdeff1fa4af53e86e37bb7333ed1", "submitter": { "id": 62065, "url": "http://patchwork.ozlabs.org/api/1.1/people/62065/?format=api", "name": "Andrei Otcheretianski", "email": "andrei.otcheretianski@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/hostap/patch/20260428200639.40243-8-andrei.otcheretianski@intel.com/mbox/", "series": [ { "id": 501927, "url": "http://patchwork.ozlabs.org/api/1.1/series/501927/?format=api", "web_url": "http://patchwork.ozlabs.org/project/hostap/list/?series=501927", "date": "2026-04-28T20:05:05", "name": "NAN: Group keys support, schedule update and more", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501927/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229804/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229804/checks/", "tags": {}, "headers": { "Return-Path": "\n <hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=bkgPVulZ;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=lpZjYo3P;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4s1X4m0Lz23gd\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 06:08:00 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoiO-00000002CJL-0Fiw;\n\tTue, 28 Apr 2026 20:07:28 +0000", "from mgamail.intel.com ([198.175.65.16])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wHoiL-00000002CHj-2uYX\n\tfor hostap@lists.infradead.org;\n\tTue, 28 Apr 2026 20:07:26 +0000", "from fmviesa001.fm.intel.com ([10.60.135.141])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:26 -0700", "from iapp347.iil.intel.com (HELO 87c02287900a.iil.intel.com)\n ([10.167.28.6])\n by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 13:07:24 -0700" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=EPrGXKvs7ZmGgrkAt7lAdYZM1F27G+VFE9xO48cnxFA=; b=bkgPVulZ+gtuMx\n\tUEfq7sxpr1N5vQ6gIoO/FYVoSxb6RJbls3ebL5fS8OM3Mg2oAEXLqSWr3fMTfqO2iJ3Fv3hkdSrhJ\n\t16AqPb/iUe0YikiW02+dw7g9XrRhPiB34qleOGB+BxgZrFyQSCquQKIDMerMcfXs1OXnOOuW/zCvd\n\tmrMGlFQRMvFRufvcMx7tsubzf+FHYH8rV3hHh/r4lzd54NbcIq1QPrznayjogZcJPvY1PVqELjYjc\n\tnX77DIZrh37t2F9Psk253o8ZLKE8aTYh2CBAQPpGamn/cas8h9D4dnPcRb5wPNCaD2jupI8XyW3o9\n\tNaMzXWRkMWc25eJXMz/Q==;", "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777406846; x=1808942846;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=3pp8zLO6ZkxNW6O39RFV01CUuyVdxosX7BL1v8fFtKk=;\n b=lpZjYo3PRdh8YyL1Ubz2cp4vED/SBD9DvrI43u/LuKZSWPRjWkLg7NgI\n av2cHG7rZEmqjp/COCQHCOvWF3AK9J+NDsSyiDIgxNY10iIb0zLp0nfY5\n zIMm3ULLGToKCka3IM8wJxHqtZodPU20RiztVg63hQRmcmzc4He+z7LUw\n M8BKa6HcXy9vy9KYXB2fFpsQixqGi6MgP5qYfb+ENiZ2oUiy/JpjA3LAS\n n2lKsG8jV+EK+xkDHf/HIcfd8aSNg8eckaLcx2QOu50otYY430r22njXs\n gfcjOALecWAUIysKILWGaC8zZHpDFRu0jf4DjpDHapMBUJqAN1CKePkQY\n g==;" ], "X-CSE-ConnectionGUID": [ "C4kuKFAOSJyhZNGUQjRKtQ==", "yAcM9GevRImOxEEFDe14Yw==" ], "X-CSE-MsgGUID": [ "KFxd4gKWTXO0qSTe1byaTA==", "YkKicUFcQ7OgrqVTpS/l8A==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11770\"; a=\"78519281\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"78519281\"", "E=Sophos;i=\"6.23,204,1770624000\";\n d=\"scan'208\";a=\"257609940\"" ], "X-ExtLoop1": "1", "From": "Andrei Otcheretianski <andrei.otcheretianski@intel.com>", "To": "hostap@lists.infradead.org", "Cc": "vamsin@qti.qualcomm.com,\n\tmaheshkkv@google.com,\n\tAndrei Otcheretianski <andrei.otcheretianski@intel.com>", "Subject": "[PATCH 07/97] NAN: Send NAF with rejection on schedule validation\n error", "Date": "Tue, 28 Apr 2026 23:05:08 +0300", "Message-ID": "<20260428200639.40243-8-andrei.otcheretianski@intel.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "References": "<20260428200639.40243-1-andrei.otcheretianski@intel.com>", "MIME-Version": "1.0", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260428_130725_770295_0A447FD3 ", "X-CRM114-Status": "GOOD ( 11.71 )", "X-Spam-Score": "-4.5 (----)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: Previously, if NDP request wasn't valid,\n the publisher wouldn't\n respond at all and silently ignore the request. This is incorrect, as the\n spec requires to explicitly send NAF response with \"reject\" st [...]\n Content analysis details: (-4.5 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/,\n medium trust\n [198.175.65.16 listed in list.dnswl.org]\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.1 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "hostap@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<hostap.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/hostap/>", "List-Post": "<mailto:hostap@lists.infradead.org>", "List-Help": "<mailto:hostap-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/hostap>,\n <mailto:hostap-request@lists.infradead.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "\"Hostap\" <hostap-bounces@lists.infradead.org>", "Errors-To": "hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "Previously, if NDP request wasn't valid, the publisher wouldn't respond\nat all and silently ignore the request. This is incorrect, as the spec\nrequires to explicitly send NAF response with \"reject\" status and a\ncorresponding reason code for invalid NDL cases. Otherwise, the\nsubscriber can only rely on internal timeouts.\n\nSigned-off-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>\n---\n src/nan/nan.c | 11 ++++++++++-\n src/nan/nan_ndl.c | 8 ++++++--\n 2 files changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/nan/nan.c b/src/nan/nan.c\nindex f06d37cb63..52db635a96 100644\n--- a/src/nan/nan.c\n+++ b/src/nan/nan.c\n@@ -1549,7 +1549,16 @@ static int nan_action_rx_ndp(struct nan_data *nan, struct nan_peer *peer,\n \t\t\treturn -1;\n \t\t}\n \n-\t\tnan_ndp_action_notif(nan, peer);\n+\t\tif (peer->ndl->status == NAN_NDL_STATUS_REJECTED) {\n+\t\t\tnan_ndp_setup_failure(nan, peer,\n+\t\t\t\t\t NAN_REASON_NDL_UNACCEPTABLE,\n+\t\t\t\t\t false);\n+\t\t\tif (peer->ndl->send_naf_on_error)\n+\t\t\t\tnan_action_send(nan, peer, resp_oui);\n+\t\t\tnan_ndp_setup_stop(nan, peer);\n+\t\t} else {\n+\t\t\tnan_ndp_action_notif(nan, peer);\n+\t\t}\n \t\treturn 0;\n \t}\n \ndiff --git a/src/nan/nan_ndl.c b/src/nan/nan_ndl.c\nindex 1f7bd4f1ad..8ab9907737 100644\n--- a/src/nan/nan_ndl.c\n+++ b/src/nan/nan_ndl.c\n@@ -211,6 +211,7 @@ static bool nan_ndl_validate_peer_avail(struct nan_data *nan,\n \tif (!ret) {\n \t\twpa_printf(MSG_DEBUG,\n \t\t\t \"NAN: Peer avail: Immutable is not covered by avail\");\n+\t\tpeer->ndl->reason = NAN_REASON_IMMUTABLE_UNACCEPTABLE;\n \t\treturn ret;\n \t}\n \n@@ -221,6 +222,7 @@ static bool nan_ndl_validate_peer_avail(struct nan_data *nan,\n \tif (!ret) {\n \t\twpa_printf(MSG_DEBUG,\n \t\t\t \"NAN: Peer avail: NDC is not covered by avail\");\n+\t\tpeer->ndl->reason = NAN_REASON_NDL_UNACCEPTABLE;\n \t\treturn ret;\n \t}\n \n@@ -883,8 +885,10 @@ static int nan_ndl_attr_handle_req(struct nan_data *nan, struct nan_peer *peer,\n \t}\n \n \tret = nan_ndl_validate_peer_avail(nan, peer);\n-\tif (!ret)\n-\t\tgoto fail;\n+\tif (!ret) {\n+\t\tndl->status = NAN_NDL_STATUS_REJECTED;\n+\t\tndl->send_naf_on_error = 1;\n+\t}\n \n \tnan_ndl_set_state(nan, ndl, NAN_NDL_STATE_REQ_RECV);\n \n", "prefixes": [ "07/97" ] }