Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229691/?format=api
{ "id": 2229691, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229691/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428160103.3551125-3-jim.shu@sifive.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428160103.3551125-3-jim.shu@sifive.com>", "date": "2026-04-28T16:01:01", "name": "[2/4] hw/intc: riscv_aplic: Add reset API to APLIC", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d73859b2f308f64aa051fdae7372f08db808a779", "submitter": { "id": 83153, "url": "http://patchwork.ozlabs.org/api/1.1/people/83153/?format=api", "name": "Jim Shu", "email": "jim.shu@sifive.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428160103.3551125-3-jim.shu@sifive.com/mbox/", "series": [ { "id": 501889, "url": "http://patchwork.ozlabs.org/api/1.1/series/501889/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501889", "date": "2026-04-28T16:01:00", "name": "Minor fixes and enhancements of RISC-V AIA devices", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501889/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229691/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229691/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256\n header.s=google header.b=a6gfP3kn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4lbs6q6jz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 02:03:53 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHku2-0003zq-AC; Tue, 28 Apr 2026 12:03:14 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jim.shu@sifive.com>)\n id 1wHksO-00036F-VI\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:01:39 -0400", "from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <jim.shu@sifive.com>)\n id 1wHksK-0003iU-9O\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:01:32 -0400", "by mail-pg1-x536.google.com with SMTP id\n 41be03b00d2f7-c76b9efc299so4831078a12.0\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 09:01:26 -0700 (PDT)", "from hsinchu26.internal.sifive.com ([210.176.154.34])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-834daf30fbfsm3002331b3a.33.2026.04.28.09.01.22\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 09:01:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=sifive.com; s=google; t=1777392085; x=1777996885; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=CgXtKy+iVz/buq8xrh+OuZeU7ZMd1UBY6bFU951VKdw=;\n b=a6gfP3knLsX4FtRJhfd+HzAp5azDYWJ38TrYQ8VeAgo0IPzUGamnfmfuEo8C5gWEdt\n K46RBFZHwzVHpNlbtlrbuB3vxAj3Gm1KSw4SsY7uoiJHsOyVDsFLxPTlXFuf5829pDWh\n xH/I+hgnHRtCKY6/OBfGvHxN/nw4kvzk0H08qAQAq5onjJa1tKETUCosZij/vPdirDv2\n MB34H2MuhbfPsxPaw/lATaKbHuqrvL+lXsk/A2ZcTmG8LG8FWH/MmmCE8Hbyx+IugzRl\n D5EmHkOp7Q2DL18NsdQ9tG6MK5lPcWZxVfg1vYM5OJKxekl7MTvpL1sXbN62LNOru11b\n DCGA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777392085; x=1777996885;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=CgXtKy+iVz/buq8xrh+OuZeU7ZMd1UBY6bFU951VKdw=;\n b=lFDUIpKgUwXYrxJBPA9Ab9lqlUsfCvdA4zq83DcPunQVGVHm46wVkFqRlDDBgSl4X4\n nP48KXTLG+jG0y6y97DZhOOL17hNPeY3JRT94puTIh4WLJq1taFcqzUFsY04Zm8f63yd\n qccDDDlPwm03rJVvqVaVw/xsxxEGTJMMi1JlEAseZNq0TsE7UfrueRhWbEc9pQ2ixHyB\n /6uBGxST4DkoFRxqyEBKMsnFHazbxWh8dXEEIXPpiZfg/EtUeOiezOJyzCQxiAtEKKjE\n XXFSPurT9aOJGjDOWRd4HUTxgF6ndqIcu6pmbWsh4beTlN6TcxATx7r9+s3Pedpvw4Ch\n PcSA==", "X-Gm-Message-State": "AOJu0YxCay4MHKh8Z7fEHfptoej0i16Sg3klxDyO4/ko3NeisJmOyISp\n BUMpGJgObODYJtPU6lDXd29SQYqq1fa11xxZekY8KTKWFtpi7mpT/ZYvw1MuTJt1En2CvWV7zkA\n 8gdnU+90w9p/QvtDHNLIts2E3VPsD0mgm3KhTS2eDJpuadXZmARcFunDV+KVHYam3rPSDsPqIAV\n bwQkJZQQG3MvyIgBOYTyzYF+atLHHcfUTG/5qC402j", "X-Gm-Gg": "AeBDietRMLIF1zQRdaunuPa+L0mYVMVCeP0a2mF2CWx0cE/JIZcL3Mf0s44iwF9GY64\n inkBWtcznjsWQ7ArXUrtwIXE0KzDM76LkQQWB6fjlz5ZaB2cqe4TV3CSIkwjgu6m3V+fC0e9MZg\n aJ4aFNWCYJpTqBZMFUxIOQf0WmByJd3GOonFeSlpLaDoWo3+XTcVnUn/KANIZrVKYnkoBXr3sEe\n 9nus8qB7vjCB6dgFbokE8a4EnoIkZXi6UwHG+SWsH9JqO1dRPLQlXVTo3ubotGohe6ixGv9S+DX\n AEMMw3HK9MJ4fRoaZRiPx3eeCNPT//BUFMS8XZEazVgQVJ21HnxvBVXMrZVAiBnPgaamY/GmwQJ\n TWAQiH3Vha7WBLeHKO9Ms4z9F8X0uxtfDR8iWvzxMus4woB30tkH2Q1OR2TVFt8pRpZJ2xDA1Ul\n qNoIqi9NJozdrO27cy0UUqf4f7HjeVE/M/qmAlrt5uq6Fvr/gXN4QSMUQ=", "X-Received": "by 2002:a05:6a21:3294:b0:3a2:d976:2210 with SMTP id\n adf61e73a8af0-3a39c04e43dmr4507133637.8.1777392084925;\n Tue, 28 Apr 2026 09:01:24 -0700 (PDT)", "From": "Jim Shu <jim.shu@sifive.com>", "To": "qemu-devel@nongnu.org,\n\tqemu-riscv@nongnu.org", "Cc": "Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>,\n Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, Jim Shu <jim.shu@sifive.com>,\n \"Fea . Wang\" <fea.wang@sifive.com>", "Subject": "[PATCH 2/4] hw/intc: riscv_aplic: Add reset API to APLIC", "Date": "Wed, 29 Apr 2026 00:01:01 +0800", "Message-ID": "<20260428160103.3551125-3-jim.shu@sifive.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260428160103.3551125-1-jim.shu@sifive.com>", "References": "<20260428160103.3551125-1-jim.shu@sifive.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::536;\n envelope-from=jim.shu@sifive.com; helo=mail-pg1-x536.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Clearing APLIC registers and qemu_irq in the reset function\n\nSigned-off-by: Jim Shu <jim.shu@sifive.com>\nSigned-off-by: Fea.Wang <fea.wang@sifive.com>\n---\n hw/intc/riscv_aplic.c | 45 ++++++++++++++++++++++++++++++++++++++-----\n 1 file changed, 40 insertions(+), 5 deletions(-)", "diff": "diff --git a/hw/intc/riscv_aplic.c b/hw/intc/riscv_aplic.c\nindex 791e0b01b96..a04e0e1a898 100644\n--- a/hw/intc/riscv_aplic.c\n+++ b/hw/intc/riscv_aplic.c\n@@ -892,6 +892,44 @@ static const MemoryRegionOps riscv_aplic_ops = {\n }\n };\n \n+static void riscv_aplic_reset_enter(Object *obj, ResetType type)\n+{\n+ RISCVAPLICState *aplic = RISCV_APLIC(obj);\n+ int i;\n+\n+ aplic->domaincfg = 0;\n+ memset(aplic->sourcecfg, 0, sizeof(uint32_t) * aplic->num_irqs);\n+ memset(aplic->target, 0, sizeof(uint32_t) * aplic->num_irqs);\n+ if (!aplic->msimode) {\n+ for (i = 0; i < aplic->num_irqs; i++) {\n+ aplic->target[i] = 1;\n+ }\n+ }\n+\n+ for (i = 0; i < aplic->num_irqs ; i++) {\n+ riscv_aplic_set_enabled_raw(aplic, i, false);\n+ }\n+\n+ /* Need to unlock [ms]msicfgaddrh.L */\n+ aplic->mmsicfgaddr = 0;\n+ aplic->mmsicfgaddrH = 0;\n+ aplic->smsicfgaddr = 0;\n+ aplic->smsicfgaddrH = 0;\n+\n+ if (!aplic->msimode) {\n+ /* Reset IDC registers only in non-MSI mode */\n+ for (i = 0; i < aplic->num_harts; i++) {\n+ aplic->idelivery[i] = 0;\n+ aplic->iforce[i] = 0;\n+ aplic->ithreshold[i] = 0;\n+ }\n+\n+ for (i = 0; i < aplic->num_harts; i++) {\n+ qemu_irq_lower(aplic->external_irqs[i]);\n+ }\n+ }\n+}\n+\n static void riscv_aplic_realize(DeviceState *dev, Error **errp)\n {\n uint32_t i;\n@@ -925,11 +963,6 @@ static void riscv_aplic_realize(DeviceState *dev, Error **errp)\n aplic->sourcecfg = g_new0(uint32_t, aplic->num_irqs);\n aplic->state = g_new0(uint32_t, aplic->num_irqs);\n aplic->target = g_new0(uint32_t, aplic->num_irqs);\n- if (!aplic->msimode) {\n- for (i = 0; i < aplic->num_irqs; i++) {\n- aplic->target[i] = 1;\n- }\n- }\n aplic->idelivery = g_new0(uint32_t, aplic->num_harts);\n aplic->iforce = g_new0(uint32_t, aplic->num_harts);\n aplic->ithreshold = g_new0(uint32_t, aplic->num_harts);\n@@ -1014,9 +1047,11 @@ static const VMStateDescription vmstate_riscv_aplic = {\n static void riscv_aplic_class_init(ObjectClass *klass, const void *data)\n {\n DeviceClass *dc = DEVICE_CLASS(klass);\n+ ResettableClass *rc = RESETTABLE_CLASS(klass);\n \n device_class_set_props(dc, riscv_aplic_properties);\n dc->realize = riscv_aplic_realize;\n+ rc->phases.enter = riscv_aplic_reset_enter;\n dc->vmsd = &vmstate_riscv_aplic;\n }\n \n", "prefixes": [ "2/4" ] }