Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229689/?format=api
{ "id": 2229689, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229689/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428160120.12130-1-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428160120.12130-1-farosas@suse.de>", "date": "2026-04-28T16:01:20", "name": "[v1] tests/qtest: Avoid timers from default devices", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "759854bce16f24dec5f4d26cfd545ee36f79a546", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/1.1/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428160120.12130-1-farosas@suse.de/mbox/", "series": [ { "id": 501888, "url": "http://patchwork.ozlabs.org/api/1.1/series/501888/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501888", "date": "2026-04-28T16:01:20", "name": "[v1] tests/qtest: Avoid timers from default devices", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501888/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229689/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229689/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=rP8B2Rrw;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=/SFVwytb;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=pdVDzyw2;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=pDtaWcMF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4lbM3Wj5z1yJH\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 02:03:25 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHktz-0003vB-CY; Tue, 28 Apr 2026 12:03:11 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wHksW-0003AK-MP\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:01:42 -0400", "from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1wHksS-0003le-Uh\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 12:01:40 -0400", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 543A05BD3F;\n Tue, 28 Apr 2026 16:01:28 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8D434593B0;\n Tue, 28 Apr 2026 16:01:26 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id ducXF9bZ8Gm8CQAAD6G6ig\n (envelope-from <farosas@suse.de>); Tue, 28 Apr 2026 16:01:26 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777392093;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=5QS08LdqDUIEpDxve/9nBXhEGDIUiWJTjDQzQQnp94I=;\n b=rP8B2Rrw0cBwBNdvw0CnGuBrqJGon6EScfFnKqOk9j++Hyifv4TlA5ryGgC2z414nUfYXo\n 7XZnHoMhtQ8JtZjOKVCvhmaGTx3a7O0cKIcGey2DH3tsJXj1Vk3w1jNIB+mP1GKMs9TGlj\n 9hfAquQGgDUpQP8zBpZ6GksUppiOa9U=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777392093;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=5QS08LdqDUIEpDxve/9nBXhEGDIUiWJTjDQzQQnp94I=;\n b=/SFVwytbZF8OT+bxqqQnfRGvBk49eQqaufNFbJUXV+xvVQX5e9MwQS3rz4uU8m1uNlV/9r\n LuXmj5jP24GPSIAQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777392088;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=5QS08LdqDUIEpDxve/9nBXhEGDIUiWJTjDQzQQnp94I=;\n b=pdVDzyw2A/qWj/MlGPCMH5noioGFViowyqzesj/gqZE/EYSQ70JpqLeiIFa92i6aGetXoY\n uLZzbnGy/4084IgDreljAJtGA4r2f/hsvl649hLQy38k/xn+dN/9LMOBQ2UGdsPmt6W3zT\n 5WLyJmmLaxqGVUGJCLFGCoz8YSAPibk=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777392088;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=5QS08LdqDUIEpDxve/9nBXhEGDIUiWJTjDQzQQnp94I=;\n b=pDtaWcMFGW2kGrfV7NQBMTYWeXGAewvdwDnTq7NPM0lsBW3Viv8bnOyk005ejJTWyQ8ljq\n LuizQyZcnIEK7YDQ==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Stefan Hajnoczi <stefanha@redhat.com>, Tyrone Ting <kfting@nuvoton.com>,\n Hao Wu <wuhaotsh@google.com>, Laurent Vivier <lvivier@redhat.com>,\n Paolo Bonzini <pbonzini@redhat.com>", "Subject": "[PATCH v1] tests/qtest: Avoid timers from default devices", "Date": "Tue, 28 Apr 2026 13:01:20 -0300", "Message-ID": "<20260428160120.12130-1-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[];\n MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[];\n RCPT_COUNT_SEVEN(0.00)[7];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[];\n TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid,\n suse.de:email, linaro.org:email]", "X-Spam-Score": "-3.30", "Received-SPF": "pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Having default devices enabled while testing timers leads to\nnon-deterministic behavior on the usage of the QTest\nqtest_clock_step_next() command as the implicit devices can have\ntimers of their own that may have a deadline more recent than the\ntested device.\n\nIn the particular case of npcm7xx-timer-test, having SLIRP enabled in\nthe QEMU binary may cause the net_slirp_timer to shadow the clock\nadvance that was expected to trigger the NPCM7xx timer:\n\nnpcm7xx_timer-test.c:475:test_periodic_interrupt:\n assertion failed (tim_read(td, TISR) == tim_timer_bit(td)): (0x00000000 == 0x00000010)\nnpcm7xx_timer-test.c:476:test_periodic_interrupt:\n'qtest_get_irq(global_qtest, tim_timer_irq(td))' should be TRUE\n\nAdd the -nodefaults command line option to all tests that invoke\nqtest_clock_step_next.\n\nCC: Alex Bennée <alex.bennee@linaro.org>\nReported-by: Stefan Hajnoczi <stefanha@redhat.com>\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n tests/qtest/npcm7xx_timer-test.c | 2 +-\n tests/qtest/pflash-cfi02-test.c | 4 ++--\n tests/qtest/rtc-test.c | 2 +-\n 3 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/tests/qtest/npcm7xx_timer-test.c b/tests/qtest/npcm7xx_timer-test.c\nindex 43711049ca..0e2284669d 100644\n--- a/tests/qtest/npcm7xx_timer-test.c\n+++ b/tests/qtest/npcm7xx_timer-test.c\n@@ -551,7 +551,7 @@ int main(int argc, char **argv)\n }\n }\n \n- qtest_start(\"-machine npcm750-evb\");\n+ qtest_start(\"-machine npcm750-evb -nodefaults\");\n qtest_irq_intercept_in(global_qtest, \"/machine/soc/a9mpcore/gic\");\n ret = g_test_run();\n qtest_end();\ndiff --git a/tests/qtest/pflash-cfi02-test.c b/tests/qtest/pflash-cfi02-test.c\nindex 8c073efcb4..65b35811fa 100644\n--- a/tests/qtest/pflash-cfi02-test.c\n+++ b/tests/qtest/pflash-cfi02-test.c\n@@ -260,7 +260,7 @@ static void test_geometry(const void *opaque)\n {\n const FlashConfig *config = opaque;\n QTestState *qtest;\n- qtest = qtest_initf(\"-M musicpal\"\n+ qtest = qtest_initf(\"-M musicpal -nodefaults\"\n \" -drive if=pflash,file=%s,format=raw,copy-on-read=on\"\n /* Device geometry properties. */\n \" -global driver=cfi.pflash02,\"\n@@ -580,7 +580,7 @@ static void test_cfi_in_autoselect(const void *opaque)\n {\n const FlashConfig *config = opaque;\n QTestState *qtest;\n- qtest = qtest_initf(\"-M musicpal\"\n+ qtest = qtest_initf(\"-M musicpal -nodefaults\"\n \" -drive if=pflash,file=%s,format=raw,copy-on-read=on\",\n image_path);\n FlashConfig explicit_config = expand_config_defaults(config);\ndiff --git a/tests/qtest/rtc-test.c b/tests/qtest/rtc-test.c\nindex 02ed4e1238..09b6de9166 100644\n--- a/tests/qtest/rtc-test.c\n+++ b/tests/qtest/rtc-test.c\n@@ -691,7 +691,7 @@ int main(int argc, char **argv)\n \n g_test_init(&argc, &argv, NULL);\n \n- s = qtest_start(\"-rtc clock=vm\");\n+ s = qtest_start(\"-rtc clock=vm -nodefaults\");\n qtest_irq_intercept_in(s, \"ioapic\");\n \n qtest_add_func(\"/rtc/check-time/bcd\", bcd_check_time);\n", "prefixes": [ "v1" ] }