Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229650/?format=api
{ "id": 2229650, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229650/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260428151913.584739-2-kadlec@netfilter.org/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.1/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260428151913.584739-2-kadlec@netfilter.org>", "date": "2026-04-28T15:19:09", "name": "[1/5] netfilter: ipset: Fix data race between add and list header in all hash types", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "522c2a88b848ad3180e48026c837f6729d66450a", "submitter": { "id": 77226, "url": "http://patchwork.ozlabs.org/api/1.1/people/77226/?format=api", "name": "Jozsef Kadlecsik", "email": "kadlec@netfilter.org" }, "delegate": { "id": 11902, "url": "http://patchwork.ozlabs.org/api/1.1/users/11902/?format=api", "username": "strlen", "first_name": "Florian", "last_name": "Westphal", "email": "fw@strlen.de" }, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260428151913.584739-2-kadlec@netfilter.org/mbox/", "series": [ { "id": 501876, "url": "http://patchwork.ozlabs.org/api/1.1/series/501876/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501876", "date": "2026-04-28T15:19:09", "name": "netfilter: ipset fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501876/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229650/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229650/checks/", "tags": {}, "headers": { "Return-Path": "\n <netfilter-devel+bounces-12258-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=blackhole.kfki.hu header.i=@blackhole.kfki.hu\n header.a=rsa-sha256 header.s=20151130 header.b=r2StriYg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12258-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=blackhole.kfki.hu\n header.i=@blackhole.kfki.hu header.b=\"r2StriYg\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.6.0.50", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=blackhole.kfki.hu" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4kck4gnYz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 01:19:34 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id E4F7F3013869\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 15:19:31 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 277D23B2FC8;\n\tTue, 28 Apr 2026 15:19:28 +0000 (UTC)", "from smtp-out.kfki.hu (smtp-out.kfki.hu [148.6.0.50])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C08C82C2346\n\tfor <netfilter-devel@vger.kernel.org>; Tue, 28 Apr 2026 15:19:22 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.kfki.hu (Postfix) with ESMTP id 4g4kcM3vSszGFDLt;\n\tTue, 28 Apr 2026 17:19:15 +0200 (CEST)", "from smtp1.kfki.hu ([127.0.0.1])\n by localhost (smtp1.kfki.hu [127.0.0.1]) (amavis, port 10026) with ESMTP\n id JKC-TAcjYkz5; Tue, 28 Apr 2026 17:19:13 +0200 (CEST)", "from mentat.rmki.kfki.hu (unknown [148.6.40.64])\n\t(Authenticated sender: kadlecsik.jozsef@wigner.hu)\n\tby smtp1.kfki.hu (Postfix) with ESMTPSA id 4g4kcK4dNKzGFDMb;\n\tTue, 28 Apr 2026 17:19:13 +0200 (CEST)", "by mentat.rmki.kfki.hu (Postfix, from userid 1000)\n\tid 785B6140503; Tue, 28 Apr 2026 17:19:13 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777389566; cv=none;\n b=K9SG7wLGiZOgbrFgQhkGtalbFK2F2X3acN3kDtH8EPlklct3lQtVIbdTp9DoA47k4oAfNPT8Qo/AHK7N2/eBPG7pFK36MhsD4knxSyrbcZvBysDsoO8+HaYeswMuJB0GmuLTrrcf9VwgPTzYFfwKVYvcIj0zk9Ed+xTWHvUEFvQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777389566; c=relaxed/simple;\n\tbh=mNnEGDKVPa/tXsXcX0H17eaYDz01/ffGTAlCs+dAPHg=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=fu2+/UExpBxAFauB6InB9ZyJwEAYcwqDJ7ROoTlCRpLRApl+OpSwOkrc1b+LnqX/ayCh/63sXxUsrIRSGqaO6XVT91dioIFN51/Fla6r/rFS76KigYatE2WZLBoKgU7c7ED6QSLucsCsSqMyXX25uDTw2LsV0PJjyts25N5VU2s=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=blackhole.kfki.hu;\n dkim=pass (1024-bit key) header.d=blackhole.kfki.hu\n header.i=@blackhole.kfki.hu header.b=r2StriYg;\n arc=none smtp.client-ip=148.6.0.50", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tblackhole.kfki.hu; h=mime-version:references:in-reply-to\n\t:x-mailer:message-id:date:date:from:from:received:received\n\t:received; s=20151130; t=1777389553; x=1779203954; bh=rpAy0PBNWF\n\tXakzSAqAXjUE3jW1yNzRB9e/geUFBWnoc=; b=r2StriYg3raYkKvHd0gKVJ3J0G\n\tTutJZOw3GJYHei9kwievGY0h8lYa6M/XC7S6EEZppExHoVC6Uk0valYuie0V18/i\n\te3Pn8FiuMaN6CHc/De+cN7+sacegkSGIu51TmO6C1XVJ/Dq5S4YcLvbdyKPkJkQ2\n\takCZtYbrLZuySJPkA=", "X-Virus-Scanned": "Debian amavis at smtp1.kfki.hu", "From": "Jozsef Kadlecsik <kadlec@netfilter.org>", "To": "netfilter-devel@vger.kernel.org", "Cc": "Pablo Neira Ayuso <pablo@netfilter.org>", "Subject": "[PATCH 1/5] netfilter: ipset: Fix data race between add and list\n header in all hash types", "Date": "Tue, 28 Apr 2026 17:19:09 +0200", "Message-Id": "<20260428151913.584739-2-kadlec@netfilter.org>", "X-Mailer": "git-send-email 2.39.5", "In-Reply-To": "<20260428151913.584739-1-kadlec@netfilter.org>", "References": "<20260428151913.584739-1-kadlec@netfilter.org>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable" }, "content": "The \"ipset list -terse\" command is actually a dump operation which\nmay run parallel with \"ipset add\" commands, which can trigger an\ninternal resizing of the hash type of sets just being dumped. However,\ndumping just the header part of the set was not protected against\nunderlying resizing. Fix it by protecting the header dumping part\nas well.\n\nSigned-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>\n---\n net/netfilter/ipset/ip_set_core.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c\nindex c5a26236a0bb..56830e33e193 100644\n--- a/net/netfilter/ipset/ip_set_core.c\n+++ b/net/netfilter/ipset/ip_set_core.c\n@@ -1648,13 +1648,13 @@ ip_set_dump_do(struct sk_buff *skb, struct netlink_callback *cb)\n \t\t\tif (cb->args[IPSET_CB_PROTO] > IPSET_PROTOCOL_MIN &&\n \t\t\t nla_put_net16(skb, IPSET_ATTR_INDEX, htons(index)))\n \t\t\t\tgoto nla_put_failure;\n+\t\t\tif (set->variant->uref)\n+\t\t\t\tset->variant->uref(set, cb, true);\n \t\t\tret = set->variant->head(set, skb);\n \t\t\tif (ret < 0)\n \t\t\t\tgoto release_refcount;\n \t\t\tif (dump_flags & IPSET_FLAG_LIST_HEADER)\n \t\t\t\tgoto next_set;\n-\t\t\tif (set->variant->uref)\n-\t\t\t\tset->variant->uref(set, cb, true);\n \t\t\tfallthrough;\n \t\tdefault:\n \t\t\tret = set->variant->list(set, skb, cb);\n", "prefixes": [ "1/5" ] }