Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229636/?format=api
{ "id": 2229636, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229636/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428150726.1659814-6-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428150726.1659814-6-marcandre.lureau@redhat.com>", "date": "2026-04-28T15:07:15", "name": "[PULL,v2,05/15] ui: minor code simplification", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4f95edd7ddba4816b20454343c0fded009d8d01f", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428150726.1659814-6-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 501872, "url": "http://patchwork.ozlabs.org/api/1.1/series/501872/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501872", "date": "2026-04-28T15:07:10", "name": "[PULL,v2,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/501872/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229636/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229636/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BTCpXKvp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4kN254f9z1xrS\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 01:08:34 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHk2j-000254-67; Tue, 28 Apr 2026 11:08:09 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHk2g-00024m-PB\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 11:08:06 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHk2f-0000cH-Ap\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 11:08:06 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-3Xp1XgEyOhGZKAgjWJWSDA-1; Tue,\n 28 Apr 2026 11:08:02 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id B55331956052; Tue, 28 Apr 2026 15:08:01 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 45CC819560AB; Tue, 28 Apr 2026 15:07:59 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777388884;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=xcpKhY7XLUys4G2b71IeM+bUSCB6UyTf3Ja3T4QV14k=;\n b=BTCpXKvpU6b0i8CSwmbgq5Uw0Sr2o5Di8N4PNU3JYB9OA9atz5amW6R9H/9hpyvQzfdXRA\n lNbTvIAMhIvX9nJJ1bEGJL3B+zysOZUKOygT74ShS46fPmuWwok3TxagM+Uq4CCpXfgwhh\n xmxYvAulxI8pqdYJGRPt36c2jzoWoCU=", "X-MC-Unique": "3Xp1XgEyOhGZKAgjWJWSDA-1", "X-Mimecast-MFC-AGG-ID": "3Xp1XgEyOhGZKAgjWJWSDA_1777388882", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "stefanha@gmail.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL v2 05/15] ui: minor code simplification", "Date": "Tue, 28 Apr 2026 19:07:15 +0400", "Message-ID": "<20260428150726.1659814-6-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260428150726.1659814-1-marcandre.lureau@redhat.com>", "References": "<20260428150726.1659814-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-21", "X-Spam_score": "-2.2", "X-Spam_bar": "--", "X-Spam_report": "(-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.109,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nDrop memset() usage.\n\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n ui/sdl2.c | 8 ++++----\n ui/vnc.c | 6 ++----\n 2 files changed, 6 insertions(+), 8 deletions(-)", "diff": "diff --git a/ui/sdl2.c b/ui/sdl2.c\nindex 987ad334bbe..5dd612d9a6a 100644\n--- a/ui/sdl2.c\n+++ b/ui/sdl2.c\n@@ -600,10 +600,10 @@ static void handle_windowevent(SDL_Event *ev)\n switch (ev->window.event) {\n case SDL_WINDOWEVENT_RESIZED:\n {\n- QemuUIInfo info;\n- memset(&info, 0, sizeof(info));\n- info.width = ev->window.data1;\n- info.height = ev->window.data2;\n+ QemuUIInfo info = {\n+ .width = ev->window.data1,\n+ .height = ev->window.data2,\n+ };\n dpy_set_ui_info(scon->dcl.con, &info, true);\n }\n sdl2_redraw(scon);\ndiff --git a/ui/vnc.c b/ui/vnc.c\nindex ad8d58a23d7..16dbb0cd6c2 100644\n--- a/ui/vnc.c\n+++ b/ui/vnc.c\n@@ -43,6 +43,7 @@\n #include \"qapi/qapi-events-ui.h\"\n #include \"qapi/error.h\"\n #include \"qapi/qapi-commands-ui.h\"\n+#include \"ui/console.h\"\n #include \"ui/input.h\"\n #include \"crypto/hash.h\"\n #include \"crypto/tlscreds.h\"\n@@ -2639,10 +2640,7 @@ static int protocol_client_msg(VncState *vs, uint8_t *data, size_t len)\n \n trace_vnc_msg_client_set_desktop_size(vs, vs->ioc, w, h, screens);\n if (dpy_ui_info_supported(vs->vd->dcl.con)) {\n- QemuUIInfo info;\n- memset(&info, 0, sizeof(info));\n- info.width = w;\n- info.height = h;\n+ QemuUIInfo info = { .width = w, .height = h };\n dpy_set_ui_info(vs->vd->dcl.con, &info, false);\n vnc_desktop_resize_ext(vs, 4 /* Request forwarded */);\n } else {\n", "prefixes": [ "PULL", "v2", "05/15" ] }