Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229601/?format=api
{ "id": 2229601, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229601/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260428132708.95998-4-krzysztof.kozlowski@oss.qualcomm.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260428132708.95998-4-krzysztof.kozlowski@oss.qualcomm.com>", "date": "2026-04-28T13:27:10", "name": "[RESEND,v2,2/2] PCI: mvebu: Keep child node refcnt for probe duration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "11f81a169a97fdd5e7861eb946a68449c4829304", "submitter": { "id": 92171, "url": "http://patchwork.ozlabs.org/api/1.1/people/92171/?format=api", "name": "Krzysztof Kozlowski", "email": "krzysztof.kozlowski@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260428132708.95998-4-krzysztof.kozlowski@oss.qualcomm.com/mbox/", "series": [ { "id": 501864, "url": "http://patchwork.ozlabs.org/api/1.1/series/501864/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=501864", "date": "2026-04-28T13:27:10", "name": "[RESEND,v2,1/2] PCI: mvebu: Simplify with scoped for each OF child loop", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/501864/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229601/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229601/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-53334-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=dW/1JQe9;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=UcRHpEkL;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-53334-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"dW/1JQe9\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"UcRHpEkL\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.168.131", "smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hwg35sJz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 29 Apr 2026 00:03:15 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 8B8E5321BCEC\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 13:35:11 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 79BA6450905;\n\tTue, 28 Apr 2026 13:27:37 +0000 (UTC)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC88450902\n\tfor <linux-pci@vger.kernel.org>; Tue, 28 Apr 2026 13:27:36 +0000 (UTC)", "from pps.filterd (m0279865.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63SC0TQd1625044\n\tfor <linux-pci@vger.kernel.org>; Tue, 28 Apr 2026 13:27:35 GMT", "from mail-vs1-f70.google.com (mail-vs1-f70.google.com\n [209.85.217.70])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtgmsb66r-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-pci@vger.kernel.org>; Tue, 28 Apr 2026 13:27:35 +0000 (GMT)", "by mail-vs1-f70.google.com with SMTP id\n ada2fe7eead31-6056351129bso16226759137.2\n for <linux-pci@vger.kernel.org>; Tue, 28 Apr 2026 06:27:35 -0700 (PDT)", "from quoll ([178.197.219.94])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4463d5ee9ecsm7232213f8f.16.2026.04.28.06.27.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 06:27:19 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777382857; cv=none;\n b=SLTePRQ62eUAZ662yDgXlGvDtUDObY5vIWlxgMhvz2gNWycGXxWFzDZWCHCJlW2PD41oS4wiKgtFlkeOMwEC5Df4aMb5c2NbTz6rbfic8CvHYwaTlD2FGTwUd4WHbsoeRTJaP+PIe0EyK746cXLZEf39wp+qayQWgEbSRhQq4cg=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777382857; c=relaxed/simple;\n\tbh=ov8hIF8M1z6R9wDtFRkRAkC1i3judy0L71MjXuy8SHg=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=mxgYtgCY14fuExEpCfKbtJWGSn4RpkSw/LyFczE/cm3FvbtMl1m5f9mSSdhWxFvmB7vHECUIz7c5foZgQH/0IFkw2ZpwV33pCBr/5VzRmWKj3rubCxwPDLD5qCUfEEawuZEp9vSacQhPkbiVoFKbzST93jZByfsiNraH9ZHGWJE=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=dW/1JQe9;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=UcRHpEkL; arc=none smtp.client-ip=205.220.168.131", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=wClwdHi//EK\n\tovApGGp/o1/cMKxisBXL2sxG8w7zO7Fo=; b=dW/1JQe9cBtpzMr3eMM/+Eqt4vo\n\t0ZSC+iHG5TPw/xMg2XFg6GwVycdDVghqjMmcwUHoFoBBTu2k02Iqux4l9Dy+ugQp\n\t2MWnmuqNsGUVl5O2w+Hv4sP6jOYwTa4qpSmVi6q1qXmJZk4OLaeTrK3xBe35It2T\n\tR7LsM8nBmLY+f9r73wsgUyRtzBKA64N0TVm0x+rsVYfCtz5OiudxL5hTo8ARKWA/\n\tSVpbvFedwKEVGJFLqP+I7F1YnMcx5QMTrZCLlU0XyBBdB1v4GPWJ43pSDsGclisF\n\toMxvcs5QbZ0UUO/1sYYucyM3ew42wqnPo6IKYPNXMVfj1h8abVpZK4KqA5Q==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1777382854; x=1777987654;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wClwdHi//EKovApGGp/o1/cMKxisBXL2sxG8w7zO7Fo=;\n b=UcRHpEkLmkqrsoFjjEI8AAkd/TQzu0/DczlvkAqT97GHO1G8x88Lg4ultHuPfGihhe\n ZtbdYRPo3660qwN/98b2Z3Nnq7eXWhuFgLPJLnDZ5JBNM/SmuLrcrgeF3SPne2camEd+\n zVJp/N7NmyaCQTS1oJsXPp3zBveVGwPJa6rmt3e3uPtuqpTzDrjerQm7Wg6VvJTjeb8i\n ofLCP8n/UXO5JipymKYD1JW8eNaMsEwuCE0F6SRXueEhGRDvpzibWSoWGPNGGqfyL9vQ\n cqL/Nx3mVnoTkdCSPGe4HIDlLK7O6GeEDf8qgB7db4D3j05ICxXufMfPzyBiBOnMQu3E\n pvPg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777382854; x=1777987654;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=wClwdHi//EKovApGGp/o1/cMKxisBXL2sxG8w7zO7Fo=;\n b=o9qjszBTQskw+lmkpV40HQbKo+Rw0OTcbj/qcCuNpbsAKp1sH9xnJlwIP1a45bx0Dv\n uQWuOFGmRJMJjiWMG64VquyCS+FWCcDvT1S2GBikWLcyW3TQxF6FE12wAK7b8/WPhAcR\n 0hYSW9N3FvKWptjyU4Ci8RdGVkgXANL/jyun9U5Y7sZNtH630NyQaUsYakXXA78vH9IA\n ZCa9aP/nbFM6VeGt+3cQ+/TsGQMANTiDf0cTddysD1aWW2zoQ64PXpFBfTXuXVN0/HhT\n VQapy5mxifRL4TCQbUuSiCL+WTBHuRQa0kkq53NrX/AQD48gn65s7eq0bY75GZsru0N7\n jySw==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+bEW8mpw0XNV67HOFDh+Gwzu0OQQ+HbUq0oKMCw4ApEHF8oyWHAn8FZEQo5cSOxoWwSCXWAdm8cmo=@vger.kernel.org", "X-Gm-Message-State": "AOJu0Yxi6CDKvo5d040Ast1/lV035H5A18PWZ/zkqjvoxbz6nmmeOjlW\n\t/ilAMfyzCQkU7uUSM2huE6FCua5w8R7DfaTOzNrwtTyw95/UCt5N2L2zSI0Kk9osuN8atJKAUlM\n\tJopNRR6wEyNFX2uMA0mgYl14Xk4BTi76sIuKwYjJavN8XXmJL4ET57ZaCB0WxrnM=", "X-Gm-Gg": "AeBDiet0ey6M993yT7gdLpLnNdA3dohihz7GTsdYghhwqnnlOeIqj1uzpDYtoHE6+9Q\n\tzx5pYMY4bb7PAL/M59AOMiXUlrtiC56O4iUiMP0OovEgHzBxUrUP/zc3WHjBWxkQCL6FBFJt7Sr\n\tOKJMZQJBBlpyxSUYsmmU0WsZ972dZ9un64UW9FCJ8OVGYu1jaTEzzOLGZoYww/vVMOxVEJ2saM0\n\tRuw69lFJu6nyCv6okbhVLiRyMqb9ycY8z2BRRUbCBXGbV4/NJl6eB6sZzqIEhhwkhdNg1JY7Dkt\n\tEUQF6YRstZh+mQKMG0neKcZx+gOZTYuPtjMj8AeDzODd4x4xzAgVI2au1kBcSZxn3M6rB0gIU8e\n\tpmNdNKdvU37RtfB3zId73jJEvEM+nYvJcQspTSSL+sphDhOM=", "X-Received": [ "by 2002:a05:6102:54a7:b0:610:56a:4bdd with SMTP id\n ada2fe7eead31-6280bde472fmr1278814137.28.1777382853830;\n Tue, 28 Apr 2026 06:27:33 -0700 (PDT)", "by 2002:a05:6102:54a7:b0:610:56a:4bdd with SMTP id\n ada2fe7eead31-6280bde472fmr1278233137.28.1777382840066;\n Tue, 28 Apr 2026 06:27:20 -0700 (PDT)" ], "From": "Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>", "To": "Thomas Petazzoni <thomas.petazzoni@bootlin.com>, =?utf-8?q?Pali_Roh?=\n\t=?utf-8?q?=C3=A1r?= <pali@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kwilczynski@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org,\n linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org", "Cc": "Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>", "Subject": "[RESEND PATCH v2 2/2] PCI: mvebu: Keep child node refcnt for probe\n duration", "Date": "Tue, 28 Apr 2026 15:27:10 +0200", "Message-ID": "<20260428132708.95998-4-krzysztof.kozlowski@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260428132708.95998-3-krzysztof.kozlowski@oss.qualcomm.com>", "References": "<20260428132708.95998-3-krzysztof.kozlowski@oss.qualcomm.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1813;\n i=krzysztof.kozlowski@oss.qualcomm.com;\n h=from:subject; bh=ov8hIF8M1z6R9wDtFRkRAkC1i3judy0L71MjXuy8SHg=;\n b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBp8LWvxjL35h3b9GCXehstfFtvOosrOCx8JxD2V\n bgJIU/Bh3aJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCafC1rwAKCRDBN2bmhouD\n 16WlD/9v1FyqjVeDIKt9vW6cdG/antel/dqTkWtauYAQHcCKwfJF/GUZ7e5Ze/UthhvEqtUjfNW\n qZ/SJxUyDrHJFuFruqiSughQx1TfTQw6NpicAiWE6hLuGADO/tBlh1WO4FEqmSq6/onJPPh1eyK\n IM5GewioAdS3wz7EE0DOVoncynQBibxpTkhhKaRg6sE54NQJ9YDNHOya4xtiY7rAitvZmQsYBnJ\n eajJULQzgNDHPXvaa6XGiQ+YB3TuW+2d8gBKWywb9RjfrTfvPT3Wr9tjk3jZOlXf0BYqF8EwMY8\n p8f+69RByv/MAkZzG5yeLjLU+dCQJkH20OzLi+Y4nFu+g/pSwCYc3z34JBAVYtQ68cH2jaCpKvI\n voA7mxbSB769nrhf2neiMDLMVvZxY+ndor98M+G1p4lrgjo3e6nYtW0GNSxKkrqGCqJth68mibs\n +FRu106p7ZkPS0Fc1/pRSz1u5xoTxQGizvKPWkjNjJDzYenIot2+/F/r5pYio5Q3FYZHiV6AXfS\n 4hHkeKMgqe5tV6O3bInL4xOmnh6ZFt6+UUUzYpdxhFL/Dvbg/no+ZoxiAlOq03mUU1f0r4Gch7x\n 7PkoM4XZNene8Vm2AcQUTxlesu1YkVtRLteTwGEklVDXm0NtEu5KBmnqO8YLFGu0QzplzXxKb5x\n KqbBl83c5g0ouSw==", "X-Developer-Key": "i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp;\n fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "5liD-z_cMS29LmzWDqRbcNHa42ZduGF9", "X-Authority-Analysis": "v=2.4 cv=R4gz39RX c=1 sm=1 tr=0 ts=69f0b5c7 cx=c_pps\n a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17\n a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8\n a=pABr9VbpVV2WwmlfmZwA:9 a=crWF4MFLhNY0qMRaF8an:22", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwNDI4MDEyNiBTYWx0ZWRfX73m1xmWMPEyL\n 2fEVwmJ4MaxcNlfpLPc/bzAVC6XOzYKjDejlAHSiNf8etLqrZkuTKg5zSVCPtzCP+VoIiD/2Fdu\n BFE1Z+b+LtOlMDd8kaUoRw1lRi3Q0vCj1HnsRY0dP0u6DtT7cRYyws5vqDtscNlX2BAw6pfRYbO\n GjTZCW90Zzih/jKtsAJ1ConnUi1NO8ajDHvS5W4Pprfb5EVtDNvSLYsWRPyROsDHrx0pH2nwwig\n ZXJHc0cn+mft5PjlfnDBXh0FIooKQb8lqKg9dWf/RiQYH5t2kH96GTHghYsr+Zqf7EdmNFpFvGT\n kkLWT+zAM7ke1PLNTtxQMb4oSI4y1X5hN6ZkLZS5llFCGBQJCoAypqMUdTzp/1Ul75e8aDrdvNJ\n 6bqxHFazKEas3TLzUMb6/YxlePisIG0TXNYv+n9SNbYgBIozJVtJROOSlvkUWl+g33GOX5oQRpl\n yUuLccnpCEjJoa0kiSA==", "X-Proofpoint-ORIG-GUID": "5liD-z_cMS29LmzWDqRbcNHa42ZduGF9", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-28_04,2026-04-28_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 priorityscore=1501 malwarescore=0 clxscore=1015\n impostorscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0\n lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000\n definitions=main-2604280126" }, "content": "Driver in probe() first iterates over child device nodes, storing the OF\nnode pointer but does not take the reference to it for the remaining\npart of the probe where it is used.\n\nThe pointer thus could become invalid if children OF nodes are being\nremoved from the Devicetree, e.g. by removing OF overlay, while the\nprobe is being executed. That's is highly theoretical issue, thus it\ndoes not look like bug with any effect.\n\nNevertheless, make the code logically correct, so acquire the OF node\nrefcnt for entire lifetime of the device, since the pointer is stored in\neach port state container structure.\n\nSigned-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>\n\n---\n\nChanges in v2:\n1. New patch\n\nNote: Not a fix, because practical impact is absolutely zero since\nof_node_get is a noop.\n---\n drivers/pci/controller/pci-mvebu.c | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/pci/controller/pci-mvebu.c b/drivers/pci/controller/pci-mvebu.c\nindex 4d3c97b62fe0..7fb9c7393588 100644\n--- a/drivers/pci/controller/pci-mvebu.c\n+++ b/drivers/pci/controller/pci-mvebu.c\n@@ -1236,6 +1236,11 @@ static void mvebu_pcie_port_clk_put(void *data)\n \tclk_put(port->clk);\n }\n \n+static void mvebu_pcie_port_of_node_put(void *data)\n+{\n+\tof_node_put(data);\n+}\n+\n static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie,\n \tstruct mvebu_pcie_port *port, struct device_node *child)\n {\n@@ -1482,7 +1487,11 @@ static int mvebu_pcie_probe(struct platform_device *pdev)\n \t\telse if (ret == 0)\n \t\t\tcontinue;\n \n-\t\tport->dn = child;\n+\t\tport->dn = of_node_get(child);\n+\t\tret = devm_add_action_or_reset(dev, mvebu_pcie_port_of_node_put,\n+\t\t\t\t\t child);\n+\t\tif (ret)\n+\t\t\treturn ret;\n \t\ti++;\n \t}\n \tpcie->nports = i;\n", "prefixes": [ "RESEND", "v2", "2/2" ] }