Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229589/?format=api
{ "id": 2229589, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229589/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260428135614.2A39F4B920AC@sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260428135614.2A39F4B920AC@sourceware.org>", "date": "2026-04-28T13:55:45", "name": "[x86] Adjust gcc.target/i386/vect-strided-?.c for cost compare", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6456564812f4db6f1fb02dd1852ef2de1f42e170", "submitter": { "id": 4338, "url": "http://patchwork.ozlabs.org/api/1.1/people/4338/?format=api", "name": "Richard Biener", "email": "rguenther@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260428135614.2A39F4B920AC@sourceware.org/mbox/", "series": [ { "id": 501860, "url": "http://patchwork.ozlabs.org/api/1.1/series/501860/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501860", "date": "2026-04-28T13:55:45", "name": "[x86] Adjust gcc.target/i386/vect-strided-?.c for cost compare", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501860/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229589/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229589/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=D16DibeH;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=oJxL0HQW;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=DF4EfUcJ;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=9n0cCT6w;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=D16DibeH;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=oJxL0HQW;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=DF4EfUcJ;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=9n0cCT6w", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de", "sourceware.org; spf=pass smtp.mailfrom=suse.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.131", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hn642Hcz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 23:56:21 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 2A39F4B920AC\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 13:56:14 +0000 (GMT)", "from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n by sourceware.org (Postfix) with ESMTPS id 02D4C4BA79BA\n for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2026 13:55:46 +0000 (GMT)", "from murzim.nue2.suse.org (unknown [10.168.4.243])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id D35DB5BD3F;\n Tue, 28 Apr 2026 13:55:45 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 2A39F4B920AC", "OpenDKIM Filter v2.11.0 sourceware.org 02D4C4BA79BA" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 02D4C4BA79BA", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 02D4C4BA79BA", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777384547; cv=none;\n b=dDiCKrA6/2lNfsf2waxRuqWmnGDEWgH1RtLPM02z9a1Fci7Pvcko9phI0Ih/mP/A9LMqDzz4O9oKbNqUajrmTNg5V1rFGquMVvcLeuR83M1twhZHaDg+xsvQmQhW1/B9gUWVSfZDUq3FAvXTVEM9bYNHZ4D/QO1L71jdbr/hPZ8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777384547; c=relaxed/simple;\n bh=L791dFu/0VcAD4H7ARjaBIyVb6XP453LwwAP7+Ox+fI=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version;\n b=OdR+ikeAZwemGySEIm68bafU0Q0fQJrBa3FtDP4XOoN3LTincYALRAAqFb/GN5fq2gXU9RTGgIffxWnDiup1fLaPDZQY0xsWf+ukGm2mxL3WrJ+eu3BLHScMvLowSNY/4L150p1MgifmFgbZeexyJaPbmhCStdAMQl4OQvQkZew=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777384546;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=Nv0JGXEq/ovOF/3PsCp6lVdRUiJTPGa4qTjAYX6uwgE=;\n b=D16DibeH1zhQ7lgRmjrZgtLBwxr2TxGB/vrYmhu4OK0UVaDWTptt9Q7TG4yht7eDR9cA63\n 7cX6Uz5i9kF9asJXY9Cd8i7bJ0rKdcf6eFGyRcyK4qVfBOWSLHxvdKIsQ14TznlvzmzQz2\n KFlGIuv7HQZeDxpJa9dqC8hX/jJnSAw=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777384546;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=Nv0JGXEq/ovOF/3PsCp6lVdRUiJTPGa4qTjAYX6uwgE=;\n b=oJxL0HQWLkTCBuh5G92Piu1j7K5xX7GH3LtUs+OeEQIytzfAzEB14mbv7xc8UTSDC5YH/N\n DHrvBojxOQmxDsDw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777384545;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=Nv0JGXEq/ovOF/3PsCp6lVdRUiJTPGa4qTjAYX6uwgE=;\n b=DF4EfUcJwiUtD+LAycps+FSKo/3rZZckuoYIBmb46ZJoe5gGPp/NHSj3HcMs+bWUZPKFP+\n gOy+gqrtRE/2bGPkWws8h3FZOXE85MJrqGqzPE1xwQUPJQLNKLa+dEkxVbKST4Yi03Gsqk\n xkHV0yRD8I7SLZTf3zKcKHJ0kcjkqUY=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777384545;\n h=from:from:reply-to:date:date:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type; bh=Nv0JGXEq/ovOF/3PsCp6lVdRUiJTPGa4qTjAYX6uwgE=;\n b=9n0cCT6wKSiYQ0KUzDNTu6iPig9WCDH1fAuOxPG84XAnXKFrsYfxjmgYQMFHtDRWaWj6Eu\n 853VlB3hsb7rF2Ag==" ], "Date": "Tue, 28 Apr 2026 15:55:45 +0200 (CEST)", "From": "Richard Biener <rguenther@suse.de>", "To": "gcc-patches@gcc.gnu.org", "cc": "hongtao.liu@intel.com", "Subject": "[PATCH] [x86] Adjust gcc.target/i386/vect-strided-?.c for cost\n compare", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "X-Spamd-Result": "default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain];\n ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; MISSING_XM_UA(0.00)[];\n RCVD_COUNT_ZERO(0.00)[0]; RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+];\n TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n SUBJECT_HAS_QUESTION(0.00)[]", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org", "Message-Id": "<20260428135614.2A39F4B920AC@sourceware.org>" }, "content": "With cost comparison and MMX-with-SSE vector width available we\nprefer to use V2SImode over V4SImode with shuffles, rightfully\nso I think. The following adds variants with explicit cost\ncompare enabled and disabled and adjusts the cost comparison\nvariant accordingly.\n\nTested on x86_64 with {,-m32,-mx32}.\n\nOK?\n\nThanks,\nRichard.\n\n\t* gcc.target/i386/vect-strided-1.c: Disable vector cost\n\tcomparison.\n\t* gcc.target/i386/vect-strided-2.c: Likewise.\n\t* gcc.target/i386/vect-strided-3.c: Likewise.\n\t* gcc.target/i386/vect-strided-4.c: Likewise.\n\t* gcc.target/i386/vect-strided-1b.c: Copy of\n\tgcc.target/i386/vect-strided-1.c, enable vector cost comparison\n\tand adjust expected code generation.\n\t* gcc.target/i386/vect-strided-2b.c: Likewise.\n\t* gcc.target/i386/vect-strided-3b.c: Likewise.\n\t* gcc.target/i386/vect-strided-4b.c: Likewise.\n---\n .../gcc.target/i386/vect-strided-1.c | 2 +-\n .../gcc.target/i386/vect-strided-1b.c | 23 +++++++++++++++++++\n .../gcc.target/i386/vect-strided-2.c | 2 +-\n .../gcc.target/i386/vect-strided-2b.c | 17 ++++++++++++++\n .../gcc.target/i386/vect-strided-3.c | 2 +-\n .../gcc.target/i386/vect-strided-3b.c | 20 ++++++++++++++++\n .../gcc.target/i386/vect-strided-4.c | 2 +-\n .../gcc.target/i386/vect-strided-4b.c | 19 +++++++++++++++\n 8 files changed, 83 insertions(+), 4 deletions(-)\n create mode 100644 gcc/testsuite/gcc.target/i386/vect-strided-1b.c\n create mode 100644 gcc/testsuite/gcc.target/i386/vect-strided-2b.c\n create mode 100644 gcc/testsuite/gcc.target/i386/vect-strided-3b.c\n create mode 100644 gcc/testsuite/gcc.target/i386/vect-strided-4b.c", "diff": "diff --git a/gcc/testsuite/gcc.target/i386/vect-strided-1.c b/gcc/testsuite/gcc.target/i386/vect-strided-1.c\nindex db4a06711f1..8e232540bd4 100644\n--- a/gcc/testsuite/gcc.target/i386/vect-strided-1.c\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-1.c\n@@ -1,5 +1,5 @@\n /* { dg-do compile } */\n-/* { dg-options \"-O2 -msse2 -mno-avx\" } */\n+/* { dg-options \"-O2 -msse2 -mno-avx --param ix86-vect-compare-costs=0\" } */\n \n void foo (int * __restrict a, int *b, int s)\n {\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-1b.c b/gcc/testsuite/gcc.target/i386/vect-strided-1b.c\nnew file mode 100644\nindex 00000000000..6f173eaea5c\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-1b.c\n@@ -0,0 +1,23 @@\n+/* { dg-do compile { target { ! ia32 } } } */\n+/* { dg-options \"-O2 -msse2 -mno-avx --param ix86-vect-compare-costs=1\" } */\n+\n+void foo (int * __restrict a, int *b, int s)\n+{\n+ for (int i = 0; i < 1024; ++i)\n+ {\n+ a[8*i+0] = b[s*i+0];\n+ a[8*i+1] = b[s*i+1];\n+ a[8*i+2] = b[s*i+2];\n+ a[8*i+3] = b[s*i+3];\n+ a[8*i+4] = b[s*i+4];\n+ a[8*i+5] = b[s*i+5];\n+ a[8*i+6] = b[s*i+4];\n+ a[8*i+7] = b[s*i+5];\n+ }\n+}\n+\n+/* Three two-element loads, four two-element stores. No wider loads\n+ or permutes. */\n+/* { dg-final { scan-assembler-times \"movq\" 7 } } */\n+/* { dg-final { scan-assembler-times \"movhps\" 0 } } */\n+/* { dg-final { scan-assembler-times \"movups\" 0 } } */\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-2.c b/gcc/testsuite/gcc.target/i386/vect-strided-2.c\nindex 6fd64e28cf0..67aa3917c4e 100644\n--- a/gcc/testsuite/gcc.target/i386/vect-strided-2.c\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-2.c\n@@ -1,5 +1,5 @@\n /* { dg-do compile } */\n-/* { dg-options \"-O2 -msse2 -mno-avx\" } */\n+/* { dg-options \"-O2 -msse2 -mno-avx --param ix86-vect-compare-costs=0\" } */\n \n void foo (int * __restrict a, int *b, int s)\n {\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-2b.c b/gcc/testsuite/gcc.target/i386/vect-strided-2b.c\nnew file mode 100644\nindex 00000000000..9eabfbb082b\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-2b.c\n@@ -0,0 +1,17 @@\n+/* { dg-do compile { target { ! ia32 } } } */\n+/* { dg-options \"-O2 -msse2 -mno-avx --param ix86-vect-compare-costs=1\" } */\n+\n+void foo (int * __restrict a, int *b, int s)\n+{\n+ for (int i = 0; i < 1024; ++i)\n+ {\n+ a[4*i+0] = b[s*i+0];\n+ a[4*i+1] = b[s*i+1];\n+ a[4*i+2] = b[s*i+0];\n+ a[4*i+3] = b[s*i+1];\n+ }\n+}\n+\n+/* One two-element load, two two-element stores. */\n+/* { dg-final { scan-assembler-times \"movq\" 3 } } */\n+/* { dg-final { scan-assembler-times \"movups\" 0 } } */\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-3.c b/gcc/testsuite/gcc.target/i386/vect-strided-3.c\nindex f9c54a6f715..d08d5836a7a 100644\n--- a/gcc/testsuite/gcc.target/i386/vect-strided-3.c\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-3.c\n@@ -1,5 +1,5 @@\n /* { dg-do compile } */\n-/* { dg-options \"-O2 -msse2 -mno-sse4 -fno-tree-slp-vectorize\" } */\n+/* { dg-options \"-O2 -msse2 -mno-sse4 -fno-tree-slp-vectorize --param ix86-vect-compare-costs=0\" } */\n \n void foo (int * __restrict a, int *b, int s)\n {\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-3b.c b/gcc/testsuite/gcc.target/i386/vect-strided-3b.c\nnew file mode 100644\nindex 00000000000..829fb0ccd39\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-3b.c\n@@ -0,0 +1,20 @@\n+/* { dg-do compile { target { ! ia32 } } } */\n+/* { dg-options \"-O2 -msse2 -mno-sse4 -fno-tree-slp-vectorize --param ix86-vect-compare-costs=1\" } */\n+\n+void foo (int * __restrict a, int *b, int s)\n+{\n+ if (s >= 6)\n+ for (int i = 0; i < 1024; ++i)\n+ {\n+\ta[s*i+0] = b[4*i+0];\n+\ta[s*i+1] = b[4*i+1];\n+\ta[s*i+2] = b[4*i+2];\n+\ta[s*i+3] = b[4*i+3];\n+\ta[s*i+4] = b[4*i+0];\n+\ta[s*i+5] = b[4*i+1];\n+ }\n+}\n+\n+/* The vectorizer generates 3 uint64 stores and two uint64 loads. */\n+/* { dg-final { scan-assembler-times \"movq\" 5 } } */\n+/* { dg-final { scan-assembler-times \"movhps\" 0 } } */\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-4.c b/gcc/testsuite/gcc.target/i386/vect-strided-4.c\nindex 3fb9f07886e..37f6e72c0a9 100644\n--- a/gcc/testsuite/gcc.target/i386/vect-strided-4.c\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-4.c\n@@ -1,5 +1,5 @@\n /* { dg-do compile } */\n-/* { dg-options \"-O2 -msse4.2 -mno-avx -fno-tree-slp-vectorize\" } */\n+/* { dg-options \"-O2 -msse4.2 -mno-avx -fno-tree-slp-vectorize --param ix86-vect-compare-costs=0\" } */\n \n void foo (int * __restrict a, int * __restrict b, int *c, int s)\n {\ndiff --git a/gcc/testsuite/gcc.target/i386/vect-strided-4b.c b/gcc/testsuite/gcc.target/i386/vect-strided-4b.c\nnew file mode 100644\nindex 00000000000..3183a5c5385\n--- /dev/null\n+++ b/gcc/testsuite/gcc.target/i386/vect-strided-4b.c\n@@ -0,0 +1,19 @@\n+/* { dg-do compile { target { ! ia32 } } } */\n+/* { dg-options \"-O2 -msse4.2 -mno-avx -fno-tree-slp-vectorize --param ix86-vect-compare-costs=1\" } */\n+\n+void foo (int * __restrict a, int * __restrict b, int *c, int s)\n+{\n+ if (s >= 2)\n+ for (int i = 0; i < 1024; ++i)\n+ {\n+\ta[s*i+0] = c[4*i+0];\n+\ta[s*i+1] = c[4*i+1];\n+\tb[s*i+0] = c[4*i+2];\n+\tb[s*i+1] = c[4*i+3];\n+ }\n+}\n+\n+/* Vectorization factor two, two two-element stores using movq\n+ and two two-element stores to b via movq. One reg-reg copy with movq. */\n+/* { dg-final { scan-assembler-times \"movq\\[^\\r\\n\\]+\\\\\\(\" 4 } } */\n+/* { dg-final { scan-assembler-times \"pextrq\" 0 } } */\n", "prefixes": [ "x86" ] }