Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229582/?format=api
{ "id": 2229582, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229582/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428131756.922303-19-dhowells@redhat.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428131756.922303-19-dhowells@redhat.com>", "date": "2026-04-28T13:17:48", "name": "[v5,18/24] netfs: Fix leak of request in netfs_write_begin() error handling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "37583c13953b134c69d327c18f6310f5f21a234e", "submitter": { "id": 59, "url": "http://patchwork.ozlabs.org/api/1.1/people/59/?format=api", "name": "David Howells", "email": "dhowells@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260428131756.922303-19-dhowells@redhat.com/mbox/", "series": [ { "id": 501852, "url": "http://patchwork.ozlabs.org/api/1.1/series/501852/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501852", "date": "2026-04-28T13:17:35", "name": "netfs: Miscellaneous fixes", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/501852/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229582/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229582/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-11205-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=GN9m28G4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11205-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"GN9m28G4\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4hg318HFz1xrS\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 23:51:27 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 9FC69319CDB8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 13:29:02 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id B7BA247F2FC;\n\tTue, 28 Apr 2026 13:19:38 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id B078A47F2E5\n\tfor <linux-cifs@vger.kernel.org>; Tue, 28 Apr 2026 13:19:36 +0000 (UTC)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-MMscdLOhOGKsXqAJlrHUMw-1; Tue,\n 28 Apr 2026 09:19:31 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A1A041955E9C;\n\tTue, 28 Apr 2026 13:19:29 +0000 (UTC)", "from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id A608B180047F;\n\tTue, 28 Apr 2026 13:19:26 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777382378; cv=none;\n b=A/naOxcmboHvyGrSuk/k/JzTuJU04OEIqdKPnsF3yCsMDfO84v8cUk7pvBx/dJ46/AUvnS9YJCKrBZ+X2FxAhNBE62G2ph/zN1WjDcrBtnp/dRvjkHyrpjYi/+02l+HUhBF84KbNtw58+BsjFO4UFsYog5uniju/5yl41O557cw=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777382378; c=relaxed/simple;\n\tbh=JmXP+QXfysKowXIq/+dNx74WhS6n5x7XmBRvcwsYGOE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=EA+G6c1H45sSaOXr/pbFn8TsE7tH4LYDg/iaW0msxoEkG/0sdONa2yKHDJHJZlLiiemLnAKrEqVJuWK89ODOVGIsHsml4w0ypaW/8LeXCfelAvtoxFGRvPbSeLLIVHCGhlrhknneY/+UD7CmBuWsn+8rOfw36zD8PH+Inex6Pho=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=GN9m28G4; arc=none smtp.client-ip=170.10.133.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777382375;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=NVdup9Yb9JycCAuf4DYfAvqCMMZy27DYqgj2TZFqU1c=;\n\tb=GN9m28G4aDW9usE76rExurM2wPdL82uUkq+Rd0jZHj9xy38HO7pDHkE3EwE1PubNSD+13T\n\tCqfhXOBpvNoMQ6mEggPu1I4B9V6lTFUyE9A5/kNO+USBlU5gymRR4MqpmBaZAcBG8Au1uH\n\tugsU5xNQ7oAhpQij6nf81nR2A43fx90=", "X-MC-Unique": "MMscdLOhOGKsXqAJlrHUMw-1", "X-Mimecast-MFC-AGG-ID": "MMscdLOhOGKsXqAJlrHUMw_1777382369", "From": "David Howells <dhowells@redhat.com>", "To": "Christian Brauner <christian@brauner.io>", "Cc": "David Howells <dhowells@redhat.com>,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMatthew Wilcox <willy@infradead.org>", "Subject": "[PATCH v5 18/24] netfs: Fix leak of request in netfs_write_begin()\n error handling", "Date": "Tue, 28 Apr 2026 14:17:48 +0100", "Message-ID": "<20260428131756.922303-19-dhowells@redhat.com>", "In-Reply-To": "<20260428131756.922303-1-dhowells@redhat.com>", "References": "<20260428131756.922303-1-dhowells@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111" }, "content": "Fix netfs_write_begin() to not leak our ref on the request in the event\nthat we get an error from netfs_wait_for_read().\n\nFixes: 4090b31422a6 (\"netfs: Add a function to consolidate beginning a read\")\nCloses: https://sashiko.dev/#/patchset/20260414082004.3756080-1-dhowells%40redhat.com\nSigned-off-by: David Howells <dhowells@redhat.com>\ncc: Paulo Alcantara <pc@manguebit.org>\ncc: Matthew Wilcox <willy@infradead.org>\ncc: netfs@lists.linux.dev\ncc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/buffered_read.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c\nindex 18c8e00626c9..db279124d450 100644\n--- a/fs/netfs/buffered_read.c\n+++ b/fs/netfs/buffered_read.c\n@@ -687,9 +687,9 @@ int netfs_write_begin(struct netfs_inode *ctx,\n \n \tnetfs_read_to_pagecache(rreq, NULL);\n \tret = netfs_wait_for_read(rreq);\n+\tnetfs_put_request(rreq, netfs_rreq_trace_put_return);\n \tif (ret < 0)\n \t\tgoto error;\n-\tnetfs_put_request(rreq, netfs_rreq_trace_put_return);\n \n have_folio:\n \tret = folio_wait_private_2_killable(folio);\n", "prefixes": [ "v5", "18/24" ] }