Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229526/?format=api
{ "id": 2229526, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229526/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/patch/20260428-fix_clock_settime_helper-v2-1-26cce3b7d706@suse.com/", "project": { "id": 59, "url": "http://patchwork.ozlabs.org/api/1.1/projects/59/?format=api", "name": "Linux Test Project development", "link_name": "ltp", "list_id": "ltp.lists.linux.it", "list_email": "ltp@lists.linux.it", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428-fix_clock_settime_helper-v2-1-26cce3b7d706@suse.com>", "date": "2026-04-28T12:24:50", "name": "[v2] clock_settime: use POSIX runtime detection for CLOCK_MONOTONIC", "commit_ref": null, "pull_url": null, "state": "needs-review-ack", "archived": false, "hash": "35458e94ab332f96b95c2173e6d34e2ffc1805aa", "submitter": { "id": 83220, "url": "http://patchwork.ozlabs.org/api/1.1/people/83220/?format=api", "name": "Andrea Cervesato", "email": "andrea.cervesato@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/ltp/patch/20260428-fix_clock_settime_helper-v2-1-26cce3b7d706@suse.com/mbox/", "series": [ { "id": 501837, "url": "http://patchwork.ozlabs.org/api/1.1/series/501837/?format=api", "web_url": "http://patchwork.ozlabs.org/project/ltp/list/?series=501837", "date": "2026-04-28T12:24:50", "name": "[v2] clock_settime: use POSIX runtime detection for CLOCK_MONOTONIC", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/501837/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229526/comments/", "check": "success", "checks": "http://patchwork.ozlabs.org/api/patches/2229526/checks/", "tags": {}, "headers": { "Return-Path": "<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "ltp@lists.linux.it" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "ltp@picard.linux.it" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wfT/vGiO;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.de\n header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=UaGvqW4c;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa\n header.b=wfT/vGiO;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=UaGvqW4c;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)", "smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=\"wfT/vGiO\";\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=UaGvqW4c" ], "Received": [ "from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4flF38Btz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 22:24:57 +1000 (AEST)", "from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 437CC3DEFF3\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 14:24:55 +0200 (CEST)", "from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id CC44B3C9B85\n for <ltp@lists.linux.it>; Tue, 28 Apr 2026 14:24:52 +0200 (CEST)", "from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 39D851A003D2\n for <ltp@lists.linux.it>; Tue, 28 Apr 2026 14:24:51 +0200 (CEST)", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id 157006A83A;\n Tue, 28 Apr 2026 12:24:51 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EDB63593B0;\n Tue, 28 Apr 2026 12:24:50 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 4x5QOBKn8GkLLAAAD6G6ig\n (envelope-from <andrea.cervesato@suse.de>); Tue, 28 Apr 2026 12:24:50 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777379091;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=HzzH64yGxX+IJzZd59TZINRbLor8Qp901vHQfFHENqk=;\n b=wfT/vGiOnDGAShA/vateCS9liLhBx40/A4mg4pklOKMf/exwlnym7x46BmN1XcPBj1/A53\n aFUw0BPjDQB+3VYhEOVK5Z1sp9OaRh8dYolLqytHdQMg6I2VYdiPkVgbBnUA16Fp5XflnQ\n IcfNDlI/ikPFj3FjOzWjHWtv1NEMD8I=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777379091;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=HzzH64yGxX+IJzZd59TZINRbLor8Qp901vHQfFHENqk=;\n b=UaGvqW4cf+M2W18LU7X4jDEuXl/6WqJHcqtl4Hdr3L//fG28ptCQxezcoEJHNcWUtkQcUA\n IGDt23M87wtWKuAg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777379091;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=HzzH64yGxX+IJzZd59TZINRbLor8Qp901vHQfFHENqk=;\n b=wfT/vGiOnDGAShA/vateCS9liLhBx40/A4mg4pklOKMf/exwlnym7x46BmN1XcPBj1/A53\n aFUw0BPjDQB+3VYhEOVK5Z1sp9OaRh8dYolLqytHdQMg6I2VYdiPkVgbBnUA16Fp5XflnQ\n IcfNDlI/ikPFj3FjOzWjHWtv1NEMD8I=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777379091;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=HzzH64yGxX+IJzZd59TZINRbLor8Qp901vHQfFHENqk=;\n b=UaGvqW4cf+M2W18LU7X4jDEuXl/6WqJHcqtl4Hdr3L//fG28ptCQxezcoEJHNcWUtkQcUA\n IGDt23M87wtWKuAg==" ], "From": "Andrea Cervesato <andrea.cervesato@suse.de>", "Date": "Tue, 28 Apr 2026 14:24:50 +0200", "MIME-Version": "1.0", "Message-Id": "<20260428-fix_clock_settime_helper-v2-1-26cce3b7d706@suse.com>", "X-B4-Tracking": "v=1; b=H4sIABGn8GkC/42NUQ6CMBBEr0L225q2QVC/uIchRMpiNwIl3dpoS\n O9u5QR+vsnMmw0YPSHDtdjAYyQmt2TQhwKMvS8PFDRkBi11JUtViZHenZmceXaMIdCMncVpRS+\n Gsh7l0Et5qhHyfPWYu7v61ma2xMH5z/4U1S/9QxqVUEKf6zJX9UX1Y8MvxqNxM7QppS+MMFQBv\n wAAAA==", "X-Change-ID": "20260416-fix_clock_settime_helper-d47f0db0057e", "To": "Linux Test Project <ltp@lists.linux.it>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1777379090; l=5079;\n i=andrea.cervesato@suse.com; s=20251210; h=from:subject:message-id;\n bh=pgS1EXFWNt+JtXyk9qSzVMcN/zYmNJLE2nCbyjUrk4A=;\n b=i3xKHvnFgAE/GTCY5HrNFpg2USDtiznx6TtW8ZSx7PgnwQPpIw9Zw3G9OfxEMuVe45DY02VPo\n Q7KyWh44YqQDPA8I8mWRX5zD9tHglej6buNGWsaetPJitI98/Yrsarq", "X-Developer-Key": "i=andrea.cervesato@suse.com; a=ed25519;\n pk=zKY+6GCauOiuHNZ//d8PQ/UL4jFCTKbXrzXAOQSLevI=", "X-Spamd-Result": "default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n MIME_TRACE(0.00)[0:+];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.com:mid,suse.com:email];\n TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]", "X-Rspamd-Action": "no action", "X-Spam-Score": "-4.51", "X-Spam-Level": "", "X-Rspamd-Server": "rspamd1.dmz-prg2.suse.org", "X-Rspamd-Queue-Id": "157006A83A", "X-Spam-Status": "No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on in-3.smtp.seeweb.it", "X-Virus-Scanned": "clamav-milter 1.0.9 at in-3.smtp.seeweb.it", "X-Virus-Status": "Clean", "Subject": "[LTP] [PATCH v2] clock_settime: use POSIX runtime detection for\n CLOCK_MONOTONIC", "X-BeenThere": "ltp@lists.linux.it", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "Linux Test Project <ltp.lists.linux.it>", "List-Unsubscribe": "<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>", "List-Archive": "<http://lists.linux.it/pipermail/ltp/>", "List-Post": "<mailto:ltp@lists.linux.it>", "List-Help": "<mailto:ltp-request@lists.linux.it?subject=help>", "List-Subscribe": "<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it", "Sender": "\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>" }, "content": "From: Andrea Cervesato <andrea.cervesato@suse.com>\n\nThe clock_settime helpers.h used a compile-time #ifdef on\n_POSIX_MONOTONIC_CLOCK to select between real and stub\nimplementations of pts_mono_time_start()/pts_mono_time_check().\n\nOn Linux/glibc, _POSIX_MONOTONIC_CLOCK is defined as 0, meaning\nsupport is optional and must be verified at runtime via\nsysconf(_SC_MONOTONIC_CLOCK). The #ifdef treated 0 the same as\n>0 (always available), which is not POSIX-correct.\n\nReplace the compile-time #ifdef/#else split with a runtime\npts_mono_available() helper that performs proper POSIX detection\nvia sysconf(). Extract pts_mono_available() into the shared\ninclude/clock.h so it can be reused by nanosleep helpers as well.\nAlso add a missing #ifndef include guard and #include <unistd.h>\nso _POSIX_MONOTONIC_CLOCK is always defined.\n\nFixes: 9ecb4a004b18 (\"clock_settime: Detect external clock adjustments via CLOCK_MONOTONIC\")\nSigned-off-by: Andrea Cervesato <andrea.cervesato@suse.com>\n---\nChanges in v2:\n- add testcases/open_posix_testsuite/include/clock.h helper\n- Link to v1: https://lore.kernel.org/r/20260416-fix_clock_settime_helper-v1-1-2874202291bf@suse.com\n---\n .../conformance/interfaces/clock_settime/helpers.h | 67 ++++++++++++----------\n testcases/open_posix_testsuite/include/clock.h | 23 ++++++++\n 2 files changed, 59 insertions(+), 31 deletions(-)\n\n\n---\nbase-commit: 068617a55d86f94c21cc8cbaef1c8dd7b31531e3\nchange-id: 20260416-fix_clock_settime_helper-d47f0db0057e\n\nBest regards,", "diff": "diff --git a/testcases/open_posix_testsuite/conformance/interfaces/clock_settime/helpers.h b/testcases/open_posix_testsuite/conformance/interfaces/clock_settime/helpers.h\nindex 37bf30926f039553e9e370751b7938ca5ea1d00a..2802b694133b90f478ee10073bcdfa0e34320f7d 100644\n--- a/testcases/open_posix_testsuite/conformance/interfaces/clock_settime/helpers.h\n+++ b/testcases/open_posix_testsuite/conformance/interfaces/clock_settime/helpers.h\n@@ -13,7 +13,12 @@\n * by those tests.\n */\n \n+#ifndef CLOCK_SETTIME_HELPERS_H\n+#define CLOCK_SETTIME_HELPERS_H\n+\n #include <stdlib.h>\n+#include <unistd.h>\n+#include \"clock.h\"\n \n static int getBeforeTime(struct timespec *tpget)\n {\n@@ -37,53 +42,53 @@ static int setBackTime(struct timespec tpset)\n \n #define PTS_MONO_MAX_RETRIES 3\n \n-#ifdef _POSIX_MONOTONIC_CLOCK\n-static struct timespec _pts_mono_start;\n+static struct timespec pts_mono_start;\n \n static inline int pts_mono_time_start(void)\n {\n-\tif (clock_gettime(CLOCK_MONOTONIC, &_pts_mono_start) != 0) {\n+\tif (!pts_mono_available()) {\n+\t\tstatic int warned;\n+\n+\t\tif (!warned) {\n+\t\t\tprintf(\"CLOCK_MONOTONIC unavailable, test may fail due to clock adjustment\\n\");\n+\t\t\twarned = 1;\n+\t\t}\n+\t\treturn 0;\n+\t}\n+\n+#ifdef _POSIX_MONOTONIC_CLOCK\n+\tif (clock_gettime(CLOCK_MONOTONIC, &pts_mono_start) != 0) {\n \t\tperror(\"clock_gettime(CLOCK_MONOTONIC) failed\");\n \t\treturn -1;\n \t}\n+#endif\n \treturn 0;\n }\n \n static inline int pts_mono_time_check(unsigned int expected_secs)\n {\n-\tstruct timespec now;\n-\tlong elapsed;\n-\n-\tif (clock_gettime(CLOCK_MONOTONIC, &now) != 0) {\n-\t\tperror(\"clock_gettime(CLOCK_MONOTONIC) failed\");\n-\t\treturn -1;\n-\t}\n+#ifdef _POSIX_MONOTONIC_CLOCK\n+\tif (pts_mono_available()) {\n+\t\tstruct timespec now;\n+\t\tlong elapsed;\n \n-\telapsed = now.tv_sec - _pts_mono_start.tv_sec;\n+\t\tif (clock_gettime(CLOCK_MONOTONIC, &now) != 0) {\n+\t\t\tperror(\"clock_gettime(CLOCK_MONOTONIC) failed\");\n+\t\t\treturn -1;\n+\t\t}\n \n-\tif (labs(elapsed - (long)expected_secs) > 1) {\n-\t\tprintf(\"Clock adjustment detected (elapsed %lds, expected ~%us)\\n\",\n-\t\t elapsed, expected_secs);\n-\t\treturn 1;\n-\t}\n-\treturn 0;\n-}\n-#else\n-static inline int pts_mono_time_start(void)\n-{\n-\tstatic int warned;\n+\t\telapsed = now.tv_sec - pts_mono_start.tv_sec;\n \n-\tif (!warned) {\n-\t\tprintf(\"CLOCK_MONOTONIC unavailable, test may fail due to clock adjustment\\n\");\n-\t\twarned = 1;\n+\t\tif (labs(elapsed - (long)expected_secs) > 1) {\n+\t\t\tprintf(\"Clock adjustment detected (elapsed %lds, expected ~%us)\\n\",\n+\t\t\t elapsed, expected_secs);\n+\t\t\treturn 1;\n+\t\t}\n+\t\treturn 0;\n \t}\n-\treturn 0;\n-}\n-\n-static inline int pts_mono_time_check(unsigned int expected_secs)\n-{\n+#endif\n \t(void)expected_secs;\n \treturn 0;\n }\n-#endif\n \n+#endif /* CLOCK_SETTIME_HELPERS_H */\ndiff --git a/testcases/open_posix_testsuite/include/clock.h b/testcases/open_posix_testsuite/include/clock.h\nnew file mode 100644\nindex 0000000000000000000000000000000000000000..351064f988bd1af75aa16da03bf8a545990bbbfc\n--- /dev/null\n+++ b/testcases/open_posix_testsuite/include/clock.h\n@@ -0,0 +1,23 @@\n+/*\n+ * Copyright (c) 2026, Linux Test Project\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+#ifndef PTS_CLOCK_H\n+#define PTS_CLOCK_H\n+\n+#include <unistd.h>\n+\n+static inline int pts_mono_available(void)\n+{\n+#ifdef _POSIX_MONOTONIC_CLOCK\n+\tif (_POSIX_MONOTONIC_CLOCK > 0)\n+\t\treturn 1;\n+\n+\tif (!_POSIX_MONOTONIC_CLOCK && sysconf(_SC_MONOTONIC_CLOCK) > 0)\n+\t\treturn 1;\n+#endif\n+\treturn 0;\n+}\n+\n+#endif /* PTS_CLOCK_H */\n", "prefixes": [ "v2" ] }