Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229460/?format=api
{ "id": 2229460, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229460/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428093339.2087081-5-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428093339.2087081-5-peter.maydell@linaro.org>", "date": "2026-04-28T09:33:39", "name": "[4/4] system/memory: assert on invalid MemoryRegionOps .unaligned combo", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d34a649e743458fa26d0ec368303dabe65c1982", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/1.1/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428093339.2087081-5-peter.maydell@linaro.org/mbox/", "series": [ { "id": 501806, "url": "http://patchwork.ozlabs.org/api/1.1/series/501806/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501806", "date": "2026-04-28T09:33:37", "name": "MemoryRegionOps .impl cleanups", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501806/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229460/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229460/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ChUf3Tpw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Zys31tNz1yJH\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 19:34:43 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHepF-0003Sz-AR; Tue, 28 Apr 2026 05:33:53 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHepB-0003Pv-No\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 05:33:49 -0400", "from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHepA-0007Rt-1i\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 05:33:49 -0400", "by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-488e1a8ac40so137997275e9.2\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 02:33:47 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a774d7a1fsm19665595e9.4.2026.04.28.02.33.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 02:33:45 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777368826; x=1777973626; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oIPgICtUT5mEW768v6oe59XIzNRMnfU3f85R7Lwvkp8=;\n b=ChUf3TpwErRjFtnd1jx33aEyljcZ0yBYDyG8DO1dOd0ZY/Uug6HZp49azaogAYwHY6\n 19K+KEzSp26z5EdSqOPZC6XTERMUj4BfoDk+cuZcXQtsjOGR8I/OCykY4o090sehHhMW\n Sh8xTqIVMDHO0XUSY9RkbbCTPfbrkXE2Fd3RUcDxtkYHlRJtjZZtUn/Y36kAyP3bh0+d\n l+3h35Xgi1EBg7ci+0Pvoya1NOKtzSelumfK3E/MoPjFvBldo+diOlUvbo+CWXU+JqsW\n rAiTryuNySaTGUdE8bWzONIlR2XpGPBqss7UFts+nBGMp8vGxZPSzws3lTPdmataOxIX\n +jIA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777368826; x=1777973626;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=oIPgICtUT5mEW768v6oe59XIzNRMnfU3f85R7Lwvkp8=;\n b=DeC0F/4Sn+0rYmz1bmGy58VDcInEhLdO4XPtmlxuG6asx7g7lkqwsG4k7pZ71NKJR7\n iDww7FgPbxpdmjZKuRX7s3BAre5YsiBqyBSox4YtI9PbUSxooNU+LmJiExFXXsjqmQfG\n jJGfMU3DW9m9m7loK2ls2zMIoX7qrPd5W+Chr/ffbGFnsxbtSve6WLxP7AuBxNnwxX4h\n Yjgxui7+VITPlSZ4momkbP71PeaMJJzVky9ax7IjxwV9pBJTJnOVIzj5A/YLIzFBuZlS\n K9xRry8zH2HchxmVPvRu33vgIUogGTJ3jC4568tVciVFSlsMGAI09XBwSFOhoXmiESF6\n ya7w==", "X-Gm-Message-State": "AOJu0YwER50P2s84M2zRiMBB3dsQrXO+NQBZOUwFyM/T+O3GkF4YzIAJ\n xNP2KS/hCOHR7DyHPqDbNj/ciQS4yhubZsrKPerjFYiVMi0VgG8/UNKx4kK6IkNouN5KrzdDe+d\n yLSYI", "X-Gm-Gg": "AeBDievJxCtZVJdjiSph3uECxozMjdgalDznE0tsPB25OQH/cQTVdjnoxA13PxhF1C8\n uLQG2Bx53xgxJHW7urnPqi6m/Ox7egrNwSduWjuBR9CusDbYRYoUFpt0AnPpJKQMrvMzlLkLWMT\n 1tBkgl1FZB9/AlVwfFsG7laYCijrpSaP1WoMVxjh71QFyURer+R8acrkR0t/nsZL6gQ9meQa+Sn\n SBYcmp3ATzxuL6vggGH+JAiVCdLUFNsTWWE3vC7jfWdQwypJD56S7HrI5I+Mr/gPyXd0bHtOQmd\n 7bod6wOzCJDDz5semC162bjJCW7bPXQr2hGke3D7up+ZBa5eHCyyKdbANNw13aLlR1U17dBSPHc\n 0Tn3uMLASwyS2FhZ0SkD/1nsG3Bdz81W0a2klB1JRDOaA5AsfrU89SQWoRoMe5N1RP9WSEltdD3\n UAt3GVK9exN47eZfhzXr29p0kak5WdWhEcUQOBAF9HBBWXgWuY/OsuPX/2c3MS58wruZCu+AciE\n Du9uqrJ0HNtgZW5PHfXnEsK5cc8Jl2xKLmDn4rSAQ==", "X-Received": "by 2002:a05:600c:a013:b0:48a:563c:c8e0 with SMTP id\n 5b1f17b1804b1-48a77ad5a89mr38930575e9.1.1777368826507;\n Tue, 28 Apr 2026 02:33:46 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, Tyrone Ting <kfting@nuvoton.com>,\n Hao Wu <wuhaotsh@google.com>, Max Filippov <jcmvbkbc@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n qemu-riscv@nongnu.org, qemu-arm@nongnu.org", "Subject": "[PATCH 4/4] system/memory: assert on invalid MemoryRegionOps\n .unaligned combo", "Date": "Tue, 28 Apr 2026 10:33:39 +0100", "Message-ID": "<20260428093339.2087081-5-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260428093339.2087081-1-peter.maydell@linaro.org>", "References": "<20260428093339.2087081-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::333;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: CJ Chen <cjchen@igel.co.jp>\n\nWhen it comes to this pattern: .valid.unaligned = false and\nimpl.unaligned = true, is effectlvely contradictory. The .valid\nstructure indicates that unaligned access should be rejected at\nthe access validation phase, yet .impl suggests the underlying\ndevice implementation can handle unaligned operations. As a result,\nthe upper-layer code will never even reach the .impl logic.\n\nAdd an assertion that the MemoryRegionOps doesn't specify\nthis invalid combination.\n\nSigned-off-by: CJ Chen <cjchen@igel.co.jp>\nTested-by: CJ Chen <cjchen@igel.co.jp>\nSuggested-by: Peter Xu <peterx@redhat.com>\nAcked-by: Tomoyuki Hirose <hrstmyk811m@gmail.com>\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n[PMM: tweaked commit message]\nReviewed-by: Peter Maydell <peter.maydell@linaro.org>\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n system/memory.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/system/memory.c b/system/memory.c\nindex 225bbe38c3..739ba11da6 100644\n--- a/system/memory.c\n+++ b/system/memory.c\n@@ -1573,6 +1573,7 @@ void memory_region_init_io(MemoryRegion *mr, Object *owner,\n const MemoryRegionOps *ops, void *opaque,\n const char *name, uint64_t size)\n {\n+ g_assert(!ops || !(ops->impl.unaligned && !ops->valid.unaligned));\n memory_region_init(mr, owner, name, size);\n memory_region_set_ops(mr, ops, opaque);\n }\n", "prefixes": [ "4/4" ] }