Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229459/?format=api
{ "id": 2229459, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229459/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428093339.2087081-3-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428093339.2087081-3-peter.maydell@linaro.org>", "date": "2026-04-28T09:33:37", "name": "[2/4] hw/npcm7xx_fiu: Specify .impl for npcm7xx_fiu_flash_ops", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7ae256a3cfc27b6f1831160cda5b8ea003aa600d", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/1.1/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428093339.2087081-3-peter.maydell@linaro.org/mbox/", "series": [ { "id": 501806, "url": "http://patchwork.ozlabs.org/api/1.1/series/501806/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501806", "date": "2026-04-28T09:33:37", "name": "MemoryRegionOps .impl cleanups", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501806/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229459/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229459/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=rj7zdTA8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Zys2zMwz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 19:34:43 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHepD-0003Qr-4k; Tue, 28 Apr 2026 05:33:51 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHep9-0003NR-O5\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 05:33:47 -0400", "from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHep8-0007Qo-3c\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 05:33:47 -0400", "by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-4890098abbaso88560305e9.0\n for <qemu-devel@nongnu.org>; Tue, 28 Apr 2026 02:33:45 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a774d7a1fsm19665595e9.4.2026.04.28.02.33.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 28 Apr 2026 02:33:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777368824; x=1777973624; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WVC3itSIffFeC7Z8GlSjGgA9Tg3i0GpOS5eY/5lxrn4=;\n b=rj7zdTA8M/AZW7o8vRqn91sKKqoXjmGfBR0Pv3NXWQh4kjT5S1hNDBT9K8yhs9Quh8\n 02+Xn0ZBMYwv12pcIjRVo4fN+T8fK4UisSRsBRowVX1tPMu50lzcccMQ6yE9T8UnWf6G\n FWNYThWxIWBW0E1FX4cPndl1eVfAnNo/TQQxqzLxcbdn6vNB4oU/CrgGwWhQOMxaJduT\n KwHcb604gg+ACBDtq4iAwA5BSVNKRUd86k1SngxYnXj0EIQ4Tc+2NqZj0eNPibG+Iq9O\n jw5uquvw+AVsZoEbOZg/By9WQRUmQE67f/krqDOC2jAIYpBFoAEAGOpJhS2HZ3PUqY9P\n b1ag==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777368824; x=1777973624;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WVC3itSIffFeC7Z8GlSjGgA9Tg3i0GpOS5eY/5lxrn4=;\n b=p2zuq9PEo09PA2UyiPgqWqtVpYeQOOGLak2zZ6CLiG4IVu/6QrXqZG7XJkF14vLhIa\n vnEdw16A167w9Ft885e8izaKGu9wXv3SJPCMV8qeylOcXQlP4cpLiNmBGdyRHG0x0+bN\n dFOmIwToYim10kp1cAVlAjEcwDhDaJ4mZE8iqEgSBWoC3o7k54Pq+6Z4meLmwNcTYaSJ\n CFjQCfGBM2lj+0L7Q/FaJJhm12LzvtnHOYHqbN61aiBQ5uFy4nB82DBUEngNdOoN14VO\n l/Y3pNkECvOdnx234R9ExqU3VDl2gfeGAc21LeHx64jh1zZ0HMKnFtNQ/i6YfzmZ9nF6\n p6Xg==", "X-Gm-Message-State": "AOJu0Yz4ngLdqmO4/s3jtC8RbEaRpugsJu/eBvU40k+3UNFazJ7OiyCu\n b9SDVrg1kgRFOUrrp7Eji0Hon13K5ebMABx1ICmub+9dlBvGOgamXD8IbSxMB91dkQAP8Ic+Gt6\n XGvj5", "X-Gm-Gg": "AeBDietiL9CEtn5DHEhqCnW6AP2s2RYw6GTr7tVqhHDantxe55KZbA/GJVRzycvptwN\n +Mb28q3Yx6ET/SKtxJokCQXAX1d6UBjvghPWSuJ4YSJZDMuxl1Kjkj8eMQMTECbKhAwm955OleB\n bBVh5lhtnc51X38dNtNDY27GiXjR5mvmhWSlkIxVsew0Q+c2+ILT1GPmN306uxdBWvhOt9gD4ZU\n pGJ/SqyfZZwEwAkQbx/TUs3MBGQ0frHHb4OljTBoSq5J95ZW6HrG0hAElrOkJuBFcZc+Br4Z3mG\n jC//1EPsegRAH2Vcx+7ecZPyRywwS/ZtZBLOzD/FdSjMeetCzzgZGkQLTRDzDoIjy0S6xonOnA7\n ZyFxf3SvXZWnuJqtDwfkr2JN5pxQYmTITjQukjqXoJBIfnbCU6N9hF4XXNXVh2wfg89kOlHadK1\n WVsn5tvPsp0HABoAhhI/Bwvq8Vnn+oMRVDbvxAAi8EzBz7Qs0KTJccLdVBkOcGIeTnpoSvATUl6\n 4Ivbwp3iuJG9fEUc3mGRDXU51GRxb+yDIYR9XVqnw==", "X-Received": "by 2002:a05:600c:6995:b0:488:a2ac:a334 with SMTP id\n 5b1f17b1804b1-48a77aee4a3mr37301045e9.3.1777368824444;\n Tue, 28 Apr 2026 02:33:44 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, Tyrone Ting <kfting@nuvoton.com>,\n Hao Wu <wuhaotsh@google.com>, Max Filippov <jcmvbkbc@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>, Peter Xu <peterx@redhat.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n qemu-riscv@nongnu.org, qemu-arm@nongnu.org", "Subject": "[PATCH 2/4] hw/npcm7xx_fiu: Specify .impl for npcm7xx_fiu_flash_ops", "Date": "Tue, 28 Apr 2026 10:33:37 +0100", "Message-ID": "<20260428093339.2087081-3-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260428093339.2087081-1-peter.maydell@linaro.org>", "References": "<20260428093339.2087081-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::336;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Currently npcm7xx_fiu_flash_ops provides no .impl substruct; this\nmeans that it gets the default of \"implements 1, 2 and 4 byte aligned\naccesses\". This is more constrained than the device permits in its\n.valid substruct, and also narrower than the functions are written to\nhandle.\n\nAdd a .impl substruct matching the .valid substruct; this means that\nall guest accesses are handled directly by the read and write\nfunctions, and are never synthesized by the memory subsystem\nperforming multiple accesses to the device (which would not behave\ncorrectly, as these read and write fucntions have side effects).\n\nBased-on-a-patch-by: CJ Chen <cjchen@igel.co.jp>\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n hw/ssi/npcm7xx_fiu.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/hw/ssi/npcm7xx_fiu.c b/hw/ssi/npcm7xx_fiu.c\nindex 02707de350..2d5bed005a 100644\n--- a/hw/ssi/npcm7xx_fiu.c\n+++ b/hw/ssi/npcm7xx_fiu.c\n@@ -250,6 +250,11 @@ static const MemoryRegionOps npcm7xx_fiu_flash_ops = {\n .read = npcm7xx_fiu_flash_read,\n .write = npcm7xx_fiu_flash_write,\n .endianness = DEVICE_LITTLE_ENDIAN,\n+ .impl = {\n+ .min_access_size = 1,\n+ .max_access_size = 8,\n+ .unaligned = true,\n+ },\n .valid = {\n .min_access_size = 1,\n .max_access_size = 8,\n", "prefixes": [ "2/4" ] }