Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229452/?format=api
{ "id": 2229452, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229452/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260428091147.387324BB58C7@sourceware.org/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260428091147.387324BB58C7@sourceware.org>", "date": "2026-04-28T09:10:55", "name": "[1/4] Simplify vect_get_known_peeling_cost", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4265515b4e96789dfd9b6519c51427f8debc36b7", "submitter": { "id": 4338, "url": "http://patchwork.ozlabs.org/api/1.1/people/4338/?format=api", "name": "Richard Biener", "email": "rguenther@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260428091147.387324BB58C7@sourceware.org/mbox/", "series": [ { "id": 501803, "url": "http://patchwork.ozlabs.org/api/1.1/series/501803/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501803", "date": "2026-04-28T09:11:06", "name": "[1/4] Simplify vect_get_known_peeling_cost", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501803/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229452/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229452/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=i83A32+d;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Vk1bJqL8;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=i83A32+d;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Vk1bJqL8;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=i83A32+d;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Vk1bJqL8;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=i83A32+d;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=Vk1bJqL8", "sourceware.org;\n dmarc=pass (p=none dis=none) header.from=suse.de", "sourceware.org; spf=pass smtp.mailfrom=suse.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.130", "smtp-out1.suse.de;\n\tnone" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4ZSP0F5tz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 19:11:49 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 387324BB58C7\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 09:11:47 +0000 (GMT)", "from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130])\n by sourceware.org (Postfix) with ESMTPS id 204E84BA902A\n for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2026 09:10:57 +0000 (GMT)", "from murzim.nue2.suse.org (unknown [10.168.4.243])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id F34956A7E7\n for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2026 09:10:55 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 387324BB58C7", "OpenDKIM Filter v2.11.0 sourceware.org 204E84BA902A" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 204E84BA902A", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 204E84BA902A", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777367457; cv=none;\n b=B/n7YrsA8uFyRZUcjnIwnY7A+zvHmz6d1r7/BGXFvLRlf1fi6s6w3vk1D0om85o7mdJ7D8SQu3DkwTz8gQeabf0mQq8NzOrHzLfFxflFOaPz00/U6r0ptXGSCxE/1Wk00A1jNZEn19zcTFqzriBQ4fPvW0AhNHplp2QuvAhFLRQ=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777367457; c=relaxed/simple;\n bh=AIyKmfoh4H93JFyOKIOjJng8p1eAAizF78rAkw7Boio=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date:\n From:To:Subject:MIME-Version;\n b=K86R0ISD+1qVMH0zgWo2omR5LDhiIjs6sKJCPlut2x4k1436AKAG9svtF+P/S0Cj70iIWROp+nlyT+4q3X1JAc6SfhS2JbM9G4AZpHTD4Nr4H/mYPAhZKghRDCsMyHJUQKfcxqp6Fsj+9mSogs+py7flXdm6lYxU5wtyct9iqLk=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777367456;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=Gf2JE+fNxoIzvnj96UidK2QG1AeQusYPJJm5QFPccjM=;\n b=i83A32+dSijVA3xVLGMwVliXLbHIZx3hgZIjCm+2Yje6T8Lhb0lVMTvSDAfLTuy6P1O5zm\n OHYAG5qLyJU91BB0tC0jcrdEuNn//MwtSvYUbCaNfCca4wWGq6oOFKuKv+K2738f0mylSs\n QVtD4LOF4luhdAkUjQM8VhTdWKUwQpo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777367456;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=Gf2JE+fNxoIzvnj96UidK2QG1AeQusYPJJm5QFPccjM=;\n b=Vk1bJqL8bLODfS8HXCRs3nhRSyU1xlu+WoKDTLZYcSps79oVv1EqGQ/wsmXvsAeEWuYgPY\n 58bGz32LeYZ+XPDA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1777367456;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=Gf2JE+fNxoIzvnj96UidK2QG1AeQusYPJJm5QFPccjM=;\n b=i83A32+dSijVA3xVLGMwVliXLbHIZx3hgZIjCm+2Yje6T8Lhb0lVMTvSDAfLTuy6P1O5zm\n OHYAG5qLyJU91BB0tC0jcrdEuNn//MwtSvYUbCaNfCca4wWGq6oOFKuKv+K2738f0mylSs\n QVtD4LOF4luhdAkUjQM8VhTdWKUwQpo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1777367456;\n h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=Gf2JE+fNxoIzvnj96UidK2QG1AeQusYPJJm5QFPccjM=;\n b=Vk1bJqL8bLODfS8HXCRs3nhRSyU1xlu+WoKDTLZYcSps79oVv1EqGQ/wsmXvsAeEWuYgPY\n 58bGz32LeYZ+XPDA==" ], "Date": "Tue, 28 Apr 2026 11:10:55 +0200 (CEST)", "From": "Richard Biener <rguenther@suse.de>", "To": "gcc-patches@gcc.gnu.org", "Subject": "[PATCH 1/4] Simplify vect_get_known_peeling_cost", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "X-Spamd-Result": "default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-0.999];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1];\n MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n TO_DN_NONE(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org", "Message-Id": "<20260428091147.387324BB58C7@sourceware.org>" }, "content": "The following reflects into vect_get_known_peeling_cost what it actually\ndoes and simplifies that with the three callers in mind which do not\nneed most of what is computed. The function ends up using\nlegacy builtin_vectorization_cost to sum up N scalar loop copies.\n\nWith the next patch in the series this should improve, also\ncompile-time wise.\n\nBootstrapped and tested on x86_64-unknown-linux-gnu, pushed.\n\n\t* tree-vectorizer.h (vect_get_known_peeling_cost): Simplify API.\n\t* tree-vect-loop.cc (vect_get_known_peeling_cost): Avoid\n\tall the overhead of record_stmt_cost as we only are interested\n\tin the overall sum of the included builtin_vectorization_cost\n\tcalls.\n\t* tree-vect-data-refs.cc (vect_peeling_hash_get_lowest_cost):\n\tAdjust.\n\t(vect_enhance_data_refs_alignment): Likewise.\n---\n gcc/tree-vect-data-refs.cc | 45 +++++---------------------------------\n gcc/tree-vect-loop.cc | 37 ++++++++++++-------------------\n gcc/tree-vectorizer.h | 5 +----\n 3 files changed, 21 insertions(+), 66 deletions(-)", "diff": "diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc\nindex 48181a4e7f0..da65f1d652c 100644\n--- a/gcc/tree-vect-data-refs.cc\n+++ b/gcc/tree-vect-data-refs.cc\n@@ -2074,33 +2074,21 @@ vect_peeling_hash_get_lowest_cost (_vect_peel_info **slot,\n \t\t\t\t _vect_peel_extended_info *min)\n {\n vect_peel_info elem = *slot;\n- int dummy;\n unsigned int inside_cost = 0, outside_cost = 0;\n loop_vec_info loop_vinfo = dyn_cast <loop_vec_info> (min->vinfo);\n- stmt_vector_for_cost prologue_cost_vec, body_cost_vec,\n-\t\t epilogue_cost_vec;\n+ stmt_vector_for_cost prologue_cost_vec, body_cost_vec;\n \n prologue_cost_vec.create (2);\n body_cost_vec.create (2);\n- epilogue_cost_vec.create (2);\n \n vect_get_peeling_costs_all_drs (loop_vinfo, elem->dr_info, &inside_cost,\n \t\t\t\t &outside_cost, &body_cost_vec,\n \t\t\t\t &prologue_cost_vec, elem->npeel);\n \n body_cost_vec.release ();\n-\n- outside_cost += vect_get_known_peeling_cost\n- (loop_vinfo, elem->npeel, &dummy,\n- &LOOP_VINFO_SCALAR_ITERATION_COST (loop_vinfo),\n- &prologue_cost_vec, &epilogue_cost_vec);\n-\n- /* Prologue and epilogue costs are added to the target model later.\n- These costs depend only on the scalar iteration cost, the\n- number of peeling iterations finally chosen, and the number of\n- misaligned statements. So discard the information found here. */\n prologue_cost_vec.release ();\n- epilogue_cost_vec.release ();\n+\n+ outside_cost += vect_get_known_peeling_cost (loop_vinfo, elem->npeel);\n \n if (inside_cost < min->inside_cost\n || (inside_cost == min->inside_cost\n@@ -2691,18 +2679,8 @@ vect_enhance_data_refs_alignment (loop_vec_info loop_vinfo)\n \t peel_for_unknown_alignment.outside_cost = load_outside_cost;\n \t}\n \n- stmt_vector_for_cost prologue_cost_vec, epilogue_cost_vec;\n- prologue_cost_vec.create (2);\n- epilogue_cost_vec.create (2);\n-\n- int dummy2;\n- peel_for_unknown_alignment.outside_cost += vect_get_known_peeling_cost\n-\t(loop_vinfo, estimated_npeels, &dummy2,\n-\t &LOOP_VINFO_SCALAR_ITERATION_COST (loop_vinfo),\n-\t &prologue_cost_vec, &epilogue_cost_vec);\n-\n- prologue_cost_vec.release ();\n- epilogue_cost_vec.release ();\n+ peel_for_unknown_alignment.outside_cost\n+\t+= vect_get_known_peeling_cost (loop_vinfo, estimated_npeels);\n \n peel_for_unknown_alignment.peel_info.count = dr0_same_align_drs + 1;\n }\n@@ -2760,18 +2738,7 @@ vect_enhance_data_refs_alignment (loop_vec_info loop_vinfo)\n \n /* Add epilogue costs. As we do not peel for alignment here, no prologue\n \t costs will be recorded. */\n- stmt_vector_for_cost prologue_cost_vec, epilogue_cost_vec;\n- prologue_cost_vec.create (2);\n- epilogue_cost_vec.create (2);\n-\n- int dummy2;\n- nopeel_outside_cost += vect_get_known_peeling_cost\n-\t(loop_vinfo, 0, &dummy2,\n-\t &LOOP_VINFO_SCALAR_ITERATION_COST (loop_vinfo),\n-\t &prologue_cost_vec, &epilogue_cost_vec);\n-\n- prologue_cost_vec.release ();\n- epilogue_cost_vec.release ();\n+ nopeel_outside_cost += vect_get_known_peeling_cost (loop_vinfo, 0);\n \n npeel = best_peel.peel_info.npeel;\n dr0_info = best_peel.peel_info.dr_info;\ndiff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc\nindex ca200dc14da..1452677c461 100644\n--- a/gcc/tree-vect-loop.cc\n+++ b/gcc/tree-vect-loop.cc\n@@ -3923,17 +3923,14 @@ vect_get_peel_iters_epilogue (loop_vec_info loop_vinfo, int peel_iters_prologue)\n }\n }\n \n-/* Calculate cost of peeling the loop PEEL_ITERS_PROLOGUE times. */\n+/* Calculate cost of peeling the scalar loop PEEL_ITERS_PROLOGUE times for\n+ a prologue and the corresponding times for the epilogue. */\n int\n-vect_get_known_peeling_cost (loop_vec_info loop_vinfo, int peel_iters_prologue,\n-\t\t\t int *peel_iters_epilogue,\n-\t\t\t stmt_vector_for_cost *scalar_cost_vec,\n-\t\t\t stmt_vector_for_cost *prologue_cost_vec,\n-\t\t\t stmt_vector_for_cost *epilogue_cost_vec)\n+vect_get_known_peeling_cost (loop_vec_info loop_vinfo, int peel_iters_prologue)\n {\n int retval = 0;\n \n- *peel_iters_epilogue\n+ int peel_iters_epilogue\n = vect_get_peel_iters_epilogue (loop_vinfo, peel_iters_prologue);\n \n if (!LOOP_VINFO_NITERS_KNOWN_P (loop_vinfo))\n@@ -3941,27 +3938,21 @@ vect_get_known_peeling_cost (loop_vec_info loop_vinfo, int peel_iters_prologue,\n /* If peeled iterations are known but number of scalar loop\n \t iterations are unknown, count a taken branch per peeled loop. */\n if (peel_iters_prologue > 0)\n-\tretval = record_stmt_cost (prologue_cost_vec, 1, cond_branch_taken,\n-\t\t\t\t vect_prologue);\n- if (*peel_iters_epilogue > 0)\n-\tretval += record_stmt_cost (epilogue_cost_vec, 1, cond_branch_taken,\n-\t\t\t\t vect_epilogue);\n+\tretval = builtin_vectorization_cost (cond_branch_taken, NULL_TREE, 0);\n+ if (peel_iters_epilogue > 0)\n+\tretval += builtin_vectorization_cost (cond_branch_taken, NULL_TREE, 0);\n }\n \n stmt_info_for_cost *si;\n int j;\n if (peel_iters_prologue)\n- FOR_EACH_VEC_ELT (*scalar_cost_vec, j, si)\n- retval += record_stmt_cost (prologue_cost_vec,\n-\t\t\t\t si->count * peel_iters_prologue,\n-\t\t\t\t si->kind, si->stmt_info, si->misalign,\n-\t\t\t\t vect_prologue);\n- if (*peel_iters_epilogue)\n- FOR_EACH_VEC_ELT (*scalar_cost_vec, j, si)\n- retval += record_stmt_cost (epilogue_cost_vec,\n-\t\t\t\t si->count * *peel_iters_epilogue,\n-\t\t\t\t si->kind, si->stmt_info, si->misalign,\n-\t\t\t\t vect_epilogue);\n+ FOR_EACH_VEC_ELT (LOOP_VINFO_SCALAR_ITERATION_COST (loop_vinfo), j, si)\n+ retval += (builtin_vectorization_cost (si->kind, NULL_TREE, si->misalign)\n+\t\t * peel_iters_prologue);\n+ if (peel_iters_epilogue)\n+ FOR_EACH_VEC_ELT (LOOP_VINFO_SCALAR_ITERATION_COST (loop_vinfo), j, si)\n+ retval += (builtin_vectorization_cost (si->kind, NULL_TREE, si->misalign)\n+\t\t * peel_iters_epilogue);\n \n return retval;\n }\ndiff --git a/gcc/tree-vectorizer.h b/gcc/tree-vectorizer.h\nindex 1d20725c69e..bdc0180b4c3 100644\n--- a/gcc/tree-vectorizer.h\n+++ b/gcc/tree-vectorizer.h\n@@ -2725,10 +2725,7 @@ extern bool vectorizable_early_exit (loop_vec_info, stmt_vec_info,\n extern bool vect_emulated_vector_p (tree);\n extern bool vect_can_vectorize_without_simd_p (tree_code);\n extern bool vect_can_vectorize_without_simd_p (code_helper);\n-extern int vect_get_known_peeling_cost (loop_vec_info, int, int *,\n-\t\t\t\t\tstmt_vector_for_cost *,\n-\t\t\t\t\tstmt_vector_for_cost *,\n-\t\t\t\t\tstmt_vector_for_cost *);\n+extern int vect_get_known_peeling_cost (loop_vec_info, int);\n extern tree cse_and_gimplify_to_preheader (loop_vec_info, tree);\n \n /* Nonlinear induction. */\n", "prefixes": [ "1/4" ] }