Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229375/?format=api
{ "id": 2229375, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229375/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428081303.990973-4-marcandre.lureau@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428081303.990973-4-marcandre.lureau@redhat.com>", "date": "2026-04-28T08:12:50", "name": "[PULL,03/15] ui: make qemu_default_pixelformat() static inline", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8471d7c6f558449458e31e8cba8b039c9be85313", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428081303.990973-4-marcandre.lureau@redhat.com/mbox/", "series": [ { "id": 501785, "url": "http://patchwork.ozlabs.org/api/1.1/series/501785/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501785", "date": "2026-04-28T08:12:48", "name": "[PULL,01/15] ui: move FONT_WIDTH/HEIGHT to vgafont.h", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501785/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229375/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229375/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UAdXOi0b;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Y9Q0WMZz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 18:13:44 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHdZV-0005ux-E9; Tue, 28 Apr 2026 04:13:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHdZT-0005ub-VT\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:13:31 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHdZS-0005op-Fr\n for qemu-devel@nongnu.org; Tue, 28 Apr 2026 04:13:31 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-7NBnKe7uOn6hTuzQb1DDfg-1; Tue,\n 28 Apr 2026 04:13:28 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 307B919560B7; Tue, 28 Apr 2026 08:13:27 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id D08BA1800352; Tue, 28 Apr 2026 08:13:25 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777364009;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=qcHo94HuD0MwG1Lrycu+X8H89uP+8uG3alrwsl0qpx8=;\n b=UAdXOi0bPq7MGq71bFykMQExjjD6IN+q+A9OEMamC20YKene3e9AHBSRa8+YGcmqytk8pt\n Cpn2MgUYNO6aI9+/1i0FhFR1GsrbvAplxIzbGLDmb2tp1k/L/TCrFxMoqKLLVrG8qYv9io\n uiix3GeLc9qFkVLpFJMFw0xzVwgFtoc=", "X-MC-Unique": "7NBnKe7uOn6hTuzQb1DDfg-1", "X-Mimecast-MFC-AGG-ID": "7NBnKe7uOn6hTuzQb1DDfg_1777364007", "From": "marcandre.lureau@redhat.com", "To": "qemu-devel@nongnu.org", "Cc": "peter.maydell@linaro.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Subject": "[PULL 03/15] ui: make qemu_default_pixelformat() static inline", "Date": "Tue, 28 Apr 2026 12:12:50 +0400", "Message-ID": "<20260428081303.990973-4-marcandre.lureau@redhat.com>", "In-Reply-To": "<20260428081303.990973-1-marcandre.lureau@redhat.com>", "References": "<20260428081303.990973-1-marcandre.lureau@redhat.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Marc-André Lureau <marcandre.lureau@redhat.com>\n\nThe function is a trivial wrapper around qemu_default_pixman_format()\nand qemu_pixelformat_from_pixman(), so make it static inline in\nqemu-pixman.h instead of a standalone function in console.c, allowing to\nbe easily reused.\n\nReviewed-by: Daniel P. Berrangé <berrange@redhat.com>\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n include/ui/qemu-pixman.h | 8 ++++++++\n include/ui/surface.h | 2 --\n ui/console.c | 7 -------\n 3 files changed, 8 insertions(+), 9 deletions(-)", "diff": "diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h\nindex 2ca0ed7029c..4bc7a59698e 100644\n--- a/include/ui/qemu-pixman.h\n+++ b/include/ui/qemu-pixman.h\n@@ -73,6 +73,14 @@ typedef struct PixelFormat {\n \n PixelFormat qemu_pixelformat_from_pixman(pixman_format_code_t format);\n pixman_format_code_t qemu_default_pixman_format(int bpp, bool native_endian);\n+\n+static inline PixelFormat qemu_default_pixelformat(int bpp)\n+{\n+ pixman_format_code_t fmt = qemu_default_pixman_format(bpp, true);\n+ PixelFormat pf = qemu_pixelformat_from_pixman(fmt);\n+ return pf;\n+}\n+\n pixman_format_code_t qemu_drm_format_to_pixman(uint32_t drm_format);\n uint32_t qemu_pixman_to_drm_format(pixman_format_code_t pixman);\n int qemu_pixman_get_type(int rshift, int gshift, int bshift, int endian);\ndiff --git a/include/ui/surface.h b/include/ui/surface.h\nindex d2542d3ace5..8e5f3e35e8c 100644\n--- a/include/ui/surface.h\n+++ b/include/ui/surface.h\n@@ -24,8 +24,6 @@ typedef struct DisplaySurface {\n uint32_t share_handle_offset;\n } DisplaySurface;\n \n-PixelFormat qemu_default_pixelformat(int bpp);\n-\n DisplaySurface *qemu_create_displaysurface_from(int width, int height,\n pixman_format_code_t format,\n int linesize, uint8_t *data);\ndiff --git a/ui/console.c b/ui/console.c\nindex 475a72aa08f..ff561617657 100644\n--- a/ui/console.c\n+++ b/ui/console.c\n@@ -1390,13 +1390,6 @@ DisplaySurface *qemu_console_surface(QemuConsole *console)\n }\n }\n \n-PixelFormat qemu_default_pixelformat(int bpp)\n-{\n- pixman_format_code_t fmt = qemu_default_pixman_format(bpp, true);\n- PixelFormat pf = qemu_pixelformat_from_pixman(fmt);\n- return pf;\n-}\n-\n static QemuDisplay *dpys[DISPLAY_TYPE__MAX];\n \n void qemu_display_register(QemuDisplay *ui)\n", "prefixes": [ "PULL", "03/15" ] }