Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229364/?format=api
{ "id": 2229364, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229364/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428070647.777141-3-michal.swiatkowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428070647.777141-3-michal.swiatkowski@linux.intel.com>", "date": "2026-04-28T07:06:47", "name": "[iwl-net,v1,2/2] ice: use NETIF_F_HW_CSUM instead of IP/IPV6", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "71ef1883ab774f27a7d658d9264743bafd68e3b4", "submitter": { "id": 81972, "url": "http://patchwork.ozlabs.org/api/1.1/people/81972/?format=api", "name": "Michal Swiatkowski", "email": "michal.swiatkowski@linux.intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260428070647.777141-3-michal.swiatkowski@linux.intel.com/mbox/", "series": [ { "id": 501778, "url": "http://patchwork.ozlabs.org/api/1.1/series/501778/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501778", "date": "2026-04-28T07:06:47", "name": "Rework ice Tx checksum", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501778/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229364/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229364/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=O0id5QIA;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Xcc1XMnz1yJH\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 17:48:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B34F660ED3;\n\tTue, 28 Apr 2026 07:48:46 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id vWpKP2SS0Adz; Tue, 28 Apr 2026 07:48:45 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id D916560EDC;\n\tTue, 28 Apr 2026 07:48:45 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 509371B8\n for <intel-wired-lan@lists.osuosl.org>; Tue, 28 Apr 2026 07:48:44 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 368ED81DF6\n for <intel-wired-lan@lists.osuosl.org>; Tue, 28 Apr 2026 07:48:44 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0Y8ajV3lGc_6 for <intel-wired-lan@lists.osuosl.org>;\n Tue, 28 Apr 2026 07:48:43 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 2F73080984\n for <intel-wired-lan@lists.osuosl.org>; Tue, 28 Apr 2026 07:48:43 +0000 (UTC)", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Apr 2026 00:48:43 -0700", "from os-delivery.igk.intel.com ([10.102.21.165])\n by fmviesa003.fm.intel.com with ESMTP; 28 Apr 2026 00:48:41 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org D916560EDC", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2F73080984" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777362525;\n\tbh=5KLkgtc/ClwA1IW4x25/+pMIcPRvAbZOkKaAblLfepE=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=O0id5QIAOo0z/3eHdsE7CQyr/i4prbjwq3Jl7rCn5s4RkoOTv8qAU2AqIX162J7Ls\n\t efkXZJKRVXHNbe9WlAtFduINDGBRVeSHiMMjHKjhqacnyEB5PBy9p9DtUHE9VjH8R9\n\t gKu6HaxWjVHrC7ZJdcSTDaymaxXQHR/aG1INV1C3sj7hhc8sFqLBOMZPq7ntGCtvkv\n\t LD6RDINsLeisoVllI+rDmfDIBZrAIcoj8DlTnSQ+2uEkWtR43Ojb0an8SE1gvyR3RX\n\t XPHKNyuErhApP/TAFeTpDJ2EUu4LI90TsYE72O9SN7WGGnXVVatl++lIhwvfGvmywR\n\t TuMQbK0kp/IjA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.12;\n helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 2F73080984", "X-CSE-ConnectionGUID": [ "SynQMH3cS0mFhnfCxUjMBA==", "Wk4hzHRfT0iqPGSytiMW/A==" ], "X-CSE-MsgGUID": [ "5Hq8utxFRAWOiSTtggpRpw==", "srlJlaO7Tty0WggEyj2/eA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11769\"; a=\"82114988\"", "E=Sophos;i=\"6.23,203,1770624000\"; d=\"scan'208\";a=\"82114988\"" ], "X-ExtLoop1": "1", "From": "Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, jramaseu@redhat.com, anthony.l.nguyen@intel.com,\n przemyslaw.kitszel@intel.com, aleksandr.loktionov@intel.com,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>", "Date": "Tue, 28 Apr 2026 09:06:47 +0200", "Message-ID": "<20260428070647.777141-3-michal.swiatkowski@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20260428070647.777141-1-michal.swiatkowski@linux.intel.com>", "References": "<20260428070647.777141-1-michal.swiatkowski@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777362523; x=1808898523;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=v7FR8f9Bf7hDGtGHvqy69oIKLKN59GzoNuO6jFdL1vk=;\n b=JcDMAm2tcklVcaEKqyF7daMU+Z/dxDCxIFp/x185+7iq49xsBlbMEol7\n lljNWCopkpNqprA30TI4recK2r+kiDdRVO9HlWQX666esmLedl7YxF1+f\n qYggrULNQeEr49nBhS/utjcNpXspFTsQw6UJn62qHKIu2MpYspi68YUJK\n OPgZ/nSbaV4NzFn4HNy7Txl2jhSIS9eT9dkLmjKzp53SsLAiK51Tb9OrZ\n YyzM7dBgRKhsSED3BqDo/nvywHJqIQEqntC+hQqro7+4zZUIV+lBkm0q6\n xC+SGC2SniUQTkuDH2viiFck5Lw7qUwYRKqj4LuYs03q6vvOoHlqbYG/7\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=JcDMAm2t" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net v1 2/2] ice: use NETIF_F_HW_CSUM\n instead of IP/IPV6", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The hardware is capable of calculating checksum for IPV6 packets with\nextension header. To not drop such packets switch from IP/IPV6 checksum\nto HW_CSUM.\n\nHW_CSUM is also used in previous generation (i40e).\n\nPreviously HW_CSUM was used to indicate that hardware supports general\nchecksum. Drop it assuming that if the hardware supports it, it is used.\n\nDisabling offload for E830 in case of TSO isn't needed anymore as the\ncheck for TSO is done in Tx path just before preparation of the special\nGCS descriptor.\n\nThe commit from Fixes didn't introduce a bug, it just shown that the\ndriver is doing sth wrong with the checksum features.\n\nSuggested-by: Jakub Ramaseuski <jramaseu@redhat.com>\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\nFixes: 04c20a9356f2 (\"net: skip offload for NETIF_F_IPV6_CSUM if ipv6 header contains extension\")\nSigned-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 21 +--------------------\n 1 file changed, 1 insertion(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 15550216fbf0..0f2f949af536 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3500,9 +3500,8 @@ void ice_set_netdev_features(struct net_device *netdev)\n \t\t\tNETIF_F_RXHASH;\n \n \tcsumo_features = NETIF_F_RXCSUM\t |\n-\t\t\t NETIF_F_IP_CSUM |\n \t\t\t NETIF_F_SCTP_CRC |\n-\t\t\t NETIF_F_IPV6_CSUM;\n+\t\t\t NETIF_F_HW_CSUM;\n \n \tvlano_features = NETIF_F_HW_VLAN_CTAG_FILTER |\n \t\t\t NETIF_F_HW_VLAN_CTAG_TX |\n@@ -3564,12 +3563,6 @@ void ice_set_netdev_features(struct net_device *netdev)\n \t/* Allow core to manage IRQs affinity */\n \tnetif_set_affinity_auto(netdev);\n \n-\t/* Mutual exclusivity for TSO and GCS is enforced by the set features\n-\t * ndo callback.\n-\t */\n-\tif (ice_is_feature_supported(pf, ICE_F_GCS))\n-\t\tnetdev->hw_features |= NETIF_F_HW_CSUM;\n-\n \tnetif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);\n }\n \n@@ -6489,18 +6482,6 @@ ice_set_features(struct net_device *netdev, netdev_features_t features)\n \tif (changed & NETIF_F_LOOPBACK)\n \t\tret = ice_set_loopback(vsi, !!(features & NETIF_F_LOOPBACK));\n \n-\t/* Due to E830 hardware limitations, TSO (NETIF_F_ALL_TSO) with GCS\n-\t * (NETIF_F_HW_CSUM) is not supported.\n-\t */\n-\tif (ice_is_feature_supported(pf, ICE_F_GCS) &&\n-\t ((features & NETIF_F_HW_CSUM) && (features & NETIF_F_ALL_TSO))) {\n-\t\tif (netdev->features & NETIF_F_HW_CSUM)\n-\t\t\tdev_err(ice_pf_to_dev(pf), \"To enable TSO, you must first disable HW checksum.\\n\");\n-\t\telse\n-\t\t\tdev_err(ice_pf_to_dev(pf), \"To enable HW checksum, you must first disable TSO.\\n\");\n-\t\treturn -EIO;\n-\t}\n-\n \treturn ret;\n }\n \n", "prefixes": [ "iwl-net", "v1", "2/2" ] }