Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229310/?format=api
{ "id": 2229310, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229310/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428055254.76581-2-kane_chen@aspeedtech.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260428055254.76581-2-kane_chen@aspeedtech.com>", "date": "2026-04-28T05:52:56", "name": "[v1,1/1] hw/misc/aspeed_sbc: Add bounds checking for OTP write operations", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1971e5fe763177af41b947a16b3d56f1414db03a", "submitter": { "id": 92037, "url": "http://patchwork.ozlabs.org/api/1.1/people/92037/?format=api", "name": "Kane Chen", "email": "kane_chen@aspeedtech.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260428055254.76581-2-kane_chen@aspeedtech.com/mbox/", "series": [ { "id": 501764, "url": "http://patchwork.ozlabs.org/api/1.1/series/501764/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501764", "date": "2026-04-28T05:52:55", "name": "hw/misc/aspeed_sbc: Add bounds checking for OTP write operations", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501764/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229310/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229310/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=L6QKbt1C;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4V5d3jtXz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 15:55:17 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHbPN-0001sV-Qc; Tue, 28 Apr 2026 01:55:01 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kane_chen@aspeedtech.com>)\n id 1wHbNg-0001ZC-Oo; Tue, 28 Apr 2026 01:53:14 -0400", "from mail-japaneastazlp170130007.outbound.protection.outlook.com\n ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kane_chen@aspeedtech.com>)\n id 1wHbNd-0002G9-KE; Tue, 28 Apr 2026 01:53:11 -0400", "from SI6PR06MB7631.apcprd06.prod.outlook.com (2603:1096:4:239::11)\n by TYZPR06MB6073.apcprd06.prod.outlook.com (2603:1096:400:333::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Tue, 28 Apr\n 2026 05:52:56 +0000", "from SI6PR06MB7631.apcprd06.prod.outlook.com\n ([fe80::afe5:a3f1:b435:e43c]) by SI6PR06MB7631.apcprd06.prod.outlook.com\n ([fe80::afe5:a3f1:b435:e43c%4]) with mapi id 15.20.9846.025; Tue, 28 Apr 2026\n 05:52:56 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=NxHKz1aqOow73/ndwk9Ewd5IAg2BkZ8bq+u0Nl8AA5MdsT9oN/jAcF10/PLHcW7Q0RDTOdUvGf99fCi8PPC9721zba64GeaA13nvbSeWpx5gvxasSGr1yonf2Y+yt+7LeYP2Ke7s8Y9r5yPfK35FMB6Y2FNSWLIvaLX9cojft3azug1w0CZs+tT9xHdmjSehak+F/KnjG2NcWkPmKTrk5RTlMD6GAWJqAzGfYVo6DtsAf9b2qNB2zWjAVa/Fj7BOc700YIXaskBoFPaFNtcDIJDs5cQu8Wik3ZRy8pI1D53GqEo+SujvhHy1PozlGvDepCJ5k0y94/Sr2FOtbP4LHg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=O8qblrHi+XZYcgcuozYGykKoHPUFypGVq5jG5uqnmjA=;\n b=Zg7yrj0AeqFQGnL/4MWPDZkKeoQCURJaY8iI0u9LFToeD7djyNaGf19HNHW/k+mZQXrdHQaHsBkTIpJAX/wVROlzUORouJydZWTlZth/B6PBD3tCYn5Ik9juDqbwl20DiPXnNwKqN2203d7ZOhQdgyN/TDJ1h7k/a/yFcq7GXYULVDBwe5c0KuC7KCwWWhYvoL4wz6qEl8HhHlXkmTvINAkYVD2QYdTEUzNoqOJnKGOaduh9UQeOk58Ci0zuQJvRwZlpB7sBVHoPlBiYzr7SzJxGfvaE+pPGR4YOGZ2qZXNqBDZZ3sAOrxiAQZZPvrcIX4w7kCy93SdodmYBO9LP+Q==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=aspeedtech.com; dmarc=pass action=none\n header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=O8qblrHi+XZYcgcuozYGykKoHPUFypGVq5jG5uqnmjA=;\n b=L6QKbt1CT7qlTiHJQnx2uDSdiQG2claByzS0su0O6V2gvHcV7CtpwoFAnIbekarA490A891blNdUVaNDHjtm0dWkqn5Eh6mw8x+xTbi1mKAx333AB5BVtHL+Med60S0TynEU0CmyS3OAP/v7ougBjAAW+ooYNkZxnT97VC4WvNw169xat3f/K0Wd0HJAPZ4uAhOv0UTp6dUJEhhckHxukv4XJLD6+MGnaDNxBT9GMnax+0ZSqIqiVJTlfVxJIVjnsHaM55/BEgwiLoyiaJueVympU62n9mtML64Q+1mOMJmbUrxFFM43dihoY69f2RlLSHJynZX23b84NATyNA/4Tg==", "From": "Kane Chen <kane_chen@aspeedtech.com>", "To": "=?iso-8859-1?q?C=E9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n \"open list:ASPEED BMCs\" <qemu-arm@nongnu.org>,\n \"open list:All patches CC here\" <qemu-devel@nongnu.org>", "CC": "Troy Lee <troy_lee@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>,\n \"qemu-stable@nongnu.org\" <qemu-stable@nongnu.org>, =?iso-8859-1?q?C=E9dric?=\n\t=?iso-8859-1?q?_Le_Goater?= <clg@redhat.com>", "Subject": "[PATCH v1 1/1] hw/misc/aspeed_sbc: Add bounds checking for OTP write\n operations", "Thread-Topic": "[PATCH v1 1/1] hw/misc/aspeed_sbc: Add bounds checking for OTP\n write operations", "Thread-Index": "AQHc1tNDVtPV7xe+NUODvFad+2Zigg==", "Date": "Tue, 28 Apr 2026 05:52:56 +0000", "Message-ID": "<20260428055254.76581-2-kane_chen@aspeedtech.com>", "References": "<20260428055254.76581-1-kane_chen@aspeedtech.com>", "In-Reply-To": "<20260428055254.76581-1-kane_chen@aspeedtech.com>", "Accept-Language": "zh-TW, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=aspeedtech.com header.i=@aspeedtech.com\n header.a=rsa-sha256 header.s=selector1 header.b=L6QKbt1C;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=aspeedtech.com;" ], "x-ms-publictraffictype": "Email", "x-ms-traffictypediagnostic": "SI6PR06MB7631:EE_|TYZPR06MB6073:EE_", "x-ms-office365-filtering-correlation-id": "67ee702a-eb21-47c8-b80c-08dea4ea658f", "x-ms-exchange-senderadcheck": "1", "x-ms-exchange-antispam-relay": "0", "x-microsoft-antispam": "BCL:0;\n ARA:13230040|366016|376014|1800799024|22082099003|18002099003|56012099003|38070700021;", "x-microsoft-antispam-message-info": "\n 9R/VPb0hjeOIoa58H2DoJupVMZGNWcAT7w6u9hDToxmkNr41gdyBQgdMAiRp3CZjDAwi4FaaZr1wwG9q5/z+LoDNOkOf9D7GUtf2mrpeJoBMjm1ORmwpH2CqQqDs6k2YntWstp8xZaJIwG/MEwYQ+94sEhyVA4+eACTVDPJzk+mAA7nDkpk9vku7fS6vLT7Fx7sKRPoa4x6qIaCjvRxKkAtUYujFAVEuSvBiGBTrGN9k0X6dLn/zIhL9bAauwaMrowF0PFdHmF3uTORqGuuXAAlQgTWitp45b0ADmfh3XpaRU4lz+KqC0XNPdcgf18mJmYh5F/1kPYLp8sWu3GGhCfatsehaiybp5JcQ2u144Bmt6ATwZo2zvfj/FpVtgN7t4wEqQXhnoCSlekRB8eLg4HzrXYFViFfj+bkjEr7yXbZYmSgDbmCJLCWirKhMYiBz969PgtGT88mev0RYs0lKUf5dv76s98pynePywy9cHXiX4rUS2YRJ+LBafbKpJ4gsuqPRSKYR1hzWHQySrUlVnPfhrE0ug9CIX0SuoVC1ZdX8GcWu1D+M7202V8Sgr1SxgF9U9nSK1QWuXnqxpPLybK7kJ0PpdHLuCbC280ieNU3KlattJNbTrFuIjrqBH41+ENm5T7lJAAttUbk6O6XqdJ7ME9XNSN3HLvnl1UYesgy4x7pjSEXlAT/HXno7m88gT+Cukx6rBatGSbKFcs2SaubZm1Re8SjIo64Jss+ew8PKJmxLRTYhbWxirERsm0ReKG1ShH3ff39bjTGhXwbGloCqNaAKvvE/VTlG3+D9aZo=", "x-forefront-antispam-report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SI6PR06MB7631.apcprd06.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(18002099003)(56012099003)(38070700021);\n DIR:OUT; SFP:1102;", "x-ms-exchange-antispam-messagedata-chunkcount": "1", "x-ms-exchange-antispam-messagedata-0": "=?iso-8859-1?q?KGgke/tJsMdkC/3glT1QY/+?=\n\t=?iso-8859-1?q?TBeU5dXKWY1WM91CClSW5g0lSpYCGCk0HdOFOs0yX6STpVx2G/YDlqjS5pNJ?=\n\t=?iso-8859-1?q?SX30m0Dt/3lnxdd2Ivq42EShYG9fnV3B9OtpVgn3N0k1W5JmwrhBThBNIo9t?=\n\t=?iso-8859-1?q?msEVQNR1akzOzE4UWFcdJKhSg5yVjoDMs6ZJk8uzgEDfKzT9tSpCjsC1JQpn?=\n\t=?iso-8859-1?q?scIVdk8eFDa5FQQuDvWmIdh+QP5uFLrBMtyapaqYb/S92ERl+o/thpwm9hI7?=\n\t=?iso-8859-1?q?k2n0hSYtkLTynNAefz5e0hNd/W133eY6cjGxHNkWa4RLGjcUc2RNB0wLtDju?=\n\t=?iso-8859-1?q?OQbn6s9MAI2/2JaWTq0GgRlD/hp6FEt8p5xBc7PYIV/vvmrbE7lzwfb3vWJw?=\n\t=?iso-8859-1?q?9Y+00J6bjk/cppLBHG7ho5NI08lK0FESF+GqYnYZ4aJ2Caxg3Ditlpgie3pj?=\n\t=?iso-8859-1?q?A4fVnuna0AKE8DDw+jkUA0ynlkXW/YdSVnfn+0cuw4+uPPW8aYisC/J757KT?=\n\t=?iso-8859-1?q?bLaOEbJ+arwN6aMeeJ3NPcjb1+lF2WY7W0Ae+OUm61gaCE4o1eTcKEz6PBS1?=\n\t=?iso-8859-1?q?YMmHcjBX4MPxKPKvTMuZ6LUuKQFuQodadFJPi6UYlvWv3VFBO9+J4hh5GWOi?=\n\t=?iso-8859-1?q?8Dx4qhBrwU3ZvF1oDgt/xjeT7zXU2GEhPK3/9b7sX/1ycFhbyd6JwN+3RNDM?=\n\t=?iso-8859-1?q?Y1wuQZIMakeXxnZgS3AGSxVkYdcGEOQQmDGSlaEXIgYXPKd535VUfcdneVZu?=\n\t=?iso-8859-1?q?Dba3lLJW41RwPhobQG6AyOatFxHd/Xzgnd35yyZU6Fr37+W2fS+UOTI02x7i?=\n\t=?iso-8859-1?q?e8qVmOwuogoEEUttW4FglZbmB9pnZuvP0XqR4+Lni0NGY3QnVtH/fNWzOfeB?=\n\t=?iso-8859-1?q?6bfO+9ZfNNZylZDauX2RLQQlOW3e5cVjdk/gBdfaPNpZ2ne5PNGHcW7lwaaW?=\n\t=?iso-8859-1?q?0bD53qyRTViN3jMJXhL4bGC/ji0ol8NyJDmjysbwpWS+OhhiJuFnh9OuYLWx?=\n\t=?iso-8859-1?q?qVIl7PJZJct6Du1wDxfjTo1m8qagyGiKMq1/3VsQ//p9NjcB6SmoYMdu6Obp?=\n\t=?iso-8859-1?q?KhDK0UuD9wZKecoSiqOcG+aYpM/Iw13w7tD5tEqmLrQUHOxr5QzLTid6+G1b?=\n\t=?iso-8859-1?q?ZW8CBWqfARHVw/2xgSHUWWGyNbsxwZhDLqy5TNC/raJGYzEMBA/p7JCHzzhq?=\n\t=?iso-8859-1?q?i7bwTI9IopTD24VzTSYUO1Qc+U1DiR7BpAYq8sA+8yq9vBaNntAfB2JTHRsc?=\n\t=?iso-8859-1?q?RaDjmPNxlhSj/zEF6ZVWjVc3fVG+nZNQrPZVN5Q+pWGJJFqwxvtrwAjsc61S?=\n\t=?iso-8859-1?q?6t7HVtTqmUhmq+9/OqrqY+MOCRmw/cObxBvvx4sDCBdkWN7++jiwavRnUpae?=\n\t=?iso-8859-1?q?vuvfO8tIj0bFUukH0xLTVKyEgIIBj+q35NJ+t0pqvogqBALnvPMpEeh61PFg?=\n\t=?iso-8859-1?q?mvEpOGo8FcWKTG6iXovNZd1uWeUUd9ul0OUPjQu4PStz0eCoz5rfH2VO41eb?=\n\t=?iso-8859-1?q?NwQAr7qVNN8KOhr8QBm+YjNvQ7z56izta9VIqWIj7PnrTQJ8vaZxFL+HDarF?=\n\t=?iso-8859-1?q?tnoH/77cdBhVaSP3FoZtKX5ozq6Hl8Vv5K/cXG8aQ463bgzuFF63dDCJiZZK?=\n\t=?iso-8859-1?q?G8/W3sWR6YUv6h1Q+2EuqIwQtElyCTPVlph1AzkEFmuN79Z1xpB8B0liQU7s?=\n\t=?iso-8859-1?q?YXcsrPsHJLbbYsHb0mcxpiJVwdQm0+a4PG6Edv7hbpVaHRtiG0Vzaxk13mDI?=\n\t=?iso-8859-1?q?g0sezaBphexH5MkcNpjMMqNq1hySoYttbQP0Ih0oVM/bHcA=3D=3D?=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-Exchange-RoutingPolicyChecked": "\n UgmDgvGGQ69AJjEWFijBNH7gNwrmGYw3FU0va4FZZ5K/9Kh3jHjpe7UUtf7Quq4yate+zdFEkwgFVbLw4F/hClmwvqF+l/DM6el5i7WhOgedA/Ksj45ZD9fOJvEhg9KW9BRgPSw6NdWWf2MSB5rRJjhWO9FIF4xBVOJQmcVktDBgS77QULLS8w2Q/2ooH3RTNYEH5UT7HKGces+6kTT/4CWhJXyHFySMBhgDpsOCo5UuDj8XrK4Zd63Ig6uk+cAnJAg7PvX7Q6gSeW0FC8Ev3CbgP1QohwqP5pWZNN6RKQync4Uh6mVWmKWTk0hJwbwJKdQEQsZFUcEyGeoTf66yOg==", "X-OriginatorOrg": "aspeedtech.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-AuthSource": "SI6PR06MB7631.apcprd06.prod.outlook.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 67ee702a-eb21-47c8-b80c-08dea4ea658f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "28 Apr 2026 05:52:56.6367 (UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "43d4aa98-e35b-4575-8939-080e90d5a249", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-userprincipalname": "\n kch+5CpIF9NAPqTDxB54lWqyURlS8CqnKXT65aRWVIYtZHARDy0snWjLY/OVDs+0/KbwIXQFdUZo5UhFa3vY5iXLCfJzf2wRM40cXIdZRN0=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "TYZPR06MB6073", "Received-SPF": "pass client-ip=2a01:111:f403:c405::7;\n envelope-from=kane_chen@aspeedtech.com;\n helo=TYDPR03CU002.outbound.protection.outlook.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "There is a mismatch between the Aspeed OTP model and the Aspeed SBC\nmodel in how the guest-provided address is handled.\naspeed_sbc_otp_prog() passes a word-indexed address directly\nto address_space_write() without converting it to a byte offset,\nwhereas aspeed_otp_write() expects a byte offset and applies an\nadditional shift (otp_addr << 2). This double-shift confusion means\nthat an out-of-range word address can lead to a write beyond the\nallocated storage.\n\nFix this by adding bounds checking on the word offset before\nconverting to byte offset and passing to address_space_write().\nThis matches the existing bounds check in aspeed_sbc_otp_read().\n\nCc: Kane-Chen-AS <kane_chen@aspeedtech.com>\nCc: qemu-stable@nongnu.org\nFixes: 1a00754ccf15 (\"hw/misc: Add Aspeed Secure Boot Controller model\")\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3436\nReported-by: Peter Maydell <peter.maydell@linaro.org>\nSigned-off-by: Cédric Le Goater <clg@redhat.com>\nSigned-off-by: Kane-Chen-AS <kane_chen@aspeedtech.com>\n---\n hw/misc/aspeed_sbc.c | 14 +++++++++++---\n hw/nvram/aspeed_otp.c | 13 ++++++-------\n 2 files changed, 17 insertions(+), 10 deletions(-)", "diff": "diff --git a/hw/misc/aspeed_sbc.c b/hw/misc/aspeed_sbc.c\nindex 065e822e70..8b74dca13c 100644\n--- a/hw/misc/aspeed_sbc.c\n+++ b/hw/misc/aspeed_sbc.c\n@@ -159,13 +159,21 @@ static bool aspeed_sbc_otp_prog(AspeedSBCState *s,\n MemTxResult ret;\n AspeedOTPState *otp = &s->otp;\n uint32_t value = s->regs[R_CAMP1];\n+ uint32_t otp_offset = otp_addr << 2;\n \n- ret = address_space_write(&otp->as, otp_addr, MEMTXATTRS_UNSPECIFIED,\n- &value, sizeof(value));\n+ if (otp_addr >= OTP_TOTAL_DWORD_COUNT) {\n+ qemu_log_mask(LOG_GUEST_ERROR,\n+ \"Invalid OTP addr 0x%x\\n\",\n+ otp_addr);\n+ return false;\n+ }\n+\n+ ret = address_space_write(&otp->as, otp_offset, MEMTXATTRS_UNSPECIFIED,\n+ &value, sizeof(value));\n if (ret != MEMTX_OK) {\n qemu_log_mask(LOG_GUEST_ERROR,\n \"Failed to write OTP memory, addr = %x\\n\",\n- otp_addr);\n+ otp_offset);\n return false;\n }\n \ndiff --git a/hw/nvram/aspeed_otp.c b/hw/nvram/aspeed_otp.c\nindex a60289000c..1a9d3841b8 100644\n--- a/hw/nvram/aspeed_otp.c\n+++ b/hw/nvram/aspeed_otp.c\n@@ -57,12 +57,12 @@ static bool valid_program_data(uint32_t otp_addr,\n return has_programmable_bits != 0;\n }\n \n-static bool program_otpmem_data(void *opaque, uint32_t otp_addr,\n+static bool program_otpmem_data(void *opaque, hwaddr otp_offset,\n uint32_t prog_bit, uint32_t *value)\n {\n AspeedOTPState *s = opaque;\n+ uint32_t otp_addr = otp_offset >> 2;\n bool is_odd = otp_addr & 1;\n- uint32_t otp_offset = otp_addr << 2;\n \n memcpy(value, s->storage + otp_offset, sizeof(uint32_t));\n \n@@ -79,26 +79,25 @@ static bool program_otpmem_data(void *opaque, uint32_t otp_addr,\n return true;\n }\n \n-static void aspeed_otp_write(void *opaque, hwaddr otp_addr,\n+static void aspeed_otp_write(void *opaque, hwaddr otp_offset,\n uint64_t val, unsigned size)\n {\n AspeedOTPState *s = opaque;\n- uint32_t otp_offset, value;\n+ uint32_t value;\n \n- if (!program_otpmem_data(s, otp_addr, val, &value)) {\n+ if (!program_otpmem_data(s, otp_offset, val, &value)) {\n qemu_log_mask(LOG_GUEST_ERROR,\n \"%s: Failed to program data, value = %x, bit = %\"PRIx64\"\\n\",\n __func__, value, val);\n return;\n }\n \n- otp_offset = otp_addr << 2;\n memcpy(s->storage + otp_offset, &value, size);\n \n if (s->blk) {\n if (blk_pwrite(s->blk, otp_offset, size, &value, 0) < 0) {\n qemu_log_mask(LOG_GUEST_ERROR,\n- \"%s: Failed to write %x to %x\\n\",\n+ \"%s: Failed to write %x to %\"HWADDR_PRIx\"\\n\",\n __func__, value, otp_offset);\n \n return;\n", "prefixes": [ "v1", "1/1" ] }