Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229306/?format=api
{ "id": 2229306, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229306/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260428043035.1540264-1-jason@redhat.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260428043035.1540264-1-jason@redhat.com>", "date": "2026-04-28T04:30:29", "name": "[pushed] c++: ICE with [[trivial_abi]] [PR125022]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "d48085158cbd380dbf8b0dfd102f42aee242bec4", "submitter": { "id": 4337, "url": "http://patchwork.ozlabs.org/api/1.1/people/4337/?format=api", "name": "Jason Merrill", "email": "jason@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260428043035.1540264-1-jason@redhat.com/mbox/", "series": [ { "id": 501761, "url": "http://patchwork.ozlabs.org/api/1.1/series/501761/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501761", "date": "2026-04-28T04:30:29", "name": "[pushed] c++: ICE with [[trivial_abi]] [PR125022]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501761/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229306/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229306/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=a8zFuHh3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=a8zFuHh3", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4SDc5BN1z1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 14:31:10 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id AE7854BABF26\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 04:31:07 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id AEFF24B9DB64\n for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2026 04:30:40 +0000 (GMT)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-4WvRTckuN-eA4YIjdUUwkw-1; Tue,\n 28 Apr 2026 00:30:38 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2A9A1195608E\n for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2026 04:30:37 +0000 (UTC)", "from jason-thinkpadp1gen4i.rmtusma.csb (unknown [10.22.65.150])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C1E69180047F\n for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2026 04:30:36 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org AE7854BABF26", "OpenDKIM Filter v2.11.0 sourceware.org AEFF24B9DB64" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org AEFF24B9DB64", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org AEFF24B9DB64", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777350640; cv=none;\n b=Ph0eAQzwCBWe93QKr6F+aafYAM2Ex58emt+ceN5UZGMSlMSWu505IylnDN0nzDM2srI4VN6lkeAUkSbCUDFxSGQB5+JjvAtSN/3FN/pxTZjF9KIhcE5NvexFY6ahyOd7C20/QAslJNUCYfvG4hWQe25RhNQiOA6KrtsWrnXvl2w=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777350640; c=relaxed/simple;\n bh=c7nL2vE7iRcwq48kIuTRC6FfJpEvhsxx9SbwaojBd4U=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=QZUN/favITh+UbUFuJA/Jv5jLgxu+At/Dak8CVKj7Ky4MG8ZJBnS6QErXCxCVpEForxilmyHD/01h6TyibcSgtY6Z/gROAQCLK1nW8kPDcL1niaHgp7iRZ4UBYKAu5smIovTut8eDe0Aa9tPtcXzK0ScIKQB2U6thQO04tagBM0=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777350640;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=kdL6cVik/bN/QWFUVwxMf9vmMyZIJl7QP5QfUzpCj30=;\n b=a8zFuHh3MCBUZMiR4twX1Aw2HZ7j1LyE7Fp0ueVhCgWvXCP4fFPLmVUwdIn356+I+oP/I4\n 43oMVBmXDWcdk9U8/U2aQm01Uc3Mg1j1fH+CXqfE8ERX4lxWdRucVEVAro3H/Wd+U7GOXk\n uAfTEeBvlC8HNmw/wK5656ybDVlAag0=", "X-MC-Unique": "4WvRTckuN-eA4YIjdUUwkw-1", "X-Mimecast-MFC-AGG-ID": "4WvRTckuN-eA4YIjdUUwkw_1777350637", "From": "Jason Merrill <jason@redhat.com>", "To": "gcc-patches@gcc.gnu.org", "Subject": "[pushed] c++: ICE with [[trivial_abi]] [PR125022]", "Date": "Tue, 28 Apr 2026 00:30:29 -0400", "Message-ID": "<20260428043035.1540264-1-jason@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "0kpeH2wZY058A0NvpGy5wKxwBN7hmZ1vTOKUWo2KYY0_1777350637", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Tested x86_64-pc-linux-gnu, applying to trunk.\n\n-- 8< --\n\nWe don't mess with cleanups at template parsing time.\n\n\tPR c++/125022\n\ngcc/cp/ChangeLog:\n\n\t* decl.cc (store_parm_decls): Only do trivial_abi stuff when\n\t!processing_template_decl.\n\ngcc/testsuite/ChangeLog:\n\n\t* g++.dg/cpp0x/attr-trivial_abi7.C: New test.\n---\n gcc/cp/decl.cc | 29 ++++++++++---------\n .../g++.dg/cpp0x/attr-trivial_abi7.C | 19 ++++++++++++\n 2 files changed, 34 insertions(+), 14 deletions(-)\n create mode 100644 gcc/testsuite/g++.dg/cpp0x/attr-trivial_abi7.C\n\n\nbase-commit: e487b4ae3013b93d01406aaa6fbf9287bd704c3c", "diff": "diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc\nindex 6415f0b4bc2..f0f37560dec 100644\n--- a/gcc/cp/decl.cc\n+++ b/gcc/cp/decl.cc\n@@ -20271,20 +20271,21 @@ store_parm_decls (tree current_function_parms)\n \n /* Register cleanups for parameters with trivial_abi attribute, the cleanup\n of which is the callee's responsibility. */\n- for (tree parm = DECL_ARGUMENTS (fndecl); parm; parm = DECL_CHAIN (parm))\n- {\n- if (TREE_CODE (parm) == PARM_DECL)\n-\t{\n-\t tree parm_type = TREE_TYPE (parm);\n-\t if (has_trivial_abi_attribute (parm_type))\n-\t {\n-\t tree cleanup\n-\t\t= cxx_maybe_build_cleanup (parm, tf_warning_or_error);\n-\t if (cleanup && cleanup != error_mark_node)\n-\t\tfinish_decl_cleanup (parm, cleanup);\n-\t }\n-\t}\n- }\n+ if (!processing_template_decl)\n+ for (tree parm = DECL_ARGUMENTS (fndecl); parm; parm = DECL_CHAIN (parm))\n+ {\n+\tif (TREE_CODE (parm) == PARM_DECL)\n+\t {\n+\t tree parm_type = TREE_TYPE (parm);\n+\t if (has_trivial_abi_attribute (parm_type))\n+\t {\n+\t\ttree cleanup\n+\t\t = cxx_maybe_build_cleanup (parm, tf_warning_or_error);\n+\t\tif (cleanup && cleanup != error_mark_node)\n+\t\t finish_decl_cleanup (parm, cleanup);\n+\t }\n+\t }\n+ }\n \n if (use_eh_spec_block (current_function_decl))\n current_eh_spec_block = begin_eh_spec_block ();\ndiff --git a/gcc/testsuite/g++.dg/cpp0x/attr-trivial_abi7.C b/gcc/testsuite/g++.dg/cpp0x/attr-trivial_abi7.C\nnew file mode 100644\nindex 00000000000..4c76e5e9df3\n--- /dev/null\n+++ b/gcc/testsuite/g++.dg/cpp0x/attr-trivial_abi7.C\n@@ -0,0 +1,19 @@\n+// PR c++/125022\n+// { dg-do compile { target c++11 } }\n+\n+struct raw_ptr {\n+ raw_ptr(int *);\n+};\n+struct [[clang::trivial_abi]] scoped_refptr {\n+ ~scoped_refptr();\n+ template <typename...> void emplace(scoped_refptr) {}\n+} main_thread_, AsyncMemoryConsumerRegistration_main_task_runner;\n+struct AsyncMemoryConsumerRegistration {\n+ AsyncMemoryConsumerRegistration();\n+ raw_ptr consumer_;\n+};\n+int AsyncMemoryConsumerRegistration_consumer;\n+AsyncMemoryConsumerRegistration::AsyncMemoryConsumerRegistration()\n+ : consumer_(&AsyncMemoryConsumerRegistration_consumer) {\n+ main_thread_.emplace(AsyncMemoryConsumerRegistration_main_task_runner);\n+}\n", "prefixes": [ "pushed" ] }