Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229266/?format=api
{ "id": 2229266, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229266/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260427031158.2665916-1-vincent.chen@sifive.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427031158.2665916-1-vincent.chen@sifive.com>", "date": "2026-04-27T03:11:58", "name": "[RFC] ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f09f0c8c0d7087ea1ba70febf357eb542b712b46", "submitter": { "id": 79516, "url": "http://patchwork.ozlabs.org/api/1.1/people/79516/?format=api", "name": "Vincent Chen", "email": "vincent.chen@sifive.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260427031158.2665916-1-vincent.chen@sifive.com/mbox/", "series": [ { "id": 501743, "url": "http://patchwork.ozlabs.org/api/1.1/series/501743/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501743", "date": "2026-04-27T03:11:58", "name": "[RFC] ice: allow creating VFs when !CONFIG_ICE_SWITCHDEV", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501743/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229266/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229266/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gHmIAHU4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Kg40DZYz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 09:35:11 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B33C780F73;\n\tMon, 27 Apr 2026 23:35:09 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NpycVxVtc-vt; Mon, 27 Apr 2026 23:35:09 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 214B980F75;\n\tMon, 27 Apr 2026 23:35:09 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 222CE231\n for <intel-wired-lan@lists.osuosl.org>; Mon, 27 Apr 2026 03:12:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 080C285250\n for <intel-wired-lan@lists.osuosl.org>; Mon, 27 Apr 2026 03:12:15 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id F_g6dmKk3oUB for <intel-wired-lan@lists.osuosl.org>;\n Mon, 27 Apr 2026 03:12:14 +0000 (UTC)", "from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com\n [IPv6:2607:f8b0:4864:20::52e])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 5D8C58524F\n for <intel-wired-lan@lists.osuosl.org>; Mon, 27 Apr 2026 03:12:14 +0000 (UTC)", "by mail-pg1-x52e.google.com with SMTP id\n 41be03b00d2f7-c736261ee8dso3489092a12.1\n for <intel-wired-lan@lists.osuosl.org>; Sun, 26 Apr 2026 20:12:14 -0700 (PDT)", "from Vincent-X1Extreme-TW.internal.sifive.com ([210.176.154.33])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c797702fbfcsm23211560a12.22.2026.04.26.20.12.10\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 20:12:13 -0700 (PDT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 214B980F75", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5D8C58524F" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777332909;\n\tbh=gp1K2EXsXJjLmVYIVoTLMJ2MCl9E+BqqW584mODwD4o=;\n\th=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=gHmIAHU4Xe4xZcR8NLbRF3Gwg0f3Iw5rcRy9d78IcHzKFH4xNswbDjEWL70OY7SaX\n\t +AI+3H5KAl9ObKHQlm6lSZq3vrDE+HB7BFAGfm2OXVDvsWHI1xmBup8KnLOKLPqWHv\n\t fgyipHPusld/C7ZQntvWdGvIlWwJOlVn+T/jTUvPUCjjPahaGmYb+Zqd5fqK6UsgAU\n\t jXooradBf8rk2GNzfkARtlin8pF6syFIeMNwxCFQFiUqAhVgTgmhjvE0U+UvDbllCv\n\t +yX4I+BPtqzDZ8BhPlXFLpzLoOgCY0xcRPb6v65ijBl6GPSWDLumIqqZm4bAI6ZHHy\n\t x/IfTHzDFoy6w==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::52e; helo=mail-pg1-x52e.google.com;\n envelope-from=vincent.chen@sifive.com; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 5D8C58524F", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777259533; x=1777864333;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=gp1K2EXsXJjLmVYIVoTLMJ2MCl9E+BqqW584mODwD4o=;\n b=JFXSx4vWN1OhtcGpVU+DtNktsh5ZwZRaJbTJZMoe71/eAy+jrXnlyUw+XaLBxGigCB\n pIsMH3bU6eeFXjF5e/Vudx05KoSWAPI6ZeltOdpTXM9UMHeBVRbSIzgwlaxloFJve4Gn\n /PXKdEW/CZac/MNRKurgWSZlLMQf/QQBTMFrD1wKSisXijOwEoY0PeNpnv3Qjadsy/+X\n lFHpbo5/cgzptLLWqFojFu7TZztWwVYaoMx3EREfUCQZg9kiofUbtWSsLsODWwhOssy9\n uJZLpTYP5/cTsfxyvdAU1UdOKnm1Rte89bGzHN1gmkgIfLoZiV6KsfT5v9BjgszFHZd1\n iMZA==", "X-Gm-Message-State": "AOJu0Yz2z0H1JrUgpGevaMjxXu6YHoK52F4yk5PoXzr+89FgtibG1WeR\n N0RcK8eRvpO4ZVKoyHt0HvjHV3OhtyQSY4GDf/+/LLEu9O3G2VuTr4dqkM4EFewSMjY=", "X-Gm-Gg": "AeBDietY+uIRG81dWr6lI7oMTKet/nJwEzgFIzcqk2QR0WADNakll1TpAA25TzvsGjN\n sNFycm5VdvLMzDXwZW75fPuZEbu5wsiI3UGuhvjdavw9VfZ5IbUMRCC9bdeLq9SMCqFbjKodNlC\n EAhVIg+tunDd6nBEt0eyUJnBBCReQZyrYx9mHNkYamqOl7upJhXA/507TNcKgZ+0VcRy415ypg3\n UYVsM5UmjCXZ5wkTywWgHtXKDoTo/9tPnxlWzuI5e9V3ORvXgJhwCSg96sWON0cHNqE6T4i0gU9\n nl7/Qo0jUIWOeKl75kgwtAEAtQgMV2htpyN8DOhBlkzKbUhrCmQvmvbcWfazvauSora8NwyNuxH\n 6P9YqXo4Ms8MOdjTLj4KZAfdAF74K4CuDHzRSdqV2YKMijiTC2ciUQBfZG0vsmXmfM1C4zNGuph\n QeiKMXzpEUIs9kkGWB2W/SaAYeapXpgclJRwCMPDaPcfJY6YSUywmyBopzmVQCdO52181jYCUJW\n 4/A", "X-Received": "by 2002:a05:6a20:2590:b0:3a2:e8f1:b873 with SMTP id\n adf61e73a8af0-3a2e8f1c216mr27643860637.36.1777259533362;\n Sun, 26 Apr 2026 20:12:13 -0700 (PDT)", "To": "anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com", "Cc": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n vincent.chen@sifive.com", "Date": "Mon, 27 Apr 2026 11:11:58 +0800", "Message-Id": "<20260427031158.2665916-1-vincent.chen@sifive.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 27 Apr 2026 23:35:08 +0000", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=sifive.com; s=google; t=1777259533; x=1777864333; darn=lists.osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=gp1K2EXsXJjLmVYIVoTLMJ2MCl9E+BqqW584mODwD4o=;\n b=Sth4fhXDXhcrh9HNBeEkvkq+sjzdc8Smta3+PeCqDP2rqhNicBmXsaklLvQA7baaUO\n aF4uB2af1kZVCMOOHmqG9XJaQ9iaTOo6cprCMaf9iAfCqJRtKhPgD8Czhv0PgZnZSHoc\n r4RQvSAsFUkIipEivimD+vVu6EQXefpBrfv7oLCUpfO+6S9IosgcPqwcBrkphCJc5E2M\n 1RvF8btKrd/QqaXvcWGhAv337osGai4W2TjuGx93p6bhQRw/N0JRQuRq0orsWPCjQO2v\n DIJfdtr8EJsr/E4KIeCZfewwu9QpcgmnV1Ni85wFTWvB9PdFLifhemOutrr5Nc3KB+tE\n kwJw==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=sifive.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256\n header.s=google header.b=Sth4fhXD" ], "Subject": "[Intel-wired-lan] [RFC PATCH] ice: allow creating VFs when\n !CONFIG_ICE_SWITCHDEV", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "From": "Vincent Chen via Intel-wired-lan <intel-wired-lan@osuosl.org>", "Reply-To": "Vincent Chen <vincent.chen@sifive.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Currently ice_eswitch_attach_vf() is called unconditionally in\nice_start_vfs() and ice_reset_all_vfs(), which causes VF creation\nto fail when CONFIG_ICE_SWITCHDEV is not defined or switchdev mode\nis not enabled at runtime.\nFix this by adding switchdev mode checks at the call sites before\ncalling ice_eswitch_attach_vf(), consistent with how\nice_eswitch_attach_sf() is already handled in ice_devlink_port_new().\nAlso remove the redundant check inside ice_eswitch_attach_vf() itself.\nThis is similar to commit aacca7a83b97 (\"ice: allow creating VFs for\n!CONFIG_NET_SWITCHDEV\") which fixed the same issue for the previous\nice_eswitch_configure() API.\n\nSigned-off-by: Vincent Chen <vincent.chen@sifive.com>\n---\n drivers/net/ethernet/intel/ice/ice_eswitch.c | 3 ---\n drivers/net/ethernet/intel/ice/ice_sriov.c | 14 ++++++++------\n drivers/net/ethernet/intel/ice/ice_vf_lib.c | 3 ++-\n 3 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_eswitch.c b/drivers/net/ethernet/intel/ice/ice_eswitch.c\nindex 2e4f0969035f..c709decb26d5 100644\n--- a/drivers/net/ethernet/intel/ice/ice_eswitch.c\n+++ b/drivers/net/ethernet/intel/ice/ice_eswitch.c\n@@ -512,9 +512,6 @@ int ice_eswitch_attach_vf(struct ice_pf *pf, struct ice_vf *vf)\n \tstruct ice_repr *repr;\n \tint err;\n \n-\tif (!ice_is_eswitch_mode_switchdev(pf))\n-\t\treturn 0;\n-\n \trepr = ice_repr_create_vf(vf);\n \tif (IS_ERR(repr))\n \t\treturn PTR_ERR(repr);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_sriov.c b/drivers/net/ethernet/intel/ice/ice_sriov.c\nindex 843e82fd3bf9..6a0b724e46f9 100644\n--- a/drivers/net/ethernet/intel/ice/ice_sriov.c\n+++ b/drivers/net/ethernet/intel/ice/ice_sriov.c\n@@ -484,12 +484,14 @@ static int ice_start_vfs(struct ice_pf *pf)\n \t\t\tgoto teardown;\n \t\t}\n \n-\t\tretval = ice_eswitch_attach_vf(pf, vf);\n-\t\tif (retval) {\n-\t\t\tdev_err(ice_pf_to_dev(pf), \"Failed to attach VF %d to eswitch, error %d\",\n-\t\t\t\tvf->vf_id, retval);\n-\t\t\tice_vf_vsi_release(vf);\n-\t\t\tgoto teardown;\n+\t\tif (ice_is_eswitch_mode_switchdev(pf)) {\n+\t\t\tretval = ice_eswitch_attach_vf(pf, vf);\n+\t\t\tif (retval) {\n+\t\t\t\tdev_err(ice_pf_to_dev(pf), \"Failed to attach VF %d to eswitch, error %d\",\n+\t\t\t\t\tvf->vf_id, retval);\n+\t\t\t\tice_vf_vsi_release(vf);\n+\t\t\t\tgoto teardown;\n+\t\t\t}\n \t\t}\n \n \t\tset_bit(ICE_VF_STATE_INIT, vf->vf_states);\ndiff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\nindex de9e81ccee66..71595410174c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c\n@@ -807,7 +807,8 @@ void ice_reset_all_vfs(struct ice_pf *pf)\n \t\tice_vf_rebuild_vsi(vf);\n \t\tice_vf_post_vsi_rebuild(vf);\n \n-\t\tice_eswitch_attach_vf(pf, vf);\n+\t\tif (ice_is_eswitch_mode_switchdev(pf))\n+\t\t\tice_eswitch_attach_vf(pf, vf);\n \n \t\tmutex_unlock(&vf->cfg_lock);\n \t}\n", "prefixes": [ "RFC" ] }