Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229190/?format=api
{ "id": 2229190, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229190/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260427214126.17818-1-m32285159@gmail.com/", "project": { "id": 42, "url": "http://patchwork.ozlabs.org/api/1.1/projects/42/?format=api", "name": "Linux GPIO development", "link_name": "linux-gpio", "list_id": "linux-gpio.vger.kernel.org", "list_email": "linux-gpio@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427214126.17818-1-m32285159@gmail.com>", "date": "2026-04-27T21:41:26", "name": "[v2] gpio: sim: Replace sprintf() with sysfs_emit()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3e97694f2e15642e64b7294360887a1fc231725a", "submitter": { "id": 93193, "url": "http://patchwork.ozlabs.org/api/1.1/people/93193/?format=api", "name": "Maxwell Doose", "email": "m32285159@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-gpio/patch/20260427214126.17818-1-m32285159@gmail.com/mbox/", "series": [ { "id": 501728, "url": "http://patchwork.ozlabs.org/api/1.1/series/501728/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-gpio/list/?series=501728", "date": "2026-04-27T21:41:26", "name": "[v2] gpio: sim: Replace sprintf() with sysfs_emit()", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/501728/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229190/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229190/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-gpio+bounces-35631-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-gpio@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Ci+ImqOB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35631-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"Ci+ImqOB\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.160.52", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4H8g35qyz1xrS\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 07:42:11 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 7F4BA305E99D\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 21:41:32 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 00B6437C939;\n\tMon, 27 Apr 2026 21:41:31 +0000 (UTC)", "from mail-oa1-f52.google.com (mail-oa1-f52.google.com\n [209.85.160.52])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CDCD242D6A\n\tfor <linux-gpio@vger.kernel.org>; Mon, 27 Apr 2026 21:41:29 +0000 (UTC)", "by mail-oa1-f52.google.com with SMTP id\n 586e51a60fabf-4094b31a037so6197075fac.1\n for <linux-gpio@vger.kernel.org>;\n Mon, 27 Apr 2026 14:41:29 -0700 (PDT)", "from linuxescape.lan (23-88-128-2.fttp.usinternet.com.\n [23.88.128.2])\n by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-6965ba3686bsm348322eaf.9.2026.04.27.14.41.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 14:41:27 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777326090; cv=none;\n b=EYfj1tkEqWT0eAICchMr0U7EAA5NrvBwckBHxX2+4n5GsKgVSFA5yhRb3diGDP5tJmMRTfcGgzm1PsWLf6A1RxP4BgxHjBcQPNRRYDzkCh5Ets1NMgTePEWmJ+CKy46+wNUVLH9lYxyS6rfWb0z/XoJpgsSw7vmg/WGm5G6PPW8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777326090; c=relaxed/simple;\n\tbh=eZX3CDov/wKXGxHlMANg1Y9JRIPqVl+INQsMru3R7jw=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=EYK91sGVw8Yjqm6upVYoZEosy4pXAhsCgqxvBxw/DVRv9vyf3HP1Ot0avuVdJFUVoAtmH/wjL5orXEUpShLo1kaqrYHLA4CjfOU6t/G6Pj5y0VUgSxC3jsoNSmbvzbd+x9I/qiUGcAa89QPyvSE3zFIoUKe0kmnqRgab2pWcKzU=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=Ci+ImqOB; arc=none smtp.client-ip=209.85.160.52", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1777326088; x=1777930888;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=XccsB8eYNsZqIBiFPfFrnn/DwDUI5DYyitE3KWf801U=;\n b=Ci+ImqOBhp/t+JVUKiQwYz7KgpcsAAuL4Q4WHtr/qhuzOwDErg9k93jmt781xwLLgz\n pJtjg+6UW8xIMsxbiQVxFhatvigiJuY7tpjQ4t4nTKkQqZ5JsYDfgxJTYOl9qUDAvw8b\n qtD9ge6atiF0SvrjhS/Y/XikiUkqp5uN1ZHyhdudsrDerZx5GdIaUQpG+0jkLwAuAy5z\n N/zxPGeZvFxj9UTWGWGW54YzxUaKaDnZZN3MMbASTDlT2gI+HygFl/jbrdXcKo9N0pVM\n 11NT005yQvaJrkYQkw8xNn2xLm3DXvtxAZJ7ydaUEqaqM4Rq3iFVdmogV7TGr5Uz3fMR\n DRpQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777326088; x=1777930888;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=XccsB8eYNsZqIBiFPfFrnn/DwDUI5DYyitE3KWf801U=;\n b=fqqGxxKSpVjEwP7rpjCluBXInrix27f32D6bhScTmVPzOwcGxR4ZulAm7kS94eqyJm\n wy2pghbv1WQE2su1wZgvzFKlN47pYOViEWHPxk86fP+lLg5IIueRUZ7aaxcICSosLrTj\n TngyS+ohappP/3ZZJK6iYnrp3dTV78Y/BOKNhFUuXFcMdPpti38gzjBq6usTHpqLLIgB\n 8bTngbBGVZqLkSFP/XxflUySzb1yEwu419GKuY3sYtBD2yoYdrsCgWkZXSdLUb6Emkkw\n v5ps5ytqzZYh78edGZysSboIYivY1HFr/RqHSMum4CrnDody+crGBC2UB1ohgmB8RWz1\n g90A==", "X-Gm-Message-State": "AOJu0Yw1AIr/FzG30uXEi6KBMDQDJp9zRBaxkPhKR+5QPg5mPVjHQIy3\n\tLND0wdyaxsUBnYLfUt3a4JuphJlJHVgOw4AQ5jk1gjZK0ETXgZ2+vlFrKTBD2Q==", "X-Gm-Gg": "AeBDieueT14N7DvkKCpWO2TovPP2cadHCCkp3yWst9d44cM45Wo0Ci7uD6FbgytXeRZ\n\tRZvrj3Z458LMbebETbAKCDKb5hKTPCbB+OqA7RndjNY+jLTID/wsIVh/oSVutH5Co2nxaCSUZBy\n\twrm9k3Mww/oBPId2Bh2GGpFg6axAHOrwPjQS90kjik2RQdCzrARA6pFI3tb7+AZlEmR2MMFqprl\n\tcMLdLO/2XSLHN2aJSQU+28bD1q9d0ma5HQDc5YPEcdF+Rtj+FY6RiYycLDBb4odgAr2mo5L4iQq\n\tb2zrWszx+wC8BKX7Kzlnty5UpeJ/3f6cVwsQ4SN7B/G5x3goFW1esWi6jW/C6Us8MP/JAcFNL9O\n\tM6+Yg3STcnq9HTOvDqMt575XFcjVkMYHIYNzELqHyBLFdPzuZIDUuGEMULo+9O9CbHC8OMuvgIL\n\tTNDEEMgGLhIugw8muAbS2Hw1WHkNlJlDRgq8rWec9o9axD5T36S8cYtC530jXvRqky8Iyv", "X-Received": "by 2002:a05:6820:2005:b0:696:23ca:a8 with SMTP id\n 006d021491bc7-6965cbafc8emr180949eaf.54.1777326088256;\n Mon, 27 Apr 2026 14:41:28 -0700 (PDT)", "From": "Maxwell Doose <m32285159@gmail.com>", "To": "linusw@kernel.org,\n\tbrgl@kernel.org", "Cc": "linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH v2] gpio: sim: Replace sprintf() with sysfs_emit()", "Date": "Mon, 27 Apr 2026 16:41:26 -0500", "Message-ID": "<20260427214126.17818-1-m32285159@gmail.com>", "X-Mailer": "git-send-email 2.53.0", "Precedence": "bulk", "X-Mailing-List": "linux-gpio@vger.kernel.org", "List-Id": "<linux-gpio.vger.kernel.org>", "List-Subscribe": "<mailto:linux-gpio+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-gpio+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "Replace sprintf() function calls with sysfs_emit() in the configfs show\ncallbacks. This will help harden the driver and will bring the driver\nup-to-date with more modern functions.\n\nSuggested-by: Bartosz Golaszewski <brgl@kernel.org>\nSigned-off-by: Maxwell Doose <m32285159@gmail.com>\n---\n v2:\n - Rebase commit onto tag 7.1-rc1.\n - No functional changes from v1.\n\n drivers/gpio/gpio-sim.c | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\n\nbase-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731", "diff": "diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c\nindex e19701c2ed67..d1e5f0ad56ad 100644\n--- a/drivers/gpio/gpio-sim.c\n+++ b/drivers/gpio/gpio-sim.c\n@@ -695,9 +695,9 @@ static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,\n \n \tpdev = dev->pdev;\n \tif (pdev)\n-\t\treturn sprintf(page, \"%s\\n\", dev_name(&pdev->dev));\n+\t\treturn sysfs_emit(page, \"%s\\n\", dev_name(&pdev->dev));\n \n-\treturn sprintf(page, \"gpio-sim.%d\\n\", dev->id);\n+\treturn sysfs_emit(page, \"gpio-sim.%d\\n\", dev->id);\n }\n \n CONFIGFS_ATTR_RO(gpio_sim_device_config_, dev_name);\n@@ -711,7 +711,7 @@ gpio_sim_device_config_live_show(struct config_item *item, char *page)\n \tscoped_guard(mutex, &dev->lock)\n \t\tlive = gpio_sim_device_is_live(dev);\n \n-\treturn sprintf(page, \"%c\\n\", live ? '1' : '0');\n+\treturn sysfs_emit(page, \"%c\\n\", live ? '1' : '0');\n }\n \n static unsigned int gpio_sim_get_line_names_size(struct gpio_sim_bank *bank)\n@@ -1056,7 +1056,7 @@ static int gpio_sim_emit_chip_name(struct device *dev, void *data)\n \t\treturn 0;\n \n \tif (device_match_fwnode(dev, ctx->swnode))\n-\t\treturn sprintf(ctx->page, \"%s\\n\", dev_name(dev));\n+\t\treturn sysfs_emit(ctx->page, \"%s\\n\", dev_name(dev));\n \n \treturn 0;\n }\n@@ -1074,7 +1074,7 @@ static ssize_t gpio_sim_bank_config_chip_name_show(struct config_item *item,\n \t\treturn device_for_each_child(&dev->pdev->dev, &ctx,\n \t\t\t\t\t gpio_sim_emit_chip_name);\n \n-\treturn sprintf(page, \"none\\n\");\n+\treturn sysfs_emit(page, \"none\\n\");\n }\n \n CONFIGFS_ATTR_RO(gpio_sim_bank_config_, chip_name);\n@@ -1087,7 +1087,7 @@ gpio_sim_bank_config_label_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%s\\n\", bank->label ?: \"\");\n+\treturn sysfs_emit(page, \"%s\\n\", bank->label ?: \"\");\n }\n \n static ssize_t gpio_sim_bank_config_label_store(struct config_item *item,\n@@ -1122,7 +1122,7 @@ gpio_sim_bank_config_num_lines_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%u\\n\", bank->num_lines);\n+\treturn sysfs_emit(page, \"%u\\n\", bank->num_lines);\n }\n \n static ssize_t\n@@ -1168,7 +1168,7 @@ gpio_sim_line_config_name_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%s\\n\", line->name ?: \"\");\n+\treturn sysfs_emit(page, \"%s\\n\", line->name ?: \"\");\n }\n \n static ssize_t gpio_sim_line_config_name_store(struct config_item *item,\n@@ -1203,7 +1203,7 @@ gpio_sim_line_config_valid_show(struct config_item *item, char *page)\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%c\\n\", line->valid ? '1' : '0');\n+\treturn sysfs_emit(page, \"%c\\n\", line->valid ? '1' : '0');\n }\n \n static ssize_t gpio_sim_line_config_valid_store(struct config_item *item,\n@@ -1241,7 +1241,7 @@ static ssize_t gpio_sim_hog_config_name_show(struct config_item *item,\n \n \tguard(mutex)(&dev->lock);\n \n-\treturn sprintf(page, \"%s\\n\", hog->name ?: \"\");\n+\treturn sysfs_emit(page, \"%s\\n\", hog->name ?: \"\");\n }\n \n static ssize_t gpio_sim_hog_config_name_store(struct config_item *item,\n@@ -1295,7 +1295,7 @@ static ssize_t gpio_sim_hog_config_direction_show(struct config_item *item,\n \t\treturn -EINVAL;\n \t}\n \n-\treturn sprintf(page, \"%s\\n\", repr);\n+\treturn sysfs_emit(page, \"%s\\n\", repr);\n }\n \n static ssize_t\n", "prefixes": [ "v2" ] }