Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229183/?format=api
{ "id": 2229183, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229183/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427210133.6016-4-deller@kernel.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427210133.6016-4-deller@kernel.org>", "date": "2026-04-27T21:01:21", "name": "[PULL,v2,03/15] linux-user: fix off-by-one in host_to_target_for_each_rtattr()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70072080fdd4c7e4d4957443f33b232572602c24", "submitter": { "id": 87076, "url": "http://patchwork.ozlabs.org/api/1.1/people/87076/?format=api", "name": "Helge Deller", "email": "deller@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427210133.6016-4-deller@kernel.org/mbox/", "series": [ { "id": 501726, "url": "http://patchwork.ozlabs.org/api/1.1/series/501726/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501726", "date": "2026-04-27T21:01:22", "name": "[PULL,v2,01/15] MAINTAINERS: Add myself as maintainer for linux-user", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/501726/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229183/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229183/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=dolpgwhF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4GJm6T5Hz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 07:04:08 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHT5a-0000PG-50; Mon, 27 Apr 2026 17:01:58 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <deller@kernel.org>) id 1wHT5R-0000CV-7c\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 17:01:50 -0400", "from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <deller@kernel.org>) id 1wHT5L-0003Tn-UR\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 17:01:45 -0400", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id A997360138;\n Mon, 27 Apr 2026 21:01:42 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id EE350C19425;\n Mon, 27 Apr 2026 21:01:40 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1777323702;\n bh=qF/E4NTHGEzqRslmvhkeGAs4imRoAsHDEXNz7p4ViJw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=dolpgwhFKQTL1J8SAS2gLOQ+ffjAi00MC5jjjJsUSgIdbJtS3upO1e7Nz1THbqmTu\n fEAsM8D3PyNRWCzXJoWlJtOfUJgoTfu5r6D+WFYTf05YpC8jc/ObdAb4Dkg7PJ4lH0\n 4hV4w3RiTKmEOfr/Ybw8Q2/+wx0OBlXqpcDd4NxkE3my8GxHMj2+bESMhGn0lQ+tOD\n oKJPCSj6J95ZBFIDWo3WRn8bCm1PyFtoUnFizvoI3NBrNVvwMmY8Ke9JwVyUmiGNVc\n lJpS+WM1ikcXqUtxVdU54Q7/bFflFveQUmMZU2WMRd9TCaCY6hXjDfw1nRmGGSZaFt\n c77TzS2rVMhkg==", "From": "Helge Deller <deller@kernel.org>", "To": "qemu-devel@nongnu.org", "Cc": "Laurent Vivier <laurent@vivier.eu>, =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= <philmd@linaro.org>, Helge Deller <deller@gmx.de>,\n Jiaxun Yang <jiaxun.yang@flygoat.com>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PULL v2 03/15] linux-user: fix off-by-one in\n host_to_target_for_each_rtattr()", "Date": "Mon, 27 Apr 2026 23:01:21 +0200", "Message-ID": "<20260427210133.6016-4-deller@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260427210133.6016-1-deller@kernel.org>", "References": "<20260427210133.6016-1-deller@kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2600:3c04:e001:324:0:1991:8:25;\n envelope-from=deller@kernel.org; helo=tor.source.kernel.org", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Yixin Wei <easonwei1998@gmail.com>\n\nhost_to_target_for_each_rtattr() uses \"len > sizeof(struct rtattr)\"\nas its loop condition. When the last rtattr in a netlink message has\nexactly sizeof(struct rtattr) (4) bytes remaining, the loop exits\nwithout byte-swapping its rta_len and rta_type. A big-endian guest\nthen reads rta_len in the wrong byte order and fails validation.\n\nThe companion function target_to_host_for_each_rtattr() correctly\nuses \">=\" (added in commit fa2229dbf8). The kernel's RTA_OK macro\nalso uses \">=\". Fix the host_to_target direction to match.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/2485\nSigned-off-by: Yixin Wei <yixinwei@meta.com>\nFixes: 6c5b5645ae0 (\"linux-user: add rtnetlink(7) support\")\nReviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nSigned-off-by: Helge Deller <deller@gmx.de>\nCc: qemu-stable@nongnu.org\n---\n linux-user/fd-trans.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/linux-user/fd-trans.c b/linux-user/fd-trans.c\nindex 64dd0745d2..7f55a0690b 100644\n--- a/linux-user/fd-trans.c\n+++ b/linux-user/fd-trans.c\n@@ -480,7 +480,7 @@ static abi_long host_to_target_for_each_rtattr(struct rtattr *rtattr,\n unsigned short aligned_rta_len;\n abi_long ret;\n \n- while (len > sizeof(struct rtattr)) {\n+ while (len >= sizeof(struct rtattr)) {\n rta_len = rtattr->rta_len;\n if (rta_len < sizeof(struct rtattr) ||\n rta_len > len) {\n", "prefixes": [ "PULL", "v2", "03/15" ] }