Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229142/?format=api
{ "id": 2229142, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229142/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-39-c413f3605311@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427-qom-tests-v1-39-c413f3605311@redhat.com>", "date": "2026-04-27T19:42:38", "name": "[39/41] hw/riscv/virt: free flash devices and OEM strings on finalization", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "70ff307fe36c71253e1cbe714160de16a66b0c9f", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-39-c413f3605311@redhat.com/mbox/", "series": [ { "id": 501716, "url": "http://patchwork.ozlabs.org/api/1.1/series/501716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716", "date": "2026-04-27T19:42:03", "name": "Fix various QOM object life-cycle issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501716/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229142/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229142/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=R2eVyqsD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4Df96j3tz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 05:49:05 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHRur-0002sq-R3; Mon, 27 Apr 2026 15:46:50 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRua-0002lu-72\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:33 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRuY-0000GU-Lm\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:46:31 -0400", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-rl599GoVPO68LvpiNffp2w-1; Mon,\n 27 Apr 2026 15:46:25 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E560419560BB; Mon, 27 Apr 2026 19:46:21 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 9B01B1800664; Mon, 27 Apr 2026 19:46:20 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319190;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=21tqP8lo9LBFSvH7A6FrcFDu2dSjpwHDzyS3XvE13w8=;\n b=R2eVyqsD360L99In3+ml3News5eF/OqHvayVfFDt2PKEVdyTkZdBRXd0QTLHk9ybUACIsk\n dgiIvvLSENJqNCaJphifMP/uP5mnODNiegsEbUnGaVrm1r9vEY/55sooXZFGHRRZZwp9Mr\n pGd/764wIFk1tuCrDeQetb8LdHtqHSA=", "X-MC-Unique": "rl599GoVPO68LvpiNffp2w-1", "X-Mimecast-MFC-AGG-ID": "rl599GoVPO68LvpiNffp2w_1777319182", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 27 Apr 2026 23:42:38 +0400", "Subject": "[PATCH 39/41] hw/riscv/virt: free flash devices and OEM strings on\n finalization", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260427-qom-tests-v1-39-c413f3605311@redhat.com>", "References": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "In-Reply-To": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>,\n Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, qemu-riscv@nongnu.org", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1534;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=jKlBV2vW9MmXkiDj0aUyz1PT6pjDCbRhdhlP2u5ZfZk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wWrBOjNVGMG8NnDAHrZQTa3DrhN2Eh3pJhD\n NLOPtOzJ0iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FgAKCRDa6OEJdZac\n 5XYBD/4va9fk8mS/iZgqHaK0/86XuSW7lHtQ5WAV6LpWmskhApa+J/mU87vD9WqgysnhHQ468do\n 12diWTF9Avk8iKXUXteLBoG1WE4oMA/hcV5LMIzFAuRVSLcyB4Jmh5jq9UxvcKCfsaaELYrzNOb\n T85l7ok27K1F5LCAPqXJb19NNknc270Rs7YNPtDjscdSTxIvp+H0abuvmq6QjC2fMNweQICk228\n WwfQPYI7NUvY5C+pyYljg/AEbKD4fI0Deb5hyMNAK+Y1tt9NU6ZS9UdmLnA7AUn8yDJWBxXhPaS\n PV7z02nun18JHQ5QY+uisY4+R9sCKjL3ZLK55bCxDm4jDyJ/vpNoBaW0VwTEsINRVYcdNFbVyh3\n SyDH5tmuLwjiRqFWwtyZV2xYJ38xoHIlwRxILVopETvgTVLWX7swRJ2kK+70whTSQXArEmz+4ur\n JjXzrazKVVjMgDSE2yd/QHy5tyMZXW6c5qMqhjouFzJufsZKa7oxHFi3ehtaDUlAdsAY7rZsnvY\n U6MVJ+KPFAsVzFWP6qc6obG+G4U34eZAJoY3wuQxgCVBg9ThhrbXKDJLWYY5jSsbFYbmLb6OqiF\n jK+6i/tqVOSkOaqLE0Co7B87Qoy5MoGqK0JO/5GicbV/G23nzB8/1QRDM07+YfiKJzii7r03dlJ\n UX0VuL+lSxTLpKg==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Add instance_finalize to free the two pflash devices (when unrealized)\nand the OEM ID strings allocated during instance_init. Fixes leaks\nfound by ASan.\n\nFixes: 71eb522c4063 (\"riscv/virt: Add the PFlash CFI01 device\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/riscv/virt.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c\nindex a1c323e66df..315049bc86c 100644\n--- a/hw/riscv/virt.c\n+++ b/hw/riscv/virt.c\n@@ -1745,6 +1745,19 @@ static void virt_machine_init(MachineState *machine)\n qemu_add_machine_init_done_notifier(&s->machine_done);\n }\n \n+static void virt_machine_instance_finalize(Object *obj)\n+{\n+ RISCVVirtState *s = RISCV_VIRT_MACHINE(obj);\n+\n+ for (int i = 0; i < ARRAY_SIZE(s->flash); i++) {\n+ if (s->flash[i] && !qdev_is_realized(DEVICE(s->flash[i]))) {\n+ object_unref(OBJECT(s->flash[i]));\n+ }\n+ }\n+ g_free(s->oem_id);\n+ g_free(s->oem_table_id);\n+}\n+\n static void virt_machine_instance_init(Object *obj)\n {\n RISCVVirtState *s = RISCV_VIRT_MACHINE(obj);\n@@ -1984,6 +1997,7 @@ static const TypeInfo virt_machine_typeinfo = {\n .parent = TYPE_MACHINE,\n .class_init = virt_machine_class_init,\n .instance_init = virt_machine_instance_init,\n+ .instance_finalize = virt_machine_instance_finalize,\n .instance_size = sizeof(RISCVVirtState),\n .interfaces = (const InterfaceInfo[]) {\n { TYPE_HOTPLUG_HANDLER },\n", "prefixes": [ "39/41" ] }