Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229139/?format=api
{ "id": 2229139, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229139/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-29-c413f3605311@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427-qom-tests-v1-29-c413f3605311@redhat.com>", "date": "2026-04-27T19:42:28", "name": "[29/41] hw/fsi: move OPBus address space init to realize", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fb68ab6a152bce8eac660d472221d9720555e926", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-29-c413f3605311@redhat.com/mbox/", "series": [ { "id": 501716, "url": "http://patchwork.ozlabs.org/api/1.1/series/501716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716", "date": "2026-04-27T19:42:03", "name": "Fix various QOM object life-cycle issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501716/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229139/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229139/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=NSavbMoT;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DdB3j6tz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 05:48:14 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHRtd-0007bf-GU; Mon, 27 Apr 2026 15:45:33 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRtb-0007O3-Pm\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:31 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRtZ-0008M7-TY\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:45:31 -0400", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-DZew6p90MVaRME9onTFi8Q-1; Mon,\n 27 Apr 2026 15:45:22 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 64BFE1800367; Mon, 27 Apr 2026 19:45:20 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B05FA196B8FB; Mon, 27 Apr 2026 19:45:18 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319129;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=oU4SNskSDPFZiif/NOcNoCJdXW+fc2i/XPbr9XUbsk0=;\n b=NSavbMoTPGRzwSDClFBJydnaeFkHeeE2JSzCEOirDsDsbbSUnQVS/nKmrvpVQCKQmf1iyf\n 2t2mTffnoRQfYgdoB8e/hwoT4giAApLMKX2Gwq+CYvOuOToEF+y0Qli2kykNS9Sx2JybRE\n NFULJriShssolYHl1cgVOhphdNmXOJs=", "X-MC-Unique": "DZew6p90MVaRME9onTFi8Q-1", "X-Mimecast-MFC-AGG-ID": "DZew6p90MVaRME9onTFi8Q_1777319121", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 27 Apr 2026 23:42:28 +0400", "Subject": "[PATCH 29/41] hw/fsi: move OPBus address space init to realize", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260427-qom-tests-v1-29-c413f3605311@redhat.com>", "References": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "In-Reply-To": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Ninad Palsule <ninad@linux.ibm.com>,\n =?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>,\n Peter Maydell <peter.maydell@linaro.org>,\n Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>,\n Jamin Lin <jamin_lin@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>,\n Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>,\n qemu-arm@nongnu.org", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2716;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=BS8tdTzpkf4ZJcQmTy07g8mUo37sYFyz7sUGqL/kRMQ=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVAfCGmF7+C/wG/j5UXHa8K7V/bavziGb/I\n 4m4DPa4chOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5d44D/9oYfS6O6eLw30OBwOwiUXqwI+itdapJnwCWfu+Gi+CmBIiIyuATT/LL+x9PrTukg6/OM2\n cBKaJT/ShE+tjzg+2g0X9oSZS2pHVV70LCBCF65nanhCL8ww4xFVXOfFd8b8Yt/lih/EeL6cA6Q\n 8xnfNwXGo4MkpLQPyxs9ReVXyPh4KTUHeTWyP377R3YP3OQErDTigSLlJMUNXd4wVT4q+ZuflSx\n aTTviPy4GVXih+ZHpgHhnPA/J+valLmY4Jhz0kytR/8A3UX7rrq13j5Wz6/zdbXE8HSQfi/mdJs\n YcFLjg+pox4EZwFRDsvyupY3A4iPbq5olpCIRSWZb5lMOKHiywauRmVEuCuoh4O0rHdzPq+3hFI\n cioO4Q8PAdQCtV1YtDEkJLpgnpnTMMBHr/ZQvAbIpU1N1LrKen/3iK+78D0dBCxAAuNwNUAGBmX\n OTNTow+JgHX46z3uwTiH6bUX7lZRSOyVUrUa0OT+LUO1XhYW5Ni9AZ391SXwcGa+eyDDsRGceCT\n nFAfI6kcknXxgg20qAhwCc//RjIwfmDoRFqM1BKIXDjMzeapojx6271IW04OZeKwbFCxCTNFcKb\n GuBqVEc+W1EjLK+Jc1gaGhTtV/yiqGCkG75IFs42nCzznfeLrdUo3tirD3r+ZczAylYAlLHaP51\n jqxPPlUnAmWD7uw==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The OPBus instance_init initializes an AddressSpace, registering it in\nthe global address_spaces list. When a bare OPBus object is created\nand destroyed (e.g. by qom-tests), there is no finalize to remove the\nstale entry, leading to a heap-use-after-free when a subsequent\nflatviews_reset iterates the list.\n\nMove address_space_init to the bus realize callback and add the\ncorresponding address_space_destroy in unrealize, following the\nNubusBus pattern. Also fix the memory_region_init owner from NULL to\nthe OPBus object, so the MR is properly parented instead of dangling\nunder the \"unattached\" container.\n\nFixes: eb04c35da2c0 (\"hw/fsi: Aspeed APB2OPB & On-chip peripheral bus\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n hw/fsi/aspeed_apb2opb.c | 31 +++++++++++++++++++++++--------\n 1 file changed, 23 insertions(+), 8 deletions(-)", "diff": "diff --git a/hw/fsi/aspeed_apb2opb.c b/hw/fsi/aspeed_apb2opb.c\nindex b9d72f3ecf6..5d1e471288b 100644\n--- a/hw/fsi/aspeed_apb2opb.c\n+++ b/hw/fsi/aspeed_apb2opb.c\n@@ -282,13 +282,6 @@ static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp)\n AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev);\n int i;\n \n- /*\n- * TODO: The OPBus model initializes the OPB address space in\n- * the .instance_init handler and this is problematic for test\n- * device-introspect-test. To avoid a memory corruption and a QEMU\n- * crash, qbus_init() should be called from realize(). Something to\n- * improve. Possibly, OPBus could also be removed.\n- */\n for (i = 0; i < ASPEED_FSI_NUM; i++) {\n qbus_init(&s->opb[i], sizeof(s->opb[i]), TYPE_OP_BUS, DEVICE(s),\n NULL);\n@@ -348,15 +341,37 @@ static void fsi_opb_init(Object *o)\n {\n OPBus *opb = OP_BUS(o);\n \n- memory_region_init(&opb->mr, 0, TYPE_FSI_OPB, UINT32_MAX);\n+ memory_region_init(&opb->mr, o, TYPE_FSI_OPB, UINT32_MAX);\n+}\n+\n+static void fsi_opb_realize(BusState *bus, Error **errp)\n+{\n+ OPBus *opb = OP_BUS(bus);\n+\n address_space_init(&opb->as, &opb->mr, TYPE_FSI_OPB);\n }\n \n+static void fsi_opb_unrealize(BusState *bus)\n+{\n+ OPBus *opb = OP_BUS(bus);\n+\n+ address_space_destroy(&opb->as);\n+}\n+\n+static void fsi_opb_class_init(ObjectClass *klass, const void *data)\n+{\n+ BusClass *bc = BUS_CLASS(klass);\n+\n+ bc->realize = fsi_opb_realize;\n+ bc->unrealize = fsi_opb_unrealize;\n+}\n+\n static const TypeInfo opb_info = {\n .name = TYPE_OP_BUS,\n .parent = TYPE_BUS,\n .instance_init = fsi_opb_init,\n .instance_size = sizeof(OPBus),\n+ .class_init = fsi_opb_class_init,\n };\n \n static void fsi_opb_register_types(void)\n", "prefixes": [ "29/41" ] }