Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229122/?format=api
{ "id": 2229122, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229122/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-18-c413f3605311@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427-qom-tests-v1-18-c413f3605311@redhat.com>", "date": "2026-04-27T19:42:17", "name": "[18/41] net/filter: free old values in property setters", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "465be4f8a9cb6e0293055e1c8903d2717dde6958", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-18-c413f3605311@redhat.com/mbox/", "series": [ { "id": 501716, "url": "http://patchwork.ozlabs.org/api/1.1/series/501716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716", "date": "2026-04-27T19:42:03", "name": "Fix various QOM object life-cycle issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501716/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229122/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229122/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=hcbZWHYm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DZ05Crlz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 05:45:28 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHRsb-0002hO-AH; Mon, 27 Apr 2026 15:44:29 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRsR-0002AX-Fw\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:21 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRsP-0007yS-U5\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:44:19 -0400", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-77-0lrkFSldMOeP6j2n0Pkgwg-1; Mon,\n 27 Apr 2026 15:44:15 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8C7C61956088\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 19:44:14 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 50EB919560AB; Mon, 27 Apr 2026 19:44:12 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319057;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1vODrsVhyVyPcxPKeorFPGsjKDbcWUqmWEDNJlt/Brc=;\n b=hcbZWHYmED1gMsqADEc0om3Knn97SmDde4IWkEacbDMiN71YMN3/wlNE7oKqDVPHGoxTmZ\n yVVV1Tlk8GOYpybcEVXP/uw50e1f9A9xCjQ6iU8iVLKlzqa73dtF/p8oHoBJUwYON7v6Xj\n qwu2GzqheRbARHSrz9fBoEUNa4C4jHs=", "X-MC-Unique": "0lrkFSldMOeP6j2n0Pkgwg-1", "X-Mimecast-MFC-AGG-ID": "0lrkFSldMOeP6j2n0Pkgwg_1777319054", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 27 Apr 2026 23:42:17 +0400", "Subject": "[PATCH 18/41] net/filter: free old values in property setters", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260427-qom-tests-v1-18-c413f3605311@redhat.com>", "References": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "In-Reply-To": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n Jason Wang <jasowang@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=946;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=t0rAI0UZ5Soh2qRGC318tnu7sO3f1cUnwR6syUG2oKk=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wVWcppFqMLXn0ij9ZMApbly/sE+yM8IvHiB\n 1Y+SFmx3aKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FQAKCRDa6OEJdZac\n 5erRD/0XXT4ZyuEVpGlELeWNS3a9VAe4RYLGrS/nReCzsauJFqFCAY/zAFDqiqwxEOBnDHRfMXd\n 3l5K4rb/vPouSNaVku4+mzzGVh3he1dFmwuDpy8alnGe6sFMU5s6st+MrcSs1jvH09VpiZjhprv\n GH8GYOI825ecOIuNG47ytPb/OoUNfpExBGuf4V+H6hTi/BvCJddm/UyVmbLLNNSwsCcoSrZV5x5\n RL+in1mvxIw9vrT7dbN2T3jNhTf4lDRdfhNuFCogQ/x9PXaczDAqDcno6HX0tO8jhLoZaReoDTm\n fAH5zWVMX0wX81Bnzrd3AefW57QxJfN+i9kZNl+U+4ISrYE4UbXNLqS/A0WDFGVQVJ8VzW0rljE\n PK4oC5fiXIvHKZSwTqgXWf2YwjwGI8HpR7jK01CjeIz4SZShJZiWVQFZYHkspHmrHx5f1f3C1xL\n onNKrLzElS8fhZEGxEk3l8stOBXKJWDR264Q1j988ccc+yDl5Rjo5pYPV+p6V6FtOZpHWU5zWY3\n l633tZu1fgZjEZoacz2InpP893ljxOfSFpNf7MvV50jjkV21nNd9DbXic6VYFHrhBaxN4W4D37i\n /TJTKFjH8WlXcDPDTzzBCiKjQbXyt2RYyzbpiydidhdXJO06N5heDAMerlxVpIwJx0nakIwSKqf\n x+dwd+wdp/2H9nQ==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "Received-SPF": "pass client-ip=170.10.129.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "netfilter_set_position and netfilter_set_netdev_id overwrote their\nrespective fields with g_strdup without freeing the previous value,\nleaking memory on each property write.\n\nFixes: fdccce459621 (\"init/cleanup of netfilter object\")\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n net/filter.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/net/filter.c b/net/filter.c\nindex c7cc6615dc9..389f3b0bfef 100644\n--- a/net/filter.c\n+++ b/net/filter.c\n@@ -130,6 +130,7 @@ static void netfilter_set_netdev_id(Object *obj, const char *str, Error **errp)\n {\n NetFilterState *nf = NETFILTER(obj);\n \n+ g_free(nf->netdev_id);\n nf->netdev_id = g_strdup(str);\n }\n \n@@ -182,6 +183,7 @@ static void netfilter_set_position(Object *obj, const char *str, Error **errp)\n {\n NetFilterState *nf = NETFILTER(obj);\n \n+ g_free(nf->position);\n nf->position = g_strdup(str);\n }\n \n", "prefixes": [ "18/41" ] }