Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2229110/?format=api
{ "id": 2229110, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2229110/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-12-c413f3605311@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427-qom-tests-v1-12-c413f3605311@redhat.com>", "date": "2026-04-27T19:42:11", "name": "[12/41] RFC net/colo-compare: guard finalize against uninitialized state", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "254ba2d89c43e8dd684cb911565fd1f037df7cb8", "submitter": { "id": 66774, "url": "http://patchwork.ozlabs.org/api/1.1/people/66774/?format=api", "name": "Marc-André Lureau", "email": "marcandre.lureau@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427-qom-tests-v1-12-c413f3605311@redhat.com/mbox/", "series": [ { "id": 501716, "url": "http://patchwork.ozlabs.org/api/1.1/series/501716/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501716", "date": "2026-04-27T19:42:03", "name": "Fix various QOM object life-cycle issues", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501716/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2229110/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2229110/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=isqVzbNt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g4DXz0ZC1z1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 05:44:35 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHRsC-0001nC-69; Mon, 27 Apr 2026 15:44:04 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRrr-0001Od-9M\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:46 -0400", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <marcandre.lureau@redhat.com>)\n id 1wHRro-0007tu-7J\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 15:43:43 -0400", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-i_E1BIMSOvawB08oIqZ-Lg-1; Mon,\n 27 Apr 2026 15:43:38 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 35DA0195608F; Mon, 27 Apr 2026 19:43:37 +0000 (UTC)", "from localhost (unknown [10.44.24.6])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 384F3180045E; Mon, 27 Apr 2026 19:43:35 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777319019;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=1VqF0c2mTa8FvKXeY4elAFuahUQbbqA9YzOgLwlQqoY=;\n b=isqVzbNtiZ3DuP3CCjWi3HkPo9B48bHWjwQuiS7cPqaGJZP1qjsm9Xd9Umd0iocMXrUrLU\n wOwHZXHEp/OXMqQmf3flCo+m79JvxBAKGMarptWvP2wauTNlTD6P1Ioi5jwA0gb/ox2Bf5\n Dflm03FwvP1IdId2AxMbZev0KYmZaGc=", "X-MC-Unique": "i_E1BIMSOvawB08oIqZ-Lg-1", "X-Mimecast-MFC-AGG-ID": "i_E1BIMSOvawB08oIqZ-Lg_1777319017", "From": "=?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>", "Date": "Mon, 27 Apr 2026 23:42:11 +0400", "Subject": "[PATCH 12/41] RFC net/colo-compare: guard finalize against\n uninitialized state", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260427-qom-tests-v1-12-c413f3605311@redhat.com>", "References": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "In-Reply-To": "<20260427-qom-tests-v1-0-c413f3605311@redhat.com>", "To": "qemu-devel@nongnu.org", "Cc": "armbru@redhat.com,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com>,\n peterx@redhat.com, Zhang Chen <zhangckid@gmail.com>,\n Li Zhijian <lizhijian@fujitsu.com>, Jason Wang <jasowang@redhat.com>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2979;\n i=marcandre.lureau@redhat.com; h=from:subject:message-id;\n bh=kxmSjH+HqdSVTIPt3wYQYv2C7Vi1QsvEwdqKLo4jzD4=;\n b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBp77wUjI9iWiFZPPEqnmLGNs8xkazFOZ8KyIhMQ\n wZxmU0YFzyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCae+8FAAKCRDa6OEJdZac\n 5QA4EACzV/hk+sozwkWT0flUZLm5udNENR8k0XbsMTDlqYn4O8VhAOAw54vV6tdQChhyl3W9Vtc\n IGGNKH/+yNk1eTKq0pM54avHNHCbnaxCjTCsbr3sfMtNnLZGMRMCS0VeqJtHE+0IS7RpvoxmrbW\n aJheLRu9vTAVzn4gZeehJ/65R9E3onxFQB70La3ekrc6+l6j/jO0DglxgimGcl9ozZsXPPNYPAN\n BZ1r/uxMsmNkyH45Tgb/KGGyxyJPU4bQqgT86ATxr7AOKBsUChBvRsdSKawjDsBNYB5Nd3Olj+K\n eaymbeFnuFiHFps2PBLvQzuY++zJhqmW1w6bdAXZS8USZdbkmJdVYRGq+6Tj/8q8k5OAOlLUn0i\n vuzckHxc8SzDMErJcwR00YXDaHMpfXKtbGVPh/xXYza+cIadhZHmtBUxWitaDwR4BXi5qJP0uM+\n wb3JStnTY5m1i/NwX0CZPoVjagjsViG5nhlLcM/tIEAIFC8aBc4pv8PmHMWOWAo7uTXa3S0t0Cq\n ZL4YZm+3RKTEMk7HMZdSix1a3/eqfSwW6Op1jt1YPOPAx887wM/kb0DCKymmVlT6DqnjrJCIv0E\n u0TO8DLTLJFS3FlhnKqF4mxcZ8OMmUnI8JVUPtGO14RfzXmEIRrzyYPBb8e/J5J1pSmmXNsS+tu\n bv7EkBC4Ml96FsA==", "X-Developer-Key": "i=marcandre.lureau@redhat.com; a=openpgp;\n fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "Received-SPF": "pass client-ip=170.10.133.124;\n envelope-from=marcandre.lureau@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "colo_compare_finalize() assumes the object was fully set up by\ncolo_compare_complete(), but a bare object_new() followed by\nobject_unref() skips the complete callback entirely.\n\nThis causes two crashes:\n- qemu_mutex_destroy on the static event_mtx which was never\n initialized (colo_compare_active is false)\n- qemu_bh_delete(NULL) and iothread dereference when s->iothread\n is NULL\n\nGuard the event_mtx teardown with colo_compare_active, and the\niothread-dependent cleanup with an s->iothread NULL check.\n\nThis is an alternative to patch \"colo-compare: Fix QMP\nqom-list-properties crashing\", sent earlier, hence the RFC.\n\nFixes: 45942b79b9f8 (\"net/colo-compare.c: Check that colo-compare is active\")\nCc: peterx@redhat.com\nSigned-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>\n---\n net/colo-compare.c | 31 +++++++++++++++----------------\n 1 file changed, 15 insertions(+), 16 deletions(-)", "diff": "diff --git a/net/colo-compare.c b/net/colo-compare.c\nindex c356419d6a8..be819db06c9 100644\n--- a/net/colo-compare.c\n+++ b/net/colo-compare.c\n@@ -1416,7 +1416,7 @@ static void colo_compare_finalize(Object *obj)\n break;\n }\n }\n- if (QTAILQ_EMPTY(&net_compares)) {\n+ if (colo_compare_active && QTAILQ_EMPTY(&net_compares)) {\n colo_compare_active = false;\n qemu_mutex_destroy(&event_mtx);\n qemu_cond_destroy(&event_complete_cond);\n@@ -1431,30 +1431,29 @@ static void colo_compare_finalize(Object *obj)\n }\n \n colo_compare_timer_del(s);\n+ g_clear_pointer(&s->event_bh, qemu_bh_delete);\n \n- qemu_bh_delete(s->event_bh);\n+ if (s->iothread) {\n+ AioContext *ctx = iothread_get_aio_context(s->iothread);\n \n- AioContext *ctx = iothread_get_aio_context(s->iothread);\n- AIO_WAIT_WHILE(ctx, !s->out_sendco.done);\n- if (s->notify_dev) {\n- AIO_WAIT_WHILE(ctx, !s->notify_sendco.done);\n- }\n+ AIO_WAIT_WHILE(ctx, !s->out_sendco.done);\n+ if (s->notify_dev) {\n+ AIO_WAIT_WHILE(ctx, !s->notify_sendco.done);\n+ }\n+\n+ /* Release all unhandled packets after compare thread exited */\n+ g_queue_foreach(&s->conn_list, colo_flush_packets, s);\n+ AIO_WAIT_WHILE(NULL, !s->out_sendco.done);\n \n- /* Release all unhandled packets after compare thead exited */\n- g_queue_foreach(&s->conn_list, colo_flush_packets, s);\n- AIO_WAIT_WHILE(NULL, !s->out_sendco.done);\n+ object_unref(OBJECT(s->iothread));\n+ }\n \n g_queue_clear(&s->conn_list);\n g_queue_clear(&s->out_sendco.send_list);\n if (s->notify_dev) {\n g_queue_clear(&s->notify_sendco.send_list);\n }\n-\n- if (s->connection_track_table) {\n- g_hash_table_destroy(s->connection_track_table);\n- }\n-\n- object_unref(OBJECT(s->iothread));\n+ g_clear_pointer(&s->connection_track_table, g_hash_table_destroy);\n \n g_free(s->pri_indev);\n g_free(s->sec_indev);\n", "prefixes": [ "12/41" ] }