Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228986/?format=api
{ "id": 2228986, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228986/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427154441.1918536-3-rkir@google.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427154441.1918536-3-rkir@google.com>", "date": "2026-04-27T15:44:41", "name": "[2/2] display: rutabaga: unparent MemoryRegions in unmap", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5ddcc4227bb795a6037efc075e9bc693be9289f0", "submitter": { "id": 78520, "url": "http://patchwork.ozlabs.org/api/1.1/people/78520/?format=api", "name": "Roman Kiryanov", "email": "rkir@google.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427154441.1918536-3-rkir@google.com/mbox/", "series": [ { "id": 501681, "url": "http://patchwork.ozlabs.org/api/1.1/series/501681/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501681", "date": "2026-04-27T15:44:39", "name": "improve qom debugging and fix a dangling MemoryRegion in rutabaga", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501681/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228986/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228986/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20251104 header.b=Rut0n27p;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47Jv4Cxfz1yHX\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 01:48:46 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHOC6-0005Xo-VF; Mon, 27 Apr 2026 11:48:23 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from\n <3OoXvaQQKClkIB9I7FF7C5.3FDH5DL-45M5CEFE7EL.FI7@flex--rkir.bounces.google.com>)\n id 1wHOBz-0005XG-It\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 11:48:16 -0400", "from mail-pf1-x44a.google.com ([2607:f8b0:4864:20::44a])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from\n <3OoXvaQQKClkIB9I7FF7C5.3FDH5DL-45M5CEFE7EL.FI7@flex--rkir.bounces.google.com>)\n id 1wHOBx-0003wA-7g\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 11:48:14 -0400", "by mail-pf1-x44a.google.com with SMTP id\n d2e1a72fcca58-82f0e12d375so6005900b3a.1\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 08:48:12 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20251104; t=1777304891; x=1777909691; darn=nongnu.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=lsRufq+zOvxiSTMD2bdcsGu3QRTVJFWUCnfJIMUaVas=;\n b=Rut0n27pVKOablkh16z+6Z/ztvWfJUzlxI5SaX8xPsGxqgM1yUsug3uBqNzs0ty+kJ\n haDx5/XQqffr2g4gzymus/tlLXFsa1kt8ryy2Pq4u6NHCKkhJ5qGUyGZ671cf+Qupc7c\n ZfHnQW+M2c+wT1qAp3h+jFWAlW50gXki0RpbjQCIGrtydEJzpOrVCbMLgG0aZgxERYHk\n u9BzOoI2iv6bh3pdfqksajQJgxHx09/ns2eLonxxXoZh54wFmOFIySlru3GVXpzuf9Fr\n d1wotrWG9Ft9DUQhk7xAONk1Lgb0qYAq44PIPQaju806zAj7IyHwV605QfpEOrO0J0YE\n URNQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777304891; x=1777909691;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=lsRufq+zOvxiSTMD2bdcsGu3QRTVJFWUCnfJIMUaVas=;\n b=KeuiKbNWjg/h+h1TFS2oCIywpmhjYw4MEhyEZSsDtI41H/ygHwXU6F6pRFQrMt5nlN\n dRwZNOr3xJA1MTVvvK0MsX924V8BMeqlw2SqyTKrylZoeNUv8EyZicwE1Hjb8IJqgGlZ\n NZSzsTAdL8zOHNlnMOanFDipxqV2raDMI2/wTBGqujAxUDrrxE4E2fVCUU9qstHmjXzZ\n lCdwKllRj9alwNxBvRGdSw0xQ2vw2n4qP7JxuwvFYjHjAXStrHO6ufKvGNcGeb26aanE\n Fp0KwPABOw4v3s2GuLBXFoedeSXudw1ZeipYIqN+XS3FE+F6vuO1L+9R3NdK8Xo2PIIA\n g8sQ==", "X-Gm-Message-State": "AOJu0Yxv81hbPj7GQHzN+NFQeJaRs0XXiKdJShDBitp/7nE9fDv9twIp\n arGhbiHKpbcQcea/7/jEDz8w370WJEvBl+KEPekdvirjeMXkGY+zA5n47NI5bUS8t/QoGPmSMQ=\n =", "X-Received": "from pfbdw7.prod.google.com\n ([2002:a05:6a00:3687:b0:82f:4afa:eef2])\n (user=rkir job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:6a00:2288:b0:82c:e1aa:21e3\n with SMTP id d2e1a72fcca58-82f8c84da16mr45072169b3a.10.1777304890832; Mon, 27\n Apr 2026 08:48:10 -0700 (PDT)", "Date": "Mon, 27 Apr 2026 15:44:41 +0000", "In-Reply-To": "<20260427154441.1918536-1-rkir@google.com>", "Mime-Version": "1.0", "References": "<20260427154441.1918536-1-rkir@google.com>", "X-Mailer": "git-send-email 2.54.0.rc2.544.gc7ae2d5bb8-goog", "Message-ID": "<20260427154441.1918536-3-rkir@google.com>", "Subject": "[PATCH 2/2] display: rutabaga: unparent MemoryRegions in unmap", "From": "Roman Kiryanov <rkir@google.com>", "To": "pbonzini@redhat.com, alex.bennee@linaro.org", "Cc": "qemu-devel@nongnu.org, Roman Kiryanov <rkir@google.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::44a;\n envelope-from=3OoXvaQQKClkIB9I7FF7C5.3FDH5DL-45M5CEFE7EL.FI7@flex--rkir.bounces.google.com;\n helo=mail-pf1-x44a.google.com", "X-Spam_score_int": "-95", "X-Spam_score": "-9.6", "X-Spam_bar": "---------", "X-Spam_report": "(-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001,\n USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The virtio-gpu-rutabaga-device instance holds a\nhash table of child objects (`Object::properties`)\nand a memory region is added there every time\n`memory_region_init_ram_ptr` is called.\n\nThe `unmap_blob` call invalidates a `MemoryRegion`\nbut does not remove it from the device, which makes\npointers to the region dangling and eventually causes\na crash when those pointers are dereferenced.\n\nSigned-off-by: Roman Kiryanov <rkir@google.com>\n---\n hw/display/virtio-gpu-rutabaga.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutabaga.c\nindex ebb6c783fb..5cd9b19336 100644\n--- a/hw/display/virtio-gpu-rutabaga.c\n+++ b/hw/display/virtio-gpu-rutabaga.c\n@@ -737,6 +737,7 @@ rutabaga_cmd_resource_unmap_blob(VirtIOGPU *g,\n \n MemoryRegion *mr = &(vr->memory_regions[slot].mr);\n memory_region_del_subregion(&vb->hostmem, mr);\n+ object_unparent(OBJECT(mr));\n \n vr->memory_regions[slot].resource_id = 0;\n vr->memory_regions[slot].used = 0;\n", "prefixes": [ "2/2" ] }