Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228981/?format=api
{ "id": 2228981, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228981/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427152953.180038-9-dhowells@redhat.com/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427152953.180038-9-dhowells@redhat.com>", "date": "2026-04-27T15:29:35", "name": "[v4,08/22] netfs: fix error handling in netfs_extract_user_iter()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "25e23439a1dfe08509dd584c628ece8e8f0cf738", "submitter": { "id": 59, "url": "http://patchwork.ozlabs.org/api/1.1/people/59/?format=api", "name": "David Howells", "email": "dhowells@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260427152953.180038-9-dhowells@redhat.com/mbox/", "series": [ { "id": 501677, "url": "http://patchwork.ozlabs.org/api/1.1/series/501677/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=501677", "date": "2026-04-27T15:29:27", "name": "netfs: Miscellaneous fixes", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/501677/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228981/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228981/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-11151-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=SQcM+AXc;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-11151-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"SQcM+AXc\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g47Bf3PCNz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 28 Apr 2026 01:43:22 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id A1930303A12A\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 15:36:01 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5F1513E275F;\n\tMon, 27 Apr 2026 15:30:51 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BBA234E762\n\tfor <linux-cifs@vger.kernel.org>; Mon, 27 Apr 2026 15:30:49 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-4SWfnZdyOOmdwlqwJIgzPw-1; Mon,\n 27 Apr 2026 11:30:41 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id EE8D119560A6;\n\tMon, 27 Apr 2026 15:30:39 +0000 (UTC)", "from warthog.procyon.org.com (unknown [10.44.32.126])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C294E180045E;\n\tMon, 27 Apr 2026 15:30:36 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777303851; cv=none;\n b=FHoPx0OOLbZH7NmD22EKiAexteWncTtGx9rwF4p7CAjQFTVc/3ajQe3EZp19eh64UTZUkzi1zpsucbuaBoihZ5XMHX+SanziVtMOYAVEjMhdwoBAC+M2wBSOFXc0rR4rpw/di7awk44vajFtmOVf2Z8orPLhKrZvHbL+z4Lk7cE=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777303851; c=relaxed/simple;\n\tbh=S62t+upgojIYhz1p6dALu+kyrentByS35lQhzLSLXbY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=IdOdGhaGTm6VZQbVV/bSuDTY05UDHAZjMQJtykK0PIFjIvAmxr+P2urY1fpPaeDU8xdgpHR2jrVZnq829YVho31so991l7GZ8JqETBGpLWCuWg15NPORrDZ9Gxe0/TUSsZrcINsrfZnhF4Dzcg5B3XpYqGGtLxKR4zu3yQtt5Js=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=SQcM+AXc; arc=none smtp.client-ip=170.10.129.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1777303848;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=0M8NeyGOtxqcK9n3lFvZBV03uT/fzw4I/4MxBJJ99Zo=;\n\tb=SQcM+AXcZ499HTKGc6CMi3u4D+47dCaAQEE9bdMjz1jqojE3icyzM/Dm+nAyFOTHm25c/P\n\tuhvvjjIQRCnC5CB+1n2fZQMh8XkX5wk00NpRNm8TJh0Ji0pCyhAUPyKsL8fSv0U6og1tKy\n\tYn5fphJ5nySWsiaKBxsfioAuvF2gVjU=", "X-MC-Unique": "4SWfnZdyOOmdwlqwJIgzPw-1", "X-Mimecast-MFC-AGG-ID": "4SWfnZdyOOmdwlqwJIgzPw_1777303840", "From": "David Howells <dhowells@redhat.com>", "To": "Christian Brauner <christian@brauner.io>", "Cc": "David Howells <dhowells@redhat.com>,\n\tPaulo Alcantara <pc@manguebit.org>,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tXiaoli Feng <xifeng@redhat.com>,\n\tstable@vger.kernel.org", "Subject": "[PATCH v4 08/22] netfs: fix error handling in\n netfs_extract_user_iter()", "Date": "Mon, 27 Apr 2026 16:29:35 +0100", "Message-ID": "<20260427152953.180038-9-dhowells@redhat.com>", "In-Reply-To": "<20260427152953.180038-1-dhowells@redhat.com>", "References": "<20260427152953.180038-1-dhowells@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111" }, "content": "From: Paulo Alcantara <pc@manguebit.org>\n\nIn netfs_extract_user_iter(), if iov_iter_extract_pages() failed to\nextract user pages, bail out on -ENOMEM, otherwise return the error\ncode only if @npages == 0, allowing short DIO reads and writes to be\nissued.\n\nThis fixes mmapstress02 from LTP tests against CIFS.\n\nFixes: 85dd2c8ff368 (\"netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator\")\nReported-by: Xiaoli Feng <xifeng@redhat.com>\nSigned-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>\nSigned-off-by: David Howells <dhowells@redhat.com>\nCc: netfs@lists.linux.dev\nCc: stable@vger.kernel.org\nCc: linux-cifs@vger.kernel.org\nCc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/iterator.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/fs/netfs/iterator.c b/fs/netfs/iterator.c\nindex 154a14bb2d7f..adca78747f23 100644\n--- a/fs/netfs/iterator.c\n+++ b/fs/netfs/iterator.c\n@@ -22,7 +22,7 @@\n *\n * Extract the page fragments from the given amount of the source iterator and\n * build up a second iterator that refers to all of those bits. This allows\n- * the original iterator to disposed of.\n+ * the original iterator to be disposed of.\n *\n * @extraction_flags can have ITER_ALLOW_P2PDMA set to request peer-to-peer DMA be\n * allowed on the pages extracted.\n@@ -67,8 +67,8 @@ ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,\n \t\tret = iov_iter_extract_pages(orig, &pages, count,\n \t\t\t\t\t max_pages - npages, extraction_flags,\n \t\t\t\t\t &offset);\n-\t\tif (ret < 0) {\n-\t\t\tpr_err(\"Couldn't get user pages (rc=%zd)\\n\", ret);\n+\t\tif (unlikely(ret <= 0)) {\n+\t\t\tret = ret ?: -EIO;\n \t\t\tbreak;\n \t\t}\n \n@@ -97,6 +97,13 @@ ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,\n \t\tnpages += cur_npages;\n \t}\n \n+\tif (ret < 0 && (ret == -ENOMEM || npages == 0)) {\n+\t\tfor (i = 0; i < npages; i++)\n+\t\t\tunpin_user_page(bv[i].bv_page);\n+\t\tkvfree(bv);\n+\t\treturn ret;\n+\t}\n+\n \tiov_iter_bvec(new, orig->data_source, bv, npages, orig_len - count);\n \treturn npages;\n }\n", "prefixes": [ "v4", "08/22" ] }