Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228880/?format=api
{ "id": 2228880, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228880/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-60-peter.maydell@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427124738.966578-60-peter.maydell@linaro.org>", "date": "2026-04-27T12:47:33", "name": "[PULL,59/63] target/arm: make hvf use syndrome helpers for decode", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "6627f3a40497ac5f2f90cdc02508ce7005b89222", "submitter": { "id": 5111, "url": "http://patchwork.ozlabs.org/api/1.1/people/5111/?format=api", "name": "Peter Maydell", "email": "peter.maydell@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427124738.966578-60-peter.maydell@linaro.org/mbox/", "series": [ { "id": 501642, "url": "http://patchwork.ozlabs.org/api/1.1/series/501642/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501642", "date": "2026-04-27T12:46:34", "name": "[PULL,01/63] docs/system: add FEAT_AA32 and FEAT_AA64 to emulation list", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501642/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228880/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228880/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=rEWBbd92;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g43YG1pYtz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 22:59:14 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHLU8-0006Kq-1A; Mon, 27 Apr 2026 08:54:48 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHLOA-0008Hh-Km\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:41 -0400", "from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wHLO7-0005n2-HN\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 08:48:38 -0400", "by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488ad135063so93529745e9.0\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 05:48:34 -0700 (PDT)", "from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488ffc5e3f4sm448974115e9.2.2026.04.27.05.48.32\n for <qemu-devel@nongnu.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 27 Apr 2026 05:48:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777294114; x=1777898914; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=2kPC1nSjy09rWvg26KQH5UE7UfFjCOQkaqBSnSpqoXk=;\n b=rEWBbd92M4oDRyAehhLIliJfAg6/ycTM7TeoEkLduaD9Qc65Ip53dzaBgJIZxk/0Vr\n UsPb1d/xaYEkcJr4uRjGijbYZizElgUSnP2gCn4zpN3gnj7KkijOjZbK5DiJfQHpPdmp\n ooJgFzWu1XxTHaXIZHdKbE1fZ+HsrV9VQb5zI8qHWIr2oOngdN1qdqE7E5iRKqz4CRJc\n 57prs1zcU7rn/J5k+fDCYcpzJbI/1mK82t66jggfFWpb5/hsln7Lx3V1VBb/KkwI1scG\n MCwu5YrwHvO0t9ZhiK87xm++rent7ebkc1yHpJpEjPo/T/W4jcYahoUVD9OZ42nLNKLv\n KO2g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777294114; x=1777898914;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=2kPC1nSjy09rWvg26KQH5UE7UfFjCOQkaqBSnSpqoXk=;\n b=QLBk4o01v4dzG4awkIlvAmdKWXoLzqD+I9hhMEt5tmlBCTdmIUUPLFskl4d8nJkJEl\n SxeOLg/b53NfE/EuRB0YaqTGE4nXqJyNJPuCxJyNsjQlfhJubuFP44td86eTyxtioM/7\n jJT+TsRU4jI7OkbMDw5NdIxG+0Gj6YycMXKmGQvi/l6ZlfFXO1g1b+YhTxqmfEN+6tXB\n pfkine5D6jyVJjdxsl2bXHrieoA0bVp2P6jRVrWSy5AEcRocvQCJfwjrD2ljFUlVXbP/\n ygx7wkWJKeP5Pj1SaeguapUeJqdmH70LON85XRfEbODtuasea8Q7v3yD84sj9rbCyq5W\n Acdg==", "X-Gm-Message-State": "AOJu0YxSgXntb9HH9FaX7JVoAogZT727h7/xVOaUgPPKtZwMIDIHE4pU\n 0lZVHRt02Xg/W9Ep0Exl0j/GrWX61nDr5ao4vrbnUsyZYR4EQQk8kypbl0k+Ea4/Hl2cGiVS2DH\n 6YYiX", "X-Gm-Gg": "AeBDieudKKJ/PweYJ5HxiNr/ok/cx++1MKwLQW7KDyFq+JOVdYqdcWJFh04jNbfAhe+\n HbPN0wFc8i6QqnnMCj23rpsZGnfKrZ6bUnkXRdup1bZ5xscFcGM5XNwngxc967UMTb7gbt5aP5g\n S32NZhV/DXJyB4slolI0qnCCzXUdia49pmj/2bLZnrPhi2kXGo0Rgpu06MSDv5doolk+/j7pFu8\n lABPdLy3JW13tSSGByyCH7eRADttfRKu+Og8TC6e34qXhtt6gS91FugOPOsrZmVNP2KMC+pGuTL\n O8S3Z2mp1gbltp95wNFovsUh+lIXGLl22yV1rlPyIW7ppa9RQlW2dABrtYQlbqY5equ1shjmdki\n Ggjmn2SmkZgdCmhQOlMMm1IYlekv37ulgquNkxt9i9USPz/fhdXJrMTFr421i4ZXXikH7mkmqG/\n xxGqgQv133SIPJlH26EnAKHb1RL7lWJokE4lR3acltFdfFKCLLfWPkDyqNayb9W0rz3yH4Dlfx4\n YRnpNFr5G/SmpTUFL0d0I1Jre6LLL+68X3xyPjZuw==", "X-Received": "by 2002:a05:600c:1da1:b0:488:d376:42cd with SMTP id\n 5b1f17b1804b1-488fb785901mr653773505e9.22.1777294113658;\n Mon, 27 Apr 2026 05:48:33 -0700 (PDT)", "From": "Peter Maydell <peter.maydell@linaro.org>", "To": "qemu-devel@nongnu.org", "Subject": "[PULL 59/63] target/arm: make hvf use syndrome helpers for decode", "Date": "Mon, 27 Apr 2026 13:47:33 +0100", "Message-ID": "<20260427124738.966578-60-peter.maydell@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260427124738.966578-1-peter.maydell@linaro.org>", "References": "<20260427124738.966578-1-peter.maydell@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Alex Bennée <alex.bennee@linaro.org>\n\nRather than open coding a bunch of shifts and masks we can use the\nsyndrome definitions.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>\nTested-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nMessage-id: 20260422125250.1303100-20-alex.bennee@linaro.org\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n target/arm/hvf/hvf.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c\nindex 678afe5c8e..ef4c3671e9 100644\n--- a/target/arm/hvf/hvf.c\n+++ b/target/arm/hvf/hvf.c\n@@ -2123,14 +2123,14 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcpu_exit_exception_t *excp)\n break;\n }\n case EC_DATAABORT: {\n- bool isv = syndrome & ARM_EL_ISV;\n- bool iswrite = (syndrome >> 6) & 1;\n- bool s1ptw = (syndrome >> 7) & 1;\n- bool sse = (syndrome >> 21) & 1;\n- uint32_t sas = (syndrome >> 22) & 3;\n+ bool isv = FIELD_EX32(syndrome, DABORT_ISS, ISV);\n+ bool iswrite = FIELD_EX32(syndrome, DABORT_ISS, WNR);\n+ bool s1ptw = FIELD_EX32(syndrome, DABORT_ISS, S1PTW);\n+ bool sse = FIELD_EX32(syndrome, DABORT_ISS, SSE);\n+ uint32_t sas = FIELD_EX32(syndrome, DABORT_ISS, SAS);\n uint32_t len = 1 << sas;\n- uint32_t srt = (syndrome >> 16) & 0x1f;\n- uint32_t cm = (syndrome >> 8) & 0x1;\n+ uint32_t srt = FIELD_EX32(syndrome, DABORT_ISS, SRT);\n+ uint32_t cm = FIELD_EX32(syndrome, DABORT_ISS, CM);\n uint64_t val = 0;\n uint64_t ipa = excp->physical_address;\n AddressSpace *as = cpu_get_address_space(cpu, ARMASIdx_NS);\n", "prefixes": [ "PULL", "59/63" ] }