Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228691/?format=api
{ "id": 2228691, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228691/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-29-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427080738.77138-29-philmd@linaro.org>", "date": "2026-04-27T08:07:34", "name": "[v4,28/32] target/m68k: Replace target_monitor_defs -> SysemuCPUOps::monitor_defs", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "66bb3c3f047b989c882ef94d7947382c15c5ec02", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-29-philmd@linaro.org/mbox/", "series": [ { "id": 501599, "url": "http://patchwork.ozlabs.org/api/1.1/series/501599/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599", "date": "2026-04-27T08:07:06", "name": "monitor: Remove need of per-target handlers", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/501599/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228691/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228691/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cs0qNY3z;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x9L5wbkz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 18:11:34 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHH3Z-0000t9-5o; Mon, 27 Apr 2026 04:11:05 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH3P-0000kR-Rw\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:57 -0400", "from mail-wm1-x330.google.com ([2a00:1450:4864:20::330])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH3N-0002n6-IU\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:55 -0400", "by mail-wm1-x330.google.com with SMTP id\n 5b1f17b1804b1-488ad135063so90594395e9.0\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 01:10:53 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a5c4b9e8dsm113167865e9.7.2026.04.27.01.10.51\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277452; x=1777882252; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=pWkinHow/eylS7JBe+fWXt/Nq4YrC48hyztEBorpfGw=;\n b=cs0qNY3z/xRPmuigO1xe6Epwlpll1VlMdM+Gla/DCkf+6dkNI051XFGKGKTEfC1Yqw\n BF3fosOGAa+nFRFWuZt5EpimPWnXnoxyROAx4vwZea5vKFALBXI+91RdiY4G6MHujsA8\n GUDVwAnrtau2GJCZyinYT09PUI6koICc6ATkCrQQwpNwcuh5eYl4vW9xWNzjwEIzQXDv\n /D/vhrAmK3zEW9cSZ7SOtAalQ3toQJ6zDG15FVeajU7K9nt6dgXFtVm6gyob+JXmd/mE\n pYbGqTORNiIzMhufv8S9/r3hZMDZnWM4+HjEyrrOwNV6hkpsg1J0uDpO+e4NjG05EPyZ\n cCog==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277452; x=1777882252;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=pWkinHow/eylS7JBe+fWXt/Nq4YrC48hyztEBorpfGw=;\n b=mT4/OnTWntSm49jvJLqGtY9dnNZI+4Dx7GrduxLdYWE82Zz6aydiYhMdbZTy1hzkgk\n Imrkt7xWBwmVVQv2/JRhTNl+0OYNvEBy/bqrQ302GpI87QgqBP+FWUCSaaBg1+TZztcg\n ULROiW/nOjMINP3yZzz1L3pgKa3EvzueRinfUueQWK/VcGX5pyKUfW6pTa6slplMjQwb\n EvBwArrcLNXQYrrExUaLKaD7gR3+gsN3N+XhtJGsv1i6dqlcRrwZeK945DFIsYVpB000\n 9p9OOFsXPrC3yF16oaZSkThrrR+BnGE9FBE/7O9A1JM5xbSkRoRw3bz0RXs4mVpaLFlq\n sI9Q==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ+dwTTjF7ZBII9ogt0b5/IzqxzAsTZ9Vqzu8MQ3UXxDbw7vvO8cTvE6jbh7LasVO08t12m54bFCW9fy@nongnu.org", "X-Gm-Message-State": "AOJu0Yyjw7gNTCTdbdn1TAYVHygwcFNjhaDusbvgdBFZvvnOjwogJCN5\n JYCJqmaLhkslwsASVR1WoPg8/O5swUROOgBL4NDND7dZYeQn7YrEIvS2WAmg6rdoaUc=", "X-Gm-Gg": "AeBDievcJabqJQ5xP4oEO8H1mkVYQtvmoiLiq9DV5db7+nbFO+69u7Zfn4V4v3ZqfQ6\n i29DfcOwNzx7ofi4C/eD15TeG1QjNN3PtPnDlYh/sP+BW6uZSb3pCwTIhj04wCuN2FOSsm9+BCz\n r5ORZ/dhakmJULjSogXwa0cmt6iTr8VA7N+NHtEBz5jZiE4LKy/ul0ZVmCWKFgFeekS+dhvioJP\n hcxZO/hFq7RkC9O99xxtAvc9yqKqcAELMCYFdX3eNYPVYh1XInrWeb0rZaODdfdGKEv9GcwfeiJ\n R9M2gU562ngM9pVP3AVtCs9xGGN2Y+yViLONVVdExZDQes74HJdLRLSONF3hdudG3LzPxIGxb4k\n TYc7WePqQnFRKssmvIaOrbNVyl6Bk8jSPI0lXACmoE//SeoqTJuCEoflNcPjPmoieoSDVo9XW+i\n as4Srk5ORnU+0NycEUsLquviy97meGYe7RzxUjH/nuAmSVyMhhxTJtL/msBJqKzySdbFPFNK+eV\n SIc67IsVak=", "X-Received": "by 2002:a05:600c:c0c8:b0:471:700:f281 with SMTP id\n 5b1f17b1804b1-488fb78b8c5mr430143325e9.25.1777277451990;\n Mon, 27 Apr 2026 01:10:51 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org", "Subject": "[PATCH v4 28/32] target/m68k: Replace target_monitor_defs ->\n SysemuCPUOps::monitor_defs", "Date": "Mon, 27 Apr 2026 10:07:34 +0200", "Message-ID": "<20260427080738.77138-29-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260427080738.77138-1-philmd@linaro.org>", "References": "<20260427080738.77138-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::330;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Restrict m68k_monitor_defs[] to cpu.c, register it as\nSysemuCPUOps::monitor_defs hook, allowing to remove\nthe target_monitor_defs() method.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n---\n target/m68k/cpu.c | 18 ++++++++++++++++++\n target/m68k/monitor.c | 21 ---------------------\n 2 files changed, 18 insertions(+), 21 deletions(-)", "diff": "diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c\nindex d849a4a90fc..f704a6af613 100644\n--- a/target/m68k/cpu.c\n+++ b/target/m68k/cpu.c\n@@ -25,6 +25,7 @@\n \n #ifndef CONFIG_USER_ONLY\n #include \"migration/vmstate.h\"\n+#include \"monitor/hmp.h\"\n #endif\n \n #include \"cpu.h\"\n@@ -602,11 +603,28 @@ static const VMStateDescription vmstate_m68k_cpu = {\n },\n };\n \n+static const MonitorDef m68k_monitor_defs[] = {\n+ { \"ssp\", offsetof(CPUM68KState, sp[0]) },\n+ { \"usp\", offsetof(CPUM68KState, sp[1]) },\n+ { \"isp\", offsetof(CPUM68KState, sp[2]) },\n+ { \"sfc\", offsetof(CPUM68KState, sfc) },\n+ { \"dfc\", offsetof(CPUM68KState, dfc) },\n+ { \"urp\", offsetof(CPUM68KState, mmu.urp) },\n+ { \"srp\", offsetof(CPUM68KState, mmu.srp) },\n+ { \"dttr0\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR0]) },\n+ { \"dttr1\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR1]) },\n+ { \"ittr0\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR0]) },\n+ { \"ittr1\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR1]) },\n+ { \"mmusr\", offsetof(CPUM68KState, mmu.mmusr) },\n+ { NULL },\n+};\n+\n #include \"hw/core/sysemu-cpu-ops.h\"\n \n static const struct SysemuCPUOps m68k_sysemu_ops = {\n .has_work = m68k_cpu_has_work,\n .get_phys_page_debug = m68k_cpu_get_phys_page_debug,\n+ .monitor_defs = m68k_monitor_defs,\n };\n #endif /* !CONFIG_USER_ONLY */\n \ndiff --git a/target/m68k/monitor.c b/target/m68k/monitor.c\nindex be7411edca6..3e0df40a6b8 100644\n--- a/target/m68k/monitor.c\n+++ b/target/m68k/monitor.c\n@@ -21,24 +21,3 @@ void hmp_info_tlb(Monitor *mon, const QDict *qdict)\n \n dump_mmu(env1);\n }\n-\n-static const MonitorDef monitor_defs[] = {\n- { \"ssp\", offsetof(CPUM68KState, sp[0]) },\n- { \"usp\", offsetof(CPUM68KState, sp[1]) },\n- { \"isp\", offsetof(CPUM68KState, sp[2]) },\n- { \"sfc\", offsetof(CPUM68KState, sfc) },\n- { \"dfc\", offsetof(CPUM68KState, dfc) },\n- { \"urp\", offsetof(CPUM68KState, mmu.urp) },\n- { \"srp\", offsetof(CPUM68KState, mmu.srp) },\n- { \"dttr0\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR0]) },\n- { \"dttr1\", offsetof(CPUM68KState, mmu.ttr[M68K_DTTR1]) },\n- { \"ittr0\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR0]) },\n- { \"ittr1\", offsetof(CPUM68KState, mmu.ttr[M68K_ITTR1]) },\n- { \"mmusr\", offsetof(CPUM68KState, mmu.mmusr) },\n- { NULL },\n-};\n-\n-const MonitorDef *target_monitor_defs(void)\n-{\n- return monitor_defs;\n-}\n", "prefixes": [ "v4", "28/32" ] }