Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228684/?format=api
{ "id": 2228684, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228684/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-23-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427080738.77138-23-philmd@linaro.org>", "date": "2026-04-27T08:07:28", "name": "[v4,22/32] monitor: Have MonitorDef::get_value() always return int64_t type", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e1dab318efa8956f03dd433ee6c44617c9f53c7b", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-23-philmd@linaro.org/mbox/", "series": [ { "id": 501599, "url": "http://patchwork.ozlabs.org/api/1.1/series/501599/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599", "date": "2026-04-27T08:07:06", "name": "monitor: Remove need of per-target handlers", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/501599/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228684/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228684/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=HpnP6B4l;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x8P6xpYz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 18:10:45 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHH2n-0007IR-0e; Mon, 27 Apr 2026 04:10:17 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH2m-0007Bw-0M\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:16 -0400", "from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH2j-0002TP-7d\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:10:15 -0400", "by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-48896199cbaso98654235e9.1\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 01:10:12 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48a4b329542sm856930445e9.3.2026.04.27.01.10.10\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:10:10 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277411; x=1777882211; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=HQd4kWlVL3tTuUUEKzzbm5wkvsPG410wtgsY2aydV/I=;\n b=HpnP6B4lSgWNfY/dMvsTmCiZxr8ZESgCwH2xTd8rTEechp0y32jyC0xelF9PYep//S\n WJvwDmzTVccb7hVC6/YmeMjhjaxBvjLuDax0ZKe4Vc9juZnhVzoC5JfM79LFc2fhsQ1L\n yjipzvkzFXYotCyhqpEB4fZqUNBgo3zwYKR4Md6Xr8JKnbNaNW+ZYs9Nd1M2/RMFX38C\n NDdrN9uBGbwOM6/EHj0frEDae/5sx4SIT/YcuOZkKCY+traeOuHFavAmEgPtYfrSxaew\n Q+hRpjNTLpCIUxntMosf+UUdO5t/0DN2xPxHF6hB8BMsyn50lwzQ1aK7JK8nbhkUJNgT\n GLVA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277411; x=1777882211;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=HQd4kWlVL3tTuUUEKzzbm5wkvsPG410wtgsY2aydV/I=;\n b=WTcFNRxryazDiFVAJBp1LpmQn83WBBPYGwg4PEYWDwXd+iPJ0tnfBzZm4jcaQDIGdp\n S/+uNqZl3qKNiqcPDiXagg3EZmes6iUIJBjTWnmsbrBN0RgUY0bBtU1Oo9UYqOYEbiDV\n ztb1Rc/3or1nVs9ivzW6Y9Q5mSyRnykXv6USMTQDLIgIcRkxf4wuJP1uLISoKxQFOHrV\n 8L3+xYZ48Y83s17rLaDScffIoKR3HyH7Qj/TlCiOoUmAzYoUTf/xPAVIxBjsATvTrRa+\n WvOnf5YVIqRWJF81HQI+PpUupwUNPDCfEgH9E7Kc33nyAd63XmuMzPpF74yWrjwXer2s\n BBgg==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ8RhqgvANpkydVmgNYjyIywCwC59CVKlVN8NRIQquambyNdh+C6J/dDVj4RpSuQNC/+SJtPueEUBUX6@nongnu.org", "X-Gm-Message-State": "AOJu0YzrYtm3MjvyPF2+anqqrHungOPrrl3A0WHFPou7CJXXR4yeWaev\n sy8uhWyF/xQ3BP4hM7paqcZKkxLNNEVoaMDNYOSfJPlkjBNcfwldd1ivyyTNEh0qVaTc0u6cPq/\n 1hhxgeCo=", "X-Gm-Gg": "AeBDievj/jl4zpg3c+ynn1LmsnXkWT3qJj4OiUHPCtvX9DxboTzk7SxaAZhPOTGjEpA\n ZbNR/C4PR8guhJhFTZ2MOeko7u8glPbtDNlP+koGsTvht6yMY3ZXQKf7MRW8Sm73bxYi0QKcaTz\n E08/giCuhsIBTriRpDUynz/p8qqleXXH1ygYLUQ/PoEJBb7roWWAA/P0KvgJ7NYqctKHzZP7rc0\n TtT46JcN6UIv2W4Ac4yu+qtmz9DWD3br/n4XKiXKohcs0fnzuZ9Omd/lMrMDYcuuDvhaKkIRWss\n OoMj+OoZciBJE6YvbCLhWDFQEdxOmdQoQZRRObQZTpUY3slfp6e4ygnIqci4nUnjWDHbyfX1egP\n apybUea1QDcXLiva2eC/csyNtUFQHdUXmL3tpsJON1rOJMZsISrM+8UsDsJUzp6A/jJjoErnovg\n 2C6lBCUJ/8b6Cjghi7VVTFP1Bt6LqiEO7dn1IHOX3uyEfD25L957gjFJDzbsJBylAqUAmxrrWiK\n G7sUzTtjaI=", "X-Received": "by 2002:a05:600c:5246:b0:488:a639:b787 with SMTP id\n 5b1f17b1804b1-488fb74fc0dmr600756645e9.11.1777277411297;\n Mon, 27 Apr 2026 01:10:11 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org", "Subject": "[PATCH v4 22/32] monitor: Have MonitorDef::get_value() always return\n int64_t type", "Date": "Mon, 27 Apr 2026 10:07:28 +0200", "Message-ID": "<20260427080738.77138-23-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260427080738.77138-1-philmd@linaro.org>", "References": "<20260427080738.77138-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Simplify MonitorDef::get_value() handler by having it always\nreturn a int64_t type.\n\nLet the single caller (x86 targets) sign-extend the returned\nvalue, directly handling 64-bit CPUs in 32-bit or 16-bit mode.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nReviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>\n---\n include/monitor/hmp-target.h | 6 +-----\n target/i386/monitor.c | 11 ++++++++---\n 2 files changed, 9 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/monitor/hmp-target.h b/include/monitor/hmp-target.h\nindex 008c1a6570c..ae34ca65ded 100644\n--- a/include/monitor/hmp-target.h\n+++ b/include/monitor/hmp-target.h\n@@ -27,15 +27,11 @@\n \n typedef struct MonitorDef MonitorDef;\n \n-#ifdef COMPILING_PER_TARGET\n-#include \"exec/target_long.h\"\n struct MonitorDef {\n const char *name;\n int offset;\n- target_long (*get_value)(Monitor *mon, const struct MonitorDef *md,\n- int val);\n+ int64_t (*get_value)(Monitor *mon, const MonitorDef *md, int offset);\n };\n-#endif\n \n const MonitorDef *target_monitor_defs(void);\n \ndiff --git a/target/i386/monitor.c b/target/i386/monitor.c\nindex 977f65fe16c..98df5c7fd12 100644\n--- a/target/i386/monitor.c\n+++ b/target/i386/monitor.c\n@@ -593,11 +593,16 @@ void hmp_mce(Monitor *mon, const QDict *qdict)\n }\n }\n \n-static target_long monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n- int val)\n+static int64_t monitor_get_pc(Monitor *mon, const struct MonitorDef *md,\n+ int offset)\n {\n CPUArchState *env = mon_get_cpu_env(mon);\n- return env->eip + env->segs[R_CS].base;\n+ int64_t ret = env->eip + env->segs[R_CS].base;\n+\n+ if (!(env->hflags & HF_CS64_MASK)) {\n+ ret = (int32_t)ret;\n+ }\n+ return ret;\n }\n \n const MonitorDef monitor_defs[] = {\n", "prefixes": [ "v4", "22/32" ] }