Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228676/?format=api
{ "id": 2228676, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228676/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-13-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260427080738.77138-13-philmd@linaro.org>", "date": "2026-04-27T08:07:18", "name": "[v4,12/32] hw/s390x: Reduce 'monitor/monitor.h' inclusions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "765216820ee99f3a92e198a7c8ad203d2cfe1ab1", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/1.1/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260427080738.77138-13-philmd@linaro.org/mbox/", "series": [ { "id": 501599, "url": "http://patchwork.ozlabs.org/api/1.1/series/501599/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501599", "date": "2026-04-27T08:07:06", "name": "monitor: Remove need of per-target handlers", "version": 4, "mbox": "http://patchwork.ozlabs.org/series/501599/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228676/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228676/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=egeU0eVQ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3x7n01w0z1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 18:10:12 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wHH1x-0001Wb-55; Mon, 27 Apr 2026 04:09:25 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH1h-0001J1-SU\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:10 -0400", "from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wHH1e-0001qL-L8\n for qemu-devel@nongnu.org; Mon, 27 Apr 2026 04:09:09 -0400", "by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-43eb012ac4fso5952818f8f.0\n for <qemu-devel@nongnu.org>; Mon, 27 Apr 2026 01:09:04 -0700 (PDT)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4cc09b1sm79693042f8f.9.2026.04.27.01.09.02\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 27 Apr 2026 01:09:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777277344; x=1777882144; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:from:to:cc:subject:date:message-id\n :reply-to; bh=vj1VCyGpmEVZZgVNhKzGcdjLaf+nPbuu+8SZqhBUOlE=;\n b=egeU0eVQCadUmdEanMQFm3vXfE2gdLqQ6np2ddcTYBt2S89TGn5Myj8dkDXCfftWbv\n ZhwKmGsKCu1KMwciqZXXES8VZzk4X/N/O50f872Xil/wDabn/WI/he+vuMzgFzBpEU7C\n gRy89XfjUPsMIISWbKmiUhSkLTBU63h1o2qQgM65MIFgYECSiihjMnSCY3ysZgveFqXO\n /QTkcPzeSYb2MR4L6MyExMsRqF+bQI5IYJYh9mG9E8PZVkptGp4mqJHul4B3bFYt/hYP\n bihsJsAp85THWlBOsoZ6aWZlO3vEuP8PZa+8UNc5fFwMNq2bzM7wPHymhgsB1++OouOI\n Qb2w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777277344; x=1777882144;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=vj1VCyGpmEVZZgVNhKzGcdjLaf+nPbuu+8SZqhBUOlE=;\n b=baVHUOqebuSJrBVCjA2K443qGRvFVxpfPWkzJRcVAR1JCmHkn230Tm0FdgD4JxMPq4\n fIlLwcw39SV7Pwmac7m5USjcBQnRj9H/mrqtH40cyiS4HvQSAq+ZE05Xo7I0nCXgRKYE\n oPXDS399GrORBCmF7qS26TdMKgl/fhikpFdSM4eCX2dUlYkkroWNArffup0R9SRNCp/W\n jXQzSbwVYd50wcAMdmqLy73CTKZXe8EVtQIFjrLS+OlM1dbd79ej/JDmAd3muoeXkvvj\n Z2gnDQa8oGPfybZghny+394bVGnOLDp4OiyHzxDVdcC4jAnTd/t7eRfreJMzQd4XTffR\n Ze9A==", "X-Forwarded-Encrypted": "i=1;\n AFNElJ/KOgfurPILpMSj2SEALR7pex/ZCBP9fgEpySzfYuHcKMzANvl6vwJC8ZBo0jOjxZbLx3Ou/Xzr2IvT@nongnu.org", "X-Gm-Message-State": "AOJu0YzsAGPeOwigtCx8TPU9gLSUyDpdPK5H8zFK0sm/Q1QEojIH/XFt\n 61v9tYgNl4UjXfjnao+VxOY6R6R0iAMHQsFnTqVFe69ZEouljoJgflsT8XrZ5CKfGwW38FFX72c\n 5nMzQQpg=", "X-Gm-Gg": "AeBDievVyF5PnQfR+ytyBEPT+7oSzKR1CeQSQ2RsUEb3K+aO22GG27vFDv2ZRtGV3yB\n 7BX5j2LQslOf66ALdzM3Blq4nZLwPqOOi3jNHjj0W6aQOoLp2ziflI3ovHSG886gLtWi2+hhRH8\n ICcyxiyWy19p5KaHXdUHBzLZ4pIYciWcIhfRttQntw1NU+BN5i5LnoHrmrlFXAypUD6ILvWVyhw\n YlpbmnpbwRGBiGPTcmN38vSWlI9eoz3bEc5R1exU+/fIxfKqw7YZV4FD7URiYWLh5YxJzmpGrUz\n BDZ6yn8764N/+EhiRJGi6Str5OwDCbUCUvSJDvJ6ryxEbWbAzcgMAlWlg2G6PCkpyxiATaMsPeM\n eX9w4gXSFHNLkDv3TW0fL0Ky6swKE8TPALgOymhmbzgGXPpBRI0V0rfFJUSc274o2coxTBcaUMg\n c76Dt2dNp+/f5suAdP24PPR7Qo5cvD+Mhuso6aHkLQ7YtJcHT6WxLZcQ4fJKMWl1UShJXTZ0o85\n n1w/XYy5+I=", "X-Received": "by 2002:a05:6000:184d:b0:43d:e31:68d1 with SMTP id\n ffacd0b85a97d-43fe3dd958amr64858841f8f.21.1777277343559;\n Mon, 27 Apr 2026 01:09:03 -0700 (PDT)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "Markus Armbruster <armbru@redhat.com>,\n\tqemu-devel@nongnu.org", "Subject": "[PATCH v4 12/32] hw/s390x: Reduce 'monitor/monitor.h' inclusions", "Date": "Mon, 27 Apr 2026 10:07:18 +0200", "Message-ID": "<20260427080738.77138-13-philmd@linaro.org>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260427080738.77138-1-philmd@linaro.org>", "References": "<20260427080738.77138-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42d;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "We want to make the HMP commands available for all targets,\nmove the declarations to \"monitor/hmp.h\" where all other\nare, and only include the monitor headers in the source files.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nAcked-by: Cornelia Huck <cohuck@redhat.com>\nReviewed-by: Eric Farman <farman@linux.ibm.com>\n---\n include/hw/s390x/storage-attributes.h | 4 ----\n include/hw/s390x/storage-keys.h | 3 ---\n include/monitor/hmp.h | 5 +++++\n hw/s390x/s390-skeys.c | 2 ++\n hw/s390x/s390-stattrib.c | 2 ++\n 5 files changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/hw/s390x/storage-attributes.h b/include/hw/s390x/storage-attributes.h\nindex 66716a97c05..0305873b019 100644\n--- a/include/hw/s390x/storage-attributes.h\n+++ b/include/hw/s390x/storage-attributes.h\n@@ -13,7 +13,6 @@\n #define S390_STORAGE_ATTRIBUTES_H\n \n #include \"hw/core/qdev.h\"\n-#include \"monitor/monitor.h\"\n #include \"qom/object.h\"\n \n #define TYPE_S390_STATTRIB \"s390-storage_attributes\"\n@@ -72,7 +71,4 @@ static inline Object *kvm_s390_stattrib_create(void)\n }\n #endif\n \n-void hmp_info_cmma(Monitor *mon, const QDict *qdict);\n-void hmp_migrationmode(Monitor *mon, const QDict *qdict);\n-\n #endif /* S390_STORAGE_ATTRIBUTES_H */\ndiff --git a/include/hw/s390x/storage-keys.h b/include/hw/s390x/storage-keys.h\nindex 2d02936c31c..666c05e2996 100644\n--- a/include/hw/s390x/storage-keys.h\n+++ b/include/hw/s390x/storage-keys.h\n@@ -13,7 +13,6 @@\n #define S390_STORAGE_KEYS_H\n \n #include \"hw/core/qdev.h\"\n-#include \"monitor/monitor.h\"\n #include \"qom/object.h\"\n \n #define TYPE_S390_SKEYS \"s390-skeys\"\n@@ -123,8 +122,6 @@ int s390_skeys_set(S390SKeysState *ks, uint64_t start_gfn,\n S390SKeysState *s390_get_skeys_device(void);\n \n void s390_qmp_dump_skeys(const char *filename, Error **errp);\n-void hmp_dump_skeys(Monitor *mon, const QDict *qdict);\n-void hmp_info_skeys(Monitor *mon, const QDict *qdict);\n \n #define TYPE_DUMP_SKEYS_INTERFACE \"dump-skeys-interface\"\n \ndiff --git a/include/monitor/hmp.h b/include/monitor/hmp.h\nindex 9c2330205fc..d694bfdf768 100644\n--- a/include/monitor/hmp.h\n+++ b/include/monitor/hmp.h\n@@ -173,4 +173,9 @@ void hmp_gva2gpa(Monitor *mon, const QDict *qdict);\n void hmp_gpa2hva(Monitor *mon, const QDict *qdict);\n void hmp_gpa2hpa(Monitor *mon, const QDict *qdict);\n \n+void hmp_dump_skeys(Monitor *mon, const QDict *qdict);\n+void hmp_info_skeys(Monitor *mon, const QDict *qdict);\n+void hmp_info_cmma(Monitor *mon, const QDict *qdict);\n+void hmp_migrationmode(Monitor *mon, const QDict *qdict);\n+\n #endif\ndiff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c\nindex d974d97b5e7..7dca67d6618 100644\n--- a/hw/s390x/s390-skeys.c\n+++ b/hw/s390x/s390-skeys.c\n@@ -24,6 +24,8 @@\n #include \"system/kvm.h\"\n #include \"migration/qemu-file-types.h\"\n #include \"migration/register.h\"\n+#include \"monitor/hmp.h\"\n+#include \"monitor/monitor.h\"\n #include \"trace.h\"\n \n #define S390_SKEYS_BUFFER_SIZE (128 * KiB) /* Room for 128k storage keys */\ndiff --git a/hw/s390x/s390-stattrib.c b/hw/s390x/s390-stattrib.c\nindex 2e83aa211cd..74b23b0a995 100644\n--- a/hw/s390x/s390-stattrib.c\n+++ b/hw/s390x/s390-stattrib.c\n@@ -15,6 +15,8 @@\n #include \"system/ram_addr.h\"\n #include \"migration/qemu-file.h\"\n #include \"migration/register.h\"\n+#include \"monitor/hmp.h\"\n+#include \"monitor/monitor.h\"\n #include \"hw/core/qdev-properties.h\"\n #include \"hw/s390x/storage-attributes.h\"\n #include \"qemu/error-report.h\"\n", "prefixes": [ "v4", "12/32" ] }