Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228642/?format=api
{ "id": 2228642, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228642/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260427073424.573672-2-kadlec@netfilter.org/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.1/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260427073424.573672-2-kadlec@netfilter.org>", "date": "2026-04-27T07:34:20", "name": "[1/5] netfilter: ipset: Fix data race between add and list header in all hash types", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "522c2a88b848ad3180e48026c837f6729d66450a", "submitter": { "id": 77226, "url": "http://patchwork.ozlabs.org/api/1.1/people/77226/?format=api", "name": "Jozsef Kadlecsik", "email": "kadlec@netfilter.org" }, "delegate": { "id": 11902, "url": "http://patchwork.ozlabs.org/api/1.1/users/11902/?format=api", "username": "strlen", "first_name": "Florian", "last_name": "Westphal", "email": "fw@strlen.de" }, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260427073424.573672-2-kadlec@netfilter.org/mbox/", "series": [ { "id": 501591, "url": "http://patchwork.ozlabs.org/api/1.1/series/501591/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=501591", "date": "2026-04-27T07:34:21", "name": "netfilter: ipset fixes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501591/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228642/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228642/checks/", "tags": {}, "headers": { "Return-Path": "\n <netfilter-devel+bounces-12208-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=blackhole.kfki.hu header.i=@blackhole.kfki.hu\n header.a=rsa-sha256 header.s=20151130 header.b=D3nmZ+SX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12208-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=blackhole.kfki.hu\n header.i=@blackhole.kfki.hu header.b=\"D3nmZ+SX\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=148.6.0.49", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=blackhole.kfki.hu" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3wM84xrsz1yJX\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 17:35:00 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 305E6300E25B\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 27 Apr 2026 07:34:57 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 020CC379ECC;\n\tMon, 27 Apr 2026 07:34:46 +0000 (UTC)", "from smtp-out.kfki.hu (smtp-out.kfki.hu [148.6.0.49])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5589C377029\n\tfor <netfilter-devel@vger.kernel.org>; Mon, 27 Apr 2026 07:34:34 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby smtp0.kfki.hu (Postfix) with ESMTP id 4g3wLV6ns6z3sbBc;\n\tMon, 27 Apr 2026 09:34:26 +0200 (CEST)", "from smtp0.kfki.hu ([127.0.0.1])\n by localhost (smtp0.kfki.hu [127.0.0.1]) (amavis, port 10026) with ESMTP\n id fVIyqxmZBrlm; Mon, 27 Apr 2026 09:34:25 +0200 (CEST)", "from mentat.rmki.kfki.hu (254C0B05.nat.pool.telekom.hu [37.76.11.5])\n\t(Authenticated sender: kadlecsik.jozsef@wigner.hu)\n\tby smtp0.kfki.hu (Postfix) with ESMTPSA id 4g3wLT043wz3sb8d;\n\tMon, 27 Apr 2026 09:34:24 +0200 (CEST)", "by mentat.rmki.kfki.hu (Postfix, from userid 1000)\n\tid 8304B140B4D; Mon, 27 Apr 2026 09:34:24 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1777275283; cv=none;\n b=mUWSnS+UnIeMxM4Cr/8H8O/jyVXXE6uC4e8svsEhsmGab4mdymN18CWpewLJSio0WTRIlxbt6C0xwbFuTwqs+zlpt6fyy/Or/z9QSTUsU+7aXD6qj0wJ4qGvWZwcU6MphzerWgpZUsXiYrsUk9CJW4++aYWjrpEzfXhraz0DoF8=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1777275283; c=relaxed/simple;\n\tbh=4wu5LlKk2/f9u8cRyU+65DvVW7p02wWn6Zhm/6S8c9w=;\n\th=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:\n\t MIME-Version;\n b=p7mAFcFvk0EdtstF3Dtz17hfnS4yWWlswlD7JhRmY1/Eihpp1XdtZ3EnXIJ1OC6jIag4T+id7n4pc9cs+MTbY5JScHA22Mh7ZBkw5OfWYBChRdTdDc6B686QNIHXTKP5ajEgJJCaRk6wzdnAXD4iyrzsP90BkpuoesoD6IpN3ro=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=blackhole.kfki.hu;\n dkim=pass (1024-bit key) header.d=blackhole.kfki.hu\n header.i=@blackhole.kfki.hu header.b=D3nmZ+SX;\n arc=none smtp.client-ip=148.6.0.49", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tblackhole.kfki.hu; h=mime-version:references:in-reply-to\n\t:x-mailer:message-id:date:date:from:from:received:received\n\t:received; s=20151130; t=1777275265; x=1779089666; bh=PUxz9zUZ66\n\t/vcQ+IhgStDNSiyI/OowhsPncAIBiVeag=; b=D3nmZ+SXqk1moGoS/y8PUPR/ko\n\tpF1scqilbEbqNy4R8fv6VfoDrKzXyCj6fr0fTgBHidTruFv0PPRwoOHV6hp6XW6V\n\tAeyyat/IIfM9mTtPFGAkVOv6YrUVy3pIQbh7ZH6cCACOw8i36LRUMVSs5i0Pfoju\n\tnO/RcH9gVQVXYdsNU=", "X-Virus-Scanned": "Debian amavis at smtp0.kfki.hu", "From": "Jozsef Kadlecsik <kadlec@netfilter.org>", "To": "netfilter-devel@vger.kernel.org", "Cc": "Pablo Neira Ayuso <pablo@netfilter.org>", "Subject": "[PATCH 1/5] netfilter: ipset: Fix data race between add and list\n header in all hash types", "Date": "Mon, 27 Apr 2026 09:34:20 +0200", "Message-Id": "<20260427073424.573672-2-kadlec@netfilter.org>", "X-Mailer": "git-send-email 2.39.5", "In-Reply-To": "<20260427073424.573672-1-kadlec@netfilter.org>", "References": "<20260427073424.573672-1-kadlec@netfilter.org>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "X-deepspam": "maybeham 2%", "Content-Transfer-Encoding": "quoted-printable" }, "content": "The \"ipset list -terse\" command is actually a dump operation which\nmay run parallel with \"ipset add\" commands, which can trigger an\ninternal resizing of the hash type of sets just being dumped. However,\ndumping just the header part of the set was not protected against\nunderlying resizing. Fix it by protecting the header dumping part\nas well.\n\nSigned-off-by: Jozsef Kadlecsik <kadlec@netfilter.org>\n---\n net/netfilter/ipset/ip_set_core.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c\nindex a2fe711cb5e3..2cc04da95afd 100644\n--- a/net/netfilter/ipset/ip_set_core.c\n+++ b/net/netfilter/ipset/ip_set_core.c\n@@ -1648,13 +1648,13 @@ ip_set_dump_do(struct sk_buff *skb, struct netlink_callback *cb)\n \t\t\tif (cb->args[IPSET_CB_PROTO] > IPSET_PROTOCOL_MIN &&\n \t\t\t nla_put_net16(skb, IPSET_ATTR_INDEX, htons(index)))\n \t\t\t\tgoto nla_put_failure;\n+\t\t\tif (set->variant->uref)\n+\t\t\t\tset->variant->uref(set, cb, true);\n \t\t\tret = set->variant->head(set, skb);\n \t\t\tif (ret < 0)\n \t\t\t\tgoto release_refcount;\n \t\t\tif (dump_flags & IPSET_FLAG_LIST_HEADER)\n \t\t\t\tgoto next_set;\n-\t\t\tif (set->variant->uref)\n-\t\t\t\tset->variant->uref(set, cb, true);\n \t\t\tfallthrough;\n \t\tdefault:\n \t\t\tret = set->variant->list(set, skb, cb);\n", "prefixes": [ "1/5" ] }