Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228448/?format=api
{ "id": 2228448, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228448/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-66-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260426134002.865628-66-richard.henderson@linaro.org>", "date": "2026-04-26T13:39:42", "name": "[65/84] fpu: Return struct from parts{64,128}_div", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fd42d50739afbbb138e15d1cb3548b9904f8291b", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/1.1/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-66-richard.henderson@linaro.org/mbox/", "series": [ { "id": 501533, "url": "http://patchwork.ozlabs.org/api/1.1/series/501533/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533", "date": "2026-04-26T13:38:37", "name": "fpu: Export some internals for targets", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501533/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228448/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228448/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=vtkqN7gU;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Sly385tz1yJ1\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:51:26 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGzpe-0000M4-Vw; Sun, 26 Apr 2026 09:47:35 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzoS-000643-Cf\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:46:21 -0400", "from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzoF-0001Zg-M2\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:46:13 -0400", "by mail-pl1-x62c.google.com with SMTP id\n d9443c01a7336-2ad21f437eeso60077045ad.0\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:46:06 -0700 (PDT)", "from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5faa34ea7sm280544085ad.34.2026.04.26.06.46.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:46:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777211166; x=1777815966; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=beW50+D1g4WbAR+Nda9ug1MBM7TyhcdB89Yl6qrMgjA=;\n b=vtkqN7gUuYiVdig1WmW64JLUtJReLXHKSunTdcRyTGgZAKkq14Z6B+IetIx5QsSk++\n tat4f1Mhav6HT0P/EAHWeXQQ5Gye6MShLtNNDY2kJXJ5e5A7me1hbKbrgEuk7oZjjhV+\n RLc29JUQGXYgsGApAUtkcQo28Ogytk+yA7B+F557YLrnwB8AQ0TmMeCKaA4yNy36QMtT\n x4yzk9/G3gnVhuSL9R96aGYCzFU9G6Y8jfhX9huYw2yOoQqurKzBRXgwkfN/Z4n1lGNJ\n qj0+JxTbxJXcDtX814QS6uhnxHtfcLxKrjuEnlO6zwDXsCc95rwXpiCNXiZbyzWkqjk8\n VRpg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777211166; x=1777815966;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=beW50+D1g4WbAR+Nda9ug1MBM7TyhcdB89Yl6qrMgjA=;\n b=LmAF1Fgyma7+HsUeZibfg475yZIhZWoSozKlnfunnFG2cxmAysIem28le0s1KtVNiu\n DricDgrD1C0rFvVl+sNZJ2shNyuyX4WzTKzc1MznBK1zpQFSPpq/GjjG0rxllxf0YOeH\n eUYNbnfGxvj5UVJsiD+VVghLfmTkq4nHnltRcGNPpvGawExFYHEEmdpdYnhmNX+zszUV\n grUeNvm/ZVZscLX2+VNZzinqpL33M9RtAGyz6vFUYii59ALksI//oCTqcHBW8IMP2H4Q\n 16EVy94qMYKLPC6uUhO5BgasToEE8A1CurTlNvdjwevW5MmPp8inqXvtAYLbIMp+P6XF\n paVA==", "X-Gm-Message-State": "AOJu0YzsG5u/7Q5P99JWTJLtEPM895IKtjRe6axU47P5xi1hoSMtY18c\n arfcJWEYJs4qrCXTvVCgoM2y0aISNQAZDdKToPsXVFqTz1mk8YZ7EMU3PHQiEG9k2uBRdfMuyUB\n aBHLHiMk=", "X-Gm-Gg": "AeBDievB1Yahqn2sS7o9bR4sx74Zidhp/zCTPHU6N4gKSFCPugi18rz/VPUCJyVtIYQ\n +2KK5hMApBvIj1vL/oloSF31xCF0U/VCo2x2+VxKGTet3bP5p2GeYuB6h4ppL6sqVsoaYs0TCE8\n 803/W6gX3VF+yBTD1WWmwUU4toBODw5S0P8ISE7Qi3WK1ZQhVyCfnkj/5gM/61j4YWjVao6NmhO\n CiD4xKFfxuDreiYTFuovze7MqTOJsxuKETBOdCwihOS8BLHEpfgvPC937P4KwtwBE4FJExsts+e\n ScV7M8lw6GX/tF3s8apNIsL3Tc5RHyUpFeE7gMTea5B3fYDhymvCnu5KaUDfKXWs62y/xXuwsn5\n g23pTYQVbEp1YqDWanwEOBAAbi6uxueDvXvgQlmMtavDHOY8re9lQyl9L/y3MEEFP/dF/aMOITn\n +wi8XTgAhPrMMUlK0dP5rLQzLLALYNxnP8lY8ryQNWxDYDnscrgK8=", "X-Received": "by 2002:a17:903:166e:b0:2b4:64cf:e8f8 with SMTP id\n d9443c01a7336-2b5f9dbcd22mr362877915ad.2.1777211165515;\n Sun, 26 Apr 2026 06:46:05 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org", "Subject": "[PATCH 65/84] fpu: Return struct from parts{64,128}_div", "Date": "Sun, 26 Apr 2026 23:39:42 +1000", "Message-ID": "<20260426134002.865628-66-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260426134002.865628-1-richard.henderson@linaro.org>", "References": "<20260426134002.865628-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::62c;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Signed-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 34 ++++++++++++++---------------\n fpu/softfloat-parts.c.inc | 45 +++++++++++++++++----------------------\n 2 files changed, 37 insertions(+), 42 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex 246209072e..6d69b61c7f 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -2129,9 +2129,9 @@ float16 float16_div(float16 a, float16 b, float_status *status)\n {\n FloatParts64 pa = float16_unpack_canonical(a, status);\n FloatParts64 pb = float16_unpack_canonical(b, status);\n- FloatParts64 *pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pr = parts64_div(&pa, &pb, status);\n \n- return float16_round_pack_canonical(pr, status);\n+ return float16_round_pack_canonical(&pr, status);\n }\n \n static float32 QEMU_SOFTFLOAT_ATTR\n@@ -2139,9 +2139,9 @@ soft_f32_div(float32 a, float32 b, float_status *status)\n {\n FloatParts64 pa = float32_unpack_canonical(a, status);\n FloatParts64 pb = float32_unpack_canonical(b, status);\n- FloatParts64 *pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pr = parts64_div(&pa, &pb, status);\n \n- return float32_round_pack_canonical(pr, status);\n+ return float32_round_pack_canonical(&pr, status);\n }\n \n static float64 QEMU_SOFTFLOAT_ATTR\n@@ -2149,9 +2149,9 @@ soft_f64_div(float64 a, float64 b, float_status *status)\n {\n FloatParts64 pa = float64_unpack_canonical(a, status);\n FloatParts64 pb = float64_unpack_canonical(b, status);\n- FloatParts64 *pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pr = parts64_div(&pa, &pb, status);\n \n- return float64_round_pack_canonical(pr, status);\n+ return float64_round_pack_canonical(&pr, status);\n }\n \n static float hard_f32_div(float a, float b)\n@@ -2216,9 +2216,9 @@ float64 float64r32_div(float64 a, float64 b, float_status *status)\n {\n FloatParts64 pa = float64_unpack_canonical(a, status);\n FloatParts64 pb = float64_unpack_canonical(b, status);\n- FloatParts64 *pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pr = parts64_div(&pa, &pb, status);\n \n- return float64r32_round_pack_canonical(pr, status);\n+ return float64r32_round_pack_canonical(&pr, status);\n }\n \n bfloat16 QEMU_FLATTEN\n@@ -2226,9 +2226,9 @@ bfloat16_div(bfloat16 a, bfloat16 b, float_status *status)\n {\n FloatParts64 pa = bfloat16_unpack_canonical(a, status);\n FloatParts64 pb = bfloat16_unpack_canonical(b, status);\n- FloatParts64 *pr = parts64_div(&pa, &pb, status);\n+ FloatParts64 pr = parts64_div(&pa, &pb, status);\n \n- return bfloat16_round_pack_canonical(pr, status);\n+ return bfloat16_round_pack_canonical(&pr, status);\n }\n \n float128 QEMU_FLATTEN\n@@ -2236,22 +2236,22 @@ float128_div(float128 a, float128 b, float_status *status)\n {\n FloatParts128 pa = float128_unpack_canonical(a, status);\n FloatParts128 pb = float128_unpack_canonical(b, status);\n- FloatParts128 *pr = parts128_div(&pa, &pb, status);\n+ FloatParts128 pr = parts128_div(&pa, &pb, status);\n \n- return float128_round_pack_canonical(pr, status);\n+ return float128_round_pack_canonical(&pr, status);\n }\n \n floatx80 floatx80_div(floatx80 a, floatx80 b, float_status *status)\n {\n- FloatParts128 pa, pb, *pr;\n+ FloatParts128 pa, pb;\n \n if (!floatx80_unpack_canonical(&pa, a, status) ||\n !floatx80_unpack_canonical(&pb, b, status)) {\n return floatx80_default_nan(status);\n }\n \n- pr = parts128_div(&pa, &pb, status);\n- return floatx80_round_pack_canonical(pr, status);\n+ pa = parts128_div(&pa, &pb, status);\n+ return floatx80_round_pack_canonical(&pa, status);\n }\n \n /*\n@@ -5140,8 +5140,8 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n uint32_t r_flags;\n \n /* Compute precise quotient */\n- q_buf = *a;\n- q = parts64_div(&q_buf, b, status);\n+ q_buf = parts64_div(a, b, status);\n+ q = &q_buf;\n \n /*\n * Check whether two closest integers can be precisely represented,\ndiff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc\nindex 40ea7e3a39..ad53286efc 100644\n--- a/fpu/softfloat-parts.c.inc\n+++ b/fpu/softfloat-parts.c.inc\n@@ -807,68 +807,63 @@ static FloatPartsN *partsN(muladd_scalbn)(FloatPartsN *a, FloatPartsN *b,\n * corresponding value `b'. The operation is performed according to\n * the IEC/IEEE Standard for Binary Floating-Point Arithmetic.\n */\n-static FloatPartsN *partsN(div)(FloatPartsN *a, FloatPartsN *b,\n- float_status *s)\n+static FloatPartsN partsN(div)(const FloatPartsN *a, const FloatPartsN *b,\n+ float_status *s)\n {\n int ab_mask = float_cmask(a->cls) | float_cmask(b->cls);\n- bool sign = a->sign ^ b->sign;\n+ FloatPartsN r = *a;\n+\n+ r.sign ^= b->sign;\n+ r.exp -= b->exp;\n \n if (likely(cmask_is_only_normals(ab_mask))) {\n if (ab_mask & float_cmask_denormal) {\n float_raise(float_flag_input_denormal_used, s);\n }\n- a->sign = sign;\n- a->exp -= b->exp + fracN(div)(a, b);\n- return a;\n+ r.exp -= fracN(div)(&r, b);\n+ return r;\n }\n \n /* 0/0 or Inf/Inf => NaN */\n if (unlikely(ab_mask == float_cmask_zero)) {\n float_raise(float_flag_invalid | float_flag_invalid_zdz, s);\n- goto d_nan;\n+ return partsN(default_nan)(s);\n }\n if (unlikely(ab_mask == float_cmask_inf)) {\n float_raise(float_flag_invalid | float_flag_invalid_idi, s);\n- goto d_nan;\n+ return partsN(default_nan)(s);\n }\n \n /* All the NaN cases */\n if (unlikely(ab_mask & float_cmask_anynan)) {\n- *a = partsN(pick_nan)(a, b, s);\n-\treturn a;\n+ return partsN(pick_nan)(a, b, s);\n }\n \n if ((ab_mask & float_cmask_denormal) && b->cls != float_class_zero) {\n float_raise(float_flag_input_denormal_used, s);\n }\n \n- a->sign = sign;\n-\n /* Inf / X */\n- if (a->cls == float_class_inf) {\n- return a;\n+ if (r.cls == float_class_inf) {\n+ return r;\n }\n \n /* 0 / X */\n- if (a->cls == float_class_zero) {\n- return a;\n+ if (r.cls == float_class_zero) {\n+ return r;\n }\n \n /* X / Inf */\n if (b->cls == float_class_inf) {\n- a->cls = float_class_zero;\n- return a;\n+ r.cls = float_class_zero;\n+ return r;\n }\n \n /* X / 0 => Inf */\n- g_assert(b->cls == float_class_zero);\n+ assert(b->cls == float_class_zero);\n float_raise(float_flag_divbyzero, s);\n- a->cls = float_class_inf;\n- return a;\n-\n- d_nan:\n- *a = partsN(default_nan)(s);\n- return a;\n+ r.cls = float_class_inf;\n+ return r;\n }\n \n /*\n", "prefixes": [ "65/84" ] }