Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228434/?format=api
{ "id": 2228434, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228434/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-3-richard.henderson@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260426134002.865628-3-richard.henderson@linaro.org>", "date": "2026-04-26T13:38:39", "name": "[02/84] fpu: Drop parts_uncanon", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "77d6b3706e71cb2b333da4e4c8c25514f5986ac5", "submitter": { "id": 72104, "url": "http://patchwork.ozlabs.org/api/1.1/people/72104/?format=api", "name": "Richard Henderson", "email": "richard.henderson@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260426134002.865628-3-richard.henderson@linaro.org/mbox/", "series": [ { "id": 501533, "url": "http://patchwork.ozlabs.org/api/1.1/series/501533/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501533", "date": "2026-04-26T13:38:37", "name": "fpu: Export some internals for targets", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501533/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228434/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228434/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=cGkoZjkk;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g3Sk72cPVz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 23:49:51 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wGzis-0006w3-9p; Sun, 26 Apr 2026 09:40:34 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzie-0006qY-6v\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:20 -0400", "from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <richard.henderson@linaro.org>)\n id 1wGzia-0008Fs-Pu\n for qemu-devel@nongnu.org; Sun, 26 Apr 2026 09:40:19 -0400", "by mail-pl1-x634.google.com with SMTP id\n d9443c01a7336-2a8fba3f769so41654215ad.2\n for <qemu-devel@nongnu.org>; Sun, 26 Apr 2026 06:40:15 -0700 (PDT)", "from stoup.. ([180.233.125.15]) by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b5fab30f29sm277940375ad.68.2026.04.26.06.40.11\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 26 Apr 2026 06:40:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1777210814; x=1777815614; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2jIspN7Eqx+KKzfnFI2Tg1oMhKcfN1oaYCYjnDfppv8=;\n b=cGkoZjkkewP78dNyhMh/9+FicRJlOqtY2l0cqD8Pg2MbImOvyVwC2ABO9LK4GbN7G4\n 1K7ZxiOnRasUt4moJnj4lCI+AJ6PxuT+bo7o3pOgmbCzzAvBri4a/LxRWnVzl265E/Qb\n xW6VmP3xX2LM5OoZJ/EFi8cvJGzY8jVGanqMy5LB3M96JqXJiniDEbbiKcmgQ7YuMzRC\n rVEYxCeJAhM9qIQCuR6WWA2I4S4U//u22U53Fz4qzwaJXnJaft4Y4ktdHz2VsEnUhLGO\n jfJrFyMPTgCBo3wQHL80D+4EKvtzllYtWe1xJHDx9jyPImXMKvymnh+1TJjeUYIpuqJY\n AOXQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1777210814; x=1777815614;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=2jIspN7Eqx+KKzfnFI2Tg1oMhKcfN1oaYCYjnDfppv8=;\n b=FWBaa0i7mSa9WgXqXHdGfoMuP7+C9qo0rLTDZZeX2+bKSY0w3nJV2SwtEkjFJbEekJ\n +8SvQalYE/29X83coSi3/Hj3RyAt87IdcXH5/l9ptAjVoSX6iffkLEZEoDAW/u+zvPWi\n ZKBJCHD67pUI8be/g3XgCBgp3PhXn+BLZHO9Mo2O8x+lfscPVKVxc9XTeQcK8a8MtfuX\n VhB1i8Cc/KuUdQYLpsQE2cugl9fi8hu3JqmD4PjzIUeX0Ls2tL56MYwnNw7PNFo1MRc7\n HJr8QnYZt5Gc+YPzFS3Rdz6vIZh1GY85zCCoQRzpX3CXecPzHa0+iWrXwSAlnLJ9acSR\n 6zTA==", "X-Gm-Message-State": "AOJu0YwpjBO7PgvKhAxsd3nEBukI+wy0afj0osnCX0XkvC3jTWH3R1vw\n QD+5rBw7Em4X9fCRuT+3XMcwdSNXUAy5HlQ41NE0fe9Upe+Bua87zP0FUrJiUZHs9monsbWLCo2\n JUMClnUA=", "X-Gm-Gg": "AeBDietKJgmrL5lbwmcazDdqVDuB4fNSAn3Aywl65Boa6SdFW1eMfRxJRRr+IGeVWjA\n 38cIGMlzvrOIA4tJwFOdDjMpUepcjX3ynOjFxPKhClmp3tkye6aRE7e6uE6f4RPS7lOC4xrnnsc\n 2yBXYlCsh5s0LpGC6NXan7dlQdQxV01+fpD1uvSvMZYHwsG3ak6y22sJxjTSSS7lor8Wbjp0wDB\n qCA9CkxLbLktxZNmp/1gsAbpS500jxyTqkxCZM647BRF8AJpgSyauW98xSZXEy+meGU2zXKhiVo\n 4p1wt79NIk9XLC5BNs0vvnaFrLV3OrqOyK40KaYEp9hpRvZJlemWSU2ZdRVHzzq8xcigshVbbww\n 6hZfpXTUiejOkqvh2MW3Cdh5NCOiNmArEQxDXh0mmiMQAmPL7bz4JbSnX79rV2TjZHws5l0D71Q\n 8Twlx49qS5+ESb+0WwpKZowoDNpJ8gsCitiZlySZKP", "X-Received": "by 2002:a17:903:3905:b0:2b0:7e4d:f43f with SMTP id\n d9443c01a7336-2b5f9ffe73amr379940045ad.41.1777210814005;\n Sun, 26 Apr 2026 06:40:14 -0700 (PDT)", "From": "Richard Henderson <richard.henderson@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-arm@nongnu.org,\n\tqemu-s390x@nongnu.org", "Subject": "[PATCH 02/84] fpu: Drop parts_uncanon", "Date": "Sun, 26 Apr 2026 23:38:39 +1000", "Message-ID": "<20260426134002.865628-3-richard.henderson@linaro.org>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260426134002.865628-1-richard.henderson@linaro.org>", "References": "<20260426134002.865628-1-richard.henderson@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2607:f8b0:4864:20::634;\n envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Use parts{64,128}_uncanon at each call site.\n\nSigned-off-by: Richard Henderson <richard.henderson@linaro.org>\n---\n fpu/softfloat.c | 44 ++++++++++++++++++--------------------------\n 1 file changed, 18 insertions(+), 26 deletions(-)", "diff": "diff --git a/fpu/softfloat.c b/fpu/softfloat.c\nindex f9997f5236..7c13a7848e 100644\n--- a/fpu/softfloat.c\n+++ b/fpu/softfloat.c\n@@ -814,14 +814,6 @@ static void parts128_uncanon_normal(FloatParts128 *p, float_status *status,\n #define parts_uncanon_normal(A, S, F, X) \\\n PARTS_GENERIC_64_128(uncanon_normal, A)(A, S, F, X)\n \n-static void parts64_uncanon(FloatParts64 *p, float_status *status,\n- const FloatFmt *fmt, bool saturate);\n-static void parts128_uncanon(FloatParts128 *p, float_status *status,\n- const FloatFmt *fmt, bool saturate);\n-\n-#define parts_uncanon(A, S, F, X) \\\n- PARTS_GENERIC_64_128(uncanon, A)(A, S, F, X)\n-\n static void parts64_add_normal(FloatParts64 *a, FloatParts64 *b);\n static void parts128_add_normal(FloatParts128 *a, FloatParts128 *b);\n static void parts256_add_normal(FloatParts256 *a, FloatParts256 *b);\n@@ -1756,7 +1748,7 @@ static float8_e4m3 float8_e4m3_round_pack_canonical(FloatParts64 *p,\n float_status *s,\n bool saturate)\n {\n- parts_uncanon(p, s, &float8_e4m3_params, saturate);\n+ parts64_uncanon(p, s, &float8_e4m3_params, saturate);\n return float8_e4m3_pack_raw(p);\n }\n \n@@ -1764,7 +1756,7 @@ static float8_e5m2 float8_e5m2_round_pack_canonical(FloatParts64 *p,\n float_status *s,\n bool saturate)\n {\n- parts_uncanon(p, s, &float8_e5m2_params, saturate);\n+ parts64_uncanon(p, s, &float8_e5m2_params, saturate);\n return float8_e5m2_pack_raw(p);\n }\n \n@@ -1772,7 +1764,7 @@ static float16 float16a_round_pack_canonical(FloatParts64 *p,\n float_status *s,\n const FloatFmt *params)\n {\n- parts_uncanon(p, s, params, false);\n+ parts64_uncanon(p, s, params, false);\n return float16_pack_raw(p);\n }\n \n@@ -1785,7 +1777,7 @@ static float16 float16_round_pack_canonical(FloatParts64 *p,\n static bfloat16 bfloat16_round_pack_canonical(FloatParts64 *p,\n float_status *s)\n {\n- parts_uncanon(p, s, &bfloat16_params, false);\n+ parts64_uncanon(p, s, &bfloat16_params, false);\n return bfloat16_pack_raw(p);\n }\n \n@@ -1799,7 +1791,7 @@ static void float32_unpack_canonical(FloatParts64 *p, float32 f,\n static float32 float32_round_pack_canonical(FloatParts64 *p,\n float_status *s)\n {\n- parts_uncanon(p, s, &float32_params, false);\n+ parts64_uncanon(p, s, &float32_params, false);\n return float32_pack_raw(p);\n }\n \n@@ -1813,14 +1805,14 @@ static void float64_unpack_canonical(FloatParts64 *p, float64 f,\n static float64 float64_round_pack_canonical(FloatParts64 *p,\n float_status *s)\n {\n- parts_uncanon(p, s, &float64_params, false);\n+ parts64_uncanon(p, s, &float64_params, false);\n return float64_pack_raw(p);\n }\n \n static float64 float64r32_pack_raw(FloatParts64 *p)\n {\n /*\n- * In parts_uncanon, we placed the fraction for float32 at the lsb.\n+ * In parts64_uncanon, we placed the fraction for float32 at the lsb.\n * We need to adjust the fraction higher so that the least N bits are\n * zero, and the fraction is adjacent to the float64 implicit bit.\n */\n@@ -1862,7 +1854,7 @@ static float64 float64r32_pack_raw(FloatParts64 *p)\n static float64 float64r32_round_pack_canonical(FloatParts64 *p,\n float_status *s)\n {\n- parts_uncanon(p, s, &float32_params, false);\n+ parts64_uncanon(p, s, &float32_params, false);\n return float64r32_pack_raw(p);\n }\n \n@@ -1876,7 +1868,7 @@ static void float128_unpack_canonical(FloatParts128 *p, float128 f,\n static float128 float128_round_pack_canonical(FloatParts128 *p,\n float_status *s)\n {\n- parts_uncanon(p, s, &float128_params, false);\n+ parts128_uncanon(p, s, &float128_params, false);\n return float128_pack_raw(p);\n }\n \n@@ -1924,7 +1916,7 @@ static floatx80 floatx80_round_pack_canonical(FloatParts128 *p,\n case float_class_normal:\n case float_class_denormal:\n if (s->floatx80_rounding_precision == floatx80_precision_x) {\n- parts_uncanon_normal(p, s, fmt, false);\n+ parts128_uncanon_normal(p, s, fmt, false);\n frac = p->frac_hi;\n exp = p->exp;\n } else {\n@@ -1933,7 +1925,7 @@ static floatx80 floatx80_round_pack_canonical(FloatParts128 *p,\n p64.sign = p->sign;\n p64.exp = p->exp;\n frac_truncjam(&p64, p);\n- parts_uncanon_normal(&p64, s, fmt, false);\n+ parts64_uncanon_normal(&p64, s, fmt, false);\n frac = p64.frac;\n exp = p64.exp;\n }\n@@ -2331,7 +2323,7 @@ float16_muladd_scalbn(float16 a, float16 b, float16 c,\n pr = parts_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n- parts_uncanon(pr, status, &float16_params, false);\n+ parts64_uncanon(pr, status, &float16_params, false);\n if ((flags & float_muladd_negate_result) && !is_nan(pr->cls)) {\n pr->sign ^= 1;\n }\n@@ -2356,7 +2348,7 @@ float32_muladd_scalbn(float32 a, float32 b, float32 c,\n pr = parts_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n- parts_uncanon(pr, status, &float32_params, false);\n+ parts64_uncanon(pr, status, &float32_params, false);\n if ((flags & float_muladd_negate_result) && !is_nan(pr->cls)) {\n pr->sign ^= 1;\n }\n@@ -2375,7 +2367,7 @@ float64_muladd_scalbn(float64 a, float64 b, float64 c,\n pr = parts_muladd_scalbn(&pa, &pb, &pc, scale, flags, status);\n \n /* Round before applying negate result. */\n- parts_uncanon(pr, status, &float64_params, false);\n+ parts64_uncanon(pr, status, &float64_params, false);\n if ((flags & float_muladd_negate_result) && !is_nan(pr->cls)) {\n pr->sign ^= 1;\n }\n@@ -2534,7 +2526,7 @@ float64 float64r32_muladd(float64 a, float64 b, float64 c,\n pr = parts_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n- parts_uncanon(pr, status, &float32_params, false);\n+ parts64_uncanon(pr, status, &float32_params, false);\n if ((flags & float_muladd_negate_result) && !is_nan(pr->cls)) {\n pr->sign ^= 1;\n }\n@@ -2552,7 +2544,7 @@ bfloat16 QEMU_FLATTEN bfloat16_muladd(bfloat16 a, bfloat16 b, bfloat16 c,\n pr = parts_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n- parts_uncanon(pr, status, &bfloat16_params, false);\n+ parts64_uncanon(pr, status, &bfloat16_params, false);\n if ((flags & float_muladd_negate_result) && !is_nan(pr->cls)) {\n pr->sign ^= 1;\n }\n@@ -2570,7 +2562,7 @@ float128 QEMU_FLATTEN float128_muladd(float128 a, float128 b, float128 c,\n pr = parts_muladd_scalbn(&pa, &pb, &pc, 0, flags, status);\n \n /* Round before applying negate result. */\n- parts_uncanon(pr, status, &float128_params, false);\n+ parts128_uncanon(pr, status, &float128_params, false);\n if ((flags & float_muladd_negate_result) && !is_nan(pr->cls)) {\n pr->sign ^= 1;\n }\n@@ -5600,7 +5592,7 @@ static void parts_s390_divide_to_integer(FloatParts64 *a, FloatParts64 *b,\n /* Round remainder to the target format */\n *r = *r_precise;\n status->float_exception_flags = 0;\n- parts_uncanon(r, status, fmt, false);\n+ parts64_uncanon(r, status, fmt, false);\n r_flags = status->float_exception_flags;\n r->frac &= (1ULL << fmt->frac_size) - 1;\n parts64_canonicalize(r, status, fmt);\n", "prefixes": [ "02/84" ] }