Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228330/?format=api
{ "id": 2228330, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228330/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/patch/20260426000339.57049-1-sashal@kernel.org/", "project": { "id": 60, "url": "http://patchwork.ozlabs.org/api/1.1/projects/60/?format=api", "name": "User-mode Linux Development", "link_name": "linux-um", "list_id": "linux-um.lists.infradead.org", "list_email": "linux-um@lists.infradead.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260426000339.57049-1-sashal@kernel.org>", "date": "2026-04-26T00:03:39", "name": "um: Consolidate MAGIC_SYSRQ into generic Kconfig definition", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9721cf87ac575ba29cee3a851bd86cbed61e6c57", "submitter": { "id": 75065, "url": "http://patchwork.ozlabs.org/api/1.1/people/75065/?format=api", "name": "Sasha Levin", "email": "sashal@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-um/patch/20260426000339.57049-1-sashal@kernel.org/mbox/", "series": [ { "id": 501496, "url": "http://patchwork.ozlabs.org/api/1.1/series/501496/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-um/list/?series=501496", "date": "2026-04-26T00:03:39", "name": "um: Consolidate MAGIC_SYSRQ into generic Kconfig definition", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501496/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228330/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228330/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=qwbj+2yo;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=QZfBuGEw;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g36PB6XWPz1yHv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 10:03:52 +1000 (AEST)", "from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wGmyN-0000000F5vx-2fDd;\n\tSun, 26 Apr 2026 00:03:43 +0000", "from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wGmyL-0000000F5vb-33Kb\n\tfor linux-um@lists.infradead.org;\n\tSun, 26 Apr 2026 00:03:42 +0000", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 6026744056;\n\tSun, 26 Apr 2026 00:03:41 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 8F96CC2BCB0;\n\tSun, 26 Apr 2026 00:03:40 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help\n\t:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding:\n\tContent-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:\n\tContent-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:\n\tResent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner;\n\tbh=FaiLW/pVXClx0hGhS3rNh2hU+gA/RQ/q+swTpIKpuX4=; b=qwbj+2yo+qh+7jKnuUmrp7dw0j\n\tCT73sG9zMfE1x1Id4WKkXhkx4MBIochxDZ1FTB9laPL/aZnYAs4w+L067l8JkHndGecUUKo+YUIuz\n\tgg74jqxYREDbJWDXK9Tj8pRvT74Q1BlFGk86POIPhuHWUv5V80/Mm+txEewHB57LzZMR9VZE4aQDd\n\tJmyDKyiCQyKQ+B6GJjzNJKiWrzpYMIlBTIKn+aAmns4DO2WoHbrQ8Z6NU4RtB67Zlw2tjw603rpJU\n\t9zMYPu+W9+Y6Wug6NSLah8nj+eXcaIjQxPmvhXwh/MxiYUXbUB3EEVblWUXcJrSbG/NhNYd1JDkXI\n\t450FRKwA==;", "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1777161821;\n\tbh=l0kIGOnwEOk/z/NCHNJe/hFxFNb+wlfcj7Roc12943g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=QZfBuGEwfNmc903opHbEC2LM1hIjcYDq/xfEddYzpJK9w0JLj84Y1tK6RmZUMzMq+\n\t hhcEU0eDJ581PMmJTWzs69zze7rrClxHxmETLJ6OwFVAzxzA8p4DwZCM6DUUtB3HRf\n\t c/yXvFhh1KMSZrmAoZfljdvj4tIiOjwL08DhAB2qdS4t2jnxwLh3uVXvKtABMD0Ast\n\t u2PoDEb4fkH/QPi4cSxHTPqtj18Ke/Alnjg+Ul0pF11pZkv2wz65jdUyOHed3Wh5m0\n\t 7hAUzotbSfTQObc+TYJgHt9MMnk/3PVvkZq9S5IZVtkRd4rC3d8lxszGHLyQFLc9Of\n\t tw9GkrTcY2nTQ==" ], "From": "Sasha Levin <sashal@kernel.org>", "To": "Richard Weinberger <richard@nod.at>", "Cc": "Anton Ivanov <anton.ivanov@cambridgegreys.com>,\n\tJohannes Berg <johannes@sipsolutions.net>,\n\tAndrew Morton <akpm@linux-foundation.org>,\n\tlinux-um@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org", "Subject": "[PATCH] um: Consolidate MAGIC_SYSRQ into generic Kconfig definition", "Date": "Sat, 25 Apr 2026 20:03:39 -0400", "Message-ID": "<20260426000339.57049-1-sashal@kernel.org>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-CRM114-Version": "20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ", "X-CRM114-CacheID": "sfid-20260425_170341_831333_F00979E5 ", "X-CRM114-Status": "GOOD ( 16.04 )", "X-Spam-Score": "-2.1 (--)", "X-Spam-Report": "Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: kconfiglint reports: K008: config MAGIC_SYSRQ has prompts\n in 2 separate definitions MAGIC_SYSRQ is defined in two places with\n complementary\n conditions:\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.0 SPF_PASS SPF: sender matches SPF record\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender", "X-BeenThere": "linux-um@lists.infradead.org", "X-Mailman-Version": "2.1.34", "Precedence": "list", "List-Id": "<linux-um.lists.infradead.org>", "List-Unsubscribe": "<http://lists.infradead.org/mailman/options/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=unsubscribe>", "List-Archive": "<http://lists.infradead.org/pipermail/linux-um/>", "List-Post": "<mailto:linux-um@lists.infradead.org>", "List-Help": "<mailto:linux-um-request@lists.infradead.org?subject=help>", "List-Subscribe": "<http://lists.infradead.org/mailman/listinfo/linux-um>,\n <mailto:linux-um-request@lists.infradead.org?subject=subscribe>", "Sender": "\"linux-um\" <linux-um-bounces@lists.infradead.org>", "Errors-To": "linux-um-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org" }, "content": "kconfiglint reports:\n\n K008: config MAGIC_SYSRQ has prompts in 2 separate definitions\n\nMAGIC_SYSRQ is defined in two places with complementary conditions:\n\n arch/um/Kconfig:213 — depends on MCONSOLE (UML only)\n lib/Kconfig.debug:665 — depends on !UML (everything except UML)\n\nThe UML definition has existed since the initial git import in\ncommit 1da177e4c3f4 (\"Linux-2.6.12-rc2\"). UML needs MAGIC_SYSRQ to work\nthrough its mconsole interface rather than through keyboard input, so the\nUML version depends on MCONSOLE while the generic version excludes UML\nentirely with `depends on !UML`.\n\nThese two definitions are logically complementary: on UML, MAGIC_SYSRQ\nrequires MCONSOLE; on everything else, it has no special dependencies.\nThis can be expressed as a single definition with\n`depends on !UML || MCONSOLE`, which evaluates to:\n - On UML: requires MCONSOLE (same as before)\n - On non-UML: always satisfiable (same as before)\n\nConsolidate into the generic definition in lib/Kconfig.debug by changing\nthe dependency to `depends on !UML || MCONSOLE` and merging the UML-\nspecific help text that explains the mconsole-based sysrq interface.\nRemove the now-redundant definition from arch/um/Kconfig.\n\nThis follows the same unification pattern used by commit 7bd291abe2da\n(\"sched: Unify the SCHED_{SMT,CLUSTER,MC} Kconfig\") and our earlier\nSCHED_MC consolidation for SH.\n\nNo functional change — the resulting Kconfig behavior is identical.\n\nAssisted-by: Claude:claude-opus-4-6 kconfiglint\nSigned-off-by: Sasha Levin <sashal@kernel.org>\n---\n arch/um/Kconfig | 19 -------------------\n lib/Kconfig.debug | 10 ++++++----\n 2 files changed, 6 insertions(+), 23 deletions(-)", "diff": "diff --git a/arch/um/Kconfig b/arch/um/Kconfig\nindex d9541d13d9eb0..5af245ede463f 100644\n--- a/arch/um/Kconfig\n+++ b/arch/um/Kconfig\n@@ -210,25 +210,6 @@ config MCONSOLE\n \n \t It is safe to say 'Y' here.\n \n-config MAGIC_SYSRQ\n-\tbool \"Magic SysRq key\"\n-\tdepends on MCONSOLE\n-\thelp\n-\t If you say Y here, you will have some control over the system even\n-\t if the system crashes for example during kernel debugging (e.g., you\n-\t will be able to flush the buffer cache to disk, reboot the system\n-\t immediately or dump some status information). A key for each of the\n-\t possible requests is provided.\n-\n-\t This is the feature normally accomplished by pressing a key\n-\t while holding SysRq (Alt+PrintScreen).\n-\n-\t On UML, this is accomplished by sending a \"sysrq\" command with\n-\t mconsole, followed by the letter for the requested command.\n-\n-\t The keys are documented in <file:Documentation/admin-guide/sysrq.rst>. Don't say Y\n-\t unless you really know what this hack does.\n-\n config KERNEL_STACK_ORDER\n \tint \"Kernel stack size order\"\n \tdefault 2 if 64BIT\ndiff --git a/lib/Kconfig.debug b/lib/Kconfig.debug\nindex 8ff5adcfe1e0a..695e118f910fb 100644\n--- a/lib/Kconfig.debug\n+++ b/lib/Kconfig.debug\n@@ -664,7 +664,7 @@ menu \"Generic Kernel Debugging Instruments\"\n \n config MAGIC_SYSRQ\n \tbool \"Magic SysRq key\"\n-\tdepends on !UML\n+\tdepends on !UML || MCONSOLE\n \thelp\n \t If you say Y here, you will have some control over the system even\n \t if the system crashes for example during kernel debugging (e.g., you\n@@ -672,9 +672,11 @@ config MAGIC_SYSRQ\n \t immediately or dump some status information). This is accomplished\n \t by pressing various keys while holding SysRq (Alt+PrintScreen). It\n \t also works on a serial console (on PC hardware at least), if you\n-\t send a BREAK and then within 5 seconds a command keypress. The\n-\t keys are documented in <file:Documentation/admin-guide/sysrq.rst>.\n-\t Don't say Y unless you really know what this hack does.\n+\t send a BREAK and then within 5 seconds a command keypress. On UML,\n+\t this is accomplished by sending a \"sysrq\" command with mconsole,\n+\t followed by the letter for the requested command. The keys are\n+\t documented in <file:Documentation/admin-guide/sysrq.rst>. Don't say\n+\t Y unless you really know what this hack does.\n \n config MAGIC_SYSRQ_DEFAULT_ENABLE\n \thex \"Enable magic SysRq key functions by default\"\n", "prefixes": [] }