Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228257/?format=api
{ "id": 2228257, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228257/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260424173151.371134-5-harsimransingh.tungal@arm.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260424173151.371134-5-harsimransingh.tungal@arm.com>", "date": "2026-04-24T17:31:43", "name": "[04/12] efi_loader: enable EFI runtime SetVariable()/GetVariable() using FF-A transport", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "518c7c87b3998a2c01549d6534d267ff5d763da7", "submitter": { "id": 88701, "url": "http://patchwork.ozlabs.org/api/1.1/people/88701/?format=api", "name": "Harsimran Singh Tungal", "email": "harsimransingh.tungal@arm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260424173151.371134-5-harsimransingh.tungal@arm.com/mbox/", "series": [ { "id": 501471, "url": "http://patchwork.ozlabs.org/api/1.1/series/501471/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=501471", "date": "2026-04-24T17:31:50", "name": "arm64: FF-A runtime transport for EFI variables", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501471/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228257/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228257/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256\n header.s=foss header.b=d9oD9fTN;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=fail (p=none dis=none) header.from=arm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=arm.com header.i=@arm.com header.b=\"d9oD9fTN\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=arm.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=harsimransingh.tungal@arm.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2yRM11Rhz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 04:05:19 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DF50C844E4;\n\tSat, 25 Apr 2026 20:02:48 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 12E9680087; Sat, 25 Apr 2026 19:01:54 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by phobos.denx.de (Postfix) with ESMTP id C86A5843F3\n for <u-boot@lists.denx.de>; Sat, 25 Apr 2026 19:01:46 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 385BD35A4;\n Fri, 24 Apr 2026 10:32:37 -0700 (PDT)", "from e132995.arm.com (unknown [10.57.64.144])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 007363F7B4;\n Fri, 24 Apr 2026 10:32:40 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss;\n t=1777051962; bh=o25mbI5+VH/4QVNB7QXTgECO/6BXCMNh6anOaf4gBlA=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=d9oD9fTN330CcEhoZ4VfVxtcVVd8+fNWs002Hy7R7dO7I2OKGUJNVFV/S6s6RohAA\n pupmeCohV3hgbbe3mdLuM2QmrirG6wqX6PlBLGExYA8TpGY2SQKfcZZytTLCUOvapk\n d7Qs5xXZ5mxKs1EOyN2/CjkMqQLmzJpZwGN+BFH8=", "From": "Harsimran Singh Tungal <harsimransingh.tungal@arm.com>", "To": "u-boot@lists.denx.de", "Cc": "Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>,\n Tom Rini <trini@konsulko.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Hugues Kamba Mpiana <hugues.kambampiana@arm.com>,\n Simon Glass <sjg@chromium.org>,\n Harsimran Singh Tungal <harsimransingh.tungal@arm.com>", "Subject": "[PATCH 04/12] efi_loader: enable EFI runtime\n SetVariable()/GetVariable() using FF-A transport", "Date": "Fri, 24 Apr 2026 18:31:43 +0100", "Message-Id": "<20260424173151.371134-5-harsimransingh.tungal@arm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260424173151.371134-1-harsimransingh.tungal@arm.com>", "References": "<20260424173151.371134-1-harsimransingh.tungal@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Sat, 25 Apr 2026 20:02:44 +0200", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Route EFI runtime variable APIs through FF-A MM communication\n\nThis patch implements full EFI Runtime Variable Services (GetVariable,\nSetVariable, GetNextVariableName, and QueryVariableInfo) using the\nFF-A/MM communication backend. Once ExitBootServices() has been invoked,\nall variable operations now use the runtime-safe FF-A transport instead\nof the boot-time communication paths.\n\nKey changes:\n============\n\n - Add runtime-safe variable property handling via FF-A MM SP.\n - Add runtime versions of variable access and property operations.\n - Replace all standard memory operations with EFI-runtime-safe variants.\n\nSigned-off-by: Harsimran Singh Tungal <harsimransingh.tungal@arm.com>\n---\n lib/charset.c | 2 +-\n lib/efi_loader/efi_variable_tee.c | 322 +++++++++++++++++++++++++++++-\n 2 files changed, 318 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/charset.c b/lib/charset.c\nindex 182c92a50c4..738ad1352de 100644\n--- a/lib/charset.c\n+++ b/lib/charset.c\n@@ -407,7 +407,7 @@ size_t __efi_runtime u16_strnlen(const u16 *in, size_t count)\n \treturn i;\n }\n \n-size_t u16_strsize(const void *in)\n+size_t __efi_runtime u16_strsize(const void *in)\n {\n \treturn (u16_strlen(in) + 1) * sizeof(u16);\n }\ndiff --git a/lib/efi_loader/efi_variable_tee.c b/lib/efi_loader/efi_variable_tee.c\nindex e4d97dc55ab..30687c21b8e 100644\n--- a/lib/efi_loader/efi_variable_tee.c\n+++ b/lib/efi_loader/efi_variable_tee.c\n@@ -859,6 +859,38 @@ out:\n \treturn ret;\n }\n \n+static efi_status_t __efi_runtime set_property_int_runtime(const u16 *variable_name,\n+\t\t\t\t\t\t\t efi_uintn_t name_size,\n+\t\t\t\t\t\t\t const efi_guid_t *vendor,\n+\t\t\t\t\t\t\t struct var_check_property *var_property)\n+{\n+\tstruct smm_variable_var_check_property *smm_property;\n+\tefi_uintn_t payload_size;\n+\tu8 *comm_buf = NULL;\n+\tefi_status_t ret;\n+\n+\tpayload_size = sizeof(*smm_property) + name_size;\n+\tif (payload_size > max_payload_size) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\tcomm_buf = setup_mm_hdr((void **)&smm_property, payload_size,\n+\t\t\t\tSMM_VARIABLE_FUNCTION_VAR_CHECK_VARIABLE_PROPERTY_SET,\n+\t\t\t\t&ret);\n+\tif (!comm_buf)\n+\t\treturn ret;\n+\n+\tefi_memcpy_runtime(&smm_property->guid, vendor, sizeof(*vendor));\n+\tsmm_property->name_size = name_size;\n+\tefi_memcpy_runtime(&smm_property->property, var_property,\n+\t\t\t sizeof(smm_property->property));\n+\tefi_memcpy_runtime(smm_property->name, variable_name, name_size);\n+\n+\tret = mm_communicate_runtime(comm_buf, payload_size);\n+\n+\treturn ret;\n+}\n+\n static efi_status_t get_property_int(const u16 *variable_name,\n \t\t\t\t efi_uintn_t name_size,\n \t\t\t\t const efi_guid_t *vendor,\n@@ -904,6 +936,49 @@ out:\n \treturn ret;\n }\n \n+static efi_status_t __efi_runtime get_property_int_runtime(const u16 *variable_name,\n+\t\t\t\t\t\t\t efi_uintn_t name_size,\n+\t\t\t\t\t\t\t const efi_guid_t *vendor,\n+\t\t\t\t\t\t\t struct var_check_property *var_property)\n+{\n+\tstruct smm_variable_var_check_property *smm_property;\n+\tefi_uintn_t payload_size;\n+\tu8 *comm_buf = NULL;\n+\tefi_status_t ret;\n+\n+\tefi_memset_runtime(var_property, 0, sizeof(*var_property));\n+\tpayload_size = sizeof(*smm_property) + name_size;\n+\tif (payload_size > max_payload_size) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\tcomm_buf = setup_mm_hdr((void **)&smm_property, payload_size,\n+\t\t\t\tSMM_VARIABLE_FUNCTION_VAR_CHECK_VARIABLE_PROPERTY_GET,\n+\t\t\t\t&ret);\n+\tif (!comm_buf)\n+\t\treturn ret;\n+\n+\tefi_memcpy_runtime(&smm_property->guid, vendor, sizeof(smm_property->guid));\n+\tsmm_property->name_size = name_size;\n+\tefi_memcpy_runtime(smm_property->name, variable_name, name_size);\n+\n+\tret = mm_communicate_runtime(comm_buf, payload_size);\n+\t/*\n+\t * Currently only R/O property is supported in StMM.\n+\t * Variables that are not set to R/O will not set the property in StMM\n+\t * and the call will return EFI_NOT_FOUND. We are setting the\n+\t * properties to 0x0 so checking against that is enough for the\n+\t * EFI_NOT_FOUND case.\n+\t */\n+\tif (ret == EFI_NOT_FOUND)\n+\t\tret = EFI_SUCCESS;\n+\tif (ret != EFI_SUCCESS)\n+\t\treturn ret;\n+\tefi_memcpy_runtime(var_property, &smm_property->property, sizeof(*var_property));\n+\n+\treturn ret;\n+}\n+\n efi_status_t efi_get_variable_int(const u16 *variable_name,\n \t\t\t\t const efi_guid_t *vendor,\n \t\t\t\t u32 *attributes, efi_uintn_t *data_size,\n@@ -991,6 +1066,92 @@ out:\n \treturn ret;\n }\n \n+efi_status_t __efi_runtime efi_get_variable_runtime(u16 *variable_name,\n+\t\t\t\t\t\t const efi_guid_t *vendor,\n+\t\t\t\t\t\t u32 *attributes,\n+\t\t\t\t\t\t efi_uintn_t *data_size,\n+\t\t\t\t\t\t void *data)\n+{\n+\tstruct var_check_property var_property;\n+\tstruct smm_variable_access *var_acc;\n+\tefi_uintn_t payload_size;\n+\tefi_uintn_t name_size;\n+\tefi_uintn_t tmp_dsize;\n+\tu8 *comm_buf = NULL;\n+\tefi_status_t ret, tmp;\n+\n+\tif (!variable_name || !vendor || !data_size) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\n+\t/* Check payload size */\n+\tname_size = u16_strsize(variable_name);\n+\tif (name_size > max_payload_size - MM_VARIABLE_ACCESS_HEADER_SIZE) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\n+\t/* Trim output buffer size */\n+\ttmp_dsize = *data_size;\n+\tif (name_size + tmp_dsize >\n+\t\t\tmax_payload_size - MM_VARIABLE_ACCESS_HEADER_SIZE) {\n+\t\ttmp_dsize = max_payload_size -\n+\t\t\t\tMM_VARIABLE_ACCESS_HEADER_SIZE -\n+\t\t\t\tname_size;\n+\t}\n+\n+\t/* Get communication buffer and initialize header */\n+\tpayload_size = MM_VARIABLE_ACCESS_HEADER_SIZE + name_size + tmp_dsize;\n+\tcomm_buf = setup_mm_hdr((void **)&var_acc, payload_size,\n+\t\t\t\tSMM_VARIABLE_FUNCTION_GET_VARIABLE, &ret);\n+\tif (!comm_buf)\n+\t\treturn ret;\n+\n+\t/* Fill in contents */\n+\tefi_memcpy_runtime(&var_acc->guid, vendor, sizeof(var_acc->guid));\n+\tvar_acc->data_size = tmp_dsize;\n+\tvar_acc->name_size = name_size;\n+\tvar_acc->attr = attributes ? *attributes : 0;\n+\tefi_memcpy_runtime(var_acc->name, variable_name, name_size);\n+\n+\t/* Communicate */\n+\tret = mm_communicate_runtime(comm_buf, payload_size);\n+\tif (ret != EFI_SUCCESS && ret != EFI_BUFFER_TOO_SMALL)\n+\t\treturn ret;\n+\n+\t/* Update with reported data size for trimmed case */\n+\t*data_size = var_acc->data_size;\n+\n+\t/* Copy the data if ret is EFI_SUCCESS */\n+\tif (ret == EFI_SUCCESS) {\n+\t\tif (data)\n+\t\t\tefi_memcpy_runtime(data, (u8 *)var_acc->name + var_acc->name_size,\n+\t\t\t\t\t var_acc->data_size);\n+\t\telse\n+\t\t\tret = EFI_INVALID_PARAMETER;\n+\t}\n+\n+\t/*\n+\t * UEFI > 2.7 needs the attributes set even if the buffer is\n+\t * smaller\n+\t */\n+\tif (attributes) {\n+\t\ttmp = get_property_int_runtime(variable_name, name_size, vendor,\n+\t\t\t\t\t &var_property);\n+\t\tif (tmp != EFI_SUCCESS) {\n+\t\t\tret = tmp;\n+\t\t\treturn ret;\n+\t\t}\n+\t\t*attributes = var_acc->attr;\n+\t\tif (var_property.property &\n+\t\t VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY)\n+\t\t\t*attributes |= EFI_VARIABLE_READ_ONLY;\n+\t}\n+\n+\treturn ret;\n+}\n+\n efi_status_t efi_get_next_variable_name_int(efi_uintn_t *variable_name_size,\n \t\t\t\t\t u16 *variable_name,\n \t\t\t\t\t efi_guid_t *guid)\n@@ -1055,6 +1216,68 @@ out:\n \treturn ret;\n }\n \n+efi_status_t __efi_runtime efi_get_next_variable_name_runtime(efi_uintn_t *variable_name_size,\n+\t\t\t\t\t\t\t u16 *variable_name,\n+\t\t\t\t\t\t\t efi_guid_t *guid)\n+{\n+\tstruct smm_variable_getnext *var_getnext;\n+\tefi_uintn_t payload_size;\n+\tefi_uintn_t out_name_size;\n+\tefi_uintn_t in_name_size;\n+\tu8 *comm_buf = NULL;\n+\tefi_status_t ret;\n+\n+\tif (!variable_name_size || !variable_name || !guid) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\n+\tout_name_size = *variable_name_size;\n+\tin_name_size = u16_strsize(variable_name);\n+\n+\tif (out_name_size < in_name_size) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\n+\tif (in_name_size > max_payload_size - MM_VARIABLE_GET_NEXT_HEADER_SIZE) {\n+\t\tret = EFI_INVALID_PARAMETER;\n+\t\treturn ret;\n+\t}\n+\n+\t/* Trim output buffer size */\n+\tif (out_name_size > max_payload_size - MM_VARIABLE_GET_NEXT_HEADER_SIZE)\n+\t\tout_name_size = max_payload_size - MM_VARIABLE_GET_NEXT_HEADER_SIZE;\n+\n+\tpayload_size = MM_VARIABLE_GET_NEXT_HEADER_SIZE + out_name_size;\n+\tcomm_buf = setup_mm_hdr((void **)&var_getnext, payload_size,\n+\t\t\t\tSMM_VARIABLE_FUNCTION_GET_NEXT_VARIABLE_NAME,\n+\t\t\t\t&ret);\n+\tif (!comm_buf)\n+\t\treturn ret;\n+\n+\t/* Fill in contents */\n+\tefi_memcpy_runtime(&var_getnext->guid, guid, sizeof(*guid));\n+\tvar_getnext->name_size = out_name_size;\n+\tefi_memcpy_runtime(var_getnext->name, variable_name, in_name_size);\n+\tefi_memset_runtime((u8 *)var_getnext->name + in_name_size, 0x0,\n+\t\t\t out_name_size - in_name_size);\n+\n+\t/* Communicate */\n+\tret = mm_communicate_runtime(comm_buf, payload_size);\n+\tif (ret == EFI_SUCCESS || ret == EFI_BUFFER_TOO_SMALL) {\n+\t\t/* Update with reported data size for trimmed case */\n+\t\t*variable_name_size = var_getnext->name_size;\n+\t}\n+\tif (ret != EFI_SUCCESS)\n+\t\treturn ret;\n+\n+\tefi_memcpy_runtime(guid, &var_getnext->guid, sizeof(*guid));\n+\tefi_memcpy_runtime(variable_name, var_getnext->name, var_getnext->name_size);\n+\n+\treturn ret;\n+}\n+\n efi_status_t efi_set_variable_int(const u16 *variable_name,\n \t\t\t\t const efi_guid_t *vendor, u32 attributes,\n \t\t\t\t efi_uintn_t data_size, const void *data,\n@@ -1197,11 +1420,11 @@ out:\n *\n * @attributes:\t\t\t\tbitmask to select variables to be\n *\t\t\t\t\tqueried\n- * @maximum_variable_storage_size:\tmaximum size of storage area for the\n+ * @max_variable_storage_size:\t\tmaximum size of storage area for the\n *\t\t\t\t\tselected variable types\n- * @remaining_variable_storage_size:\tremaining size of storage are for the\n+ * @remain_variable_storage_size:\tremaining size of storage are for the\n *\t\t\t\t\tselected variable types\n- * @maximum_variable_size:\t\tmaximum size of a variable of the\n+ * @max_variable_size:\t\t\tmaximum size of a variable of the\n *\t\t\t\t\tselected type\n * Return:\t\t\t\tstatus code\n */\n@@ -1210,7 +1433,33 @@ efi_query_variable_info_runtime(u32 attributes, u64 *max_variable_storage_size,\n \t\t\t\tu64 *remain_variable_storage_size,\n \t\t\t\tu64 *max_variable_size)\n {\n-\treturn EFI_UNSUPPORTED;\n+\tstruct smm_variable_query_info *mm_query_info;\n+\tefi_uintn_t payload_size;\n+\tefi_status_t ret;\n+\tu8 *comm_buf;\n+\n+\tif (!max_variable_storage_size ||\n+\t !remain_variable_storage_size ||\n+\t !max_variable_size || !attributes)\n+\t\treturn EFI_INVALID_PARAMETER;\n+\n+\tpayload_size = sizeof(*mm_query_info);\n+\tcomm_buf = setup_mm_hdr((void **)&mm_query_info, payload_size,\n+\t\t\t\tSMM_VARIABLE_FUNCTION_QUERY_VARIABLE_INFO,\n+\t\t\t\t&ret);\n+\tif (!comm_buf)\n+\t\treturn ret;\n+\n+\tmm_query_info->attr = attributes;\n+\tret = mm_communicate_runtime(comm_buf, payload_size);\n+\tif (ret != EFI_SUCCESS)\n+\t\treturn ret;\n+\t*max_variable_storage_size = mm_query_info->max_variable_storage;\n+\t*remain_variable_storage_size =\n+\t\t\tmm_query_info->remaining_variable_storage;\n+\t*max_variable_size = mm_query_info->max_variable_size;\n+\n+\treturn ret;\n }\n \n /**\n@@ -1228,7 +1477,70 @@ efi_set_variable_runtime(u16 *variable_name, const efi_guid_t *guid,\n \t\t\t u32 attributes, efi_uintn_t data_size,\n \t\t\t const void *data)\n {\n-\treturn EFI_UNSUPPORTED;\n+\tefi_status_t ret, mm_communicate_ret = EFI_SUCCESS;\n+\tstruct var_check_property var_property;\n+\tstruct smm_variable_access *var_acc;\n+\tefi_uintn_t payload_size;\n+\tefi_uintn_t name_size;\n+\tu8 *comm_buf = NULL;\n+\tbool ro;\n+\n+\tif (!variable_name || variable_name[0] == 0 || !guid)\n+\t\treturn EFI_INVALID_PARAMETER;\n+\n+\tif (data_size > 0 && !data)\n+\t\treturn EFI_INVALID_PARAMETER;\n+\n+\t/* Check payload size */\n+\tname_size = u16_strsize(variable_name);\n+\tpayload_size = MM_VARIABLE_ACCESS_HEADER_SIZE + name_size + data_size;\n+\tif (payload_size > max_payload_size)\n+\t\treturn EFI_INVALID_PARAMETER;\n+\n+\tro = !!(attributes & EFI_VARIABLE_READ_ONLY);\n+\tattributes &= EFI_VARIABLE_MASK;\n+\n+\tret = get_property_int_runtime(variable_name, name_size, guid,\n+\t\t\t\t &var_property);\n+\tif (ret != EFI_SUCCESS)\n+\t\treturn ret;\n+\n+\t/*\n+\t * Allocate the buffer early, before switching to RW (if needed)\n+\t * so we won't need to account for any failures in reading/setting\n+\t * the properties, if the allocation fails\n+\t */\n+\tcomm_buf = setup_mm_hdr((void **)&var_acc, payload_size,\n+\t\t\t\tSMM_VARIABLE_FUNCTION_SET_VARIABLE, &ret);\n+\tif (!comm_buf)\n+\t\treturn ret;\n+\n+\tif (var_property.property & VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY)\n+\t\treturn EFI_WRITE_PROTECTED;\n+\n+\t/* Fill in contents */\n+\tefi_memcpy_runtime(&var_acc->guid, guid, sizeof(*guid));\n+\tvar_acc->data_size = data_size;\n+\tvar_acc->name_size = name_size;\n+\tvar_acc->attr = attributes;\n+\tefi_memcpy_runtime(var_acc->name, variable_name, name_size);\n+\tefi_memcpy_runtime((u8 *)var_acc->name + name_size, data, data_size);\n+\n+\t/* Communicate */\n+\tret = mm_communicate_runtime(comm_buf, payload_size);\n+\tif (ret != EFI_SUCCESS)\n+\t\tmm_communicate_ret = ret;\n+\n+\tif (ro && !(var_property.property & VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY)) {\n+\t\tvar_property.revision = VAR_CHECK_VARIABLE_PROPERTY_REVISION;\n+\t\tvar_property.property |= VAR_CHECK_VARIABLE_PROPERTY_READ_ONLY;\n+\t\tvar_property.attributes = attributes;\n+\t\tvar_property.minsize = 1;\n+\t\tvar_property.maxsize = var_acc->data_size;\n+\t\tret = set_property_int_runtime(variable_name, name_size, guid, &var_property);\n+\t}\n+\n+\treturn (mm_communicate_ret == EFI_SUCCESS) ? ret : mm_communicate_ret;\n }\n \n /**\n", "prefixes": [ "04/12" ] }