Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2228204/?format=api
{ "id": 2228204, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2228204/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260423-rk35-cnt-freq-v1-1-8f07677be5ca@cherry.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/1.1/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260423-rk35-cnt-freq-v1-1-8f07677be5ca@cherry.de>", "date": "2026-04-23T14:05:13", "name": "rockchip: fix asm-operand-widths clang warning", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "54049259ed347fab5c294303be7495825281c4ca", "submitter": { "id": 84425, "url": "http://patchwork.ozlabs.org/api/1.1/people/84425/?format=api", "name": "Quentin Schulz", "email": "foss+uboot@0leil.net" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260423-rk35-cnt-freq-v1-1-8f07677be5ca@cherry.de/mbox/", "series": [ { "id": 501455, "url": "http://patchwork.ozlabs.org/api/1.1/series/501455/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=501455", "date": "2026-04-23T14:05:13", "name": "rockchip: fix asm-operand-widths clang warning", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501455/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2228204/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2228204/checks/", "tags": {}, "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=0leil.net header.i=@0leil.net header.a=rsa-sha256\n header.s=20231125 header.b=ZEjc7qpy;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=0leil.net", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=0leil.net header.i=@0leil.net header.b=\"ZEjc7qpy\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=0leil.net", "phobos.denx.de;\n spf=pass smtp.mailfrom=foss+uboot@0leil.net" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g2w6W0xtXz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 26 Apr 2026 02:20:35 +1000 (AEST)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 063C683FF5;\n\tSat, 25 Apr 2026 18:20:33 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 91DC683FB0; Sat, 25 Apr 2026 18:20:31 +0200 (CEST)", "from smtp-42ab.mail.infomaniak.ch (smtp-42ab.mail.infomaniak.ch\n [84.16.66.171])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id CE7E1840CB\n for <u-boot@lists.denx.de>; Sat, 25 Apr 2026 18:20:28 +0200 (CEST)", "from smtp-4-0000.mail.infomaniak.ch (smtp-4-0000.mail.infomaniak.ch\n [10.7.10.107])\n by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4g1dCS2prkzb2m;\n Thu, 23 Apr 2026 16:05:24 +0200 (CEST)", "from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA\n id 4g1dCP6Pj3zQyf; Thu, 23 Apr 2026 16:05:21 +0200 (CEST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS\n autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=0leil.net;\n s=20231125; t=1776953124;\n bh=Am+dN9nWVO3w1+L7d79/2Oz6ZB6t6UiDiMGAsf3ikNQ=;\n h=From:Date:Subject:To:Cc:From;\n b=ZEjc7qpyWwgvZ9X6riMRGoEaFMayXTrP5n8/XGO2YVOhs3Lpz0sqFJcELO/RMgLM2\n uD7d2n0CO1bYQEbvQ1ym65CNbgF73VEA3H7+oYMVbxniiKhPhG0tAn7MRZOyXEHjO8\n 9agY6eal3tQVR6VmO52lJAnrQ/bqeobDkOLQVj1fVJNEwbclBeTKFDiCTcOj7kyL15\n s5LArYRzwHIJsdoodBXfSzCNnL8if8IR+v2dIZK3vxhhZDaZXC59bCp8PiSrILaICL\n jlj6rj6Bv1wVx6PV/g12H26xvCKoMiAIppWJT7Oq5wBbMAxwxiS0kBPwQJm6kRZnw1\n e41Z+NcepL/GQ==", "From": "Quentin Schulz <foss+uboot@0leil.net>", "Date": "Thu, 23 Apr 2026 16:05:13 +0200", "Subject": "[PATCH] rockchip: fix asm-operand-widths clang warning", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260423-rk35-cnt-freq-v1-1-8f07677be5ca@cherry.de>", "X-B4-Tracking": "v=1; b=H4sIAAAAAAAC/yXMQQqDMBBA0avIrDsQExXqVUoXOpm0YyHaiYog3\n t3YLt/i/x0Sq3CCtthBeZUkY8wobwXQu4svRvHZYI1tTGUd6sfVSHHGoPxFU997R8F5bwlyMyk\n H2X6/x/PvtPQD03xN4DhO1QXN63EAAAA=", "X-Change-ID": "20260423-rk35-cnt-freq-059b3cf3dd2c", "To": "u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,\n Philipp Tomsich <philipp.tomsich@vrull.eu>,\n Kever Yang <kever.yang@rock-chips.com>, Jonas Karlman <jonas@kwiboo.se>,\n Xuhui Lin <xuhui.lin@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Mark Kettenis <mark.kettenis@xs4all.nl>", "X-Mailer": "b4 0.15-dev-47773", "X-Infomaniak-Routing": "alpha", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "From: Quentin Schulz <quentin.schulz@cherry.de>\n\nCONFIG_COUNTER_FREQUENCY is currently 24000000 for all SoCs, meaning it\nfits in a 32b type. For 64b SoCs, it's an issue since the registers are\n64b.\n\nclang complains that we're trying to fit a 32b value into a 64b\nregister:\n\narch/arm/mach-rockchip/rk3528/rk3528.c:98:45: error: value size does not match register size specified by the constraint and modifier [-Werror,-Wasm-operand-widths]\n 98 | asm volatile(\"msr cntfrq_el0, %0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n | ^\ninclude/generated/autoconf.h:372:34: note: expanded from macro 'CONFIG_COUNTER_FREQUENCY'\n 372 | #define CONFIG_COUNTER_FREQUENCY 24000000\n | ^\n/home/qschulz/work/upstream/u-boot/arch/arm/mach-rockchip/rk3528/rk3528.c:98:32: note: use constraint modifier \"w\"\n 98 | asm volatile(\"msr cntfrq_el0, %0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n | ^~\n | %w0\n\nEven though cntfrq_el0[1] is only using the 32b LSB of its 64b, use the\n'x' operand modifier[2] to force the value to be 64b and fix the\nwarning.\n\n[1] https://developer.arm.com/documentation/ddi0601/2026-03/AArch64-Registers/CNTFRQ-EL0--Counter-timer-Frequency-Register?lang=en\n[2] https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#AArch64-Operand-Modifiers\n\nSuggested-by: Mark Kettenis <mark.kettenis@xs4all.nl>\nSigned-off-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\n arch/arm/mach-rockchip/rk3528/rk3528.c | 2 +-\n arch/arm/mach-rockchip/rk3576/rk3576.c | 2 +-\n arch/arm/mach-rockchip/rk3588/rk3588.c | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)\n\n\n---\nbase-commit: bfe90a308a94caa9d855440683521ff04122ae2a\nchange-id: 20260423-rk35-cnt-freq-059b3cf3dd2c\n\nBest regards,\n-- \nQuentin Schulz <quentin.schulz@cherry.de>", "diff": "diff --git a/arch/arm/mach-rockchip/rk3528/rk3528.c b/arch/arm/mach-rockchip/rk3528/rk3528.c\nindex f9bfc445b85..a39cb8be9a1 100644\n--- a/arch/arm/mach-rockchip/rk3528/rk3528.c\n+++ b/arch/arm/mach-rockchip/rk3528/rk3528.c\n@@ -95,7 +95,7 @@ void rockchip_stimer_init(void)\n \tif (reg & TIMER_EN)\n \t\treturn;\n \n-\tasm volatile(\"msr cntfrq_el0, %0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n+\tasm volatile(\"msr cntfrq_el0, %x0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n \twritel(0xffffffff, HP_TIMER_BASE + HP_LOAD_COUNT0_REG);\n \twritel(0xffffffff, HP_TIMER_BASE + HP_LOAD_COUNT1_REG);\n \twritel(TIMER_EN, HP_TIMER_BASE + HP_CTRL_REG);\ndiff --git a/arch/arm/mach-rockchip/rk3576/rk3576.c b/arch/arm/mach-rockchip/rk3576/rk3576.c\nindex c17ba418ced..e44ebb6e676 100644\n--- a/arch/arm/mach-rockchip/rk3576/rk3576.c\n+++ b/arch/arm/mach-rockchip/rk3576/rk3576.c\n@@ -130,7 +130,7 @@ void rockchip_stimer_init(void)\n \tif (reg & TIMER_EN)\n \t\treturn;\n \n-\tasm volatile(\"msr cntfrq_el0, %0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n+\tasm volatile(\"msr cntfrq_el0, %x0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n \twritel(0xffffffff, HP_TIMER_BASE + HP_LOAD_COUNT0_REG);\n \twritel(0xffffffff, HP_TIMER_BASE + HP_LOAD_COUNT1_REG);\n \twritel((TIMER_EN << 16) | TIMER_EN, HP_TIMER_BASE + HP_CTRL_REG);\ndiff --git a/arch/arm/mach-rockchip/rk3588/rk3588.c b/arch/arm/mach-rockchip/rk3588/rk3588.c\nindex eedce7b9b08..10f96175a17 100644\n--- a/arch/arm/mach-rockchip/rk3588/rk3588.c\n+++ b/arch/arm/mach-rockchip/rk3588/rk3588.c\n@@ -167,7 +167,7 @@ void rockchip_stimer_init(void)\n \tif (reg & TIMER_EN)\n \t\treturn;\n \n-\tasm volatile(\"msr cntfrq_el0, %0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n+\tasm volatile(\"msr cntfrq_el0, %x0\" : : \"r\" (CONFIG_COUNTER_FREQUENCY));\n \twritel(0xffffffff, HP_TIMER_BASE + HP_LOAD_COUNT0_REG);\n \twritel(0xffffffff, HP_TIMER_BASE + HP_LOAD_COUNT1_REG);\n \twritel(TIMER_EN, HP_TIMER_BASE + HP_CTRL_REG);\n", "prefixes": [] }