Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2227785/?format=api
{ "id": 2227785, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2227785/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/20260424085642.804561-1-tkaminsk@redhat.com/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260424085642.804561-1-tkaminsk@redhat.com>", "date": "2026-04-24T08:52:45", "name": "libstdc+: Provide iterator type for basic_const_iterator.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "7e9232a1832f840bd3aa3fb238f37373303ea3ce", "submitter": { "id": 90409, "url": "http://patchwork.ozlabs.org/api/1.1/people/90409/?format=api", "name": "Tomasz Kamiński", "email": "tkaminsk@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/20260424085642.804561-1-tkaminsk@redhat.com/mbox/", "series": [ { "id": 501322, "url": "http://patchwork.ozlabs.org/api/1.1/series/501322/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=501322", "date": "2026-04-24T08:52:45", "name": "libstdc+: Provide iterator type for basic_const_iterator.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501322/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227785/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227785/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BhD/LBZJ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=BhD/LBZJ", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g26L24Tzkz1xvV\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 18:57:45 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id DF03C4BB3BA5\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 08:57:42 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id 60DC54BA7982\n for <gcc-patches@gcc.gnu.org>; Fri, 24 Apr 2026 08:56:49 +0000 (GMT)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-hRBCu3ZJMsmnmtdxDumoIQ-1; Fri,\n 24 Apr 2026 04:56:45 -0400", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 8E5B41955F68; Fri, 24 Apr 2026 08:56:44 +0000 (UTC)", "from localhost (unknown [10.44.48.150])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 1551E1800906; Fri, 24 Apr 2026 08:56:43 +0000 (UTC)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org DF03C4BB3BA5", "OpenDKIM Filter v2.11.0 sourceware.org 60DC54BA7982" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 60DC54BA7982", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 60DC54BA7982", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777021009; cv=none;\n b=Gg7Q1qh2naR29O2GXoOjhqfJSPYqbbhSQAGeF2HthCQ2dyQVBo6j8rHB5nSIIlHhNYWV3QBy2Xugw9z6j8z9VPLaZqx/rsBV8VdPjPbhSEtUgR5jv5yEpjrjl1IdzRJv80LYamZO4ISSt1LqopdHTNmyvt3A0iHTXbbBcGrPips=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1777021009; c=relaxed/simple;\n bh=ShPdBdPS8IPfzjYu5BmkSR+/g9hHFC4S3lgSVMdOs1c=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=SZD8VtTU8SpguCDJzyWAf191lQp28Mt9JHbV0b3QJxO+FZ6YsnI56YUJexMZk0nw8IoZ4d7S869LXaG1XnKqqocGT2rFLXv0WQEeWXrbQ2LRTiDpy5ydkp06jQQMuXAjTsUnVtt6LHK81VsXMBhbA7IUunXKUJA59Z1tYk/8dk8=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1777021009;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=mSwmkaFwEdjencfxvmnnXILepQfaeK6pAt3cO5Hd4Jg=;\n b=BhD/LBZJNASgGIFxL+3auFSww8tWSQWh10foy4H5684TA22vyEcZ0Oz3BZlcRvjzspPaMb\n 89MJQyXnlpZXk0hRAfB1r45FSNZSq4eXV4xwu4u6KFcqnv9wwzuC5pV2PF7AFWYULp5zE4\n Va9QXMa6iBEwKtdfW9iiY+kGQ9eaJP4=", "X-MC-Unique": "hRBCu3ZJMsmnmtdxDumoIQ-1", "X-Mimecast-MFC-AGG-ID": "hRBCu3ZJMsmnmtdxDumoIQ_1777021004", "From": "=?utf-8?q?Tomasz_Kami=C5=84ski?= <tkaminsk@redhat.com>", "To": "libstdc++@gcc.gnu.org,\n\tgcc-patches@gcc.gnu.org", "Subject": "[PATCH] libstdc+: Provide iterator type for basic_const_iterator.", "Date": "Fri, 24 Apr 2026 10:52:45 +0200", "Message-ID": "<20260424085642.804561-1-tkaminsk@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "zSOScFu25L3Py9e-QTA2Ohj04rk96RrYTFd_TSOxB48_1777021004", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "This resolves 4253. basic_const_iterator should provide iterator_type.\n\nlibstdc++-v3/ChangeLog:\n\n\t* include/bits/stl_iterator.h (basic_const_iterator::iterator_type):\n\tDefine.\n\t* testsuite/24_iterators/const_iterator/1.cc: Tests for\n\titerator_type.\n---\nTested on x86_64-linux. OK for trunk?\n\n libstdc++-v3/include/bits/stl_iterator.h | 3 +++\n libstdc++-v3/testsuite/24_iterators/const_iterator/1.cc | 2 ++\n 2 files changed, 5 insertions(+)", "diff": "diff --git a/libstdc++-v3/include/bits/stl_iterator.h b/libstdc++-v3/include/bits/stl_iterator.h\nindex f16f591ad63..6439deb608a 100644\n--- a/libstdc++-v3/include/bits/stl_iterator.h\n+++ b/libstdc++-v3/include/bits/stl_iterator.h\n@@ -2691,6 +2691,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION\n template<input_iterator _It2> friend class basic_const_iterator;\n \n public:\n+ // _GLIBCXX_RESOLVE_LIB_DEFECTS\n+ // 4253. basic_const_iterator should provide iterator_type\n+ using iterator_type = _It;\n using iterator_concept = decltype(_S_iter_concept());\n using value_type = iter_value_t<_It>;\n using difference_type = iter_difference_t<_It>;\ndiff --git a/libstdc++-v3/testsuite/24_iterators/const_iterator/1.cc b/libstdc++-v3/testsuite/24_iterators/const_iterator/1.cc\nindex f2bcad4f09c..7f791ddbef9 100644\n--- a/libstdc++-v3/testsuite/24_iterators/const_iterator/1.cc\n+++ b/libstdc++-v3/testsuite/24_iterators/const_iterator/1.cc\n@@ -29,6 +29,7 @@ test01()\n else\n {\n using Wrapped = std::basic_const_iterator<Iter>;\n+ static_assert( std::same_as<typename Wrapped::iterator_type, Iter> );\n \n static_assert( std::same_as<std::const_iterator<Iter>, Wrapped> );\n static_assert( std::same_as<std::const_sentinel<Iter>, Wrapped> );\n@@ -64,6 +65,7 @@ test02()\n {\n static_assert( !ranges::constant_range<Range> );\n using Wrapped = std::basic_const_iterator<ranges::iterator_t<Range>>;\n+ static_assert( std::same_as<typename Wrapped::iterator_type, ranges::iterator_t<Range>> );\n \n if constexpr (Constable)\n \t{\n", "prefixes": [] }