Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2227717/?format=api
{ "id": 2227717, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2227717/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260424061958.918404-1-aleksandr.loktionov@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/1.1/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260424061958.918404-1-aleksandr.loktionov@intel.com>", "date": "2026-04-24T06:19:58", "name": "[iwl-net] ice: only free LL TS IRQ when the handler is present", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b20890a952af09440b6400331ce47875c46957eb", "submitter": { "id": 75597, "url": "http://patchwork.ozlabs.org/api/1.1/people/75597/?format=api", "name": "Loktionov, Aleksandr", "email": "aleksandr.loktionov@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260424061958.918404-1-aleksandr.loktionov@intel.com/mbox/", "series": [ { "id": 501307, "url": "http://patchwork.ozlabs.org/api/1.1/series/501307/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=501307", "date": "2026-04-24T06:19:58", "name": "[iwl-net] ice: only free LL TS IRQ when the handler is present", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501307/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2227717/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2227717/checks/", "tags": {}, "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=atbylN9/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g22r973Kjz1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 24 Apr 2026 16:20:07 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 8C9814017F;\n\tFri, 24 Apr 2026 06:20:05 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id KXMxt6bgPhhJ; Fri, 24 Apr 2026 06:20:04 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1F95040629;\n\tFri, 24 Apr 2026 06:20:04 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 83B27231\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2026 06:20:03 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 696F742110\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2026 06:20:03 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fNZluc55mXSP for <intel-wired-lan@lists.osuosl.org>;\n Fri, 24 Apr 2026 06:20:02 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.21])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 998B4420F8\n for <intel-wired-lan@lists.osuosl.org>; Fri, 24 Apr 2026 06:20:02 +0000 (UTC)", "from orviesa008.jf.intel.com ([10.64.159.148])\n by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 Apr 2026 23:20:02 -0700", "from amlin-019-225.igk.intel.com ([10.102.19.225])\n by orviesa008.jf.intel.com with ESMTP; 23 Apr 2026 23:20:01 -0700" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1F95040629", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 998B4420F8" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1777011604;\n\tbh=p1NT8RsL9wRFUvwc4EpF4S39ue7A6ghbzK88kcsRaIo=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=atbylN9/JS5gGCXzpWJx+N+WtsQhU/k4ITg2ppXroSwMUfBPEt2zTYkRAQRtY6Y/B\n\t axPN0AKf9wv+gO8OpuNnnhgUwUH1sPT3/ZaOEt4c6VrtUk2GcROfgpdTV+KItB3AXy\n\t k7XnXxajKRMzxFLjcMjJ0dx7qXZgKDtcmKgLn8upQ/rpo23wRCGB297KnZlbg5J6Ys\n\t W745DpuiktKe5OlfFOS165x6XXeW2XrSV60AyegxWw7PVEantvuk1EKpjuDcjHx6zW\n\t 1t70zuHk3uisMGAOyh7jG3C9jQd1lw2BHhA3gbEBCQ4apd47cbi7y66QWs7cF7u6Sz\n\t RVuXpozQGhvig==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.21;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 998B4420F8", "X-CSE-ConnectionGUID": [ "HrcJHEJYQX6b+zXB7l4lyg==", "mEILhK05RXm4qLMwAgUi1Q==" ], "X-CSE-MsgGUID": [ "MBcQlmOzSWWlwYPu7zpFVA==", "xV8i61CmSK25qX6dTMnf4g==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11765\"; a=\"77873870\"", "E=Sophos;i=\"6.23,196,1770624000\"; d=\"scan'208\";a=\"77873870\"", "E=Sophos;i=\"6.23,196,1770624000\"; d=\"scan'208\";a=\"232776879\"" ], "X-ExtLoop1": "1", "From": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com", "Cc": "netdev@vger.kernel.org, Sergey Temerkhanov <sergey.temerkhanov@intel.com>", "Date": "Fri, 24 Apr 2026 08:19:58 +0200", "Message-ID": "<20260424061958.918404-1-aleksandr.loktionov@intel.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1777011603; x=1808547603;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=8FCSqw0T65YwOTutmJofsBTnijCoHEsSgp28t0Ta0y8=;\n b=KkZwKtJMCsVWBCOzwxf/Bcvawk9JzX3Wj0JEEOMym0B7vUxx9nKDNM0R\n 7Rt1lSXuno1Qcq4q+C1c0WlmnI7Ln9xybq/e3P3seu94WtDbIPLLXo/qC\n i5L/8XDj2h4UC1R5ULD2tdXGA+bh4F2qmiKHLc7IGpWtENeRZOsa2qE+k\n lF5XyjGp8kispvdanVmR3FJpZ8N9vh6scMxZZX3qyegfna/DhODvfG9Bv\n qcHgtv9O3og52jZQG18SMiRqPB/oKu2skDcjDPhTL14D5LdIuMSrH++Q/\n tU0dJ0dMHVKVhSTBgl0wBlwJkKqAku0h9x1afFiKnAYYlT+QMrYT9uKZS\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=KkZwKtJM" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] ice: only free LL TS IRQ when the\n handler is present", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Sergey Temerkhanov <sergey.temerkhanov@intel.com>\n\nFree LL TS IRQ handler only when the handler was previously installed.\nUnguarded calls to ice_free_irq_msix_ll_ts() may result in a double\nfree when the LL TS interrupt is not supported by the firmware because\nll_ts_irq.index is zero-initialised and would pass the index >= 0 check.\n\nTrack whether the LL TS IRQ was successfully requested by initialising\nll_ts_irq.index to -ENOENT in ice_init_pf() and when taking the\n\"not supported\" skip path or on request failure, then guard the free\npaths with ll_ts_irq.index >= 0.\n\nFixes: 82e71b226e0e (\"ice: Enable SW interrupt from FW for LL TS\")\nSigned-off-by: Sergey Temerkhanov <sergey.temerkhanov@intel.com>\nCc: stable@vger.kernel.org\nSigned-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex 3c36e36..cc3743a 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -3389,7 +3389,7 @@ static void ice_free_irq_msix_misc(struct ice_pf *pf)\n \tdevm_free_irq(ice_pf_to_dev(pf), misc_irq_num, pf);\n \n \tice_free_irq(pf, pf->oicr_irq);\n-\tif (pf->hw.dev_caps.ts_dev_info.ts_ll_int_read)\n+\tif (pf->ll_ts_irq.index >= 0)\n \t\tice_free_irq_msix_ll_ts(pf);\n }\n \n@@ -3473,8 +3473,10 @@ static int ice_req_irq_msix_misc(struct ice_pf *pf)\n \t}\n \n \t/* reserve one vector in irq_tracker for ll_ts interrupt */\n-\tif (!pf->hw.dev_caps.ts_dev_info.ts_ll_int_read)\n+\tif (!pf->hw.dev_caps.ts_dev_info.ts_ll_int_read) {\n+\t\tpf->ll_ts_irq.index = -ENOENT;\n \t\tgoto skip_req_irq;\n+\t}\n \n \tirq = ice_alloc_irq(pf, false);\n \tif (irq.index < 0)\n@@ -3487,6 +3489,7 @@ static int ice_req_irq_msix_misc(struct ice_pf *pf)\n \t\tdev_err(dev, \"devm_request_irq for %s failed: %d\\n\",\n \t\t\tpf->int_name_ll_ts, err);\n \t\tice_free_irq(pf, pf->ll_ts_irq);\n+\t\tpf->ll_ts_irq.index = -ENOENT;\n \t\treturn err;\n \t}\n \n@@ -3496,7 +3499,7 @@ static int ice_req_irq_msix_misc(struct ice_pf *pf)\n \tice_ena_ctrlq_interrupts(hw, pf->oicr_irq.index);\n \t/* This enables LL TS interrupt */\n \tpf_intr_start_offset = rd32(hw, PFINT_ALLOC) & PFINT_ALLOC_FIRST;\n-\tif (pf->hw.dev_caps.ts_dev_info.ts_ll_int_read)\n+\tif (pf->ll_ts_irq.index >= 0)\n \t\twr32(hw, PFINT_SB_CTL,\n \t\t ((pf->ll_ts_irq.index + pf_intr_start_offset) &\n \t\t PFINT_SB_CTL_MSIX_INDX_M) | PFINT_SB_CTL_CAUSE_ENA_M);\n@@ -4090,6 +4093,7 @@ int ice_init_pf(struct ice_pf *pf)\n \t * the misc functionality and queue processing is combined in\n \t * the same vector and that gets setup at open.\n \t */\n+\tpf->ll_ts_irq.index = -ENOENT;\n \terr = ice_req_irq_msix_misc(pf);\n \tif (err) {\n \t\tdev_err(dev, \"setup of misc vector failed: %d\\n\", err);\n", "prefixes": [ "iwl-net" ] }