Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2226608/?format=api
{ "id": 2226608, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2226608/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-13-kwilczynski@kernel.org/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260422161407.118748-13-kwilczynski@kernel.org>", "date": "2026-04-22T16:13:55", "name": "[v6,12/24] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "77620b44cfe2a7851f97f1972d3a4c3e65ba0c64", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.1/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-13-kwilczynski@kernel.org/mbox/", "series": [ { "id": 501041, "url": "http://patchwork.ozlabs.org/api/1.1/series/501041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=501041", "date": "2026-04-22T16:13:46", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/501041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226608/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226608/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-52998-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BYmOqinf;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52998-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"BYmOqinf\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14Hm1zR8z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 02:22:12 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 29CF430CDC08\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 16:14:55 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2C09A37E306;\n\tWed, 22 Apr 2026 16:14:54 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 0624137E2E0;\n\tWed, 22 Apr 2026 16:14:53 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 862E7C19425;\n\tWed, 22 Apr 2026 16:14:50 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776874494; cv=none;\n b=q3KEYIxcRh6E7CwAmGSZV8WEHj6HHZAHJ2zpnJbfOvkucA92dpkgTVnDPBoncQ0xuSmVG79Z+/GntwgdxlJFCcG/025OKLDi3id/8mr4qsGd4eAw1YT7RlwyYAigb0U4DR2CvC2u+mTJ4xdRC4achWCMamPzQJ9UldGS9hbPpAA=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776874494; c=relaxed/simple;\n\tbh=W+7qR0XM35IjlsguUPu/WCGx43xcJ1ZzJ3pRjU9kU/s=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=gBy+nwSnDjuPo//+lMfoTzRcxcnCU/sihd6udjxw5+BZxPKT6/7rLjXxxec2+UcitFmvlngFUzqT6DJ2Hm+O+d1QabvU1HgNcYRR9yNqgGpDCnzAI/niPjgV0OXEwyzLjMg80dTtUhytVGr5OmrDuf7soXc6n1Xy5W+pR9NZbgE=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=BYmOqinf; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874493;\n\tbh=W+7qR0XM35IjlsguUPu/WCGx43xcJ1ZzJ3pRjU9kU/s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BYmOqinfVDr+hgBcy/KAx20ewSKraBiPaMCJz55/dXBp9Om3ckl/EdG62taw8LTE0\n\t F0S7/n2DoewFg6YHw3tTpVpdEbtNP8lGXJg3hWXwcMN2qFfn2eQ0WA+yw8YCdVHMBM\n\t 4OCvfiXJmPgEKV0R9aom2vaijI8TNQdhyoHDWJ6Lm9TVgLrSUS/GvRj4zwOwOChjo9\n\t b1Om4d4xjfZgHAyXSn1Oc0k9HqHx3+oWhQ55V8nU/1TyDr/q6d2e5eHhoKTvCI1Mga\n\t MwkJXhWSTOsZDTBDACUtL7stz2qhW7VEiU1GusqxcwllfMgJBeNkLV3PzNc9hpRhUn\n\t TMAwACCNmE5vw==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v6 12/24] alpha/PCI: Use BAR index in sysfs attr->private\n instead of resource pointer", "Date": "Wed, 22 Apr 2026 16:13:55 +0000", "Message-ID": "<20260422161407.118748-13-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260422161407.118748-1-kwilczynski@kernel.org>", "References": "<20260422161407.118748-1-kwilczynski@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit" }, "content": "Currently, Alpha's pci_create_one_attr() stores a resource pointer in\nattr->private, and pci_mmap_resource() loops through all BARs to find\nthe matching index.\n\nThus, store the BAR index directly in attr->private and retrieve the\nresource via pci_resource_n(). This eliminates the loop and aligns\nwith the convention used by the generic PCI sysfs code.\n\nThe PCI core change was first added in the commit dca40b186b75 (\"PCI:\nUse BAR index in sysfs attr->private instead of resource pointer\").\n\nTested-by: Magnus Lindholm <linmag7@gmail.com>\nReviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\nAcked-by: Magnus Lindholm <linmag7@gmail.com>\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n arch/alpha/kernel/pci-sysfs.c | 15 +++++----------\n 1 file changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2324720c3e83..2330ab84d59c 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -69,25 +69,20 @@ static int pci_mmap_resource(struct kobject *kobj,\n \t\t\t struct vm_area_struct *vma, int sparse)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n-\tstruct resource *res = attr->private;\n+\tint barno = (unsigned long)attr->private;\n+\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n-\tint i, ret;\n+\tint ret;\n \n \tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n \tif (ret)\n \t\treturn ret;\n \n-\tfor (i = 0; i < PCI_STD_NUM_BARS; i++)\n-\t\tif (res == &pdev->resource[i])\n-\t\t\tbreak;\n-\tif (i >= PCI_STD_NUM_BARS)\n-\t\treturn -ENODEV;\n-\n \tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n \t\treturn -EINVAL;\n \n-\tif (!__pci_mmap_fits(pdev, i, vma, sparse))\n+\tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n \tpcibios_resource_to_bus(pdev->bus, &bar, res);\n@@ -170,7 +165,7 @@ static int pci_create_one_attr(struct pci_dev *pdev, int num, char *name,\n \tres_attr->attr.name = name;\n \tres_attr->attr.mode = S_IRUSR | S_IWUSR;\n \tres_attr->size = sparse ? size << 5 : size;\n-\tres_attr->private = &pdev->resource[num];\n+\tres_attr->private = (void *)(unsigned long)num;\n \treturn sysfs_create_bin_file(&pdev->dev.kobj, res_attr);\n }\n \n", "prefixes": [ "v6", "12/24" ] }