Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2226604/?format=api
{ "id": 2226604, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2226604/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-10-kwilczynski@kernel.org/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260422161407.118748-10-kwilczynski@kernel.org>", "date": "2026-04-22T16:13:52", "name": "[v6,09/24] PCI/sysfs: Add stubs for pci_{create,remove}_sysfs_dev_files()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ecd807f5d0b463004540edcad5d31171345378e5", "submitter": { "id": 86709, "url": "http://patchwork.ozlabs.org/api/1.1/people/86709/?format=api", "name": "Krzysztof Wilczyński", "email": "kwilczynski@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260422161407.118748-10-kwilczynski@kernel.org/mbox/", "series": [ { "id": 501041, "url": "http://patchwork.ozlabs.org/api/1.1/series/501041/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=501041", "date": "2026-04-22T16:13:46", "name": "PCI: Convert all dynamic sysfs attributes to static", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/501041/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226604/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226604/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-52995-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=go0jltm9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52995-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"go0jltm9\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g14GP2xzSz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 02:21:01 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 27827305EA9E\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 16:14:44 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 95544325495;\n\tWed, 22 Apr 2026 16:14:43 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 71E1D1A3164;\n\tWed, 22 Apr 2026 16:14:43 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 3907FC19425;\n\tWed, 22 Apr 2026 16:14:40 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776874483; cv=none;\n b=efeISwvSaB+/8vPX21KTRQyFBuIbn8FC4AcBCUsu31AKP97dcGD2u8PbsiIQXbEO/i6zxg4NTwsqIMFTMb04jFxlpIB4HvXFGl9eNKn5VyWKAlb0ft7vX67/v+v8jX/jSnr8D4sJ3Sq4FFE8wciyqffJd5wWRQEadp8XhxkX6cw=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776874483; c=relaxed/simple;\n\tbh=2awDDsHgKBR5YLN7vFnp7yjonylM4FPzN2pRnPvj4Aw=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=l8KQsHz6Xz1PfJ8O4ecXK/kaUnRRD7l8IDoCKeGQC/gWq11l7A2HJfOlatAGGpGnU80GTu9wpVtOz5pukxVfXsd5YKWU2VXTX8Zr+LPNFng4kng67YMKUGrhoFFOp5yX+cp/Zuj03jI/fN1j8f4EeN3s0WV3T0J3SZvinq00oYc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=go0jltm9; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776874483;\n\tbh=2awDDsHgKBR5YLN7vFnp7yjonylM4FPzN2pRnPvj4Aw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=go0jltm9zA8j6jZC4t8S4Orln0Tj/7btaG5mzBOncVpBJKPiVyMzV/d4Ud3DObxDl\n\t anDvBcU6EUCe/RcOIFmS73HCEtl41etrsWn+oGUBFFIMN/9jit4ITGN9E9MqBz1uxD\n\t XGDix0I06JJdoGzgvg4VFZgABb+cYSG8+Ir2uvq/tQCfr0gQ/u72fQ2L28LaHjh09b\n\t VMvl4tRm8xnxT9CUFYHeuiKdvx+ysdcer4pIccLMLgNwWXk6NEcEo6j8FJA79WrX+o\n\t gmZncktz4J8MI/aPFdMSPFKIiSVfI5kRztmqk16OAWxQzi6tUhxH1Kd441/ZIyavhZ\n\t 3Rspt2DNaCogA==", "From": "=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "To": "Bjorn Helgaas <bhelgaas@google.com>", "Cc": "Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Magnus Lindholm <linmag7@gmail.com>, Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org", "Subject": "[PATCH v6 09/24] PCI/sysfs: Add stubs for\n pci_{create,remove}_sysfs_dev_files()", "Date": "Wed, 22 Apr 2026 16:13:52 +0000", "Message-ID": "<20260422161407.118748-10-kwilczynski@kernel.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260422161407.118748-1-kwilczynski@kernel.org>", "References": "<20260422161407.118748-1-kwilczynski@kernel.org>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit" }, "content": "On platforms with HAVE_PCI_MMAP or ARCH_GENERIC_PCI_MMAP_RESOURCE,\nresource files are now handled by static attribute groups registered\nvia pci_dev_groups[].\n\nThus, the pci_create_sysfs_dev_files() and pci_remove_sysfs_dev_files()\ncan now be stubbed out, as the dynamic resource file creation is no\nlonger needed.\n\nAlso, simplify pci_sysfs_init() on these platforms to only iterate\nbuses for legacy attributes creation, skipping the per-device loop.\n\nMove the __weak stubs for pci_create_resource_files() and\npci_remove_resource_files() into the #else branch since only platforms\nwithout HAVE_PCI_MMAP (such as Alpha architecture) still need them.\nGuard the res_attr[] and res_attr_wc[] fields in struct pci_dev the\nsame way.\n\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n drivers/pci/pci-sysfs.c | 15 ++++++++++++---\n include/linux/pci.h | 4 ++++\n 2 files changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex c0925bdc9ecd..517efb6d71cc 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1394,10 +1394,9 @@ static const struct attribute_group *pci_dev_resource_attr_groups[] = {\n };\n #else\n #define pci_dev_resource_attr_groups NULL\n-#endif\n-\n int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }\n void __weak pci_remove_resource_files(struct pci_dev *dev) { }\n+#endif\n \n /**\n * pci_write_rom - used to enable access to the PCI ROM display\n@@ -1766,6 +1765,10 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.is_visible = resource_resize_attr_is_visible,\n };\n \n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n+void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n+#else\n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n {\n \tif (!sysfs_initialized)\n@@ -1787,9 +1790,15 @@ void pci_remove_sysfs_dev_files(struct pci_dev *pdev)\n \n \tpci_remove_resource_files(pdev);\n }\n+#endif\n \n static int __init pci_sysfs_init(void)\n {\n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+\tstruct pci_bus *pbus = NULL;\n+\n+\tsysfs_initialized = 1;\n+#else\n \tstruct pci_dev *pdev = NULL;\n \tstruct pci_bus *pbus = NULL;\n \tint retval;\n@@ -1802,7 +1811,7 @@ static int __init pci_sysfs_init(void)\n \t\t\treturn retval;\n \t\t}\n \t}\n-\n+#endif\n \twhile ((pbus = pci_find_next_bus(pbus)))\n \t\tpci_create_legacy_files(pbus);\n \ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 9c0782899ef9..30aeb8e02b7b 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -507,8 +507,10 @@ struct pci_dev {\n \tspinlock_t\tpcie_cap_lock;\t\t/* Protects RMW ops in capability accessors */\n \tu32\t\tsaved_config_space[16]; /* Config space saved at suspend time */\n \tstruct hlist_head saved_cap_space;\n+#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n \tstruct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */\n \tstruct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs file for WC mapping of resources */\n+#endif\n \n #ifdef CONFIG_HOTPLUG_PCI_PCIE\n \tunsigned int\tbroken_cmd_compl:1;\t/* No compl for some cmds */\n@@ -2526,8 +2528,10 @@ int pcibios_alloc_irq(struct pci_dev *dev);\n void pcibios_free_irq(struct pci_dev *dev);\n resource_size_t pcibios_default_alignment(void);\n \n+#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n extern int pci_create_resource_files(struct pci_dev *dev);\n extern void pci_remove_resource_files(struct pci_dev *dev);\n+#endif\n \n #if defined(CONFIG_PCI_MMCONFIG) || defined(CONFIG_ACPI_MCFG)\n void __init pci_mmcfg_early_init(void);\n", "prefixes": [ "v6", "09/24" ] }