Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2226540/?format=api
{ "id": 2226540, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2226540/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/patch/14001754.uLZWGnKmhe@rafael.j.wysocki/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/1.1/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<14001754.uLZWGnKmhe@rafael.j.wysocki>", "date": "2026-04-22T15:25:46", "name": "[v1,2/4] ACPI: TAD: Use devres for all driver cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f05583b4f29f50ac0e8103bfbb416464a92cb56a", "submitter": { "id": 64267, "url": "http://patchwork.ozlabs.org/api/1.1/people/64267/?format=api", "name": "Rafael J. Wysocki", "email": "rafael@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/patch/14001754.uLZWGnKmhe@rafael.j.wysocki/mbox/", "series": [ { "id": 501033, "url": "http://patchwork.ozlabs.org/api/1.1/series/501033/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/list/?series=501033", "date": "2026-04-22T15:25:46", "name": "ACPI: TAD: Fixes and cleanups on top of recent changes", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/501033/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226540/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226540/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-rtc+bounces-6393-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-rtc@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ABr2JXpD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-rtc+bounces-6393-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"ABr2JXpD\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g136c5dkmz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 23 Apr 2026 01:29:12 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 4D81E303418B\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 15:28:09 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E7EA23451DA;\n\tWed, 22 Apr 2026 15:28:01 +0000 (UTC)", "from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id C46CE319871;\n\tWed, 22 Apr 2026 15:28:01 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 67DF4C19425;\n\tWed, 22 Apr 2026 15:28:00 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776871681; cv=none;\n b=OWFzxvjR7FmS+20iAfOk6ZtvRVa0Q5XhQRaPQRrvKlKblZUYG/JTfw+zCJjGtWLWxkgzUsEAo2O1h1jKonAghL+Sg707HDlLeDj1nvULYJatjNfUjvkCoJ16Lzv6OGKYqQXbGBI2mV2IyXRn2YEkiT/FolBSqpJWY9VDi6wMkMk=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776871681; c=relaxed/simple;\n\tbh=oSafszJYxFNWSN+LvfPCQEZQcYEaKbGWLlT5qonPtcE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=qWEJM/HYXKaVMunQCotuQHu+zqKNLZP9C0nPwg61p+GkOcZ7a2RnUayQllYG2fuoiBcQV/YNZeXM6R89fstyv/L7q6o15pIQSRRmrLVxuc2VoWvnMNJGjWHy34giiNTg5/icrajyCMpbptu9DytRSIxR3DPkw1jlfzt97WNy3NU=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=ABr2JXpD; arc=none smtp.client-ip=10.30.226.201", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1776871681;\n\tbh=oSafszJYxFNWSN+LvfPCQEZQcYEaKbGWLlT5qonPtcE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ABr2JXpDqDMTGG3sbhbsy1ZpovCb9jceJVpA2jTtivG+mInRtgwamAOMQAFNtrtgs\n\t RbBf8sGcv/DTAT2YO1Na/p9eDrLqXuc43LSuq0IvbjHB+GeRaTTKH27896Z1GjX6eO\n\t EmIue775Ln0s9eJQKVogO1RNEgGty10UvFq3loNM50iIjHR9dYTbjL5tC7f2eMx6+Q\n\t 6ZQyJzZKGqX0p1syRO+CbiVd8VBYx0uACh9aT0pD2KNBOHpAhpi4jD8EggNC9z9VaJ\n\t LzOzSPYRlc9iatG5z3eUiqpXXYlsp0QKJNSx4B4aOfBZPAXQa0mbi9MZfQjM0z0MRZ\n\t bdGAWJx1OERbA==", "From": "\"Rafael J. Wysocki\" <rafael@kernel.org>", "To": "Linux ACPI <linux-acpi@vger.kernel.org>", "Cc": "linux-rtc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,\n Alexandre Belloni <alexandre.belloni@bootlin.com>", "Subject": "[PATCH v1 2/4] ACPI: TAD: Use devres for all driver cleanup", "Date": "Wed, 22 Apr 2026 17:25:46 +0200", "Message-ID": "<14001754.uLZWGnKmhe@rafael.j.wysocki>", "Organization": "Linux Kernel Development", "In-Reply-To": "<2415066.ElGaqSPkdT@rafael.j.wysocki>", "References": "<2415066.ElGaqSPkdT@rafael.j.wysocki>", "Precedence": "bulk", "X-Mailing-List": "linux-rtc@vger.kernel.org", "List-Id": "<linux-rtc.vger.kernel.org>", "List-Subscribe": "<mailto:linux-rtc+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-rtc+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"UTF-8\"" }, "content": "From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>\n\nThe code in acpi_tad_remove() needs to run after the unregistration of\nthe devres-managed RTC class device so that it doesn't race with the\nclass callbacks of the latter.\n\nTo make that happen, pass it to devm_add_action_or_reset() before\nregistering the RTC class device.\n\nFixes: 7572dcabe38d (\"ACPI: TAD: Add alarm support to the RTC class device interface\")\nFixes: 8a1e7f4b1764 (\"ACPI: TAD: Add RTC class device interface\")\nSigned-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>\n---\n drivers/acpi/acpi_tad.c | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "--- a/drivers/acpi/acpi_tad.c\n+++ b/drivers/acpi/acpi_tad.c\n@@ -792,9 +792,9 @@ static int acpi_tad_disable_timer(struct\n \treturn acpi_tad_wake_set(dev, \"_STV\", timer_id, ACPI_TAD_WAKE_DISABLED);\n }\n \n-static void acpi_tad_remove(struct platform_device *pdev)\n+static void acpi_tad_remove(void *data)\n {\n-\tstruct device *dev = &pdev->dev;\n+\tstruct device *dev = data;\n \tstruct acpi_tad_driver_data *dd = dev_get_drvdata(dev);\n \n \tdevice_init_wakeup(dev, false);\n@@ -821,6 +821,7 @@ static int acpi_tad_probe(struct platfor\n \tstruct acpi_tad_driver_data *dd;\n \tacpi_status status;\n \tunsigned long long caps;\n+\tint ret;\n \n \t/*\n \t * Initialization failure messages are mostly about firmware issues, so\n@@ -867,6 +868,14 @@ static int acpi_tad_probe(struct platfor\n \tpm_runtime_enable(dev);\n \tpm_runtime_suspend(dev);\n \n+\t/*\n+\t * acpi_tad_remove() needs to run after unregistering the RTC class\n+\t * device to avoid racing with the latter's callbacks.\n+\t */\n+\tret = devm_add_action_or_reset(&pdev->dev, acpi_tad_remove, &pdev->dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n \tif (caps & ACPI_TAD_RT)\n \t\tacpi_tad_register_rtc(dev, caps);\n \n@@ -885,7 +894,6 @@ static struct platform_driver acpi_tad_d\n \t\t.dev_groups = acpi_tad_groups,\n \t},\n \t.probe = acpi_tad_probe,\n-\t.remove = acpi_tad_remove,\n };\n MODULE_DEVICE_TABLE(acpi, acpi_tad_ids);\n \n", "prefixes": [ "v1", "2/4" ] }