Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2226465/?format=api
{ "id": 2226465, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2226465/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-14-alex.bennee@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260422125250.1303100-14-alex.bennee@linaro.org>", "date": "2026-04-22T12:52:30", "name": "[v3,13/32] target/arm: migrate gcs syndromes to registerfields", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f40a18f8542727191050f191479d9a4c8ff86d67", "submitter": { "id": 39532, "url": "http://patchwork.ozlabs.org/api/1.1/people/39532/?format=api", "name": "Alex Bennée", "email": "alex.bennee@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-14-alex.bennee@linaro.org/mbox/", "series": [ { "id": 501008, "url": "http://patchwork.ozlabs.org/api/1.1/series/501008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501008", "date": "2026-04-22T12:52:20", "name": "target/arm: fully model WFxT instructions for A-profile", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/501008/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226465/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226465/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=igYVC1Un;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0zhr72qCz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 22:55:08 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFX5e-0006Zd-5c; Wed, 22 Apr 2026 08:54:02 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wFX4o-00062T-1O\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 08:53:11 -0400", "from mail-wm1-x335.google.com ([2a00:1450:4864:20::335])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wFX4l-0005Wa-DX\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 08:53:09 -0400", "by mail-wm1-x335.google.com with SMTP id\n 5b1f17b1804b1-48984d29fe3so45460095e9.0\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 05:53:06 -0700 (PDT)", "from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7a051dsm137846115e9.18.2026.04.22.05.52.56\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 05:53:02 -0700 (PDT)", "from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 019D060F3D;\n Wed, 22 Apr 2026 13:52:52 +0100 (BST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776862386; x=1777467186; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=qLD556mwBZN0FOjv6jT/HPan7Y0S6BW5g1K/GkaPB6k=;\n b=igYVC1UnAeREQlFKgMkH8vv7v6oFKSl0IfrPmHFs2R9/bSFXWqWO8Y6uibCKNIVuJB\n BJikTwkXLyMBCROhchzYqgdxrqPXBi/EQzdKys3KEPlIo5ZLsRhCawLJs4Jx747vU0KQ\n vF+kf5rPJpw39rnTx+v3A3gvTHtn1dmZ+7KderIxjlvKVhyj0p2Vb5Ht0YIh91a51M4Q\n lHVsV7hk7VN2cd4RxpP2RlE1RiF9DDjTgnLLqC44r7A80LGmVSc0VBJrQJesygVjigt9\n IiPqp/FSSIvttKzUDpd1orJyOu1euRGtORj/wZR29avplP4z1DOphrojBtQkjFOjobvt\n aK5Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776862386; x=1777467186;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=qLD556mwBZN0FOjv6jT/HPan7Y0S6BW5g1K/GkaPB6k=;\n b=hpknWjmLcyNidGEV4vcgztA/o7vcQgEX32QShDytbQ4MS1Q8cZg5ay6DE1XJSvvwNP\n iQytnyV8ThVpQnQRlOuSFAEw6l8mEUolKSdLz+KdWRxHHQYINi/R+BDFvs1tlcWxr4sY\n BCikm2ryixUKEnpTCt6m7KyCoRMOtme6BSeJ8cq7XZR6NpdZjAEsNaspAlXV4RlQ6Rho\n CBRieC5sTfKohmCZTfIKaHTWMuEHVpSfMJIaIKSrZn0BvYSkSROca9c+7cOJQWAEBVj2\n e6kfGpbz0r0xjUSadONjAJNTiPqDPVooXI+g1Ld/8rAKUCm/XsNcslSm77p0PAgmCguu\n cP7w==", "X-Gm-Message-State": "AOJu0YxPjhSDmbEFG9tRd9JwD6XkgzJtrhltlTfwJCmx33l12pr/C3ab\n 8WARLdX0JOBjgkEGAhrHG5ECS4/NEjBwE2QOOOMSPyKOqYo0Y+1Rd0/FT2p97ze8crI=", "X-Gm-Gg": "AeBDiesVt3Nk5sZzCDl6G/hwJIM+Hzt1KnAR2u5ua1J0D2jhYwdjQMJNOt6+pldAyM6\n xfemPjr71HV9FRhPjhlJGHTJ0FpwvQYL/Oveer0xo6v+j9XitKQd6PhpFSO/nwS6MFNkJB/CG1H\n qxzWe9e/ca6NB3QT+QMUZMxW2LDACUw+9H+oajT1wnxzENzz0bj36vzmbU64+qm7/46aXAlGhMx\n FzB3xXABuPH7vOz3ICd3BRXFNHt9YZmWCwcOVJVXiGpO4W6+iH8ALv9hQMouYYEsNMDsLydIlks\n GpcCp24hcdPpNZIDDXbPPjNYg1yJ2T3ba8ntseAebkZePNl5+1kE0hBVRgnV5WwDvsjLCAv1Ihs\n oL65QstpoIeGOjNBjiROeywTC2t0rbD1VB31hxgtj3Ufrfg4CoUBh8cwaLQGBxUKp6mOlkdMTb7\n 4yiN97G3LpTWkQ16I4dC3B07JbG6XH5orXGg==", "X-Received": "by 2002:a05:600c:c0d5:b0:488:c683:be89 with SMTP id\n 5b1f17b1804b1-488fb74dffemr247493325e9.9.1776862385550;\n Wed, 22 Apr 2026 05:53:05 -0700 (PDT)", "From": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Pedro Barbuda <pbarbuda@microsoft.com>, Alexander Graf <agraf@csgraf.de>,\n Peter Maydell <peter.maydell@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Mohamed Mediouni <mohamed@unpredictable.fr>, kvm@vger.kernel.org,\n qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>", "Subject": "[PATCH v3 13/32] target/arm: migrate gcs syndromes to registerfields", "Date": "Wed, 22 Apr 2026 13:52:30 +0100", "Message-ID": "<20260422125250.1303100-14-alex.bennee@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260422125250.1303100-1-alex.bennee@linaro.org>", "References": "<20260422125250.1303100-1-alex.bennee@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::335;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Tweak arg names to make it clear raddr is the data address register\nnumber.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>\n\n---\nv2\n - rename ra->raddr to document things.\n---\n target/arm/syndrome.h | 39 +++++++++++++++++++++++++++++++++------\n 1 file changed, 33 insertions(+), 6 deletions(-)", "diff": "diff --git a/target/arm/syndrome.h b/target/arm/syndrome.h\nindex 65d0de63a83..7ff8c30e2bb 100644\n--- a/target/arm/syndrome.h\n+++ b/target/arm/syndrome.h\n@@ -690,21 +690,48 @@ static inline uint32_t syn_pcalignment(void)\n return res;\n }\n \n+/*\n+ * ISS encoding for a GCS exception\n+ *\n+ * Field validity depends on EXTYPE\n+ */\n+FIELD(GCS_ISS, IT, 0, 5)\n+FIELD(GCS_ISS, RN, 5, 5) /* only for non EXLOCK exceptions */\n+FIELD(GCS_ISS, RADDR, 10, 5) /* only for GCSSTR/GCSSTTR traps */\n+FIELD(GCS_ISS, EXTYPE, 20, 4)\n+\n static inline uint32_t syn_gcs_data_check(GCSInstructionType it, int rn)\n {\n- return ((EC_GCS << ARM_EL_EC_SHIFT) | ARM_EL_IL |\n- (GCS_ET_DataCheck << 20) | (rn << 5) | it);\n+ uint32_t res = syn_set_ec(0, EC_GCS);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, GCS_ISS, EXTYPE, GCS_ET_DataCheck);\n+ res = FIELD_DP32(res, GCS_ISS, RN, rn);\n+ res = FIELD_DP32(res, GCS_ISS, IT, it);\n+\n+ return res;\n }\n \n static inline uint32_t syn_gcs_exlock(void)\n {\n- return (EC_GCS << ARM_EL_EC_SHIFT) | ARM_EL_IL | (GCS_ET_EXLOCK << 20);\n+ uint32_t res = syn_set_ec(0, EC_GCS);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, GCS_ISS, EXTYPE, GCS_ET_EXLOCK);\n+\n+ return res;\n }\n \n-static inline uint32_t syn_gcs_gcsstr(int ra, int rn)\n+static inline uint32_t syn_gcs_gcsstr(int raddr, int rn)\n {\n- return ((EC_GCS << ARM_EL_EC_SHIFT) | ARM_EL_IL |\n- (GCS_ET_GCSSTR_GCSSTTR << 20) | (ra << 10) | (rn << 5));\n+ uint32_t res = syn_set_ec(0, EC_GCS);\n+ res = FIELD_DP32(res, SYNDROME, IL, 1);\n+\n+ res = FIELD_DP32(res, GCS_ISS, EXTYPE, GCS_ET_GCSSTR_GCSSTTR);\n+ res = FIELD_DP32(res, GCS_ISS, RADDR, raddr);\n+ res = FIELD_DP32(res, GCS_ISS, RN, rn);\n+\n+ return res;\n }\n \n static inline uint32_t syn_serror(uint32_t extra)\n", "prefixes": [ "v3", "13/32" ] }