Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2226450/?format=api
{ "id": 2226450, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2226450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-4-alex.bennee@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/1.1/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260422125250.1303100-4-alex.bennee@linaro.org>", "date": "2026-04-22T12:52:20", "name": "[v3,03/32] target/arm: migrate FP/SIMD trap syndromes to registerfields", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "eb100e619f882b852a9a7e30e4a3b0106bdaca3b", "submitter": { "id": 39532, "url": "http://patchwork.ozlabs.org/api/1.1/people/39532/?format=api", "name": "Alex Bennée", "email": "alex.bennee@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260422125250.1303100-4-alex.bennee@linaro.org/mbox/", "series": [ { "id": 501008, "url": "http://patchwork.ozlabs.org/api/1.1/series/501008/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=501008", "date": "2026-04-22T12:52:20", "name": "target/arm: fully model WFxT instructions for A-profile", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/501008/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226450/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226450/checks/", "tags": {}, "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=apmCZBCS;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0zgV0C79z1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 22:53:56 +1000 (AEST)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wFX4g-0005xb-GX; Wed, 22 Apr 2026 08:53:02 -0400", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wFX4b-0005u5-DE\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 08:52:57 -0400", "from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <alex.bennee@linaro.org>)\n id 1wFX4Y-0005RI-S3\n for qemu-devel@nongnu.org; Wed, 22 Apr 2026 08:52:57 -0400", "by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43d7650202fso4257465f8f.2\n for <qemu-devel@nongnu.org>; Wed, 22 Apr 2026 05:52:54 -0700 (PDT)", "from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4c221cdsm46907702f8f.0.2026.04.22.05.52.51\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 22 Apr 2026 05:52:51 -0700 (PDT)", "from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 330505FC04;\n Wed, 22 Apr 2026 13:52:51 +0100 (BST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776862373; x=1777467173; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=K6n23oz7LRRQlFUUM3gTQS/rrKewMUhskSZOvSJMe4M=;\n b=apmCZBCSxrYyZthGBc+uAQMwMicO2g5PCwX6xX9Q0Aznh7KROkEH7Bi2gnpQD87F6P\n xYhRCVZBETDn70wfm8k/MUr6UD1VuOSGV4VYQCXRg3f4nrMC0Ks6MCBCmXlU6B2OQHeo\n 8r5GCvZ7MJfkHas0vjXO8zhiMPXE3Ns3bEOsC4TbUJBYwDEnRQVTOLFXXPFDV9ioLBZj\n yIOxY8wxE993gY8cjiy987krA8xIf2/fPT3wpB+t9CIDnhdpb5wwliPUTvD/IjAKICPk\n XaEBLZi2GRc/Q3nnZIPuYKVkRKb9N9LpFYw4Q+jPyR50e7BA7uF0p6uC5ErDqD2HD7w0\n sklQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776862373; x=1777467173;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=K6n23oz7LRRQlFUUM3gTQS/rrKewMUhskSZOvSJMe4M=;\n b=WJd38wFdmweDRCXQuLEor31IV/jWCtd8+icxoRUBctUIrrXhshKaejMiYNgCd6QxwH\n bVzciF6/D2yOAhbiEDMCvfarEdS+JiHRhWchKeA59kaZmwsJGZ9xj6wl7Fkzq1qWDqrh\n TZLsLb12y3aKh1bR2ES1CwwNIAjKpVDrarvefPSqtGovqtWlO9hT7jk4N8kd/0Nl3qwW\n SgAM1vAHLyBVANDLZRfVeQOz6SF6GjYmdVXIRHmNpC/POWFkN+RMyu3siFy8pHG4pOuj\n YtvI6Z+c8LQq5ZARaHyXdCt/ATrRAcd1IWtD0JZMkG6mChQGk13UhBydEOs3Zaxv3L52\n zSZw==", "X-Gm-Message-State": "AOJu0Yx4mOygQBk7U+pPcSkFMNJuo+jCzRRJjD/SXQnLQ8V+Bt9K8ex8\n XDfdVA5Y+p566aXWb4nx7nR4hrHKSOs/ZeVf9Pz2WyWtRtolstmTcBZWmxIJizYNXcA=", "X-Gm-Gg": "AeBDiesLMsOOOHguNZuvksypO8emm3feojS2HDHC7Maw0xemlwPCq2Mq1wLWBgGAhbb\n F0vrAj0xjXpkbOEgYWDqWr54D8XWwP9pb5lM5kGMPaykWc6lZ5AJD9vv/rRRVqZCA6ihvUHt+yl\n miZzHtjyvhrpdeR/cRkdV8hOqBgtpBM/UhJhXJ0hgdZf8U3dUdVs5jVWJ7XViFNvU3CVEcX9i5K\n A1FrmjIif2hywHEHPDr7EqmosCngn25KYRXfc00sSU/ZRsZdMBZvT1uMEtNGFpyLhiRcnR4Spt0\n ni966YGlx7p81O29AWymTLSY3CxQqNo5x/JI+BhKHlBVSVC6brMLzey464wC5futgxfpHnrjmlO\n iL84PNQWl41JoVYE4IlgTbIxaqyg5lO7AE/gGUSnzCVTzhCnJ44jAisPfRkR07wAJzlL39Vd7RG\n k5sh3UkNxZHCsD+D1dEWjTh4NXfZiM74NOfA==", "X-Received": "by 2002:a05:6000:200c:b0:43d:77f4:7145 with SMTP id\n ffacd0b85a97d-43fe3dd407dmr34461259f8f.19.1776862372594;\n Wed, 22 Apr 2026 05:52:52 -0700 (PDT)", "From": "=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "Pedro Barbuda <pbarbuda@microsoft.com>, Alexander Graf <agraf@csgraf.de>,\n Peter Maydell <peter.maydell@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Mohamed Mediouni <mohamed@unpredictable.fr>, kvm@vger.kernel.org,\n qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Richard Henderson <richard.henderson@linaro.org>", "Subject": "[PATCH v3 03/32] target/arm: migrate FP/SIMD trap syndromes to\n registerfields", "Date": "Wed, 22 Apr 2026 13:52:20 +0100", "Message-ID": "<20260422125250.1303100-4-alex.bennee@linaro.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260422125250.1303100-1-alex.bennee@linaro.org>", "References": "<20260422125250.1303100-1-alex.bennee@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42c.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The syn_simd_access trap was never used so remove it. We should only\nsee the COPROC encoding on v7 architectures.\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Alex Bennée <alex.bennee@linaro.org>\n\n---\nv2\n - use !is16_bit directly\n---\n target/arm/syndrome.h | 25 +++++++++++++++----------\n 1 file changed, 15 insertions(+), 10 deletions(-)", "diff": "diff --git a/target/arm/syndrome.h b/target/arm/syndrome.h\nindex 29462aa103c..72051443d59 100644\n--- a/target/arm/syndrome.h\n+++ b/target/arm/syndrome.h\n@@ -337,21 +337,26 @@ static inline uint32_t syn_cp15_rrt_trap(int cv, int cond, int opc1, int crm,\n return res;\n }\n \n+/*\n+ * ISS encoding for an exception from an access to a register of\n+ * instruction resulting from the FPEN or TFP traps.\n+ */\n+FIELD(FP_ISS, COPROC, 0, 4) /* ARMv7 only */\n+FIELD(FP_ISS, COND, 20, 4)\n+FIELD(FP_ISS, CV, 24, 1)\n+\n static inline uint32_t syn_fp_access_trap(int cv, int cond, bool is_16bit,\n int coproc)\n {\n /* AArch32 FP trap or any AArch64 FP/SIMD trap: TA == 0 */\n- return (EC_ADVSIMDFPACCESSTRAP << ARM_EL_EC_SHIFT)\n- | (is_16bit ? 0 : ARM_EL_IL)\n- | (cv << 24) | (cond << 20) | coproc;\n-}\n+ uint32_t res = syn_set_ec(0, EC_ADVSIMDFPACCESSTRAP);\n+ res = FIELD_DP32(res, SYNDROME, IL, !is_16bit);\n \n-static inline uint32_t syn_simd_access_trap(int cv, int cond, bool is_16bit)\n-{\n- /* AArch32 SIMD trap: TA == 1 coproc == 0 */\n- return (EC_ADVSIMDFPACCESSTRAP << ARM_EL_EC_SHIFT)\n- | (is_16bit ? 0 : ARM_EL_IL)\n- | (cv << 24) | (cond << 20) | (1 << 5);\n+ res = FIELD_DP32(res, FP_ISS, CV, cv);\n+ res = FIELD_DP32(res, FP_ISS, COND, cond);\n+ res = FIELD_DP32(res, FP_ISS, COPROC, coproc);\n+\n+ return res;\n }\n \n static inline uint32_t syn_sve_access_trap(void)\n", "prefixes": [ "v3", "03/32" ] }