Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2226051/?format=api
{ "id": 2226051, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2226051/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/aehkgxtyVuTh1MDv@tucnak/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<aehkgxtyVuTh1MDv@tucnak>", "date": "2026-04-22T06:02:43", "name": "[committed] gensupport: Fix // comment handling [PR124971]", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "742a4b7beac299a4bb65b86a7672c07047603511", "submitter": { "id": 671, "url": "http://patchwork.ozlabs.org/api/1.1/people/671/?format=api", "name": "Jakub Jelinek", "email": "jakub@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/aehkgxtyVuTh1MDv@tucnak/mbox/", "series": [ { "id": 500923, "url": "http://patchwork.ozlabs.org/api/1.1/series/500923/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=500923", "date": "2026-04-22T06:02:43", "name": "[committed] gensupport: Fix // comment handling [PR124971]", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500923/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2226051/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2226051/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DGvSs653;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=DGvSs653", "sourceware.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "sourceware.org; spf=pass smtp.mailfrom=redhat.com", "server2.sourceware.org;\n arc=none smtp.remote-ip=170.10.129.124" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0pYm0z04z1yD5\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 16:03:20 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id BA7954BA9035\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 06:03:18 +0000 (GMT)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by sourceware.org (Postfix) with ESMTP id C4CF74BA23F9\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 06:02:50 +0000 (GMT)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-pirmw2lMMwGZ1t5YE6kfEQ-1; Wed,\n 22 Apr 2026 02:02:48 -0400", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id AEC451956054\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 06:02:47 +0000 (UTC)", "from tucnak.zalov.cz (unknown [10.44.48.12])\n by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 42D4B1956095\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 06:02:46 +0000 (UTC)", "from tucnak.zalov.cz (localhost [127.0.0.1])\n by tucnak.zalov.cz (8.18.1/8.18.1) with ESMTPS id 63M62i5F4013196\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT)\n for <gcc-patches@gcc.gnu.org>; Wed, 22 Apr 2026 08:02:44 +0200", "(from jakub@localhost)\n by tucnak.zalov.cz (8.18.1/8.18.1/Submit) id 63M62iid4013195\n for gcc-patches@gcc.gnu.org; Wed, 22 Apr 2026 08:02:44 +0200" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org BA7954BA9035", "OpenDKIM Filter v2.11.0 sourceware.org C4CF74BA23F9" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org C4CF74BA23F9", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org C4CF74BA23F9", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776837771; cv=none;\n b=Vcm9i1BpVX3Iy8KgT0h+cWvwSslYvxuE9YRaU+C0n85eChBvTiZvAF1YAFCIxoAyK4hk5q9XT6jKwPFtMznQ2dN3R0gAsh4PPOrTrvFlpzALUeHSLegqj4WG9MEXY2syMjj+KAIJzdF6XzE/Hwdg7O8/j7o6TUc2niZ4L7Np4m4=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776837771; c=relaxed/simple;\n bh=4PmF5K0dFEeehgU6kFO6qBdmvVIBMvDOF8AK+V8nG2Y=;\n h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version;\n b=mb3vtLXip4K3cTi8fPSxXNsXHvuoAUk7GOLutMgpByj5o/u8/t4htezzp3smesJ+SGnwI914UFlXz5WDTJSqeRw1HWJyjtt3Yz4Stoi6WS1J4oak0lFAX6Rs5ydWNFrD3j9NiJtFDCgSqMoEHrc/uQQlSmlbKD/lVqbgbQ378yw=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776837770;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:mime-version:mime-version:\n content-type:content-type; bh=lPJFx8vbck9VUwkwZon9b+uCfXcVuePpF85A2zB43gI=;\n b=DGvSs6536NALBiakhgWetbOHbO5/pFuEV+dfwGI957gIm3u63Vm67ank3ODCeo7YhiGHPy\n +98WIGpzOZklZtgQyU5vWyYdOYc1fOaoeu70WSr8784B0cTmWk1sh1D2wL9YdoUFf6+/Fs\n +YLi1KuChY5IjO2uS4WRckLI8RnpBZM=", "X-MC-Unique": "pirmw2lMMwGZ1t5YE6kfEQ-1", "X-Mimecast-MFC-AGG-ID": "pirmw2lMMwGZ1t5YE6kfEQ_1776837767", "Date": "Wed, 22 Apr 2026 08:02:43 +0200", "From": "Jakub Jelinek <jakub@redhat.com>", "To": "gcc-patches@gcc.gnu.org", "Subject": "[committed] gensupport: Fix // comment handling [PR124971]", "Message-ID": "<aehkgxtyVuTh1MDv@tucnak>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "9hFwEC_HlFHBZ5R-yPilAbQmHmCuVz2HvKohHyAFFsA_1776837767", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Reply-To": "Jakub Jelinek <jakub@redhat.com>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi!\n\nThe while (*templ != '\\n' || *templ != '\\0') ++templ; loop\nis due to a wrong logical operator an endless loop, so clearly\nwe don't have any // comments in the new syntax *.md files that\nare using it in the relevant parts of the patterns.\n\nFixed by using && instead.\n\nTested on a cross to aarch64 (no changes in any generated files),\nbootstrapped/regtested on x86_64-linux and i686-linux, acked in the PR\nby Andrew Pinski, committed to trunk.\n\n2026-04-22 Jakub Jelinek <jakub@redhat.com>\n\n\tPR middle-end/124971\n\t* gensupport.cc (convert_syntax): Fix up // comment handling.\n\n\n\tJakub", "diff": "--- gcc/gensupport.cc.jj\t2026-03-27 10:17:14.160330315 +0100\n+++ gcc/gensupport.cc\t2026-04-21 19:40:34.305053658 +0200\n@@ -1016,7 +1016,7 @@ convert_syntax (rtx x, file_location loc\n \t{\n \t templ += 2;\n \t /* Glob till newline or end of string. */\n-\t while (*templ != '\\n' || *templ != '\\0')\n+\t while (*templ != '\\n' && *templ != '\\0')\n \t templ++;\n \n \t /* Skip any newlines or whitespaces needed. */\n", "prefixes": [ "committed" ] }