Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225903/?format=api
{ "id": 2225903, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225903/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260421190619.1396589-1-mmakassikis@freebox.fr/", "project": { "id": 12, "url": "http://patchwork.ozlabs.org/api/1.1/projects/12/?format=api", "name": "Linux CIFS Client", "link_name": "linux-cifs-client", "list_id": "linux-cifs.vger.kernel.org", "list_email": "linux-cifs@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260421190619.1396589-1-mmakassikis@freebox.fr>", "date": "2026-04-21T19:06:19", "name": "fs: smb: server: stop sending fake security descriptors", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bf961bd3ae63b801f47730aaa48e2922be3f2f27", "submitter": { "id": 82633, "url": "http://patchwork.ozlabs.org/api/1.1/people/82633/?format=api", "name": "Marios Makassikis", "email": "mmakassikis@freebox.fr" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260421190619.1396589-1-mmakassikis@freebox.fr/mbox/", "series": [ { "id": 500881, "url": "http://patchwork.ozlabs.org/api/1.1/series/500881/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=500881", "date": "2026-04-21T19:06:19", "name": "fs: smb: server: stop sending fake security descriptors", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500881/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225903/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225903/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-cifs+bounces-10989-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-cifs@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=freebox-fr.20251104.gappssmtp.com\n header.i=@freebox-fr.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=Vn+e0FCp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10989-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=freebox-fr.20251104.gappssmtp.com\n header.i=@freebox-fr.20251104.gappssmtp.com header.b=\"Vn+e0FCp\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.45", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=freebox.fr", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=freebox.fr" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0Wzx25w7z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 22 Apr 2026 05:06:37 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 128533015D38\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 19:06:34 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6065436DA18;\n\tTue, 21 Apr 2026 19:06:31 +0000 (UTC)", "from mail-wm1-f45.google.com (mail-wm1-f45.google.com\n [209.85.128.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BDDB28980F\n\tfor <linux-cifs@vger.kernel.org>; Tue, 21 Apr 2026 19:06:28 +0000 (UTC)", "by mail-wm1-f45.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so62259055e9.2\n for <linux-cifs@vger.kernel.org>;\n Tue, 21 Apr 2026 12:06:28 -0700 (PDT)", "from odysseia.iliad.local (freebox.vlq16.iliad.fr. [213.36.7.13])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-4899dc95920sm43485325e9.6.2026.04.21.12.06.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 21 Apr 2026 12:06:26 -0700 (PDT)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776798391; cv=none;\n b=K3K01A5SDf4fCJjd/njVrepNTxw4jBPLmSeK2w8/2xhooVvuC5ol7LPEPi+cetRmAtUOMuan/qpt4pH7bKVqJqKEACmX51MlJY0IJf1Tp27Ihm3pc2pGuZqDqbQzN858te57Reznp2EhMYWEqooK0ip79ClS4971wXqpkonYQhY=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776798391; c=relaxed/simple;\n\tbh=VvTm4cAHZbuncy6sm/7K/bscL5eZ8MCtsCeeBZunYnE=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=agQAuSCIgJ1QgSN7Am2PTO5/Fj03+ERROR1teNVV8zyCDi4e13jmei7Q9o1Vwjt6sb2OMoRYtdVaPDvmeHlE34crbnWvbqJy6+KdZ04LKMbwl8VSvCvvtgYLfErcSmveLYFW7C0zE1RH9zele9TZf6Pzt3SoUq+Pid5k2e2fYXc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=freebox.fr;\n spf=pass smtp.mailfrom=freebox.fr;\n dkim=pass (2048-bit key) header.d=freebox-fr.20251104.gappssmtp.com\n header.i=@freebox-fr.20251104.gappssmtp.com header.b=Vn+e0FCp;\n arc=none smtp.client-ip=209.85.128.45", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=freebox-fr.20251104.gappssmtp.com; s=20251104; t=1776798387;\n x=1777403187; darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=O0jF6nh/pkH+f9VD7h6qIt/vH27AY04GwziRDF2Gm8Q=;\n b=Vn+e0FCpFZBANCD6IcAQarWQ+9J0ZTP/RGrDUH/9mLphwz7mLd/9vAo0UQwqrhWtBB\n hOOPN9mzLTsAXmVOSM6X6Pk/Glb2Dc4j74rqoHAGFv1tv9KkuHHXRDEnfZPmonOng2Z8\n EdBiQDj8caPtR/oTfw41nh5GuAtYMdh1PypVD73J38evcvl58+J5BlwqmV8zEszldCyn\n GffXVG6JRD0rQEKWMFB0iQkuy132Z4OaCHlnhEp+zmSqAjFCxZCFgn/46pctkKR0U6cK\n H+N1WeEFNIDm9MvG3WJRalOJ4qK35i+5Fq0UpJaJm6bWslv9qZtz4YdFAGpU7RHTbDsK\n 802Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776798387; x=1777403187;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=O0jF6nh/pkH+f9VD7h6qIt/vH27AY04GwziRDF2Gm8Q=;\n b=juoU+OU3UWxt2mTPclFN/SR92bhTHMsuubTy6rUpsQkZ/A/D5fEtqt1Xq2c8IVk6nI\n UBgulQmRpqRA29H/uenbCEy1enSpTELb49ujhmDuDeav92td/bIQjL+Ru6Dmsy0WojrN\n Bo9u/cXtlcjN5nppg0GS1qbFIbiIz5n5G57YWvgobMz4wMtxccWb9+AR8GfMsEqLZ0q5\n kImSChXbrhpDRwougl32TqViQT7pwivZhnc8UVC6BNiQjL0dx+4XEmFgZiKwyW1pXrwB\n oYNg5jXDD6cgNAiEvkDsEbCBRvUDGAuz8hW391DZj5OabFm3X/Cs/i5tV5L/t//x/Sb/\n YQQg==", "X-Gm-Message-State": "AOJu0YwGjZmy/zIXSF3NNAMAfrdgfi3HMZTy7Tpl8d3QhSG/7F6k9Mte\n\t7x9jIyKWDvqsBW7Ef2ZqWlgE2RsMto9az+2RgDdl1dPMR6KDdqa6hxdPVWO/LlrkcOMywwPL5lj\n\tZT2RV", "X-Gm-Gg": "AeBDies9f5dzg7mGiNqOSe5cA+EZbZ8BMEpwVUwK3KHxpMCogOCeD6eTlkzwvRtDigT\n\t5LtfXWf6z60M6Sy6LLfPdQ2qvbII5wVQlmD+zelxuUSiaQ2/VujICeka8kli212C3YC0Up7f00R\n\txKcVPhGrUku3ATeDWlxfUkWpbUWTvttW0+Ng20Y7/asyjtlhUPQzm3bM6Okq1qcmxeSrohR9HSe\n\tAyvodWYDGw3Kms5DhHEIC/n0paWwOMEQPnWx47hX4O5KC+QneAIzEnPFYZQmkBaVZQv4lxSPxF6\n\tFcfCpP3e5yhPoB8FfyFYnXoRKWbnmLTvoSVjTBaMX8TchaN/4NoqvG+Ezt0WEUhFzb1vmNbr4DA\n\txZYY9Wi3dn3t3KxM3bl0fVyqWaVX3CD09x+viStFuGXar8g3lBiMlLqywVgcSkI/FsfT8ZkRxgR\n\taRl3pIdpqMOW//yZDEUCr16JVw6T6Os+v7Pu/hDL0gMSsBX25nxb8iiCH6xWjx6Gtf5gIauujp4\n\tkXy500t65Uk5PqMbtyZLQDgz2dDAjS5c45JwSIgv2zBWWAOIuJYZAM=", "X-Received": "by 2002:a05:600c:6297:b0:486:d76c:fa57 with SMTP id\n 5b1f17b1804b1-488fb77155dmr262140515e9.17.1776798386621;\n Tue, 21 Apr 2026 12:06:26 -0700 (PDT)", "From": "Marios Makassikis <mmakassikis@freebox.fr>", "To": "linux-cifs@vger.kernel.org,\n\tlinkinjeon@kernel.org", "Cc": "smfrench@gmail.com,\n\ttom@talpey.com,\n\tsenozhatsky@chromium.org,\n\tMarios Makassikis <mmakassikis@freebox.fr>", "Subject": "[PATCH] fs: smb: server: stop sending fake security descriptors", "Date": "Tue, 21 Apr 2026 21:06:19 +0200", "Message-ID": "<20260421190619.1396589-1-mmakassikis@freebox.fr>", "X-Mailer": "git-send-email 2.51.1", "Precedence": "bulk", "X-Mailing-List": "linux-cifs@vger.kernel.org", "List-Id": "<linux-cifs.vger.kernel.org>", "List-Subscribe": "<mailto:linux-cifs+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-cifs+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "in smb2_get_info_sec, a dummy security descriptor (SD) is returned if\nthe requested information is not supported.\n\nthe code is currently wrong, as DACL_PROTECTED is set in the type field,\nbut there is no DACL is present.\n\ninstead of faking a security, report a STATUS_NOT_SUPPORTED error.\n\nthis seems to fix a \"Error 0x80090006: Invalid Signature\" on file\ntransfers with Windows 11 clients (25H2, build 26200.8246).\n\ncapturing traffic shows that the client is sending a GET_INFO/SEC_INFO\nrequest, with the additional_info field set to 0x20\n(ATTRIBUTE_SECURITY_INFORMATION). Returning an empty SD\n(with only SELF_RELATIVE set) does not fix the error.\n\nSigned-off-by: Marios Makassikis <mmakassikis@freebox.fr>\n---\n fs/smb/server/smb2pdu.c | 16 ++--------------\n 1 file changed, 2 insertions(+), 14 deletions(-)", "diff": "diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c\nindex ee32e61b6d3c..6622efdd55e3 100644\n--- a/fs/smb/server/smb2pdu.c\n+++ b/fs/smb/server/smb2pdu.c\n@@ -5745,20 +5745,8 @@ static int smb2_get_info_sec(struct ksmbd_work *work,\n \t\tksmbd_debug(SMB, \"Unsupported addition info: 0x%x)\\n\",\n \t\t addition_info);\n \n-\t\tpntsd = kzalloc(ALIGN(sizeof(struct smb_ntsd), 8),\n-\t\t\t\tKSMBD_DEFAULT_GFP);\n-\t\tif (!pntsd)\n-\t\t\treturn -ENOMEM;\n-\n-\t\tpntsd->revision = cpu_to_le16(1);\n-\t\tpntsd->type = cpu_to_le16(SELF_RELATIVE | DACL_PROTECTED);\n-\t\tpntsd->osidoffset = 0;\n-\t\tpntsd->gsidoffset = 0;\n-\t\tpntsd->sacloffset = 0;\n-\t\tpntsd->dacloffset = 0;\n-\n-\t\tsecdesclen = sizeof(struct smb_ntsd);\n-\t\tgoto iov_pin;\n+\t\trsp->hdr.Status = STATUS_NOT_SUPPORTED;\n+\t\treturn -EINVAL;\n \t}\n \n \tif (work->next_smb2_rcv_hdr_off) {\n", "prefixes": [] }