Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225375/?format=api
{ "id": 2225375, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225375/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420220215.111510-3-pablo@netfilter.org/", "project": { "id": 26, "url": "http://patchwork.ozlabs.org/api/1.1/projects/26/?format=api", "name": "Netfilter Development", "link_name": "netfilter-devel", "list_id": "netfilter-devel.vger.kernel.org", "list_email": "netfilter-devel@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260420220215.111510-3-pablo@netfilter.org>", "date": "2026-04-20T22:02:09", "name": "[net,2/8] netfilter: nfnetlink_osf: fix divide-by-zero in OSF_WSS_MODULO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e86eb5b7f50dfb83611738c26422db9076f63311", "submitter": { "id": 1315, "url": "http://patchwork.ozlabs.org/api/1.1/people/1315/?format=api", "name": "Pablo Neira Ayuso", "email": "pablo@netfilter.org" }, "delegate": { "id": 11902, "url": "http://patchwork.ozlabs.org/api/1.1/users/11902/?format=api", "username": "strlen", "first_name": "Florian", "last_name": "Westphal", "email": "fw@strlen.de" }, "mbox": "http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260420220215.111510-3-pablo@netfilter.org/mbox/", "series": [ { "id": 500691, "url": "http://patchwork.ozlabs.org/api/1.1/series/500691/?format=api", "web_url": "http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=500691", "date": "2026-04-20T22:02:07", "name": "[net,1/8] netfilter: nft_osf: restrict it to ipv4", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500691/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225375/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225375/checks/", "tags": {}, "headers": { "Return-Path": "\n <netfilter-devel+bounces-12096-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "netfilter-devel@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=netfilter.org header.i=@netfilter.org\n header.a=rsa-sha256 header.s=2025 header.b=RKY2DGer;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-12096-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=\"RKY2DGer\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=217.70.190.124", "smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=netfilter.org" ], "Received": [ "from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzzym3Qcdz1yD8\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 08:03:44 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 67B8C302548F\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 22:02:34 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id C899B3CFF73;\n\tMon, 20 Apr 2026 22:02:25 +0000 (UTC)", "from mail.netfilter.org (mail.netfilter.org [217.70.190.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E2903CAE6C;\n\tMon, 20 Apr 2026 22:02:24 +0000 (UTC)", "from localhost.localdomain (mail-agni [217.70.190.124])\n\tby mail.netfilter.org (Postfix) with ESMTPSA id DEF6660255;\n\tTue, 21 Apr 2026 00:02:21 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776722545; cv=none;\n b=lAd+wD7DSeyn0R/jIqK6If73yaD1qowSASoKsFcb/tMW8Di/+w1pAE1re1brOiP+5IbDTvJyVlnzEtDQxR8e/ZkbDLWFWVqKZa9sRNUJ4pcKFuSbsVCtN9ZLYECgNSFVYngEVXk96n+KM4vK9p68vF9tsVT3WmJYQjlsKiBvT6Q=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776722545; c=relaxed/simple;\n\tbh=RAc9hL98TaCk0E5UK92NqSh0XWR+Dt3CY9OzU/zax44=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=VNLtflXD5yqJlhW84BWC09BLUVFWmWei7CEnytZ1w2JYrz7VZpy/udgLNIujsUgFmXtU+A/Us/snKc5UjP628zNgycMNV0im9k43wRJyWZdszKQlLj6ITJS75flsdKY2JAX3wld92RpYmUmpBVgdTtj1jZNOkpkZjAHqe5Wqr2A=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=netfilter.org;\n spf=pass smtp.mailfrom=netfilter.org;\n dkim=pass (2048-bit key) header.d=netfilter.org header.i=@netfilter.org\n header.b=RKY2DGer; arc=none smtp.client-ip=217.70.190.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfilter.org;\n\ts=2025; t=1776722542;\n\tbh=smvPDymkRZRIJbSlkOFXGg3/3JQSUAitqsTCA77GeQs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RKY2DGerLJgFa77YVV3RNwVkNuBknTpe8FhRKFDaUMGKYf0h6PTxAiqs4JBHHwhkQ\n\t Oznxhy2pBYn+LsDzbrdQPPKumQLxDIEyTzqioXCzr1iPEbX6iaL2VD1414weg4AP3l\n\t XU2ZSBFzl6K69vljlnFB+wGVrX6BbHgGzOt/wLxUyFbA8hYfbNYAil5u5lwcEu+oz5\n\t DSgnSNBaQM3WqfjS+ZmqiqLlU1WQj7s7um/IugEbkMDCMW07/H6Heo0b3LKjGuNL8p\n\t 40uutPfxwdQaQ6x6KtFfzON0LAUGVhTKGm+vgNkB5/BemfXP2nqHiOV+tZSZOFQj3u\n\t iMol5eS+EdG+g==", "From": "Pablo Neira Ayuso <pablo@netfilter.org>", "To": "netfilter-devel@vger.kernel.org", "Cc": "davem@davemloft.net,\n\tnetdev@vger.kernel.org,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tedumazet@google.com,\n\tfw@strlen.de,\n\thorms@kernel.org", "Subject": "[PATCH net 2/8] netfilter: nfnetlink_osf: fix divide-by-zero in\n OSF_WSS_MODULO", "Date": "Tue, 21 Apr 2026 00:02:09 +0200", "Message-ID": "<20260420220215.111510-3-pablo@netfilter.org>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20260420220215.111510-1-pablo@netfilter.org>", "References": "<20260420220215.111510-1-pablo@netfilter.org>", "Precedence": "bulk", "X-Mailing-List": "netfilter-devel@vger.kernel.org", "List-Id": "<netfilter-devel.vger.kernel.org>", "List-Subscribe": "<mailto:netfilter-devel+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:netfilter-devel+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit" }, "content": "From: Xiang Mei <xmei5@asu.edu>\n\nnf_osf_match_one() computes ctx->window % f->wss.val in the\nOSF_WSS_MODULO branch with no guard for f->wss.val == 0. A\nCAP_NET_ADMIN user can add such a fingerprint via nfnetlink; a\nsubsequent matching TCP SYN divides by zero and panics the kernel.\n\nReject the bogus fingerprint in nfnl_osf_add_callback() above the\nper-option for-loop. f->wss is per-fingerprint, not per-option, so\nthe check must run regardless of f->opt_num (including 0). Also\nreject wss.wc >= OSF_WSS_MAX; nf_osf_match_one() already treats that\nas \"should not happen\".\n\nCrash:\n Oops: divide error: 0000 [#1] SMP KASAN NOPTI\n RIP: 0010:nf_osf_match_one (net/netfilter/nfnetlink_osf.c:98)\n Call Trace:\n <IRQ>\n nf_osf_match (net/netfilter/nfnetlink_osf.c:220)\n xt_osf_match_packet (net/netfilter/xt_osf.c:32)\n ipt_do_table (net/ipv4/netfilter/ip_tables.c:348)\n nf_hook_slow (net/netfilter/core.c:622)\n ip_local_deliver (net/ipv4/ip_input.c:265)\n ip_rcv (include/linux/skbuff.h:1162)\n __netif_receive_skb_one_core (net/core/dev.c:6181)\n process_backlog (net/core/dev.c:6642)\n __napi_poll (net/core/dev.c:7710)\n net_rx_action (net/core/dev.c:7945)\n handle_softirqs (kernel/softirq.c:622)\n\nFixes: 11eeef41d5f6 (\"netfilter: passive OS fingerprint xtables match\")\nReported-by: Weiming Shi <bestswngs@gmail.com>\nSuggested-by: Florian Westphal <fw@strlen.de>\nSuggested-by: Pablo Neira Ayuso <pablo@netfilter.org>\nSigned-off-by: Xiang Mei <xmei5@asu.edu>\nReviewed-by: Fernando Fernandez Mancera <fmancera@suse.de>\nSigned-off-by: Pablo Neira Ayuso <pablo@netfilter.org>\n---\n net/netfilter/nfnetlink_osf.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/net/netfilter/nfnetlink_osf.c b/net/netfilter/nfnetlink_osf.c\nindex d64ce21c7b55..9de91fdd107c 100644\n--- a/net/netfilter/nfnetlink_osf.c\n+++ b/net/netfilter/nfnetlink_osf.c\n@@ -320,6 +320,10 @@ static int nfnl_osf_add_callback(struct sk_buff *skb,\n \tif (f->opt_num > ARRAY_SIZE(f->opt))\n \t\treturn -EINVAL;\n \n+\tif (f->wss.wc >= OSF_WSS_MAX ||\n+\t (f->wss.wc == OSF_WSS_MODULO && f->wss.val == 0))\n+\t\treturn -EINVAL;\n+\n \tfor (i = 0; i < f->opt_num; i++) {\n \t\tif (!f->opt[i].length || f->opt[i].length > MAX_IPOPTLEN)\n \t\t\treturn -EINVAL;\n", "prefixes": [ "net", "2/8" ] }