Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225218/?format=api
{ "id": 2225218, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225218/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/yddpl3tk32j.fsf@CeBiTec.Uni-Bielefeld.DE/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/1.1/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<yddpl3tk32j.fsf@CeBiTec.Uni-Bielefeld.DE>", "date": "2026-04-20T16:29:40", "name": "testsuite: Check configured assembler in gcc.misc-tests/options.exp", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cc0d0e346055d9e756330ae944a51707ee67afcc", "submitter": { "id": 4362, "url": "http://patchwork.ozlabs.org/api/1.1/people/4362/?format=api", "name": "Rainer Orth", "email": "ro@CeBiTec.Uni-Bielefeld.DE" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/yddpl3tk32j.fsf@CeBiTec.Uni-Bielefeld.DE/mbox/", "series": [ { "id": 500630, "url": "http://patchwork.ozlabs.org/api/1.1/series/500630/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=500630", "date": "2026-04-20T16:29:40", "name": "testsuite: Check configured assembler in gcc.misc-tests/options.exp", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500630/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225218/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225218/checks/", "tags": {}, "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=RSFRcot1;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=cebitec.uni-bielefeld.de header.i=@cebitec.uni-bielefeld.de\n header.a=rsa-sha256 header.s=20200306 header.b=RSFRcot1", "sourceware.org; dmarc=none (p=none dis=none)\n header.from=CeBiTec.Uni-Bielefeld.DE", "sourceware.org;\n spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de", "server2.sourceware.org;\n arc=none smtp.remote-ip=129.70.160.84" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzrZK5745z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 02:30:12 +1000 (AEST)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 2C94C4A98F0D\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 16:30:10 +0000 (GMT)", "from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE\n [129.70.160.84])\n by sourceware.org (Postfix) with ESMTPS id B4F454C91766\n for <gcc-patches@gcc.gnu.org>; Mon, 20 Apr 2026 16:29:42 +0000 (GMT)", "from localhost (localhost.CeBiTec.Uni-Bielefeld.DE [127.0.0.1])\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id C8A23E12F7;\n Mon, 20 Apr 2026 18:29:41 +0200 (CEST)", "from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])\n by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new,\n port 10026)\n with ESMTP id 2xAEzgYj8eh7; Mon, 20 Apr 2026 18:29:41 +0200 (CEST)", "from manam.CeBiTec.Uni-Bielefeld.DE (p508551ea.dip0.t-ipconnect.de\n [80.133.81.234]) (Authenticated sender: ro)\n by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id 63F4CE26E3;\n Mon, 20 Apr 2026 18:29:41 +0200 (CEST)" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 2C94C4A98F0D", "OpenDKIM Filter v2.11.0 sourceware.org B4F454C91766" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org B4F454C91766", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org B4F454C91766", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776702582; cv=none;\n b=lzZ4aygGxHCepJ8puqekHyHxdbw0h/ustELNl8tLaEfj2Y2DkX0HFbWZrv9QNb4tyXt0cijNQHPL731nGDXQSN8ybvXENl6ltwuDwogwBdwwRJPldSYhleaNRt5lfF3660dm/C5McA0L8c/88gFMIuCpb/o28NIxyqxyBbyHGu0=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776702582; c=relaxed/simple;\n bh=tABv/iW99sGHbA2XQBkDX66Nuu87gVXxLNIbD0212NE=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=JeOAD8qyHNnfapqNXQHOUzgES0tWvTLuuTxK03sxYIUZwmNblROgwoDBknKZ2gKL4+/EmrP6ORAVaMwQ8j4VwWQOSr+ffv+KVUHlOvuAnI9CMeS6818NphQxjKP2qv0bsAsUqsvvMR0qZO3prHRve+SAa430rUaros7avwRI79E=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=\n cebitec.uni-bielefeld.de; h=content-type:content-type\n :mime-version:user-agent:message-id:date:date:subject:subject\n :from:from:received:received; s=20200306; t=1776702581; bh=tABv/\n iW99sGHbA2XQBkDX66Nuu87gVXxLNIbD0212NE=; b=RSFRcot1/tPeeQCRdM5dw\n gPnnCYxBprZotlibU4EVLromfjRDTx4KYtHn1RYBeaFm3CVTwHmT3SSjxeibatd/\n PdaRJEM28c5m0lNcsdiAiSNZsNKRY11OWZZBPxCzfwec97nAna9Fs8WIae0YheHl\n PAM6i3o8+LKvna7soUHmkiKujziAzKjQO+mjdHXVLqjphGXsGqq52iJoWNLba3gz\n KoJxiVrsHZYsGrqUaRy5XPOVFrC/7dQeJ1bSHpHuuzHs0FuMLi9p1agApFT7X0jy\n 6sfzpxPuB+KOuWbdfn+ZQOyYMN//BZT59jEq2orF6jyYgCMtdUTsX8WpAZCsffbv\n Q==", "X-Virus-Scanned": "amavisd-new at cebitec.uni-bielefeld.de", "From": "Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>", "To": "gcc-patches@gcc.gnu.org", "Cc": "Mike Stump <mikestump@comcast.net>", "Subject": "[PATCH] testsuite: Check configured assembler in\n gcc.misc-tests/options.exp", "Date": "Mon, 20 Apr 2026 18:29:40 +0200", "Message-ID": "<yddpl3tk32j.fsf@CeBiTec.Uni-Bielefeld.DE>", "User-Agent": "Gnus/5.13 (Gnus v5.13)", "MIME-Version": "1.0", "Content-Type": "multipart/mixed; boundary=\"=-=-=\"", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "When I recently dropped --with-gnu-as from my builds which had become\nunnecessary, several tests started to FAIL, e.g.\n\nFAIL: compiler driver --coverage option(s) (assembler options)\n\nand all other \"(assembler options)\" tests in gcc.misc-tests/options.exp.\n\nThis happends because my builds use something like\n--with-as=/vol/gcc/bin/gas-2.46 instead of relying on a random bundled\nversion of gas. Therefore the configured assembler name doesn't end in\n\"as\".\n\nThe assembler options check in options.exp (check_for_all_options) looks\nfor\n\n\t\" *as(\\\\.exe)? .*$as_pattern\"\n\nin the gcc -v output, with an empty as_pattern.\n\nWhile gcc was configured with --with-gnu-as, the gcc -v output starts\nwith\n\nConfigured with:...---with-gnu-as ...\n\nlater followed by\n\n /vol/gcc/bin/gas-2.46 -v -V -Qy -s --32 -o /var/tmp//ccr7.tAa.o /var/tmp//ccRnpmxb.s\n\nSince Tcl does multiline matching by default, the first line did match\nthe pattern although the actual assembler invokation does not.\n\nTo avoid this, this patch does two things:\n\n* Use newline-sensitive matching.\n\n* Check for the actual configured assembler instead of assuming its name\n ends in as.\n\nTested on i386-pc-solaris2.11 configured with --with-as as above and\nx86_64-pc-linux-gnu without --with-as, thus picking up as from PATH.\n\nOk for trunk?\n\n\tRainer", "diff": "# HG changeset patch\n# Parent c9585fcdb8356b25a3942681a60ba4f48e45bcad\ntestsuite: Check configured assembler in gcc.misc-tests/options.exp\n\ndiff --git a/gcc/testsuite/gcc.misc-tests/options.exp b/gcc/testsuite/gcc.misc-tests/options.exp\n--- a/gcc/testsuite/gcc.misc-tests/options.exp\n+++ b/gcc/testsuite/gcc.misc-tests/options.exp\n@@ -55,7 +55,11 @@ proc check_for_all_options {language gcc\n \tfail \"$test (compiler options)\"\n \treturn\n }\n- if {![regexp -- \" *as(\\\\.exe)? .*$as_pattern\" $gcc_output]} {\n+ # Match configured assembler name.\n+ set as_options [list \"additional_flags=-print-prog-name=as\"]\n+ set as_prog [lindex [gcc_target_compile \"\" \"\" \"none\" $as_options] 0]\n+ if {![regexp -line -- \" ${as_prog}(\\\\.exe)? .*$as_pattern\" $gcc_output]} {\n+\n \tfail \"$test (assembler options)\"\n \treturn\n }\n", "prefixes": [] }