Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.1/patches/2225195/?format=api
{ "id": 2225195, "url": "http://patchwork.ozlabs.org/api/1.1/patches/2225195/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260420152608.6244-2-djeffery@redhat.com/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/1.1/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null }, "msgid": "<20260420152608.6244-2-djeffery@redhat.com>", "date": "2026-04-20T15:26:04", "name": "[1/5] driver core: separate function to shutdown one device", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bb0f21284663b9d835b7143908502187083890e1", "submitter": { "id": 24471, "url": "http://patchwork.ozlabs.org/api/1.1/people/24471/?format=api", "name": "David Jeffery", "email": "djeffery@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260420152608.6244-2-djeffery@redhat.com/mbox/", "series": [ { "id": 500621, "url": "http://patchwork.ozlabs.org/api/1.1/series/500621/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=500621", "date": "2026-04-20T15:26:04", "name": "shut down devices asynchronously", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/500621/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2225195/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2225195/checks/", "tags": {}, "headers": { "Return-Path": "\n <linux-pci+bounces-52785-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=cDS2VcEZ;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pci+bounces-52785-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"cDS2VcEZ\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.133.124", "smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com" ], "Received": [ "from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzqJt51s2z1yGs\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 01:33:50 +1000 (AEST)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id E0EE6303A2BA\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 20 Apr 2026 15:26:53 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 73F182DA74C;\n\tMon, 20 Apr 2026 15:26:41 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CCC042D3EF2\n\tfor <linux-pci@vger.kernel.org>; Mon, 20 Apr 2026 15:26:39 +0000 (UTC)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-8RAE0JxiPTCvPmKMtmBm-Q-1; Mon,\n 20 Apr 2026 11:26:35 -0400", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0C1C819560AE;\n\tMon, 20 Apr 2026 15:26:28 +0000 (UTC)", "from fedora-work.redhat.com (unknown [10.22.65.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EAB4F19560B1;\n\tMon, 20 Apr 2026 15:26:23 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776698801; cv=none;\n b=eOvo5eVn2VqCS+S11+Usfxz93mDylLIV/twVar66938wVRYChXq7r2iolTQ71bQ92t7G2gcbCPWx0cdY+Bm0LLKfGjgwu1E3tBT987TNpaHEo6j705RSYtxTfGZwxQtchMWJA2xLk31DT+s9WOAa1W5VVj7MLnwIL8NfvXQ/YYo=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776698801; c=relaxed/simple;\n\tbh=q+nfGdplbvQfboPdGnfM+qYt03BBKoSZgEfNKxAkmds=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=aPCS5eZXHHnSXB164qpzZatAIqCqFPVGtcRTP4cCCS47V5YQFn5p3KaH+TgNn1taI6+rnSrr8vVGJNGvLc06tyS54+GIAdlHAMGjyGJK8G6Y8NWHqMjnwpjqmWE/Zy/eBXg1HDMUSDS0naQKBmi8y2eP3pM2NOsp6b6+uVjDekU=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=cDS2VcEZ; arc=none smtp.client-ip=170.10.133.124", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1776698799;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=lcIN1MIk0jsEfgbrlTzOCbftwfcBA0O12oRAeg/mS04=;\n\tb=cDS2VcEZIKax3kcKilpjbd33+rREybKtb8obwfnWPsLX7+DdfwW2kJ4UTbPm/+0lm2sbvA\n\te9aq6cXrJyMjh2atedmCPA1SSczuRqAbUJ+fGzBQwTk1EiiooBJZcpllLF+QhiE17OX75r\n\t0RjeJ18b3DtDms90ICSDhZ0Av3bLvcU=", "X-MC-Unique": "8RAE0JxiPTCvPmKMtmBm-Q-1", "X-Mimecast-MFC-AGG-ID": "8RAE0JxiPTCvPmKMtmBm-Q_1776698788", "From": "David Jeffery <djeffery@redhat.com>", "To": "linux-kernel@vger.kernel.org,\n\tdriver-core@lists.linux.dev,\n\tlinux-pci@vger.kernel.org,\n\tlinux-scsi@vger.kernel.org,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\t\"Rafael J. Wysocki\" <rafael@kernel.org>,\n\tDanilo Krummrich <dakr@kernel.org>", "Cc": "Tarun Sahu <tarunsahu@google.com>, Pasha Tatashin <tatashin@google.com>,\n\t=?utf-8?b?TWljaGHFgiBDxYJhcGnFhHNraQ==?= <mclapinski@google.com>,\n Jordan Richards <jordanrichards@google.com>, Ewan Milne <emilne@redhat.com>,\n John Meneghini <jmeneghi@redhat.com>, \"Lombardi,\n Maurizio\" <mlombard@redhat.com>, Stuart Hayes <stuart.w.hayes@gmail.com>,\n Laurence Oberman <loberman@redhat.com>, Bart Van Assche <bvanassche@acm.org>,\n Bjorn Helgaas <helgaas@kernel.org>,\n \"Martin K . Petersen\" <martin.petersen@oracle.com>,\n John Garry <john.g.garry@oracle.com>, David Jeffery <djeffery@redhat.com>", "Subject": "[PATCH 1/5] driver core: separate function to shutdown one device", "Date": "Mon, 20 Apr 2026 11:26:04 -0400", "Message-ID": "<20260420152608.6244-2-djeffery@redhat.com>", "In-Reply-To": "<20260420152608.6244-1-djeffery@redhat.com>", "References": "<20260420152608.6244-1-djeffery@redhat.com>", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12" }, "content": "Make a separate function for the part of device_shutdown() that does the\nshutown for a single device. This is in preparation for making device\nshutdown asynchronous.\n\nSigned-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>\nSigned-off-by: David Jeffery <djeffery@redhat.com>\nTested-by: Laurence Oberman <loberman@redhat.com>\n---\n drivers/base/core.c | 71 +++++++++++++++++++++++++--------------------\n 1 file changed, 39 insertions(+), 32 deletions(-)", "diff": "diff --git a/drivers/base/core.c b/drivers/base/core.c\nindex 0613de0fbe44..5353c6c22d49 100644\n--- a/drivers/base/core.c\n+++ b/drivers/base/core.c\n@@ -4783,12 +4783,48 @@ int device_change_owner(struct device *dev, kuid_t kuid, kgid_t kgid)\n \treturn error;\n }\n \n+static void shutdown_one_device(struct device *dev)\n+{\n+\tstruct device *parent = dev->parent;\n+\n+\t/* hold lock to avoid race with probe/release */\n+\tif (parent)\n+\t\tdevice_lock(parent);\n+\tdevice_lock(dev);\n+\n+\t/* Don't allow any more runtime suspends */\n+\tpm_runtime_get_noresume(dev);\n+\tpm_runtime_barrier(dev);\n+\n+\tif (dev->class && dev->class->shutdown_pre) {\n+\t\tif (initcall_debug)\n+\t\t\tdev_info(dev, \"shutdown_pre\\n\");\n+\t\tdev->class->shutdown_pre(dev);\n+\t}\n+\tif (dev->bus && dev->bus->shutdown) {\n+\t\tif (initcall_debug)\n+\t\t\tdev_info(dev, \"shutdown\\n\");\n+\t\tdev->bus->shutdown(dev);\n+\t} else if (dev->driver && dev->driver->shutdown) {\n+\t\tif (initcall_debug)\n+\t\t\tdev_info(dev, \"shutdown\\n\");\n+\t\tdev->driver->shutdown(dev);\n+\t}\n+\n+\tdevice_unlock(dev);\n+\tif (parent)\n+\t\tdevice_unlock(parent);\n+\n+\tput_device(parent);\n+\tput_device(dev);\n+}\n+\n /**\n * device_shutdown - call ->shutdown() on each device to shutdown.\n */\n void device_shutdown(void)\n {\n-\tstruct device *dev, *parent;\n+\tstruct device *dev;\n \n \twait_for_device_probe();\n \tdevice_block_probing();\n@@ -4810,7 +4846,7 @@ void device_shutdown(void)\n \t\t * prevent it from being freed because parent's\n \t\t * lock is to be held\n \t\t */\n-\t\tparent = get_device(dev->parent);\n+\t\tget_device(dev->parent);\n \t\tget_device(dev);\n \t\t/*\n \t\t * Make sure the device is off the kset list, in the\n@@ -4819,36 +4855,7 @@ void device_shutdown(void)\n \t\tlist_del_init(&dev->kobj.entry);\n \t\tspin_unlock(&devices_kset->list_lock);\n \n-\t\t/* hold lock to avoid race with probe/release */\n-\t\tif (parent)\n-\t\t\tdevice_lock(parent);\n-\t\tdevice_lock(dev);\n-\n-\t\t/* Don't allow any more runtime suspends */\n-\t\tpm_runtime_get_noresume(dev);\n-\t\tpm_runtime_barrier(dev);\n-\n-\t\tif (dev->class && dev->class->shutdown_pre) {\n-\t\t\tif (initcall_debug)\n-\t\t\t\tdev_info(dev, \"shutdown_pre\\n\");\n-\t\t\tdev->class->shutdown_pre(dev);\n-\t\t}\n-\t\tif (dev->bus && dev->bus->shutdown) {\n-\t\t\tif (initcall_debug)\n-\t\t\t\tdev_info(dev, \"shutdown\\n\");\n-\t\t\tdev->bus->shutdown(dev);\n-\t\t} else if (dev->driver && dev->driver->shutdown) {\n-\t\t\tif (initcall_debug)\n-\t\t\t\tdev_info(dev, \"shutdown\\n\");\n-\t\t\tdev->driver->shutdown(dev);\n-\t\t}\n-\n-\t\tdevice_unlock(dev);\n-\t\tif (parent)\n-\t\t\tdevice_unlock(parent);\n-\n-\t\tput_device(dev);\n-\t\tput_device(parent);\n+\t\tshutdown_one_device(dev);\n \n \t\tspin_lock(&devices_kset->list_lock);\n \t}\n", "prefixes": [ "1/5" ] }